Re: New x11/compton

2014-10-27 Thread Stuart Henderson
On 2014/10/26 19:03, Sunil Nimmagadda wrote:
 
 src/c2.{c,h}: base gcc version doesn't support unnamed fields so
 given a name to the union.

Actually it does, but not with --std=c99 (and compton uses other things
that need this). There are other ways around it but this is simple and
seems sanest.

It seems that some newer GCCs do allow anonymous unions with std=c99,
even though they weren't added to the standard until c11.

New tgz attached with some comments in patches (though I thought some
were simple enough not to need comments).

Any OKs to import?


compton.tgz
Description: application/tar-gz


Re: New x11/compton

2014-10-26 Thread Sunil Nimmagadda
 From owner-ports+m69...@openbsd.org Sun Oct 26 00:20:08 2014
 From: Stuart Henderson st...@openbsd.org
 To: Sunil Nimmagadda su...@nimmagadda.net
 Cc: ports@openbsd.org
 Subject: Re: New x11/compton


 --/04w6evG8XlLl3ft
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline

 On 2014/10/25 23:57, Sunil Nimmagadda wrote:
  Hi,
  
  Following a conversation on tech@, here is my attempt at porting
  compton.
  
  Compton is a compositor for X and is a fork of xcompmgr with bugs
  fixes and enchancements.
  
  Link to port: https://poolp.org/~sunil/compton.tar.gz
  
  I tested it only on amd64.
  
  Any comments/feedback?
  

 Thank you! Here are a couple of tweaks.. (diff for ease of comparison below,
 new tgz attached).

 - add rcs id
 - use our normal COMMENT style
 - use a version number that pkg_add -u can recognise (no _)
 - regen WANTLIB
 - remove some bogus BUILD_DEPENDS (either LIB_DEPENDS or BUILD_DEPENDS, not 
 both)
 - fork of xcompmgr - MIT license
 - install .desktop file
 - flesh out DESCR


Thank you for the feedback.

 I haven't reviewed the patches yet but it works for me.

I forgot to leave a comment in patches, here they are...

src/c2.{c,h}: base gcc version doesn't support unnamed fields so
given a name to the union.

Makefile: librt removal.

src/common.h: typecast to suppress warnings.

src/compton.{c,h}: default clause to switch statements to suppress warnings.



New x11/compton

2014-10-25 Thread Sunil Nimmagadda
Hi,

Following a conversation on tech@, here is my attempt at porting
compton.

Compton is a compositor for X and is a fork of xcompmgr with bugs
fixes and enchancements.

Link to port: https://poolp.org/~sunil/compton.tar.gz

I tested it only on amd64.

Any comments/feedback?



Re: New x11/compton

2014-10-25 Thread Stuart Henderson
On 2014/10/25 23:57, Sunil Nimmagadda wrote:
 Hi,
 
 Following a conversation on tech@, here is my attempt at porting
 compton.
 
 Compton is a compositor for X and is a fork of xcompmgr with bugs
 fixes and enchancements.
 
 Link to port: https://poolp.org/~sunil/compton.tar.gz
 
 I tested it only on amd64.
 
 Any comments/feedback?
 

Thank you! Here are a couple of tweaks.. (diff for ease of comparison below,
new tgz attached).

- add rcs id
- use our normal COMMENT style
- use a version number that pkg_add -u can recognise (no _)
- regen WANTLIB
- remove some bogus BUILD_DEPENDS (either LIB_DEPENDS or BUILD_DEPENDS, not 
both)
- fork of xcompmgr - MIT license
- install .desktop file
- flesh out DESCR

I haven't reviewed the patches yet but it works for me.


diff --git Makefile Makefile
index a0cf1dc..d8c1a3b 100644
--- Makefile
+++ Makefile
@@ -1,33 +1,33 @@
-COMMENT =  Compton is a compositor for X, and a fork of xcompmgr-dana
+# $OpenBSD$
+
+COMMENT =  lightweight compositor for X, forked from xcompmgr-dana
 
 VERSION =  0.1_beta2
 GH_ACCOUNT =   chjj
 GH_PROJECT =   compton
 GH_TAGNAME =   v${VERSION}
-DISTNAME = compton-${VERSION}
+DISTNAME = compton-${VERSION:S/_//}
 CATEGORIES =   x11
 HOMEPAGE = https://github.com/chjj/compton
 
 MAINTAINER =   Sunil Nimmagadda su...@nimmagadda.net
 
-# BSD-like
+# MIT
 PERMIT_PACKAGE_CDROM = Yes
 
-WANTLIB =  X11 Xcomposite Xdamage Xfixes Xext Xinerama Xrandr 
Xrender \
-   GL c m pthread
-
-WANTLIB += config dbus-1 pcre
-
-BUILD_DEPENDS =devel/libconfig \
-   textproc/asciidoc \
-   x11/dbus
+WANTLIB += GL X11 Xcomposite Xdamage Xext Xfixes Xinerama Xrandr
+WANTLIB += Xrender c config dbus-1 m pcre pthread
 
+BUILD_DEPENDS =textproc/asciidoc
+RUN_DEPENDS =  devel/desktop-file-utils
 LIB_DEPENDS =  devel/libconfig \
devel/pcre \
x11/dbus
 
 USE_GMAKE =Yes
-MAKE_FLAGS =   COMPTON_VERSION=${VERSION} \
+MAKE_FLAGS =   CC=${CC} \
+   COMPTON_VERSION=${VERSION} \
+   APPDIR=${PREFIX}/share/applications \
BINDIR=${PREFIX}/bin \
MANDIR=${PREFIX}/man/man1
 
diff --git distinfo distinfo
index be84a52..b2f9b69 100644
--- distinfo
+++ distinfo
@@ -1,2 +1,2 @@
-SHA256 (compton-0.1_beta2.tar.gz) = 
e5zVKlcyYRb7XbP1+Jt9UOF3FSUtn9ebcLRazjCmsAk=
-SIZE (compton-0.1_beta2.tar.gz) = 144239
+SHA256 (compton-0.1beta2.tar.gz) = e5zVKlcyYRb7XbP1+Jt9UOF3FSUtn9ebcLRazjCmsAk=
+SIZE (compton-0.1beta2.tar.gz) = 144239
diff --git pkg/DESCR pkg/DESCR
index d2176a8..06a 100644
--- pkg/DESCR
+++ pkg/DESCR
@@ -1 +1,13 @@
-Compton is a compositor for X, and a fork of xcompmgr-dana.
+Compton is a lightweight, standalone composite manager, suitable for use
+with window managers that do not natively provide compositing functionality.
+
+Compton itself is a fork of xcompmgr-dana, in turn a fork of xcompmgr.
+
+Compton in particular is notable for fixing numerous bugs found in
+its predecessors, and as such, is popular due to its reliability and
+stability. Numerous additional improvements and configuration options
+have also been implemented, including a faster GLX (OpenGL) backend
+(disabled by default), default inactive/active window opacity, window
+frame transparency, window background blur, window color inversion,
+painting rate throttling, VSync, condition-based fine-tune control,
+configuration file reading, and D-Bus control.
diff --git pkg/PLIST pkg/PLIST
index 00b8bd1..bb64ff1 100644
--- pkg/PLIST
+++ pkg/PLIST
@@ -3,3 +3,6 @@
 bin/compton-trans
 @man man/man1/compton-trans.1
 @man man/man1/compton.1
+share/applications/compton.desktop
+@exec %D/bin/update-desktop-database
+@unexec-delete %D/bin/update-desktop-database



compton.tgz
Description: application/tar-gz