Re: Patch for missing dep in gtk-xfce-engine
Sorry for the dup. Never saw first post until I checked gmane...
Patch for missing dep in gtk-xfce-engine
A missing dependency was exposed when I recently did 'make install'
in the /usr/ports/x11/xfce4 directory with no prior graphics (gtk)
ports installed. This is one of those ports that is split into
subdirectories, and gtk-xfce-engine is the first SUBDIR visited.
I had BIN_PACKAGES=YES set, but don't think that is relevant since
any packages I had sitting around were freshly built from the same
CVS update. Here is what happend:
Script started on Mon Oct 17 21:46:26 2005
# make install
=== x11/xfce4/gtk-xfce-engine
=== Checking files for gtk-xfce-engine-2.2.7
`/PKGROOT/ACTIVE/distdir/xfce4/gtk-xfce-engine-2.2.7.tar.gz' is up to date.
Checksum OK for xfce4/gtk-xfce-engine-2.2.7.tar.gz. (sha1)
=== gtk-xfce-engine-2.2.7 depends on: pkgconfig-* - not found
=== Verifying install for pkgconfig-* in devel/pkgconfig
=== Installing pkgconfig-0.19 from
/PKGROOT/3.8-current/packages/all/pkgconfig-0.19.tgz
pkgconfig-0.19: complete
=== Returning to build of gtk-xfce-engine-2.2.7
=== gtk-xfce-engine-2.2.7 depends on: pkgconfig-* - found
=== gtk-xfce-engine-2.2.7 depends on: gettext-=0.10.38 - not found
=== Verifying install for gettext-=0.10.38 in devel/gettext
=== gettext-0.10.40p3 depends on: libiconv-* - not found
=== Verifying install for libiconv-* in converters/libiconv
=== Installing libiconv-1.9.2p1 from
/PKGROOT/3.8-current/packages/all/libiconv-1.9.2p1.tgz
libiconv-1.9.2p1: complete
=== Returning to build of gettext-0.10.40p3
=== gettext-0.10.40p3 depends on: libiconv-* - found
=== gettext-0.10.40p3 depends on: libiconv-* - found
=== Installing gettext-0.10.40p3 from
/PKGROOT/3.8-current/packages/all/gettext-0.10.40p3.tgz
gettext-0.10.40p3: complete
=== Returning to build of gtk-xfce-engine-2.2.7
=== gtk-xfce-engine-2.2.7 depends on: gettext-=0.10.38 - found
=== gtk-xfce-engine-2.2.7 depends on: libiconv-* - found
=== gtk-xfce-engine-2.2.7 depends on: gettext-=0.10.38 - found
=== Verifying specs: iconv.2 intl.1 X11 Xcursor Xext Xft Xinerama Xrender
fontconfig freetype m atk-1.0.0.0 gdk-x11-2.0.0.0 gdk_pixbuf-2.0.0.0
glib-2.0.0.0 gmodule-2.0.0.0 gobject-2.0.0.0 gtk-x11-2.0.0.0 pango-1.0.0.0
pangox-1.0.0.0 pangoxft-1.0.0.0
Missing library for atk-1.0.0.0
Missing library for gdk-x11-2.0.0.0
Missing library for gdk_pixbuf-2.0.0.0
Missing library for glib-2.0.0.0
Missing library for gmodule-2.0.0.0
Missing library for gobject-2.0.0.0
Missing library for gtk-x11-2.0.0.0
Missing library for pango-1.0.0.0
Missing library for pangox-1.0.0.0
Missing library for pangoxft-1.0.0.0
Fatal error
*** Error code 1
Stop in /PKGROOT/ACTIVE/ports/x11/xfce4/gtk-xfce-engine (line 1428 of
/PKGROOT/ACTIVE/ports/infrastructure/mk/bsd.port.mk).
*** Error code 1
Stop in /PKGROOT/ACTIVE/ports/x11/xfce4/gtk-xfce-engine (line 1681 of
/PKGROOT/ACTIVE/ports/infrastructure/mk/bsd.port.mk).
*** Error code 1
Stop in /PKGROOT/ACTIVE/ports/x11/xfce4/gtk-xfce-engine (line 1248 of
/PKGROOT/ACTIVE/ports/infrastructure/mk/bsd.port.mk).
*** Error code 1
Stop in /data1/obsd-pkg/3.8-current/ports/x11/xfce4 (line 109 of
/PKGROOT/ACTIVE/ports/infrastructure/mk/bsd.port.subdir.mk).
# ^D
Script done on Mon Oct 17 21:46:42 2005
Here is a diff that allowed me to install, but I am unsure whether
the lib revs need to be this specific. I removed Xcursor, Xext,
and Xinerama from WANTLIB because 'make lib-depends-check' said
they were extra. I also removed from WANTLIB anything now specified
by LIB_DEPENDS. Is that correct?
Index: Makefile
===
RCS file: /CVSROOT/ports/x11/xfce4/gtk-xfce-engine/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile22 May 2005 01:30:44 - 1.2
+++ Makefile18 Oct 2005 02:30:20 -
@@ -3,6 +3,7 @@
COMMENT= theme engine for GTK2
V= 4.2.2
DISTNAME= gtk-xfce-engine-2.2.7
+PKGNAME= ${DISTNAME}p0
MASTER_SITES= http://www.xfce.org/archive/xfce-${V}/src/
HOMEPAGE= http://www.xfce.org/
@@ -15,10 +16,11 @@
MODULES= devel/gettext
BUILD_DEPENDS= :pkgconfig-*:devel/pkgconfig
+LIB_DEPENDS=
gdk-x11-2.0.600.0,gdk_pixbuf-2.0.600.0,gtk-x11-2.0.600.0::x11/gtk+2
RUN_DEPENDS= :xfwm4-*:x11/xfce4/xfwm4
-WANTLIB= X11 Xcursor Xext Xft Xinerama Xrender fontconfig freetype m \
- atk-1.0.0.0 gdk-x11-2.0.0.0 gdk_pixbuf-2.0.0.0 glib-2.0.0.0 \
- gmodule-2.0.0.0 gobject-2.0.0.0 gtk-x11-2.0.0.0 pango-1.0.0.0 \
+WANTLIB= X11 Xft Xrender fontconfig freetype m \
+ atk-1.0.0.0 glib-2.0.0.0 \
+ gmodule-2.0.0.0 gobject-2.0.0.0 pango-1.0.0.0 \
pangox-1.0.0.0 pangoxft-1.0.0.0
--
Brad Ely
Patch for missing dep in gtk-xfce-engine
A missing dependency was exposed when I recently did 'make install'
in the /usr/ports/x11/xfce4 directory with no prior graphics (gtk)
ports installed. This is one of those ports that is split into
subdirectories, and gtk-xfce-engine is the first SUBDIR visited.
I had BIN_PACKAGES=YES set, but don't think that is relevant since
any packages I had sitting around were freshly built from the same
CVS update. Here is what happend:
Script started on Mon Oct 17 21:46:26 2005
# make install
=== x11/xfce4/gtk-xfce-engine
=== Checking files for gtk-xfce-engine-2.2.7
`/PKGROOT/ACTIVE/distdir/xfce4/gtk-xfce-engine-2.2.7.tar.gz' is up to date.
Checksum OK for xfce4/gtk-xfce-engine-2.2.7.tar.gz. (sha1)
=== gtk-xfce-engine-2.2.7 depends on: pkgconfig-* - not found
=== Verifying install for pkgconfig-* in devel/pkgconfig
=== Installing pkgconfig-0.19 from
/PKGROOT/3.8-current/packages/all/pkgconfig-0.19.tgz
pkgconfig-0.19: complete
=== Returning to build of gtk-xfce-engine-2.2.7
=== gtk-xfce-engine-2.2.7 depends on: pkgconfig-* - found
=== gtk-xfce-engine-2.2.7 depends on: gettext-=0.10.38 - not found
=== Verifying install for gettext-=0.10.38 in devel/gettext
=== gettext-0.10.40p3 depends on: libiconv-* - not found
=== Verifying install for libiconv-* in converters/libiconv
=== Installing libiconv-1.9.2p1 from
/PKGROOT/3.8-current/packages/all/libiconv-1.9.2p1.tgz
libiconv-1.9.2p1: complete
=== Returning to build of gettext-0.10.40p3
=== gettext-0.10.40p3 depends on: libiconv-* - found
=== gettext-0.10.40p3 depends on: libiconv-* - found
=== Installing gettext-0.10.40p3 from
/PKGROOT/3.8-current/packages/all/gettext-0.10.40p3.tgz
gettext-0.10.40p3: complete
=== Returning to build of gtk-xfce-engine-2.2.7
=== gtk-xfce-engine-2.2.7 depends on: gettext-=0.10.38 - found
=== gtk-xfce-engine-2.2.7 depends on: libiconv-* - found
=== gtk-xfce-engine-2.2.7 depends on: gettext-=0.10.38 - found
=== Verifying specs: iconv.2 intl.1 X11 Xcursor Xext Xft Xinerama Xrender
fontconfig freetype m atk-1.0.0.0 gdk-x11-2.0.0.0 gdk_pixbuf-2.0.0.0
glib-2.0.0.0 gmodule-2.0.0.0 gobject-2.0.0.0 gtk-x11-2.0.0.0 pango-1.0.0.0
pangox-1.0.0.0 pangoxft-1.0.0.0
Missing library for atk-1.0.0.0
Missing library for gdk-x11-2.0.0.0
Missing library for gdk_pixbuf-2.0.0.0
Missing library for glib-2.0.0.0
Missing library for gmodule-2.0.0.0
Missing library for gobject-2.0.0.0
Missing library for gtk-x11-2.0.0.0
Missing library for pango-1.0.0.0
Missing library for pangox-1.0.0.0
Missing library for pangoxft-1.0.0.0
Fatal error
*** Error code 1
Stop in /PKGROOT/ACTIVE/ports/x11/xfce4/gtk-xfce-engine (line 1428 of
/PKGROOT/ACTIVE/ports/infrastructure/mk/bsd.port.mk).
*** Error code 1
Stop in /PKGROOT/ACTIVE/ports/x11/xfce4/gtk-xfce-engine (line 1681 of
/PKGROOT/ACTIVE/ports/infrastructure/mk/bsd.port.mk).
*** Error code 1
Stop in /PKGROOT/ACTIVE/ports/x11/xfce4/gtk-xfce-engine (line 1248 of
/PKGROOT/ACTIVE/ports/infrastructure/mk/bsd.port.mk).
*** Error code 1
Stop in /data1/obsd-pkg/3.8-current/ports/x11/xfce4 (line 109 of
/PKGROOT/ACTIVE/ports/infrastructure/mk/bsd.port.subdir.mk).
# ^D
Script done on Mon Oct 17 21:46:42 2005
Here is a diff that allowed me to install, but I am unsure whether
the lib revs need to be this specific. I removed Xcursor, Xext,
and Xinerama from WANTLIB because 'make lib-depends-check' said
they were extra. I also removed from WANTLIB anything now specified
by LIB_DEPENDS. Is that correct?
Index: Makefile
===
RCS file: /CVSROOT/ports/x11/xfce4/gtk-xfce-engine/Makefile,v
retrieving revision 1.2
diff -u -r1.2 Makefile
--- Makefile22 May 2005 01:30:44 - 1.2
+++ Makefile18 Oct 2005 02:30:20 -
@@ -3,6 +3,7 @@
COMMENT= theme engine for GTK2
V= 4.2.2
DISTNAME= gtk-xfce-engine-2.2.7
+PKGNAME= ${DISTNAME}p0
MASTER_SITES= http://www.xfce.org/archive/xfce-${V}/src/
HOMEPAGE= http://www.xfce.org/
@@ -15,10 +16,11 @@
MODULES= devel/gettext
BUILD_DEPENDS= :pkgconfig-*:devel/pkgconfig
+LIB_DEPENDS=
gdk-x11-2.0.600.0,gdk_pixbuf-2.0.600.0,gtk-x11-2.0.600.0::x11/gtk+2
RUN_DEPENDS= :xfwm4-*:x11/xfce4/xfwm4
-WANTLIB= X11 Xcursor Xext Xft Xinerama Xrender fontconfig freetype m \
- atk-1.0.0.0 gdk-x11-2.0.0.0 gdk_pixbuf-2.0.0.0 glib-2.0.0.0 \
- gmodule-2.0.0.0 gobject-2.0.0.0 gtk-x11-2.0.0.0 pango-1.0.0.0 \
+WANTLIB= X11 Xft Xrender fontconfig freetype m \
+ atk-1.0.0.0 glib-2.0.0.0 \
+ gmodule-2.0.0.0 gobject-2.0.0.0 pango-1.0.0.0 \
pangox-1.0.0.0 pangoxft-1.0.0.0
--
Brad Ely
