Re: [NEW]devel/py-anyio
On 2023/12/20 19:44, Daniel Dickman wrote: > > > > If I read things correctly, it's anyio that has the tight version spec, > > so there should be a mention in there. (However I don't see that reflected > > in jupyter_server's pyproject file, which just says anyio>=3.1.0...) > > I assume you're looking at a more recent version of jupyter_server. For > example I see the latest on pypi is 2.12.1. Ah, that explains it, I was looking at the most recent pyproject.toml in git. > Unfortunately we're so far behind with our jupyter ports that the version > I'm looking to bring in to start is 1.8.0 from May 2021. That version has: > > $ grep -n anyio setup.cfg > 43: anyio>=3.1.0,<4 > > I wasn't able to work out how to go straight to all the latest jupyter > versions and it looks to me like updates may need to be done in small > steps. > > One of the biggest pain points is going to the next version of nbconvert > will require us to add nbclient as a new dep which seems to result in > various circulat dependencies. And that seems to be a headache because I > think Python is able to handle circular dependencies, while our ports tree > cannot handle ciruclar RDEPs. We can however place a dependency in what is technically the wrong port though. Say X requires Y and vice-versa but in practice they're only really used by Z - we can put the dep on both X and Y within Z and that will be good enough for real world use. > I haven't worked out if it'll even be possible to upgrade jupyter fully in > our tree, but essentially the more we can update with updating nbconvert, > the better as a start. > > As a first step I was able to get jupyter notebook updated to 6.5.6 (the > last version before the 7.x series which makes things a bit tricky). So > let me start by sending that to ports@ shortly... > > I also did the work to get jupyterlab 3.2.9. I'll send that out as well. >
Re: [NEW]devel/py-anyio
> > If I read things correctly, it's anyio that has the tight version spec, > so there should be a mention in there. (However I don't see that reflected > in jupyter_server's pyproject file, which just says anyio>=3.1.0...) I assume you're looking at a more recent version of jupyter_server. For example I see the latest on pypi is 2.12.1. Unfortunately we're so far behind with our jupyter ports that the version I'm looking to bring in to start is 1.8.0 from May 2021. That version has: $ grep -n anyio setup.cfg 43: anyio>=3.1.0,<4 I wasn't able to work out how to go straight to all the latest jupyter versions and it looks to me like updates may need to be done in small steps. One of the biggest pain points is going to the next version of nbconvert will require us to add nbclient as a new dep which seems to result in various circulat dependencies. And that seems to be a headache because I think Python is able to handle circular dependencies, while our ports tree cannot handle ciruclar RDEPs. I haven't worked out if it'll even be possible to upgrade jupyter fully in our tree, but essentially the more we can update with updating nbconvert, the better as a start. As a first step I was able to get jupyter notebook updated to 6.5.6 (the last version before the 7.x series which makes things a bit tricky). So let me start by sending that to ports@ shortly... I also did the work to get jupyterlab 3.2.9. I'll send that out as well.
Re: [NEW]devel/py-anyio
On 2023/12/19 23:14, Lucas Raab wrote: > On Tue, Dec 19, 2023 at 10:02:13PM +, Stuart Henderson wrote: > > On 2023/12/19 21:46, Lucas Raab wrote: > > > On Tue, Dec 19, 2023 at 02:49:14PM -0500, Daniel Dickman wrote: > > > > > > > > > > > > > On Dec 19, 2023, at 2:21 PM, Lucas Raab > > > > > wrote: > > > > > > > > > > On Fri, Dec 15, 2023 at 07:16:01AM +, wen heping wrote: > > > > >> Hi, ports@: > > > > >> > > > > >>Here is a patch to create new port devel/py-anyio, > > > > >> which is required by the creating of devel/py-httpx, > > > > >> which is required by some other ports. > > > > >> > > > > >> It build well and run well on amd64-current system. > > > > >> The result of `make test`: > > > > >> 4 failed, 931 passed, 453 skipped > > > > >> so many tests skip because of lack of py-uvloop in > > > > >> our portstree. > > > > >> > > > > >> > > > > >> Cheers ! > > > > >> wen > > > > > > > > > > ok lraab@ > > > > > > > > > > > > > Actually this cannot be imported as is because it will break my work to > > > > add jupyterlab support. > > > > > > > > I would be ok with version 3.7.1 though or any version below anyio 4.0. > > > > > > > > The constraint on my end is jupyter_server. > > > > > > > Hm, I think that would cap an eventual httpx import to 0.25.0 or 0.25.1. > > > Those should take an httpcore version less than 1.* and httpcore 0.18.0 > > > will accept anyio>=3.0,<5.0. 3.7.1 is the last release before 4.0 for > > > anyio, as a matter of interest. h11 that wen sent is 0.14.0 which is an > > > acceptable version for httpcore 0.18.0 as well. > > > > > > wen, how does that sound to you? > > > > > > > Sounds alright to me fwiw (slightly annoying, but it is what it is). > > > > Please make sure there's a quick note in the Makefile explaining that > > it's intentionally held back and why. > > > Alrighty, how's this look taking that into account? If I read things correctly, it's anyio that has the tight version spec, so there should be a mention in there. (However I don't see that reflected in jupyter_server's pyproject file, which just says anyio>=3.1.0...) So I'd go for comments like in the attached. (I removed the patch in www/py-httpcore/patches/patch-pyproject_toml as well, it's not needed with the hatch-fancy-pypi-readme dep). anyio,httpcore.tgz Description: application/tar-gz
Re: [NEW]devel/py-anyio
On Tue, Dec 19, 2023 at 08:53:15PM -0500, Daniel Dickman wrote: > > > On Tue, 19 Dec 2023, Lucas Raab wrote: > > > On Tue, Dec 19, 2023 at 10:02:13PM +, Stuart Henderson wrote: > > > On 2023/12/19 21:46, Lucas Raab wrote: > > > > On Tue, Dec 19, 2023 at 02:49:14PM -0500, Daniel Dickman wrote: > > > > > > > > > > > > > > > > On Dec 19, 2023, at 2:21?PM, Lucas Raab > > > > > > wrote: > > > > > > > > > > > > On Fri, Dec 15, 2023 at 07:16:01AM +, wen heping wrote: > > > > > >> Hi, ports@: > > > > > >> > > > > > >>Here is a patch to create new port devel/py-anyio, > > > > > >> which is required by the creating of devel/py-httpx, > > > > > >> which is required by some other ports. > > > > > >> > > > > > >> It build well and run well on amd64-current system. > > > > > >> The result of `make test`: > > > > > >> 4 failed, 931 passed, 453 skipped > > > > > >> so many tests skip because of lack of py-uvloop in > > > > > >> our portstree. > > > > > >> > > > > > >> > > > > > >> Cheers ! > > > > > >> wen > > > > > > > > > > > > ok lraab@ > > > > > > > > > > > > > > > > Actually this cannot be imported as is because it will break my work > > > > > to add jupyterlab support. > > > > > > > > > > I would be ok with version 3.7.1 though or any version below anyio > > > > > 4.0. > > > > > > > > > > The constraint on my end is jupyter_server. > > > > > > > > > Hm, I think that would cap an eventual httpx import to 0.25.0 or 0.25.1. > > > > Those should take an httpcore version less than 1.* and httpcore 0.18.0 > > > > will accept anyio>=3.0,<5.0. 3.7.1 is the last release before 4.0 for > > > > anyio, as a matter of interest. h11 that wen sent is 0.14.0 which is an > > > > acceptable version for httpcore 0.18.0 as well. > > > > > > > > wen, how does that sound to you? > > > > > > > > > > Sounds alright to me fwiw (slightly annoying, but it is what it is). > > > > > > Please make sure there's a quick note in the Makefile explaining that > > > it's intentionally held back and why. > > > > > Alrighty, how's this look taking that into account? > > > > > > anyio is ok daniel@ to import > > On my end I had: > > COMMENT = async library on top of asyncio or trio > > and: > > CATEGORY = net > > But I'm fine with the proposed port as-is Those sound fine to me if anyone wants to import with the changes py-anyio.tgz Description: application/tar-gz
Re: [NEW]devel/py-anyio
On Tue, 19 Dec 2023, Lucas Raab wrote: > On Tue, Dec 19, 2023 at 10:02:13PM +, Stuart Henderson wrote: > > On 2023/12/19 21:46, Lucas Raab wrote: > > > On Tue, Dec 19, 2023 at 02:49:14PM -0500, Daniel Dickman wrote: > > > > > > > > > > > > > On Dec 19, 2023, at 2:21?PM, Lucas Raab > > > > > wrote: > > > > > > > > > > On Fri, Dec 15, 2023 at 07:16:01AM +, wen heping wrote: > > > > >> Hi, ports@: > > > > >> > > > > >>Here is a patch to create new port devel/py-anyio, > > > > >> which is required by the creating of devel/py-httpx, > > > > >> which is required by some other ports. > > > > >> > > > > >> It build well and run well on amd64-current system. > > > > >> The result of `make test`: > > > > >> 4 failed, 931 passed, 453 skipped > > > > >> so many tests skip because of lack of py-uvloop in > > > > >> our portstree. > > > > >> > > > > >> > > > > >> Cheers ! > > > > >> wen > > > > > > > > > > ok lraab@ > > > > > > > > > > > > > Actually this cannot be imported as is because it will break my work to > > > > add jupyterlab support. > > > > > > > > I would be ok with version 3.7.1 though or any version below anyio 4.0. > > > > > > > > The constraint on my end is jupyter_server. > > > > > > > Hm, I think that would cap an eventual httpx import to 0.25.0 or 0.25.1. > > > Those should take an httpcore version less than 1.* and httpcore 0.18.0 > > > will accept anyio>=3.0,<5.0. 3.7.1 is the last release before 4.0 for > > > anyio, as a matter of interest. h11 that wen sent is 0.14.0 which is an > > > acceptable version for httpcore 0.18.0 as well. > > > > > > wen, how does that sound to you? > > > > > > > Sounds alright to me fwiw (slightly annoying, but it is what it is). > > > > Please make sure there's a quick note in the Makefile explaining that > > it's intentionally held back and why. > > > Alrighty, how's this look taking that into account? > anyio is ok daniel@ to import On my end I had: COMMENT = async library on top of asyncio or trio and: CATEGORY = net But I'm fine with the proposed port as-is
Re: [NEW]devel/py-anyio
On Tue, Dec 19, 2023 at 10:02:13PM +, Stuart Henderson wrote: > On 2023/12/19 21:46, Lucas Raab wrote: > > On Tue, Dec 19, 2023 at 02:49:14PM -0500, Daniel Dickman wrote: > > > > > > > > > > On Dec 19, 2023, at 2:21 PM, Lucas Raab > > > > wrote: > > > > > > > > On Fri, Dec 15, 2023 at 07:16:01AM +, wen heping wrote: > > > >> Hi, ports@: > > > >> > > > >>Here is a patch to create new port devel/py-anyio, > > > >> which is required by the creating of devel/py-httpx, > > > >> which is required by some other ports. > > > >> > > > >> It build well and run well on amd64-current system. > > > >> The result of `make test`: > > > >> 4 failed, 931 passed, 453 skipped > > > >> so many tests skip because of lack of py-uvloop in > > > >> our portstree. > > > >> > > > >> > > > >> Cheers ! > > > >> wen > > > > > > > > ok lraab@ > > > > > > > > > > Actually this cannot be imported as is because it will break my work to > > > add jupyterlab support. > > > > > > I would be ok with version 3.7.1 though or any version below anyio 4.0. > > > > > > The constraint on my end is jupyter_server. > > > > > Hm, I think that would cap an eventual httpx import to 0.25.0 or 0.25.1. > > Those should take an httpcore version less than 1.* and httpcore 0.18.0 > > will accept anyio>=3.0,<5.0. 3.7.1 is the last release before 4.0 for > > anyio, as a matter of interest. h11 that wen sent is 0.14.0 which is an > > acceptable version for httpcore 0.18.0 as well. > > > > wen, how does that sound to you? > > > > Sounds alright to me fwiw (slightly annoying, but it is what it is). > > Please make sure there's a quick note in the Makefile explaining that > it's intentionally held back and why. > Alrighty, how's this look taking that into account? py-httpcore.tgz Description: application/tar-gz py-anyio.tgz Description: application/tar-gz
Re: [NEW]devel/py-anyio
On 2023/12/19 21:46, Lucas Raab wrote: > On Tue, Dec 19, 2023 at 02:49:14PM -0500, Daniel Dickman wrote: > > > > > > > On Dec 19, 2023, at 2:21 PM, Lucas Raab wrote: > > > > > > On Fri, Dec 15, 2023 at 07:16:01AM +, wen heping wrote: > > >> Hi, ports@: > > >> > > >>Here is a patch to create new port devel/py-anyio, > > >> which is required by the creating of devel/py-httpx, > > >> which is required by some other ports. > > >> > > >> It build well and run well on amd64-current system. > > >> The result of `make test`: > > >> 4 failed, 931 passed, 453 skipped > > >> so many tests skip because of lack of py-uvloop in > > >> our portstree. > > >> > > >> > > >> Cheers ! > > >> wen > > > > > > ok lraab@ > > > > > > > Actually this cannot be imported as is because it will break my work to add > > jupyterlab support. > > > > I would be ok with version 3.7.1 though or any version below anyio 4.0. > > > > The constraint on my end is jupyter_server. > > > Hm, I think that would cap an eventual httpx import to 0.25.0 or 0.25.1. > Those should take an httpcore version less than 1.* and httpcore 0.18.0 > will accept anyio>=3.0,<5.0. 3.7.1 is the last release before 4.0 for > anyio, as a matter of interest. h11 that wen sent is 0.14.0 which is an > acceptable version for httpcore 0.18.0 as well. > > wen, how does that sound to you? > Sounds alright to me fwiw (slightly annoying, but it is what it is). Please make sure there's a quick note in the Makefile explaining that it's intentionally held back and why.
Re: [NEW]devel/py-anyio
On Tue, Dec 19, 2023 at 02:49:14PM -0500, Daniel Dickman wrote: > > > > On Dec 19, 2023, at 2:21 PM, Lucas Raab wrote: > > > > On Fri, Dec 15, 2023 at 07:16:01AM +, wen heping wrote: > >> Hi, ports@: > >> > >>Here is a patch to create new port devel/py-anyio, > >> which is required by the creating of devel/py-httpx, > >> which is required by some other ports. > >> > >> It build well and run well on amd64-current system. > >> The result of `make test`: > >> 4 failed, 931 passed, 453 skipped > >> so many tests skip because of lack of py-uvloop in > >> our portstree. > >> > >> > >> Cheers ! > >> wen > > > > ok lraab@ > > > > Actually this cannot be imported as is because it will break my work to add > jupyterlab support. > > I would be ok with version 3.7.1 though or any version below anyio 4.0. > > The constraint on my end is jupyter_server. > Hm, I think that would cap an eventual httpx import to 0.25.0 or 0.25.1. Those should take an httpcore version less than 1.* and httpcore 0.18.0 will accept anyio>=3.0,<5.0. 3.7.1 is the last release before 4.0 for anyio, as a matter of interest. h11 that wen sent is 0.14.0 which is an acceptable version for httpcore 0.18.0 as well. wen, how does that sound to you?
Re: [NEW]devel/py-anyio
> On Dec 19, 2023, at 2:21 PM, Lucas Raab wrote: > > On Fri, Dec 15, 2023 at 07:16:01AM +, wen heping wrote: >> Hi, ports@: >> >>Here is a patch to create new port devel/py-anyio, >> which is required by the creating of devel/py-httpx, >> which is required by some other ports. >> >> It build well and run well on amd64-current system. >> The result of `make test`: >> 4 failed, 931 passed, 453 skipped >> so many tests skip because of lack of py-uvloop in >> our portstree. >> >> >> Cheers ! >> wen > > ok lraab@ > Actually this cannot be imported as is because it will break my work to add jupyterlab support. I would be ok with version 3.7.1 though or any version below anyio 4.0. The constraint on my end is jupyter_server.
Re: [NEW]devel/py-anyio
On Fri, Dec 15, 2023 at 07:16:01AM +, wen heping wrote: > Hi, ports@: > > Here is a patch to create new port devel/py-anyio, > which is required by the creating of devel/py-httpx, > which is required by some other ports. > >It build well and run well on amd64-current system. >The result of `make test`: >4 failed, 931 passed, 453 skipped >so many tests skip because of lack of py-uvloop in > our portstree. > > > Cheers ! > wen ok lraab@
