Re: Say NO to silent builds
http://www.mail-archive.com/ports@openbsd.org/msg34856.html While updating audio/sox to 14.3.2, I noticed that its configure script also recognizes --disable-silent-libtool (and the Makefile uses that). Is that similar to the --disable-silent-rules story (and should it be added globally), or is this just specific to SoX? A quick search suggests that --disable-silent-libtool is a general auto* option. Jan
Re: Say NO to silent builds
On Wed, Jun 01, 2011 at 02:13:17PM +, Christian Weisgerber wrote: Landry Breuil lan...@rhaalovely.net wrote: I've run it through a bulk, breaks : xemacs21/stable graphics/libgexiv2 net/bro print/apsfilter net/mldonkey/stable security/amap Hmm. graphics/libgexiv2 and security/amap built fine here. And they still fail for me with the diff to gnu.port.mk (still uncommited ?): === Configuring for libgexiv2-0.2.2 ./configure: Invalid argument --disable-silent-rules *** Error code 1 === Configuring for amap-5.2p3 Starting amap auto configuration ... Checking for openssl ... ... found Manual page will be install to: /usr/local/share/man Amap will be installed into .../bin and .../etc of: /usr/local (change this by running ./configure --prefix=path) Writing Makefile.in ... Generating Makefile ... ... Error: /usr/obj/ports//amap-5.2/fake-amd64/usr/local/bin/amap does not exist Error: /usr/obj/ports//amap-5.2/fake-amd64/usr/local/bin/amap6 does not exist Error: /usr/obj/ports//amap-5.2/fake-amd64/usr/local/bin/amapcrap does not exist Can't read /usr/obj/ports//amap-5.2/fake-amd64/usr/local/man/man1/amap.1 at /usr/libdata/perl5/OpenBSD/PackingElement.pm line 565. Landry
Re: Say NO to silent builds
Landry Breuil lan...@rhaalovely.net wrote: And they still fail for me with the diff to gnu.port.mk (still uncommited ?): You are still running with the diff kili@ posted here. A slightly different one has been committed. kili's put the option at the beginning of CONFIGURE_ARGS, the one in the tree now puts it at the end. That shouldn't make a difference, but... === Configuring for libgexiv2-0.2.2 ./configure: Invalid argument --disable-silent-rules ... libgexiv uses a hand-rolled configure script and the check for valid arguments is broken. I'll fix the port. === Configuring for amap-5.2p3 I'll look at that one, too. -- Christian naddy Weisgerber na...@mips.inka.de
Re: Say NO to silent builds
On Wed, Jun 01, 2011 at 07:47:52PM -0400, Brad wrote: I think it would make sense to add --disable-silent-rules by default and fix those five ports to deal with it. Also when adding this option in globally please follow up and garbage collect the option from the ports already using said option. I'll do the cleanup.
Re: Say NO to silent builds
Landry Breuil lan...@rhaalovely.net wrote: I've run it through a bulk, breaks : xemacs21/stable graphics/libgexiv2 net/bro print/apsfilter net/mldonkey/stable security/amap Hmm. graphics/libgexiv2 and security/amap built fine here. My list is: print/apsfilter security/its4 editors/xemacs21/stable editors/xemacs21/stable,mule net/mldonkey/stable net/bro -- Christian naddy Weisgerber na...@mips.inka.de
Re: Say NO to silent builds
Christian Weisgerber na...@mips.inka.de wrote: print/apsfilter hand-rolled configure script security/its4 hand-rolled configure script editors/xemacs21/stable editors/xemacs21/stable,mule unholy marriage of custom-baked configuration code and autoconf macros net/mldonkey/stable calls sub-configure with --enable-option-checking=fatal net/bro homebrew AC_LBL_ENABLE_CHECK macro to check for bogus enable/disable options I think it would make sense to add --disable-silent-rules by default and fix those five ports to deal with it. -- Christian naddy Weisgerber na...@mips.inka.de
Re: Say NO to silent builds
On Wed, 1 Jun 2011, Christian Weisgerber wrote: Christian Weisgerber na...@mips.inka.de wrote: print/apsfilter hand-rolled configure script security/its4 hand-rolled configure script editors/xemacs21/stable editors/xemacs21/stable,mule unholy marriage of custom-baked configuration code and autoconf macros net/mldonkey/stable calls sub-configure with --enable-option-checking=fatal net/bro homebrew AC_LBL_ENABLE_CHECK macro to check for bogus enable/disable options I think it would make sense to add --disable-silent-rules by default and fix those five ports to deal with it. FWIW I'm all for it. -- Antoine
Re: Say NO to silent builds
On Wed, 01 Jun 2011, Christian Weisgerber wrote:
Christian Weisgerber na...@mips.inka.de wrote:
print/apsfilter
hand-rolled configure script
security/its4
hand-rolled configure script
editors/xemacs21/stable
editors/xemacs21/stable,mule
unholy marriage of custom-baked configuration code and autoconf
macros
net/mldonkey/stable
calls sub-configure with --enable-option-checking=fatal
net/bro
homebrew AC_LBL_ENABLE_CHECK macro to check for bogus enable/disable
options
Thanks for your analysis. I also am in favor of adding
--disable-silent-rules by default.
Cheers!
David
This is the diff for mldonkey:
Index: Makefile
===
RCS file: /cvs/ports/net/mldonkey/stable/Makefile,v
retrieving revision 1.41
diff -u -p -r1.41 Makefile
--- Makefile16 Apr 2011 12:10:07 - 1.41
+++ Makefile1 Jun 2011 22:07:32 -
@@ -4,7 +4,7 @@ COMMENT = e-donkey client
DISTNAME = mldonkey-3.0.7
CATEGORIES = net
-REVISION = 0
+REVISION = 1
HOMEPAGE = http://mldonkey.sourceforge.net/Main_Page
MASTER_SITES = ${MASTER_SITE_SOURCEFORGE:=mldonkey/}
Index: patches/patch-configure
===
RCS file: patches/patch-configure
diff -N patches/patch-configure
--- /dev/null 1 Jan 1970 00:00:00 -
+++ patches/patch-configure 1 Jun 2011 22:07:32 -
@@ -0,0 +1,10 @@
+$OpenBSD$
+--- configure.orig Wed Jun 1 23:56:39 2011
configure Wed Jun 1 23:56:54 2011
+@@ -43,5 +43,5 @@ else
+ echo Running m4 to generate Makefile...
+ m4 Makefile.in ../Makefile
+fi \
+- ./configure --enable-option-checking=fatal $@
++ ./configure --enable-option-checking $@
+ fi
Re: Say NO to silent builds
diffs for its4 and apsfilter; ok?
On 2011-06-01, Antoine Jacoutot ajacou...@bsdfrog.org wrote:
print/apsfilter
hand-rolled configure script
hackish, but it's already handling infodir like this:
Index: patches/patch-configure
===
RCS file: /cvs/ports/print/apsfilter/patches/patch-configure,v
retrieving revision 1.1
diff -u -p -r1.1 patch-configure
--- patches/patch-configure 17 Jul 2006 19:27:54 - 1.1
+++ patches/patch-configure 1 Jun 2011 22:27:05 -
@@ -1,12 +1,13 @@
$OpenBSD: patch-configure,v 1.1 2006/07/17 19:27:54 espie Exp $
configure.orig Mon Jul 17 21:21:33 2006
-+++ configure Mon Jul 17 21:22:12 2006
-@@ -54,6 +54,9 @@ for option in $@; do
+--- configure.orig Thu Jan 10 20:44:48 2002
configure Wed Jun 1 23:26:53 2011
+@@ -54,6 +54,10 @@ for option in $@; do
--docdir=*) docdir=$optarg ;;
--docdir) shift; docdir=$1 ;;
+ --infodir=*)infodir=$optarg ;;
+ --infodir) shift; infodir=$1 ;;
++ --disable-silent-rules) shift ;;
+
--with-shell=*) with_shell=$optarg ;;
--with-shell) shift; with_shell=$1 ;;
security/its4
hand-rolled configure script
Index: patches/patch-configure
===
RCS file: patches/patch-configure
diff -N patches/patch-configure
--- /dev/null 1 Jan 1970 00:00:00 -
+++ patches/patch-configure 1 Jun 2011 22:29:49 -
@@ -0,0 +1,12 @@
+$OpenBSD$
+--- configure.orig Wed Jun 1 23:27:48 2011
configure Wed Jun 1 23:28:57 2011
+@@ -64,6 +64,8 @@ do
+ mandir)
+ MANDIR=`echo ${ARGUMENT} | sed 's/\/*\$//'`
+ ;;
++disable-silent-rules)
++ ;;
+ program-name | program | prog)
+ if test -n ${ARGUMENT}; then
+ PROGNAME=${ARGUMENT}
editors/xemacs21/stable
editors/xemacs21/stable,mule
unholy marriage of custom-baked configuration code and autoconf
macros
net/bro
homebrew AC_LBL_ENABLE_CHECK macro to check for bogus enable/disable
options
I think it would make sense to add --disable-silent-rules by default
and fix those five ports to deal with it.
FWIW I'm all for it.
Re: Say NO to silent builds
On 01/06/11 6:30 PM, Stuart Henderson wrote:
diffs for its4 and apsfilter; ok?
On 2011-06-01, Antoine Jacoutotajacou...@bsdfrog.org wrote:
print/apsfilter
hand-rolled configure script
hackish, but it's already handling infodir like this:
Index: patches/patch-configure
===
RCS file: /cvs/ports/print/apsfilter/patches/patch-configure,v
retrieving revision 1.1
diff -u -p -r1.1 patch-configure
--- patches/patch-configure 17 Jul 2006 19:27:54 - 1.1
+++ patches/patch-configure 1 Jun 2011 22:27:05 -
@@ -1,12 +1,13 @@
$OpenBSD: patch-configure,v 1.1 2006/07/17 19:27:54 espie Exp $
configure.orig Mon Jul 17 21:21:33 2006
-+++ configure Mon Jul 17 21:22:12 2006
-@@ -54,6 +54,9 @@ for option in $@; do
+--- configure.orig Thu Jan 10 20:44:48 2002
configure Wed Jun 1 23:26:53 2011
+@@ -54,6 +54,10 @@ for option in $@; do
--docdir=*) docdir=$optarg ;;
--docdir) shift; docdir=$1 ;;
+ --infodir=*)infodir=$optarg ;;
+ --infodir) shift; infodir=$1 ;;
++ --disable-silent-rules) shift ;;
+
--with-shell=*) with_shell=$optarg ;;
--with-shell) shift; with_shell=$1 ;;
security/its4
hand-rolled configure script
Index: patches/patch-configure
===
RCS file: patches/patch-configure
diff -N patches/patch-configure
--- /dev/null 1 Jan 1970 00:00:00 -
+++ patches/patch-configure 1 Jun 2011 22:29:49 -
@@ -0,0 +1,12 @@
+$OpenBSD$
+--- configure.orig Wed Jun 1 23:27:48 2011
configure Wed Jun 1 23:28:57 2011
+@@ -64,6 +64,8 @@ do
+ mandir)
+ MANDIR=`echo ${ARGUMENT} | sed 's/\/*\$//'`
+ ;;
++disable-silent-rules)
++ ;;
+ program-name | program | prog)
+ if test -n ${ARGUMENT}; then
+ PROGNAME=${ARGUMENT}
ewww. wrong direction to go in. these are not GNU autoconf scripts.
stop trying to treat them as they were when its clear whomever
created the ports made a mistake in the first place.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Re: Say NO to silent builds
On 01/06/11 5:20 PM, Christian Weisgerber wrote: Christian Weisgerberna...@mips.inka.de wrote: I think it would make sense to add --disable-silent-rules by default and fix those five ports to deal with it. Also when adding this option in globally please follow up and garbage collect the option from the ports already using said option. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
Re: Say NO to silent builds
Matthias Kilian k...@outback.escape.de wrote: AFAIK, configure scripts generated by autoconf ignore (or just warn about) unknown options. More specifically, they error out on other unknown options but ignore/warn for --with-XXX and --enable-XXX (--disable-XXX). This is by design because different configure scripts can be called recursively in subdirectories and can support different --with/--enable flags. Unless I'm completely wrong, this one should be given a try in a bulk build: I've put it into the latest i386 production build. -- Christian naddy Weisgerber na...@mips.inka.de
Re: Say NO to silent builds
On Tue, May 31, 2011 at 10:48:01AM +, Christian Weisgerber wrote: Matthias Kilian k...@outback.escape.de wrote: AFAIK, configure scripts generated by autoconf ignore (or just warn about) unknown options. More specifically, they error out on other unknown options but ignore/warn for --with-XXX and --enable-XXX (--disable-XXX). This is by design because different configure scripts can be called recursively in subdirectories and can support different --with/--enable flags. Unless I'm completely wrong, this one should be given a try in a bulk build: I've put it into the latest i386 production build. I've run it through a bulk, breaks : xemacs21/stable graphics/libgexiv2 net/bro print/apsfilter net/mldonkey/stable security/amap Landry
Re: Say NO to silent builds
On Sun, 29 May 2011, Matthias Kilian wrote:
On Sun, May 29, 2011 at 11:07:27PM +0200, Jasper Lievisse Adriaanse wrote:
Whenever you encounter these kind of builds, please fix it by either
adding:
CONFIGURE_ARGS+= --disable-silent-rules
if you're dealing with a gnu configure script,
AFAIK, configure scripts generated by autoconf ignore (or just warn
about) unknown options. Unless I'm completely wrong, this one should be
given a try in a bulk build:
I would like that if there are no bad side effects. Shouldn't it be
extented to the autoconf CONFIGURE_STYLE as well?
Index: gnu.port.mk
===
RCS file: /cvs/ports/infrastructure/mk/gnu.port.mk,v
retrieving revision 1.41
diff -u -p -r1.41 gnu.port.mk
--- gnu.port.mk 20 Dec 2010 16:39:53 - 1.41
+++ gnu.port.mk 29 May 2011 21:46:12 -
@@ -59,6 +59,7 @@ MODGNU_configure += ; mkdir -p ${MODGNU_
.endif
.if ${CONFIGURE_STYLE:L:Mgnu}
+CONFIGURE_ARGS += --disable-silent-rules
CONFIGURE_ENV += MKDIR_P='mkdir -p'
. if ${MODGNU_SAVE_CACHE:L} == yes
CONFIGURE_ARGS += --cache-file=${WRKBUILD}/config.cache
Ciao,
Kili
--
Antoine
Re: Say NO to silent builds
On 30/05/11 6:20 PM, Antoine Jacoutot wrote: On Sun, 29 May 2011, Matthias Kilian wrote: On Sun, May 29, 2011 at 11:07:27PM +0200, Jasper Lievisse Adriaanse wrote: Whenever you encounter these kind of builds, please fix it by either adding: CONFIGURE_ARGS+= --disable-silent-rules if you're dealing with a gnu configure script, AFAIK, configure scripts generated by autoconf ignore (or just warn about) unknown options. Unless I'm completely wrong, this one should be given a try in a bulk build: I would like that if there are no bad side effects. Shouldn't it be extented to the autoconf CONFIGURE_STYLE as well? autoconf = gnu. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
Re: Say NO to silent builds
On Mon, 30 May 2011, Brad wrote: On 30/05/11 6:20 PM, Antoine Jacoutot wrote: On Sun, 29 May 2011, Matthias Kilian wrote: On Sun, May 29, 2011 at 11:07:27PM +0200, Jasper Lievisse Adriaanse wrote: Whenever you encounter these kind of builds, please fix it by either adding: CONFIGURE_ARGS+= --disable-silent-rules if you're dealing with a gnu configure script, AFAIK, configure scripts generated by autoconf ignore (or just warn about) unknown options. Unless I'm completely wrong, this one should be given a try in a bulk build: I would like that if there are no bad side effects. Shouldn't it be extented to the autoconf CONFIGURE_STYLE as well? autoconf = gnu. Ah right. To more correct, not `=' but appended. -- Antoine
Re: Say NO to silent builds
On Sun, May 29, 2011 at 11:07:27PM +0200, Jasper Lievisse Adriaanse wrote:
Whenever you encounter these kind of builds, please fix it by either
adding:
CONFIGURE_ARGS+= --disable-silent-rules
if you're dealing with a gnu configure script,
AFAIK, configure scripts generated by autoconf ignore (or just warn
about) unknown options. Unless I'm completely wrong, this one should be
given a try in a bulk build:
Index: gnu.port.mk
===
RCS file: /cvs/ports/infrastructure/mk/gnu.port.mk,v
retrieving revision 1.41
diff -u -p -r1.41 gnu.port.mk
--- gnu.port.mk 20 Dec 2010 16:39:53 - 1.41
+++ gnu.port.mk 29 May 2011 21:46:12 -
@@ -59,6 +59,7 @@ MODGNU_configure += ; mkdir -p ${MODGNU_
.endif
.if ${CONFIGURE_STYLE:L:Mgnu}
+CONFIGURE_ARGS += --disable-silent-rules
CONFIGURE_ENV += MKDIR_P='mkdir -p'
. if ${MODGNU_SAVE_CACHE:L} == yes
CONFIGURE_ARGS += --cache-file=${WRKBUILD}/config.cache
Ciao,
Kili
