Re: TEST_POD [was Re: [Update] net/p5-Net-BGP : Update to 0.17]
On 2019/09/18 13:24, Gleydson Soares wrote: > > > > On 18 Sep 2019, at 12:26, Stuart Henderson wrote: > > > >> On 2019/09/18 05:48, Gleydson Soares wrote: > >> > >> > On 18 Sep 2019, at 04:40, Stuart Henderson wrote: > > On 2019/09/18 02:15, wen heping wrote: > Hi, ports@: > > Here is a patch for net/p5-Net-BGP: > i) Update to 0.17 > ii) Add TEST_POD=yes > >>> > >>> I've been wondering for a while... what's the point in using TEST_POD > >>> in ports? Isn't that more of an "author test" kind of thing? > >>> > >> > >> Some p5- ports fails on regress since it depends on p5- pod packages you > >> mean disabling pod tests? > > > > I mean, what's the point in enabling POD tests for things that don't > > normally do them? > > > > sure, adding no-op dependencies is wrong... > It's not usually a no-op dependency, rather it enables tests that seem to me to only be of real interest to the author..
Re: TEST_POD [was Re: [Update] net/p5-Net-BGP : Update to 0.17]
> On 18 Sep 2019, at 12:26, Stuart Henderson wrote: > >> On 2019/09/18 05:48, Gleydson Soares wrote: >> >> On 18 Sep 2019, at 04:40, Stuart Henderson wrote: On 2019/09/18 02:15, wen heping wrote: Hi, ports@: Here is a patch for net/p5-Net-BGP: i) Update to 0.17 ii) Add TEST_POD=yes >>> >>> I've been wondering for a while... what's the point in using TEST_POD >>> in ports? Isn't that more of an "author test" kind of thing? >>> >> >> Some p5- ports fails on regress since it depends on p5- pod packages you >> mean disabling pod tests? > > I mean, what's the point in enabling POD tests for things that don't > normally do them? > sure, adding no-op dependencies is wrong...
Re: TEST_POD [was Re: [Update] net/p5-Net-BGP : Update to 0.17]
On 2019/09/18 05:48, Gleydson Soares wrote: > > > > On 18 Sep 2019, at 04:40, Stuart Henderson wrote: > > > >> On 2019/09/18 02:15, wen heping wrote: > >> Hi, ports@: > >> > >> Here is a patch for net/p5-Net-BGP: > >> i) Update to 0.17 > >> ii) Add TEST_POD=yes > > > > I've been wondering for a while... what's the point in using TEST_POD > > in ports? Isn't that more of an "author test" kind of thing? > > > > Some p5- ports fails on regress since it depends on p5- pod packages you mean > disabling pod tests? I mean, what's the point in enabling POD tests for things that don't normally do them?
Re: TEST_POD [was Re: [Update] net/p5-Net-BGP : Update to 0.17]
> On 18 Sep 2019, at 04:40, Stuart Henderson wrote: > >> On 2019/09/18 02:15, wen heping wrote: >> Hi, ports@: >> >> Here is a patch for net/p5-Net-BGP: >> i) Update to 0.17 >> ii) Add TEST_POD=yes > > I've been wondering for a while... what's the point in using TEST_POD > in ports? Isn't that more of an "author test" kind of thing? > Some p5- ports fails on regress since it depends on p5- pod packages you mean disabling pod tests?
TEST_POD [was Re: [Update] net/p5-Net-BGP : Update to 0.17]
On 2019/09/18 02:15, wen heping wrote: > Hi, ports@: > >Here is a patch for net/p5-Net-BGP: >i) Update to 0.17 >ii) Add TEST_POD=yes I've been wondering for a while... what's the point in using TEST_POD in ports? Isn't that more of an "author test" kind of thing?