Re: Tons of empty man pages for new ports for LedgerSMB
Hi Chris, Chris Bennett wrote on Sun, Aug 30, 2020 at 11:17:24PM -0500: > On 2020/08/27 20:51, Chris Bennett wrote: >> I just found a bunch of new Locale perl modules added to the depends >> list. >> >> They all have empty man pages from no PODs. >> About 20ish ports, most are just relevant data files for each language. >> >> Should I just delete these from the PLISTs or is there an easier way to >> prevent their generation? [...] > The man page problem is from the modules only having just enough of a > POD to name the package. Nothing else. If i understand correctly what you are saying and if your assessment is correct (i didn't check), then essentially upstream is shipping empty manual pages. In such a case, commenting them out in the PLIST seems reasonable to me. Maybe put a comment similar to the following above them, to reduce the risk that upstream later adds content to them but we keep them commented out: @comment When updating, check whether these manuals are still empty. Yours, Ingo
Re: Tons of empty man pages for new ports for LedgerSMB
On Fri, Aug 28, 2020 at 10:20:12AM +0100, Stuart Henderson wrote: > On 2020/08/27 20:51, Chris Bennett wrote: > > I just found a bunch of new Locale perl modules added to the depends > > list. > > > > They all have empty man pages from no PODs. > > About 20ish ports, most are just relevant data files for each language. > > > > Should I just delete these from the PLISTs or is there an easier way to > > prevent their generation? > > > > I'll submit the new dependencies for these, then I need to send the > > rest, which are just perl data modules. > > > > Should I send them individually or one email with all attached? > > I can also put those up somewhere else if that is preferable. > > > > I'll submit one for approval first, if it's OK, then the rest are the > > same except for the data for each langugage. > > > > > > Locale::CLDR and family of Locale::CLDR::Locales:: > > For the data files I suggest an arrangement like > > textproc/p5-Locale-CLDR-Locales > textproc/p5-Locale-CLDR-Locales/lang1 > textproc/p5-Locale-CLDR-Locales/lang2 > textproc/p5-Locale-CLDR-Locales/lang3 > > etc. The Makefile should be mostly common between ports and can be handled > in textproc/p5-Locale-CLDR-Locales/Makefile.inc. Look at editors/vim-spell > or devel/pear-Date-Holidays for ideas. This is easier to review and easier > to handle if things change in the future. > That helps. I looked those over and the mozilla i18n. I see what to work toward. Had to re-read some man pages after looking at these. I'll pull together something small with several langs and see if that works. If that method works OK, I'll do the whole bunch. The man page problem is from the modules only having just enough of a POD to name the package. Nothing else. Thanks, -- Chris Bennett
Re: Tons of empty man pages for new ports for LedgerSMB
On Thu, Aug 27, 2020 at 08:30:08PM -0700, Andrew Hewus Fresh wrote:
> On Thu, Aug 27, 2020 at 08:51:52PM -0500, Chris Bennett wrote:
> > I just found a bunch of new Locale perl modules added to the depends
> > list.
> >
> > They all have empty man pages from no PODs.
> > About 20ish ports, most are just relevant data files for each language.
>
> Do you have an example? "No pod" shouldn't generate man pages I
> wouldn't think.
>
>
> > Should I just delete these from the PLISTs or is there an easier way to
> > prevent their generation?
>
> Not entirely sure without an example but often the best action is to
> @comment them out as `make update-plist` recognizes that idiom and
> updates the PLIST keeping the comments.
>
>
> > I'll submit the new dependencies for these, then I need to send the
> > rest, which are just perl data modules.
> >
> > Should I send them individually or one email with all attached?
> > I can also put those up somewhere else if that is preferable.
> >
> > I'll submit one for approval first, if it's OK, then the rest are the
> > same except for the data for each langugage.
> >
> >
> > Locale::CLDR and family of Locale::CLDR::Locales::
>
> I will review them in bulk (after September 7th when I'm back to
> computers), so I prefer a single email with all the new modules. I will
> admit that more than ten or so at the same time is hard to keep track
> of. Hard to set an exact limit, but since so many are very similar it
> seems reasonable to do them all together.
>
> I would also like all of them listed in the email so when I reply I can
> OK them or provide feedback individually and be more certain I didn't
> miss anything.
>
> I don't think there's a definitely correct answer there though.
>
> l8rZ,
> --
> andrew - http://afresh1.com
>
> The programmer's national anthem is 'GH!!'.
>
Here are the main module plus one of the language modules.
As Stewart said, they ought to follow one of his examples or some other
one. I'm also posting two other requirements as WIP.
I'm inlineing the two Makefiles here too.
# $OpenBSD$
COMMENT = create locale objects with localisation data from CLDR
DISTNAME = Locale-CLDR-v0.34.0
PKGNAME = p5-${DISTNAME:S/v//}
CATEGORIES =textproc
# Perl
PERMIT_PACKAGE =Yes
MODULES = cpan
BUILD_DEPENDS = devel/p5-Module-Build>=0.40 \
devel/p5-Test-Exception
RUN_DEPENDS = devel/p5-MooX-ClassAttribute>=0.011 \
converters/p5-Unicode-Regex-Set \
devel/p5-Class-Load \
devel/p5-DateTime>=0.72 \
devel/p5-DateTime-Locale \
devel/p5-List-MoreUtils \
devel/p5-Moo>=2 \
devel/p5-Type-Tiny \
devel/p5-namespace-autoclean>=0.16
MAKE_ENV += TEST_POD=1 \
RELEASE_TESTING=''
CONFIGURE_STYLE = modbuild
PKG_ARCH = *
.include
# $OpenBSD$
COMMENT = data package for Perl localization data for Spanish
DISTNAME = Locale-CLDR-Locales-Es-v0.34.0
PKGNAME = p5-${DISTNAME:S/v//}
CATEGORIES =textproc
# Perl
PERMIT_PACKAGE =Yes
MODULES = cpan
BUILD_DEPENDS = devel/p5-Module-Build>=0.40 \
devel/p5-Test-Exception
RUN_DEPENDS = devel/p5-Locale-CLDR>=0.34.0 \
devel/p5-MooX-ClassAttribute>=0.011 \
devel/p5-DateTime>=0.72 \
devel/p5-Moo>=2 \
devel/p5-Type-Tiny
MAKE_ENV += TEST_POD=1 \
RELEASE_TESTING=''
CONFIGURE_STYLE = modbuild
PKG_ARCH = *
.include
Thanks,
--
Chris Bennett
p5-Locale-CLDR-0.34.0.tar.gz
Description: GNU Zip compressed data
p5-Locale-CLDR-Locales-Es-0.34.0.tar.gz
Description: GNU Zip compressed data
Re: Tons of empty man pages for new ports for LedgerSMB
On 2020/08/27 20:51, Chris Bennett wrote: > I just found a bunch of new Locale perl modules added to the depends > list. > > They all have empty man pages from no PODs. > About 20ish ports, most are just relevant data files for each language. > > Should I just delete these from the PLISTs or is there an easier way to > prevent their generation? > > I'll submit the new dependencies for these, then I need to send the > rest, which are just perl data modules. > > Should I send them individually or one email with all attached? > I can also put those up somewhere else if that is preferable. > > I'll submit one for approval first, if it's OK, then the rest are the > same except for the data for each langugage. > > > Locale::CLDR and family of Locale::CLDR::Locales:: For the data files I suggest an arrangement like textproc/p5-Locale-CLDR-Locales textproc/p5-Locale-CLDR-Locales/lang1 textproc/p5-Locale-CLDR-Locales/lang2 textproc/p5-Locale-CLDR-Locales/lang3 etc. The Makefile should be mostly common between ports and can be handled in textproc/p5-Locale-CLDR-Locales/Makefile.inc. Look at editors/vim-spell or devel/pear-Date-Holidays for ideas. This is easier to review and easier to handle if things change in the future.
Re: Tons of empty man pages for new ports for LedgerSMB
On Thu, Aug 27, 2020 at 08:51:52PM -0500, Chris Bennett wrote: > I just found a bunch of new Locale perl modules added to the depends > list. > > They all have empty man pages from no PODs. > About 20ish ports, most are just relevant data files for each language. Do you have an example? "No pod" shouldn't generate man pages I wouldn't think. > Should I just delete these from the PLISTs or is there an easier way to > prevent their generation? Not entirely sure without an example but often the best action is to @comment them out as `make update-plist` recognizes that idiom and updates the PLIST keeping the comments. > I'll submit the new dependencies for these, then I need to send the > rest, which are just perl data modules. > > Should I send them individually or one email with all attached? > I can also put those up somewhere else if that is preferable. > > I'll submit one for approval first, if it's OK, then the rest are the > same except for the data for each langugage. > > > Locale::CLDR and family of Locale::CLDR::Locales:: I will review them in bulk (after September 7th when I'm back to computers), so I prefer a single email with all the new modules. I will admit that more than ten or so at the same time is hard to keep track of. Hard to set an exact limit, but since so many are very similar it seems reasonable to do them all together. I would also like all of them listed in the email so when I reply I can OK them or provide feedback individually and be more certain I didn't miss anything. I don't think there's a definitely correct answer there though. l8rZ, -- andrew - http://afresh1.com The programmer's national anthem is 'GH!!'.
Tons of empty man pages for new ports for LedgerSMB
I just found a bunch of new Locale perl modules added to the depends list. They all have empty man pages from no PODs. About 20ish ports, most are just relevant data files for each language. Should I just delete these from the PLISTs or is there an easier way to prevent their generation? I'll submit the new dependencies for these, then I need to send the rest, which are just perl data modules. Should I send them individually or one email with all attached? I can also put those up somewhere else if that is preferable. I'll submit one for approval first, if it's OK, then the rest are the same except for the data for each langugage. Locale::CLDR and family of Locale::CLDR::Locales:: Thanks -- Chris Bennett
