Re: UPDATE: redshift 1.9.1 - 1.10
I don't think we will ever support that... so while I see no problem having these files around as part of a standard install target, I see no reason to force the installation of such files if upstream does not do it. Ok I just tried the diff and the appdata is properly installed without the need for a post-install target. So case closed on that particular one ;-) -- Antoine
Re: UPDATE: redshift 1.9.1 - 1.10
On Fri, Jan 09, 2015 at 08:00:53PM -0500, Brad Smith wrote: On 01/09/15 19:46, Antoine Jacoutot wrote: On Fri, Jan 09, 2015 at 09:34:02PM +, Scarlett wrote: Needs testing on non-amd64 and of redshift-gtk by someone with a gnomish setup. Are the makefile changes ok? Seems fine at first glance. I'll have a deeper look tomorrow, thanks for the diff. Just one question, what's the point in installing the appdata file -- I don't think there's any application that can make use of it on OpenBSD. I was curious what these files were for as I noticed one pop up when I updated Pidgin as I didn't have to install it myself with a post-install target. But looking around I see this is part of the fd.o specs. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. It's only used by market-like stuffs so far. See https://wiki.gnome.org/Apps/Software for an example. I don't think we will ever support that... so while I see no problem having these files around as part of a standard install target, I see no reason to force the installation of such files if upstream does not do it. -- Antoine
Re: UPDATE: redshift 1.9.1 - 1.10
On 2015-01-09 21:34:02, Scarlett scarl...@xavin.net wrote: Needs testing on non-amd64 and of redshift-gtk by someone with a gnomish setup. Are the makefile changes ok? I can't comment on the Makefile changes, but it seems to working fine so far on i386. I don't use Gnome, so I can't comment on the -gtk portion of it either, but the base program is doing what I expect it to do. -- Bryan
Re: UPDATE: redshift 1.9.1 - 1.10
On Fri, Jan 09, 2015 at 09:34:02PM +, Scarlett wrote:
Needs testing on non-amd64 and of redshift-gtk by someone with a
gnomish setup.
Are the makefile changes ok?
Seems fine at first glance.
I'll have a deeper look tomorrow, thanks for the diff.
Just one question, what's the point in installing the appdata file -- I don't
think there's any application that can make use of it on OpenBSD.
Scarlett
Index: Makefile
===
RCS file: /cvs/ports/misc/redshift/Makefile,v
retrieving revision 1.21
diff -u -p -r1.21 Makefile
--- Makefile 12 Sep 2014 06:24:01 - 1.21
+++ Makefile 9 Jan 2015 21:24:56 -
@@ -2,9 +2,8 @@
COMMENT= automatic color temperature adjustment
-V= 1.9.1
+V= 1.10
DISTNAME=redshift-${V}
-REVISION=0
GH_PROJECT= redshift
GH_ACCOUNT= jonls
@@ -17,11 +16,14 @@ HOMEPAGE= http://jonls.dk/redshift/
# GPLv3
PERMIT_PACKAGE_CDROM=Yes
-WANTLIB += X11 Xxf86vm c dbus-1 dbus-glib-1 drm geoclue glib-2.0
-WANTLIB += gobject-2.0 m pthread xcb xcb-randr xml2
+WANTLIB += X11 Xau Xdmcp Xext Xxf86vm c dbus-1 dbus-glib-1 drm
+WANTLIB += ffi geoclue gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0
+WANTLIB += lzma m pcre pthread pthread-stubs xcb xcb-randr xml2
+WANTLIB += z
MODULES= devel/gettext \
- lang/python
+ lang/python \
+ textproc/intltool
MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
MODPY_ADJ_FILES= src/redshift-gtk/redshift-gtk.in
@@ -44,12 +46,19 @@ CONFIGURE_ARGS= --enable-gui
AUTOCONF_VERSION=2.69
AUTOMAKE_VERSION=1.14
BUILD_DEPENDS += ${MODGNU_AUTOCONF_DEPENDS} \
- ${MODGNU_AUTOMAKE_DEPENDS}
+ ${MODGNU_AUTOMAKE_DEPENDS} \
+ devel/libtool
pre-configure:
cd ${WRKSRC} \
AUTOCONF_VERSION=${AUTOCONF_VERSION} \
AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
- autoreconf -i
+ ./bootstrap
+
+post-install:
+ ${INSTALL_DATA_DIR} ${PREFIX}/share/appdata
+ ${INSTALL_DATA} \
+ ${WRKSRC}/data/appdata/redshift-gtk.appdata.xml \
+ ${PREFIX}/share/appdata
.include bsd.port.mk
Index: distinfo
===
RCS file: /cvs/ports/misc/redshift/distinfo,v
retrieving revision 1.5
diff -u -p -r1.5 distinfo
--- distinfo 29 Aug 2014 22:07:38 - 1.5
+++ distinfo 9 Jan 2015 21:24:56 -
@@ -1,2 +1,2 @@
-SHA256 (v1.9.1.tar.gz) = MWNqdsNUTNHv081D9EPZe2P50nxLzJBhmJfPSJ6nR2Y=
-SIZE (v1.9.1.tar.gz) = 163257
+SHA256 (v1.10.tar.gz) = 96HKHsz2YplXN+FPiUwrFRk5I/u+N40VHjRqgBNkTxY=
+SIZE (v1.10.tar.gz) = 519595
Index: pkg/PLIST
===
RCS file: /cvs/ports/misc/redshift/pkg/PLIST,v
retrieving revision 1.7
diff -u -p -r1.7 PLIST
--- pkg/PLIST 29 Aug 2014 22:07:38 - 1.7
+++ pkg/PLIST 9 Jan 2015 21:24:56 -
@@ -16,6 +16,8 @@ lib/python${MODPY_VERSION}/site-packages
lib/python${MODPY_VERSION}/site-packages/redshift_gtk/statusicon.py
lib/python${MODPY_VERSION}/site-packages/redshift_gtk/utils.py
@man man/man1/redshift.1
+share/appdata/
+share/appdata/redshift-gtk.appdata.xml
share/applications/redshift-gtk.desktop
share/icons/hicolor/scalable/apps/redshift-status-off.svg
share/icons/hicolor/scalable/apps/redshift-status-on.svg
@@ -36,6 +38,7 @@ share/locale/gl/LC_MESSAGES/redshift.mo
share/locale/he/LC_MESSAGES/redshift.mo
share/locale/hi/LC_MESSAGES/redshift.mo
share/locale/hr/LC_MESSAGES/redshift.mo
+share/locale/hu/LC_MESSAGES/redshift.mo
share/locale/it/LC_MESSAGES/redshift.mo
share/locale/ja/LC_MESSAGES/redshift.mo
share/locale/ka/LC_MESSAGES/redshift.mo
--
Antoine
Re: UPDATE: redshift 1.9.1 - 1.10
On 01/09/15 19:46, Antoine Jacoutot wrote: On Fri, Jan 09, 2015 at 09:34:02PM +, Scarlett wrote: Needs testing on non-amd64 and of redshift-gtk by someone with a gnomish setup. Are the makefile changes ok? Seems fine at first glance. I'll have a deeper look tomorrow, thanks for the diff. Just one question, what's the point in installing the appdata file -- I don't think there's any application that can make use of it on OpenBSD. I was curious what these files were for as I noticed one pop up when I updated Pidgin as I didn't have to install it myself with a post-install target. But looking around I see this is part of the fd.o specs. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.
UPDATE: redshift 1.9.1 - 1.10
Needs testing on non-amd64 and of redshift-gtk by someone with a
gnomish setup.
Are the makefile changes ok?
Scarlett
Index: Makefile
===
RCS file: /cvs/ports/misc/redshift/Makefile,v
retrieving revision 1.21
diff -u -p -r1.21 Makefile
--- Makefile12 Sep 2014 06:24:01 - 1.21
+++ Makefile9 Jan 2015 21:24:56 -
@@ -2,9 +2,8 @@
COMMENT= automatic color temperature adjustment
-V= 1.9.1
+V= 1.10
DISTNAME= redshift-${V}
-REVISION= 0
GH_PROJECT=redshift
GH_ACCOUNT=jonls
@@ -17,11 +16,14 @@ HOMEPAGE= http://jonls.dk/redshift/
# GPLv3
PERMIT_PACKAGE_CDROM= Yes
-WANTLIB += X11 Xxf86vm c dbus-1 dbus-glib-1 drm geoclue glib-2.0
-WANTLIB += gobject-2.0 m pthread xcb xcb-randr xml2
+WANTLIB += X11 Xau Xdmcp Xext Xxf86vm c dbus-1 dbus-glib-1 drm
+WANTLIB += ffi geoclue gio-2.0 glib-2.0 gmodule-2.0 gobject-2.0
+WANTLIB += lzma m pcre pthread pthread-stubs xcb xcb-randr xml2
+WANTLIB += z
MODULES= devel/gettext \
- lang/python
+ lang/python \
+ textproc/intltool
MODPY_VERSION= ${MODPY_DEFAULT_VERSION_3}
MODPY_ADJ_FILES= src/redshift-gtk/redshift-gtk.in
@@ -44,12 +46,19 @@ CONFIGURE_ARGS= --enable-gui
AUTOCONF_VERSION= 2.69
AUTOMAKE_VERSION= 1.14
BUILD_DEPENDS += ${MODGNU_AUTOCONF_DEPENDS} \
- ${MODGNU_AUTOMAKE_DEPENDS}
+ ${MODGNU_AUTOMAKE_DEPENDS} \
+ devel/libtool
pre-configure:
cd ${WRKSRC} \
AUTOCONF_VERSION=${AUTOCONF_VERSION} \
AUTOMAKE_VERSION=${AUTOMAKE_VERSION} \
- autoreconf -i
+ ./bootstrap
+
+post-install:
+ ${INSTALL_DATA_DIR} ${PREFIX}/share/appdata
+ ${INSTALL_DATA} \
+ ${WRKSRC}/data/appdata/redshift-gtk.appdata.xml \
+ ${PREFIX}/share/appdata
.include bsd.port.mk
Index: distinfo
===
RCS file: /cvs/ports/misc/redshift/distinfo,v
retrieving revision 1.5
diff -u -p -r1.5 distinfo
--- distinfo29 Aug 2014 22:07:38 - 1.5
+++ distinfo9 Jan 2015 21:24:56 -
@@ -1,2 +1,2 @@
-SHA256 (v1.9.1.tar.gz) = MWNqdsNUTNHv081D9EPZe2P50nxLzJBhmJfPSJ6nR2Y=
-SIZE (v1.9.1.tar.gz) = 163257
+SHA256 (v1.10.tar.gz) = 96HKHsz2YplXN+FPiUwrFRk5I/u+N40VHjRqgBNkTxY=
+SIZE (v1.10.tar.gz) = 519595
Index: pkg/PLIST
===
RCS file: /cvs/ports/misc/redshift/pkg/PLIST,v
retrieving revision 1.7
diff -u -p -r1.7 PLIST
--- pkg/PLIST 29 Aug 2014 22:07:38 - 1.7
+++ pkg/PLIST 9 Jan 2015 21:24:56 -
@@ -16,6 +16,8 @@ lib/python${MODPY_VERSION}/site-packages
lib/python${MODPY_VERSION}/site-packages/redshift_gtk/statusicon.py
lib/python${MODPY_VERSION}/site-packages/redshift_gtk/utils.py
@man man/man1/redshift.1
+share/appdata/
+share/appdata/redshift-gtk.appdata.xml
share/applications/redshift-gtk.desktop
share/icons/hicolor/scalable/apps/redshift-status-off.svg
share/icons/hicolor/scalable/apps/redshift-status-on.svg
@@ -36,6 +38,7 @@ share/locale/gl/LC_MESSAGES/redshift.mo
share/locale/he/LC_MESSAGES/redshift.mo
share/locale/hi/LC_MESSAGES/redshift.mo
share/locale/hr/LC_MESSAGES/redshift.mo
+share/locale/hu/LC_MESSAGES/redshift.mo
share/locale/it/LC_MESSAGES/redshift.mo
share/locale/ja/LC_MESSAGES/redshift.mo
share/locale/ka/LC_MESSAGES/redshift.mo
