Re: UPDATE: x11/st 0.8 -> 0.8.1

[Joerg Jung]

> On 20. Mar 2018, at 22:12, Klemens Nanni  wrote:
> 
> Small regression fix release:
> 
>   f4020b2 fix regression by selecting clipboard text
>   a5a928b don't modify argv, use a counter
>   6ac8c8a selextend: clarify: !sel.mode == SEL_IDLE
>   5345db3 clipcopy: no need to check for free(NULL), set to NULL after 
> free
>   7648697 minor code-style: whitespace fixes
>   0b507bb Fix title initialization
>   e7ef3c4 Fix regression from 69e32a6 when setting title.
> 
> Works fine for me on amd64, OK?


ok jung  but for post 6.3


> Index: Makefile
> ===
> RCS file: /cvs/ports/x11/st/Makefile,v
> retrieving revision 1.16
> diff -u -p -r1.16 Makefile
> --- Makefile  17 Mar 2018 13:28:39 -  1.16
> +++ Makefile  20 Mar 2018 21:05:19 -
> @@ -2,7 +2,7 @@
> 
> COMMENT=  simple X terminal
> 
> -V=   0.8
> +V=   0.8.1
> DISTNAME= st-${V}
> 
> CATEGORIES=   x11
> @@ -15,7 +15,7 @@ MAINTAINER= Joerg Jung  PERMIT_PACKAGE_CDROM= Yes
> 
> # uses pledge()
> -WANTLIB= c m util X11 Xft fontconfig freetype z
> +WANTLIB= X11 Xft fontconfig c freetype m util z
> 
> MASTER_SITES= https://dl.suckless.org/st/
> 
> Index: distinfo
> ===
> RCS file: /cvs/ports/x11/st/distinfo,v
> retrieving revision 1.10
> diff -u -p -r1.10 distinfo
> --- distinfo  17 Mar 2018 13:28:39 -  1.10
> +++ distinfo  20 Mar 2018 21:05:19 -
> @@ -1,2 +1,2 @@
> -SHA256 (st-0.8.tar.gz) = dzU5INB9ZsaEoPV+w3wmcMQv3FyHHWOCtwFgHNxZdXY=
> -SIZE (st-0.8.tar.gz) = 45401
> +SHA256 (st-0.8.1.tar.gz) = xPsP4rjS071ecnY+gKiuBbfUTbrI+OO7GO8BYccmaSY=
> +SIZE (st-0.8.1.tar.gz) = 45423
> Index: patches/patch-st_c
> ===
> RCS file: /cvs/ports/x11/st/patches/patch-st_c,v
> retrieving revision 1.5
> diff -u -p -r1.5 patch-st_c
> --- patches/patch-st_c17 Mar 2018 13:28:39 -  1.5
> +++ patches/patch-st_c20 Mar 2018 21:05:19 -
> @@ -2,7 +2,7 @@ $OpenBSD: patch-st_c,v 1.5 2018/03/17 13
> Index: st.c
> --- st.c.orig
> +++ st.c
> -@@ -806,9 +806,13 @@ ttynew(char *line, char *cmd, char *out, char **args)
> +@@ -805,9 +805,13 @@ ttynew(char *line, char *cmd, char *out, char **args)
>   die("ioctl TIOCSCTTY failed: %s\n", strerror(errno));
>   close(s);
>   close(m);
> 

Re: UPDATE: x11/st 0.8 -> 0.8.1

[Jeremie Courreges-Anglas]

On Wed, Mar 21 2018, Klemens Nanni  wrote:
> On Wed, Mar 21, 2018 at 12:58:28AM +0100, Jeremie Courreges-Anglas wrote:
>> On Tue, Mar 20 2018, Klemens Nanni  wrote:
>> > Small regression fix release:
>> >
>> >f4020b2 fix regression by selecting clipboard text
>> >a5a928b don't modify argv, use a counter
>> >6ac8c8a selextend: clarify: !sel.mode == SEL_IDLE
>> >5345db3 clipcopy: no need to check for free(NULL), set to NULL after 
>> > free
>> >7648697 minor code-style: whitespace fixes
>> >0b507bb Fix title initialization
>> >e7ef3c4 Fix regression from 69e32a6 when setting title.
>> >
>> > Works fine for me on amd64, OK?
>> 
>> Pasting the X selection (shift+insert) in st worked with st-0.7 and
>> doesn't work any more in 0.8 and 0.8.1.  I don't normally use st, just
>> testing.
> Upstream changed keybindings:
>
>   $ git diff 0.7 0.8.1 config.def.h | fgrep selpaste
>   -   { ShiftMask,XK_Insert,  selpaste,   {.i =  
> 0} },
>   +   { TERMMOD,  XK_Y,   selpaste,   {.i =  
> 0} },

Hah, that explains, thanks for investigating.  Unless the regressions
are an annoyance for the end user I would suggest to commit this post
6.3.

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Re: UPDATE: x11/st 0.8 -> 0.8.1

[Klemens Nanni]

On Wed, Mar 21, 2018 at 12:58:28AM +0100, Jeremie Courreges-Anglas wrote:
> On Tue, Mar 20 2018, Klemens Nanni  wrote:
> > Small regression fix release:
> >
> > f4020b2 fix regression by selecting clipboard text
> > a5a928b don't modify argv, use a counter
> > 6ac8c8a selextend: clarify: !sel.mode == SEL_IDLE
> > 5345db3 clipcopy: no need to check for free(NULL), set to NULL after 
> > free
> > 7648697 minor code-style: whitespace fixes
> > 0b507bb Fix title initialization
> > e7ef3c4 Fix regression from 69e32a6 when setting title.
> >
> > Works fine for me on amd64, OK?
> 
> Pasting the X selection (shift+insert) in st worked with st-0.7 and
> doesn't work any more in 0.8 and 0.8.1.  I don't normally use st, just
> testing.
Upstream changed keybindings:

$ git diff 0.7 0.8.1 config.def.h | fgrep selpaste
-   { ShiftMask,XK_Insert,  selpaste,   {.i =  
0} },
+   { TERMMOD,  XK_Y,   selpaste,   {.i =  
0} },

Re: UPDATE: x11/st 0.8 -> 0.8.1

[Jeremie Courreges-Anglas]

On Tue, Mar 20 2018, Klemens Nanni  wrote:
> Small regression fix release:
>
>   f4020b2 fix regression by selecting clipboard text
>   a5a928b don't modify argv, use a counter
>   6ac8c8a selextend: clarify: !sel.mode == SEL_IDLE
>   5345db3 clipcopy: no need to check for free(NULL), set to NULL after 
> free
>   7648697 minor code-style: whitespace fixes
>   0b507bb Fix title initialization
>   e7ef3c4 Fix regression from 69e32a6 when setting title.
>
> Works fine for me on amd64, OK?

Pasting the X selection (shift+insert) in st worked with st-0.7 and
doesn't work any more in 0.8 and 0.8.1.  I don't normally use st, just
testing.

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

UPDATE: x11/st 0.8 -> 0.8.1

[Klemens Nanni]

Small regression fix release:

f4020b2 fix regression by selecting clipboard text
a5a928b don't modify argv, use a counter
6ac8c8a selextend: clarify: !sel.mode == SEL_IDLE
5345db3 clipcopy: no need to check for free(NULL), set to NULL after 
free
7648697 minor code-style: whitespace fixes
0b507bb Fix title initialization
e7ef3c4 Fix regression from 69e32a6 when setting title.

Works fine for me on amd64, OK?

Index: Makefile
===
RCS file: /cvs/ports/x11/st/Makefile,v
retrieving revision 1.16
diff -u -p -r1.16 Makefile
--- Makefile17 Mar 2018 13:28:39 -  1.16
+++ Makefile20 Mar 2018 21:05:19 -
@@ -2,7 +2,7 @@
 
 COMMENT=   simple X terminal
 
-V= 0.8
+V= 0.8.1
 DISTNAME=  st-${V}
 
 CATEGORIES=x11
@@ -15,7 +15,7 @@ MAINTAINER=   Joerg Jung