Re: UPDATE security/py-asn1crypto to 0.24.0

2018-05-20 Thread Mikolaj Kucharski
Hi Stuart,

On Sun, May 20, 2018 at 07:22:37PM +0100, Stuart Henderson wrote:
> If it's necessary to use the github version and there's only an
> autogenerated file (rather than an uploaded release asset) then please
> stick to GH_* variables rather than the DISTNAME+DISTFILES+MASTER_SITES
> mess..
> 
> But it would be preferable to switch to the pypi tarball.

Tarball on PyPi doesn't have tests, so I'm sticking to the current approach.
I see the GH_* way and the DISTNAME+DISTFILES+MASTER_SITES way generate
exactly the same tarball. I was not aware of this. Thanks.

> Please kill the trailing /, update-plist no longer adds it.

Done.


Index: Makefile
===
RCS file: /cvs/ports/security/py-asn1crypto/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -u -r1.1.1.1 Makefile
--- Makefile5 Nov 2017 17:44:18 -   1.1.1.1
+++ Makefile20 May 2018 19:08:22 -
@@ -2,7 +2,7 @@
 
 COMMENT =  fast ASN.1 parser and serializer
 
-MODPY_EGG_VERSION = 0.23.0
+MODPY_EGG_VERSION = 0.24.0
 GH_TAGNAME =   ${MODPY_EGG_VERSION}
 GH_ACCOUNT =   wbond
 GH_PROJECT =   asn1crypto
Index: distinfo
===
RCS file: /cvs/ports/security/py-asn1crypto/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -u -r1.1.1.1 distinfo
--- distinfo5 Nov 2017 17:44:18 -   1.1.1.1
+++ distinfo20 May 2018 19:08:22 -
@@ -1,2 +1,2 @@
-SHA256 (asn1crypto-0.23.0.tar.gz) = 
iEtbo9m0QsFyn2eYHT3euFodfb01GZAAoLyNB3VINS0=
-SIZE (asn1crypto-0.23.0.tar.gz) = 636829
+SHA256 (asn1crypto-0.24.0.tar.gz) = 
0qgrs8KeGryzdrWWeVELWN15bIE/iYPy25tF6asigZA=
+SIZE (asn1crypto-0.24.0.tar.gz) = 641322
Index: pkg/PLIST
===
RCS file: /cvs/ports/security/py-asn1crypto/pkg/PLIST,v
retrieving revision 1.1.1.1
diff -u -p -u -r1.1.1.1 PLIST
--- pkg/PLIST   5 Nov 2017 17:44:18 -   1.1.1.1
+++ pkg/PLIST   20 May 2018 19:08:22 -
@@ -6,7 +6,7 @@ lib/python${MODPY_VERSION}/site-packages
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/dependency_links.txt
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
 lib/python${MODPY_VERSION}/site-packages/asn1crypto/__init__.py
-@comment lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}/
+${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}_elliptic_curve.${MODPY_PYC_MAGIC_TAG}pyc
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}_errors.${MODPY_PYC_MAGIC_TAG}pyc
@@ -41,7 +41,7 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/asn1crypto/_ordereddict.py
 lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/
 lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/__init__.py
-@comment 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}/
+${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}_big_num_ctypes.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/_big_num_ctypes.py


-- 
Regards,
 Mikolaj



Re: UPDATE security/py-asn1crypto to 0.24.0

2018-05-20 Thread Stuart Henderson
On 2018/05/20 16:48, Mikolaj Kucharski wrote:
> Hi,
> 
> I wanted to fix plist in py-asn1crypto, but looked at home
> page and I've noticed new version available on GitHub
> releases page.
> 
> make test for py2 and py3 pass and simple testing of ansible
> doesn't show any issues.
> 
> 
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/security/py-asn1crypto/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -u -r1.1.1.1 Makefile
> --- Makefile  5 Nov 2017 17:44:18 -   1.1.1.1
> +++ Makefile  20 May 2018 15:35:33 -
> @@ -2,10 +2,9 @@
>  
>  COMMENT =fast ASN.1 parser and serializer
>  
> -MODPY_EGG_VERSION = 0.23.0
> -GH_TAGNAME = ${MODPY_EGG_VERSION}
> -GH_ACCOUNT = wbond
> -GH_PROJECT = asn1crypto
> +MODPY_EGG_VERSION = 0.24.0
> +DISTNAME =   asn1crypto-${MODPY_EGG_VERSION}
> +DISTFILES =  ${DISTNAME}{${MODPY_EGG_VERSION}}.tar.gz
>  PKGNAME =py-${DISTNAME}
>  
>  CATEGORIES = security
> @@ -14,6 +13,8 @@ HOMEPAGE =  https://github.com/wbond/asn1
>  
>  # MIT
>  PERMIT_PACKAGE_CDROM =   Yes
> +
> +MASTER_SITES =   https://github.com/wbond/asn1crypto/archive/

If it's necessary to use the github version and there's only an
autogenerated file (rather than an uploaded release asset) then please
stick to GH_* variables rather than the DISTNAME+DISTFILES+MASTER_SITES
mess..

But it would be preferable to switch to the pypi tarball.

> -@comment 
> lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}/
> +${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}/
...
> -@comment 
> lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}/
> +${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}/

Please kill the trailing /, update-plist no longer adds it.



Re: UPDATE security/py-asn1crypto to 0.24.0

2018-05-20 Thread Mikolaj Kucharski
On Sun, May 20, 2018 at 04:48:24PM +0100, Mikolaj Kucharski wrote:
> make test for py2 and py3 pass and simple testing of ansible
> doesn't show any issues.

actually ansible tests are irrelevant here



UPDATE security/py-asn1crypto to 0.24.0

2018-05-20 Thread Mikolaj Kucharski
Hi,

I wanted to fix plist in py-asn1crypto, but looked at home
page and I've noticed new version available on GitHub
releases page.

make test for py2 and py3 pass and simple testing of ansible
doesn't show any issues.



Index: Makefile
===
RCS file: /cvs/ports/security/py-asn1crypto/Makefile,v
retrieving revision 1.1.1.1
diff -u -p -u -r1.1.1.1 Makefile
--- Makefile5 Nov 2017 17:44:18 -   1.1.1.1
+++ Makefile20 May 2018 15:35:33 -
@@ -2,10 +2,9 @@
 
 COMMENT =  fast ASN.1 parser and serializer
 
-MODPY_EGG_VERSION = 0.23.0
-GH_TAGNAME =   ${MODPY_EGG_VERSION}
-GH_ACCOUNT =   wbond
-GH_PROJECT =   asn1crypto
+MODPY_EGG_VERSION = 0.24.0
+DISTNAME = asn1crypto-${MODPY_EGG_VERSION}
+DISTFILES =${DISTNAME}{${MODPY_EGG_VERSION}}.tar.gz
 PKGNAME =  py-${DISTNAME}
 
 CATEGORIES =   security
@@ -14,6 +13,8 @@ HOMEPAGE =https://github.com/wbond/asn1
 
 # MIT
 PERMIT_PACKAGE_CDROM = Yes
+
+MASTER_SITES = https://github.com/wbond/asn1crypto/archive/
 
 MODULES =  lang/python
 
Index: distinfo
===
RCS file: /cvs/ports/security/py-asn1crypto/distinfo,v
retrieving revision 1.1.1.1
diff -u -p -u -r1.1.1.1 distinfo
--- distinfo5 Nov 2017 17:44:18 -   1.1.1.1
+++ distinfo20 May 2018 15:35:33 -
@@ -1,2 +1,2 @@
-SHA256 (asn1crypto-0.23.0.tar.gz) = 
iEtbo9m0QsFyn2eYHT3euFodfb01GZAAoLyNB3VINS0=
-SIZE (asn1crypto-0.23.0.tar.gz) = 636829
+SHA256 (asn1crypto-0.24.0.tar.gz) = 
0qgrs8KeGryzdrWWeVELWN15bIE/iYPy25tF6asigZA=
+SIZE (asn1crypto-0.24.0.tar.gz) = 641322
Index: pkg/PLIST
===
RCS file: /cvs/ports/security/py-asn1crypto/pkg/PLIST,v
retrieving revision 1.1.1.1
diff -u -p -u -r1.1.1.1 PLIST
--- pkg/PLIST   5 Nov 2017 17:44:18 -   1.1.1.1
+++ pkg/PLIST   20 May 2018 15:35:33 -
@@ -6,7 +6,7 @@ lib/python${MODPY_VERSION}/site-packages
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/dependency_links.txt
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto-${MODPY_EGG_VERSION}-py${MODPY_VERSION}.egg-info/top_level.txt
 lib/python${MODPY_VERSION}/site-packages/asn1crypto/__init__.py
-@comment lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}/
+${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}/
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}_elliptic_curve.${MODPY_PYC_MAGIC_TAG}pyc
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/${MODPY_PYCACHE}_errors.${MODPY_PYC_MAGIC_TAG}pyc
@@ -41,7 +41,7 @@ lib/python${MODPY_VERSION}/site-packages
 lib/python${MODPY_VERSION}/site-packages/asn1crypto/_ordereddict.py
 lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/
 lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/__init__.py
-@comment 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}/
+${MODPY_COMMENT}lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}/
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}__init__.${MODPY_PYC_MAGIC_TAG}pyc
 
lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/${MODPY_PYCACHE}_big_num_ctypes.${MODPY_PYC_MAGIC_TAG}pyc
 lib/python${MODPY_VERSION}/site-packages/asn1crypto/_perf/_big_num_ctypes.py