Re: git stable update (was Re: Update to git-2.14.2)

2017-09-27 Thread Stuart Henderson
On 2017/09/27 02:53, Daniel Jakots wrote:
> On Tue, 26 Sep 2017 17:22:36 -0400, Daniel Jakots 
> wrote:
> 
> > I'll look into a patch for -stable.
> 
> attached

OK.



Re: Update to git-2.14.2

2017-09-26 Thread Matthew Martin
On Tue, Sep 26, 2017 at 05:22:36PM -0400, Daniel Jakots wrote:
> Hi,
> 
> Patch to update to latest release. Security advisory:
> http://seclists.org/oss-sec/2017/q3/att-534/git_cvsserver.txt
> 
> make test looks sorta good:
> fixed   2
> success 16200
> failed  0
> broken  221
> total   16602
> (in the current version I have 'broken 222')
> 
> I'll look into a patch for -stable.
> 
> naddy, sthen you're in cc because I can smell the lock from here.
> 
> Comments? OK?
> 
> Cheers,
> Daniel

Works for me on OpenBSD 6.2 (GENERIC.MP) #111: Tue Sep 26 11:09:09 MDT 2017.

Similar test results and I see no difference in my usual workflow.

- Matthew Martin



git stable update (was Re: Update to git-2.14.2)

2017-09-26 Thread Daniel Jakots
On Tue, 26 Sep 2017 17:22:36 -0400, Daniel Jakots 
wrote:

> I'll look into a patch for -stable.

attachedIndex: Makefile
===
RCS file: /cvs/ports/devel/git/Makefile,v
retrieving revision 1.168.2.1
diff -u -p -r1.168.2.1 Makefile
--- Makefile	11 Aug 2017 12:44:18 -	1.168.2.1
+++ Makefile	27 Sep 2017 02:50:44 -
@@ -4,7 +4,7 @@ COMMENT-main =	GIT - Tree History Storag
 COMMENT-svn =	GIT - subversion interoperability tools
 COMMENT-x11 =	GIT - graphical tools
 
-V =		2.12.4
+V =		2.12.5
 DISTNAME =	git-${V}
 PKGNAME-main =	${DISTNAME}
 PKGNAME-svn =	git-svn-${V}
Index: distinfo
===
RCS file: /cvs/ports/devel/git/distinfo,v
retrieving revision 1.129.2.1
diff -u -p -r1.129.2.1 distinfo
--- distinfo	11 Aug 2017 12:44:18 -	1.129.2.1
+++ distinfo	27 Sep 2017 02:50:44 -
@@ -1,4 +1,4 @@
-SHA256 (git-2.12.4.tar.gz) = sleG8KE+OalVjuylbADHWHA8gDvekPm8WrVPS+Lrsf8=
-SHA256 (git-manpages-2.12.4.tar.gz) = 4OashhshzmBHNnTYj48+GvbifVugzt3vL4z/Am8ux9I=
-SIZE (git-2.12.4.tar.gz) = 6407661
-SIZE (git-manpages-2.12.4.tar.gz) = 654944
+SHA256 (git-2.12.5.tar.gz) = HXpZdahpoMufSHa6Hf/rc2ciZt5VNkosoUC8/kAah78=
+SHA256 (git-manpages-2.12.5.tar.gz) = eshP/V4TDMkS3cc4BeCKz8JZ2etTbUpXg40FRuC2vQE=
+SIZE (git-2.12.5.tar.gz) = 6409179
+SIZE (git-manpages-2.12.5.tar.gz) = 655108


Re: Update to git-2.14.2

2017-09-26 Thread Stuart Henderson
On 2017/09/26 21:56, Daniel Jakots wrote:
> On Tue, 26 Sep 2017 22:34:37 +0100, Stuart Henderson
>  wrote:
> 
> > but someone, please look at a source code diff
> 
> Attached the diffs between the two make extract. I try to clean it a it
> (remove the rel note, man patches) but there is also the original in
> case I removed too much stuff.

ugh, 5k lines of actual code diff, I don't know why I was expecting
a "point release" that is a security fix to have a smallish readable
diff *sigh*



Re: Update to git-2.14.2

2017-09-26 Thread Stuart Henderson
On 2017/09/26 21:22, Daniel Jakots wrote:
> Hi,
> 
> Patch to update to latest release. Security advisory:
> http://seclists.org/oss-sec/2017/q3/att-534/git_cvsserver.txt
> 
> make test looks sorta good:
> fixed   2
> success 16200
> failed  0
> broken  221
> total   16602
> (in the current version I have 'broken 222')
> 
> I'll look into a patch for -stable.
> 
> naddy, sthen you're in cc because I can smell the lock from here.
> 
> Comments? OK?
> 
> Cheers,
> Daniel

Fix should go in. ENOTIME to look myself now, but someone, please look
at a source code diff and do some good testing and make sure there isn't
anything screwed up like there was in 2.13.1 :)



Update to git-2.14.2

2017-09-26 Thread Daniel Jakots
Hi,

Patch to update to latest release. Security advisory:
http://seclists.org/oss-sec/2017/q3/att-534/git_cvsserver.txt

make test looks sorta good:
fixed   2
success 16200
failed  0
broken  221
total   16602
(in the current version I have 'broken 222')

I'll look into a patch for -stable.

naddy, sthen you're in cc because I can smell the lock from here.

Comments? OK?

Cheers,
DanielIndex: Makefile
===
RCS file: /cvs/ports/devel/git/Makefile,v
retrieving revision 1.179
diff -u -p -r1.179 Makefile
--- Makefile	11 Aug 2017 12:37:04 -	1.179
+++ Makefile	26 Sep 2017 21:15:41 -
@@ -4,7 +4,7 @@ COMMENT-main =	GIT - Tree History Storag
 COMMENT-svn =	GIT - subversion interoperability tools
 COMMENT-x11 =	GIT - graphical tools
 
-V =		2.14.1
+V =		2.14.2
 DISTNAME =	git-${V}
 PKGNAME-main =	${DISTNAME}
 PKGNAME-svn =	git-svn-${V}
Index: distinfo
===
RCS file: /cvs/ports/devel/git/distinfo,v
retrieving revision 1.136
diff -u -p -r1.136 distinfo
--- distinfo	11 Aug 2017 12:37:04 -	1.136
+++ distinfo	26 Sep 2017 21:15:41 -
@@ -1,4 +1,4 @@
-SHA256 (git-2.14.1.tar.gz) = AZJTSbloOUDlOmIe5I3Z2aw/nlnAeYBrWDIcLPhaRGQ=
-SHA256 (git-manpages-2.14.1.tar.gz) = jFgQzmXUTNMzMn06EVxbRicSovgSJdFC4HvYia2NwOA=
-SIZE (git-2.14.1.tar.gz) = 6987933
-SIZE (git-manpages-2.14.1.tar.gz) = 665202
+SHA256 (git-2.14.2.tar.gz) = oDoSMx1Pmw9xcz259H4SMtTdzgDn8qbiD27JoZzl/2E=
+SHA256 (git-manpages-2.14.2.tar.gz) = kFwKVUoWeq1l9T5HZAFXzrFKeYv+zI6W2PneWtyxNec=
+SIZE (git-2.14.2.tar.gz) = 7001045
+SIZE (git-manpages-2.14.2.tar.gz) = 666468
Index: patches/patch-Makefile
===
RCS file: /cvs/ports/devel/git/patches/patch-Makefile,v
retrieving revision 1.72
diff -u -p -r1.72 patch-Makefile
--- patches/patch-Makefile	5 Aug 2017 19:09:05 -	1.72
+++ patches/patch-Makefile	26 Sep 2017 21:15:41 -
@@ -2,7 +2,7 @@ $OpenBSD: patch-Makefile,v 1.72 2017/08/
 Index: Makefile
 --- Makefile.orig
 +++ Makefile
-@@ -2411,7 +2411,7 @@ export TEST_NO_MALLOC_CHECK
+@@ -2410,7 +2410,7 @@ export TEST_NO_MALLOC_CHECK
  
  ### Testing rules
  
Index: patches/patch-gitweb_gitweb_perl
===
RCS file: /cvs/ports/devel/git/patches/patch-gitweb_gitweb_perl,v
retrieving revision 1.28
diff -u -p -r1.28 patch-gitweb_gitweb_perl
--- patches/patch-gitweb_gitweb_perl	4 Dec 2016 15:29:46 -	1.28
+++ patches/patch-gitweb_gitweb_perl	26 Sep 2017 21:15:41 -
@@ -2,9 +2,10 @@ $OpenBSD: patch-gitweb_gitweb_perl,v 1.2
 
 This prevents the following error: '-T and -B not implemented on filehandles'
 
 gitweb/gitweb.perl.orig	Tue Nov 29 22:06:51 2016
-+++ gitweb/gitweb.perl	Fri Dec  2 16:09:37 2016
-@@ -7003,7 +7003,7 @@ sub git_blob_plain {
+Index: gitweb/gitweb.perl
+--- gitweb/gitweb.perl.orig
 gitweb/gitweb.perl
+@@ -7005,7 +7005,7 @@ sub git_blob_plain {
  		$expires = "+1d";
  	}
  
@@ -13,7 +14,7 @@ This prevents the following error: '-T a
  		or die_error(500, "Open git-cat-file blob '$hash' failed");
  
  	# content-type (can include charset)
-@@ -7065,7 +7065,7 @@ sub git_blob {
+@@ -7067,7 +7067,7 @@ sub git_blob {
  	}
  
  	my $have_blame = gitweb_check_feature('blame');
Index: patches/patch-t_t0001-init_sh
===
RCS file: patches/patch-t_t0001-init_sh
diff -N patches/patch-t_t0001-init_sh
--- patches/patch-t_t0001-init_sh	10 Aug 2017 09:11:07 -	1.2
+++ /dev/null	1 Jan 1970 00:00:00 -
@@ -1,70 +0,0 @@
-$OpenBSD: patch-t_t0001-init_sh,v 1.2 2017/08/10 09:11:07 dcoppa Exp $
-
-commit bed67874e235e8f128607728f9a03c71e92cb955
-Author: Rene Scharfe 
-Date:   Mon Aug 7 13:04:18 2017 +0200
-
-t0001: skip test with restrictive permissions if getpwd(3) respects them
-
-The sub-test "init in long base path" in t0001 checks the ability to
-handle long base paths with restrictive permissions (--x).  On OpenBSD
-getcwd(3) fails in that case even for short paths.  Check the two
-aspects separately by trying to use a long base path both with and
-without execute-only permissions.  Only attempt the former if we know
-that getcwd(3) doesn't care.
-
-Original-patch-by: David Coppa 
-Reported-by: Aevar Arnfjoro Bjarmason 
-Signed-off-by: Rene Scharfe 
-Signed-off-by: Junio C Hamano 
-
-Index: t/t0001-init.sh
 t/t0001-init.sh.orig
-+++ t/t0001-init.sh
-@@ -315,18 +315,44 @@ test_expect_success 'init with separate gitdir' '
- 	test_path_is_dir realgitdir/refs
- '
- 
--test_expect_success 'init in long base path' '
-+test_lazy_prereq GETCWD_IGNORES_PERMS '
-+	base=GETCWD_TEST_BASE_DIR &&
-+	mkdir -p $base/dir &&
-+	chmod 100 $base ||
-+	error "bug in test script: cannot prepare $base"
-+
-+	(cd $base/dir && /bin/pwd -P)
-+	status=$?
-+
-+	chmod 700 $base &&
-+	rm -rf $base ||
-+	error "bug in test script: cannot clean $base"
-+	return $status