Re: Update www/p5-Mojo 6.40 1/3

[Landry Breuil]

On Fri, Jan 22, 2016 at 12:58:56PM +0100, Landry Breuil wrote:
> On Fri, Jan 22, 2016 at 11:31:38AM +, Nigel Taylor wrote:
> > 
> > 
> > On 01/20/16 09:03, Mark Patruck wrote:
> > > Update www/p5-Mojo to 6.40.
> > > 
> > > - since 6.33 www/p5-Mojo depends on IO::Socket::IP 0.37 and according
> > >   to afresh1@ we won't get Perl 5.22.1 before the lock, so i've restored
> > >   net/p5-IO-Socket-IP from the attic (the patch is obsolete as fixed up-
> > >   stream)
> > > 
> > >   I've also updated ports/net/Makefile...diff is below
> > > 
> > 
> > Obvious No from me, needs a lot more to convince me.
> > 
> > p5-IO-Socket-Socks 0.67 requires IO::Socket::IP 0.37 but has been held
> > back at 0.65. The only way to update IO::Socket::IP is in the core,
> > followed by extensive tests. Having two possible IO::Socket:IP during
> > builds / runtime means testing twice. This is not the same as just
> > moving a port to a new version. You need not only to bring back
> > IO::Socket::IP but everything related and move it forward, to it so it's
> > an incomplete change.
> 
> I dont see the issue with readding IO::Socket::IP 0.37 in the portstree,
> since .. it was there before, and the ports using it were working fine
> with it. It's not like there have been tremendous changes between 0.37
> and 0.29
> (http://cpansearch.perl.org/src/PEVANS/IO-Socket-IP-0.37/Changes) and it
> will come with perl 5.22 anyway.

Fwiw, the requirement in mojo was bumped in
https://github.com/kraih/mojo/commit/c0342de13c9c52ad963683018e56a0558f452517

Landry

Re: Update www/p5-Mojo 6.40 1/3

[Landry Breuil]

On Fri, Jan 22, 2016 at 11:31:38AM +, Nigel Taylor wrote:
> 
> 
> On 01/20/16 09:03, Mark Patruck wrote:
> > Update www/p5-Mojo to 6.40.
> > 
> > - since 6.33 www/p5-Mojo depends on IO::Socket::IP 0.37 and according
> >   to afresh1@ we won't get Perl 5.22.1 before the lock, so i've restored
> >   net/p5-IO-Socket-IP from the attic (the patch is obsolete as fixed up-
> >   stream)
> > 
> >   I've also updated ports/net/Makefile...diff is below
> > 
> 
> Obvious No from me, needs a lot more to convince me.
> 
> p5-IO-Socket-Socks 0.67 requires IO::Socket::IP 0.37 but has been held
> back at 0.65. The only way to update IO::Socket::IP is in the core,
> followed by extensive tests. Having two possible IO::Socket:IP during
> builds / runtime means testing twice. This is not the same as just
> moving a port to a new version. You need not only to bring back
> IO::Socket::IP but everything related and move it forward, to it so it's
> an incomplete change.

I dont see the issue with readding IO::Socket::IP 0.37 in the portstree,
since .. it was there before, and the ports using it were working fine
with it. It's not like there have been tremendous changes between 0.37
and 0.29
(http://cpansearch.perl.org/src/PEVANS/IO-Socket-IP-0.37/Changes) and it
will come with perl 5.22 anyway.

I was about to commit it along the p5-Mojo updates but reading your
mail, i'll let you handle this whole thing now, or we just keep the
p5-Mojo version we have now and wait for perl 5.22 :)

Landry

Re: Update www/p5-Mojo 6.40 1/3

[Stuart Henderson]

I'm running amavisd/spamassassin with the updated IO::Socket::IP
with no problems.

Here are all the hits from a search of .pm and .pl files from ports
source unpacked at the end of August - (require|use).*IO::Socket::IP.
We could add deps to these pretty easily.


p5-ldap-0.65/perl-ldap-0.65/lib/Net/LDAP.pm
35:   eval { require IO::Socket::IP;
IO::Socket::IP->VERSION(0.20); }

amavisd-new-2.10.1/amavisd-new-2.10.1/TinyRedis.pm
22:  if (eval { require IO::Socket::IP }) {

amavisd-new-2.10.1/amavisd-new-2.10.1/p0f-analyzer.pl
72:  if (eval { require IO::Socket::IP }) {

p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Plugin/DCC.pm
96:  if (eval { require IO::Socket::IP }) {

p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Util/TinyRedis.pm
31:  if (eval { require IO::Socket::IP }) {

p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Client.pm
65:  if (eval { require IO::Socket::IP }) {

p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/DnsResolver.pm
58:  if (eval { require IO::Socket::IP }) {

p5-Net-HTTP-6.09/Net-HTTP-6.09/lib/Net/HTTP.pm
11:if (eval { require IO::Socket::IP }) {

p5-Net-INET6Glue-0.603/Net-INET6Glue-0.603/lib/Net/INET6Glue/INET_is_INET6.pm
14:if ( eval "require IO::Socket::IP"

p5-IO-Socket-SSL-2.016/IO-Socket-SSL-2.016/lib/IO/Socket/SSL.pm
288: require IO::Socket::IP;

p5-Mojolicious-6.17/Mojolicious-6.17/lib/Mojo/IOLoop/Client.pm
5:use IO::Socket::IP;

p5-Mojolicious-6.17/Mojolicious-6.17/lib/Mojo/IOLoop/Server.pm
7:use IO::Socket::IP;

p5-Plack-1.0033/Plack-1.0033/lib/HTTP/Server/PSGI.pm
72:eval { require IO::Socket::IP; 1 }
73:or Carp::croak("

Re: Update www/p5-Mojo 6.40 1/3

[Nigel Taylor]

On 01/20/16 09:03, Mark Patruck wrote:
> Update www/p5-Mojo to 6.40.
> 
> - since 6.33 www/p5-Mojo depends on IO::Socket::IP 0.37 and according
>   to afresh1@ we won't get Perl 5.22.1 before the lock, so i've restored
>   net/p5-IO-Socket-IP from the attic (the patch is obsolete as fixed up-
>   stream)
> 
>   I've also updated ports/net/Makefile...diff is below
> 

Obvious No from me, needs a lot more to convince me.

p5-IO-Socket-Socks 0.67 requires IO::Socket::IP 0.37 but has been held
back at 0.65. The only way to update IO::Socket::IP is in the core,
followed by extensive tests. Having two possible IO::Socket:IP during
builds / runtime means testing twice. This is not the same as just
moving a port to a new version. You need not only to bring back
IO::Socket::IP but everything related and move it forward, to it so it's
an incomplete change.

Expand on the exact problems solved, what test show they have been
solved. IO::Socket::IP 0.29 is passing the tests www/p5-Mojo runs.

To ensure testing correct thing you need to run a bulk and machine with

doas rm /usr/libdata/perl5/IO/Socket/IP.pm

ensuring you keep p5-IO-Socket-IP installed.

You have to run the tests on every single perl port, in case
IO:::Scoket::IP is used, and ensure results match.

Scanning the source can also be used to find which use IO::Socket:IP.

Normal bulk builds aren't enough every port should be capable of being
built by just installing it's build dependencies, so the port is not
using another unrelated port's dependencies that happened to have been
built before.


The above need this so brought back and updated doesn't close close to
what's required.


$ cvs -R -q up -p -r 1.434 INDEX | grep IO-Socket-IP | indexfmt -0 | cut
-d~ -f1-2
amavisd-new-2.10.1~mail/amavisd-new,-main
p5-Mail-SpamAssassin-3.4.0p4~mail/p5-Mail-SpamAssassin
p5-Net-INET6Glue-0.603~net/p5-Net-INET6Glue
p5-Mojolicious-5.58p0~www/p5-Mojo


Where are the others? This is not complete because it's missing
TEST_DEPENDS. But does tell me your not close to finding what's required.

Re: Update www/p5-Mojo 6.40 1/3

[Abel Abraham Camarillo Ojeda]

On Fri, Jan 22, 2016 at 6:32 AM, Stuart Henderson  wrote:
> I'm running amavisd/spamassassin with the updated IO::Socket::IP
> with no problems.
>
> Here are all the hits from a search of .pm and .pl files from ports
> source unpacked at the end of August - (require|use).*IO::Socket::IP.
> We could add deps to these pretty easily.
>
>
> p5-ldap-0.65/perl-ldap-0.65/lib/Net/LDAP.pm
> 35:   eval { require IO::Socket::IP;
> IO::Socket::IP->VERSION(0.20); }
>
> amavisd-new-2.10.1/amavisd-new-2.10.1/TinyRedis.pm
> 22:  if (eval { require IO::Socket::IP }) {
>
> amavisd-new-2.10.1/amavisd-new-2.10.1/p0f-analyzer.pl
> 72:  if (eval { require IO::Socket::IP }) {
>
> p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Plugin/DCC.pm
> 96:  if (eval { require IO::Socket::IP }) {
>
> p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Util/TinyRedis.pm
> 31:  if (eval { require IO::Socket::IP }) {
>
> p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Client.pm
> 65:  if (eval { require IO::Socket::IP }) {
>
> p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/DnsResolver.pm
> 58:  if (eval { require IO::Socket::IP }) {
>
> p5-Net-HTTP-6.09/Net-HTTP-6.09/lib/Net/HTTP.pm
> 11:if (eval { require IO::Socket::IP }) {
>
> p5-Net-INET6Glue-0.603/Net-INET6Glue-0.603/lib/Net/INET6Glue/INET_is_INET6.pm
> 14:if ( eval "require IO::Socket::IP"
>
> p5-IO-Socket-SSL-2.016/IO-Socket-SSL-2.016/lib/IO/Socket/SSL.pm
> 288: require IO::Socket::IP;
>
> p5-Mojolicious-6.17/Mojolicious-6.17/lib/Mojo/IOLoop/Client.pm
> 5:use IO::Socket::IP;
>
> p5-Mojolicious-6.17/Mojolicious-6.17/lib/Mojo/IOLoop/Server.pm
> 7:use IO::Socket::IP;


> p5-Plack-1.0033/Plack-1.0033/lib/HTTP/Server/PSGI.pm
> 72:eval { require IO::Socket::IP; 1 }
> 73:or Carp::croak("
>

I can take this... 

I'd also love to see p5-Mojo to move forward

diff coming soon~

thanks

Re: Update www/p5-Mojo 6.40 1/3

[Mark Patruck]

On Fri, Jan 22, 2016 at 11:31:38AM +, Nigel Taylor wrote:
> 
> 
> On 01/20/16 09:03, Mark Patruck wrote:
> > Update www/p5-Mojo to 6.40.
> > 
> > - since 6.33 www/p5-Mojo depends on IO::Socket::IP 0.37 and according
> >   to afresh1@ we won't get Perl 5.22.1 before the lock, so i've restored
> >   net/p5-IO-Socket-IP from the attic (the patch is obsolete as fixed up-
> >   stream)
> > 
> >   I've also updated ports/net/Makefile...diff is below
> > 
> 
> Obvious No from me, needs a lot more to convince me.
> 
> p5-IO-Socket-Socks 0.67 requires IO::Socket::IP 0.37 but has been held
> back at 0.65. The only way to update IO::Socket::IP is in the core,
> followed by extensive tests. Having two possible IO::Socket:IP during
> builds / runtime means testing twice. This is not the same as just
> moving a port to a new version. You need not only to bring back
> IO::Socket::IP but everything related and move it forward, to it so it's
> an incomplete change.
> 
> Expand on the exact problems solved, what test show they have been
> solved. IO::Socket::IP 0.29 is passing the tests www/p5-Mojo runs.

The requirement for 0.37 should prevent errors in p5-Mojo
caused by bugs in IO::Socket::IP, also i thought the change
to be rather harmless.

The last IO::Socket::IP version in ports was 0.34. Wrt
the version history of IO::Socket:IP, there is only one
"change" at all...in 0.37.
0.35 is an upstream fix of bluhms@ patch + two small bugfixes
0.36 is windows only
0.37 small fixes and wording

> To ensure testing correct thing you need to run a bulk and machine with
> 
> doas rm /usr/libdata/perl5/IO/Socket/IP.pm
> 
> ensuring you keep p5-IO-Socket-IP installed.
> 
> You have to run the tests on every single perl port, in case
> IO:::Scoket::IP is used, and ensure results match.

obvious

> Scanning the source can also be used to find which use IO::Socket:IP.
> 
> Normal bulk builds aren't enough every port should be capable of being
> built by just installing it's build dependencies, so the port is not
> using another unrelated port's dependencies that happened to have been
> built before.
> 
> 
> The above need this so brought back and updated doesn't close close to
> what's required.
> 
> 
> $ cvs -R -q up -p -r 1.434 INDEX | grep IO-Socket-IP | indexfmt -0 | cut
> -d~ -f1-2
> amavisd-new-2.10.1~mail/amavisd-new,-main
> p5-Mail-SpamAssassin-3.4.0p4~mail/p5-Mail-SpamAssassin
> p5-Net-INET6Glue-0.603~net/p5-Net-INET6Glue
> p5-Mojolicious-5.58p0~www/p5-Mojo
> 
> 
> Where are the others? This is not complete because it's missing
> TEST_DEPENDS. But does tell me your not close to finding what's required.
> 

So how to proceed?

-- 
Mark Patruck ( mark at wrapped.cx )
GPG key 0xF2865E51 / 187F F6D3 EE04 1DCE 1C74  F644 0D3C F66F F286 5E51

http://www.wrapped.cx

Re: Update www/p5-Mojo 6.40 1/3

[Nigel Taylor]

On 01/22/16 12:32, Stuart Henderson wrote:
> I'm running amavisd/spamassassin with the updated IO::Socket::IP
> with no problems.
> 
> Here are all the hits from a search of .pm and .pl files from ports
> source unpacked at the end of August - (require|use).*IO::Socket::IP.
> We could add deps to these pretty easily.
> 
True but it hadn't been done from what I could see.

Now just need to check all the scripts in base, that might have started
using IO::Socket::IP - yes I know probably none.

*.pl/ *.pm doesn't mean there aren't just plain filenames like corelist,
get_iplayer

$ grep IO::Socket /usr/local/bin/get_iplayer
use IO::Socket;
use IO::Socket;
...
use IO::Socket;

close but no IO::Socket::IP the point is it's not a *.pl or *.pm
file, and if IO::Socket was being searched for would have been
overlooked - it's about ensuring it's been checked even if the
expectation is there are going to be none.

Don't all the tests for perl go something like t/nn-.t, so
haven't checked for TEST_DEPENDS changes required. Some can also be in
xt sub-directory -



> 
> p5-ldap-0.65/perl-ldap-0.65/lib/Net/LDAP.pm
> 35:   eval { require IO::Socket::IP;
> IO::Socket::IP->VERSION(0.20); }
> 
> amavisd-new-2.10.1/amavisd-new-2.10.1/TinyRedis.pm
> 22:  if (eval { require IO::Socket::IP }) {
> 
> amavisd-new-2.10.1/amavisd-new-2.10.1/p0f-analyzer.pl
> 72:  if (eval { require IO::Socket::IP }) {
> 
> p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Plugin/DCC.pm
> 96:  if (eval { require IO::Socket::IP }) {
> 
> p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Util/TinyRedis.pm
> 31:  if (eval { require IO::Socket::IP }) {
> 
> p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/Client.pm
> 65:  if (eval { require IO::Socket::IP }) {
> 
> p5-Mail-SpamAssassin-3.4.1/Mail-SpamAssassin-3.4.1/lib/Mail/SpamAssassin/DnsResolver.pm
> 58:  if (eval { require IO::Socket::IP }) {
> 
> p5-Net-HTTP-6.09/Net-HTTP-6.09/lib/Net/HTTP.pm
> 11:if (eval { require IO::Socket::IP }) {
> 
> p5-Net-INET6Glue-0.603/Net-INET6Glue-0.603/lib/Net/INET6Glue/INET_is_INET6.pm
> 14:if ( eval "require IO::Socket::IP"
> 
> p5-IO-Socket-SSL-2.016/IO-Socket-SSL-2.016/lib/IO/Socket/SSL.pm
> 288: require IO::Socket::IP;
> 
> p5-Mojolicious-6.17/Mojolicious-6.17/lib/Mojo/IOLoop/Client.pm
> 5:use IO::Socket::IP;
> 
> p5-Mojolicious-6.17/Mojolicious-6.17/lib/Mojo/IOLoop/Server.pm
> 7:use IO::Socket::IP;
> 
> p5-Plack-1.0033/Plack-1.0033/lib/HTTP/Server/PSGI.pm
> 72:eval { require IO::Socket::IP; 1 }
> 73:or Carp::croak("
> 

Re: Update www/p5-Mojo 6.40 1/3

[Stuart Henderson]

On 2016/01/22 13:49, Nigel Taylor wrote:
> On 01/22/16 12:32, Stuart Henderson wrote:
> > I'm running amavisd/spamassassin with the updated IO::Socket::IP
> > with no problems.
> > 
> > Here are all the hits from a search of .pm and .pl files from ports
> > source unpacked at the end of August - (require|use).*IO::Socket::IP.
> > We could add deps to these pretty easily.
> > 
> True but it hadn't been done from what I could see.
> 
> Now just need to check all the scripts in base, that might have started
> using IO::Socket::IP - yes I know probably none.

Is anybody going to go that far (with all of the modules..) when
we update Perl after unlock? I think it's unlikely. We'll do builds
and some people will test things that they particularly care about
but I can't see anything more than that happening as a deliberate
effort. (I don't recall anybody doing that when we moved from
the previous ports version of IO::Socket::IP either, which was
a bigger change (moving *back* from 0.34 to 0.29)..

There are some areas in cpan where I'd be very wary of doing this
without more extensive testing (especially when a set of modules
are fairly tightly bound together) but this doesn't seem to me
like one of those situations?

> *.pl/ *.pm doesn't mean there aren't just plain filenames like corelist,
> get_iplayer

I'll run a full search then. (I don't suppose any Go users fancy
figuring out what's up with codesearch on OpenBSD do they? ;-)

Re: Update www/p5-Mojo 6.40 1/3

[Stuart Henderson]

> > *.pl/ *.pm doesn't mean there aren't just plain filenames like corelist,
> > get_iplayer
> 
> I'll run a full search then. (I don't suppose any Go users fancy
> figuring out what's up with codesearch on OpenBSD do they? ;-)

imapsync is the only extra one.

Update www/p5-Mojo 6.40 1/3

[Mark Patruck]

Update www/p5-Mojo to 6.40.

- since 6.33 www/p5-Mojo depends on IO::Socket::IP 0.37 and according
  to afresh1@ we won't get Perl 5.22.1 before the lock, so i've restored
  net/p5-IO-Socket-IP from the attic (the patch is obsolete as fixed up-
  stream)

  I've also updated ports/net/Makefile...diff is below


Index: Makefile
===
RCS file: Makefile
diff -N Makefile
--- /dev/null   1 Jan 1970 00:00:00 -
+++ Makefile20 Jan 2016 08:49:00 -
@@ -0,0 +1,18 @@
+# $OpenBSD: Makefile,v 1.6 2014/12/16 12:39:11 bluhm Exp $
+
+COMMENT =  family-neutral IP socket supporting both IPv4 and IPv6
+
+DISTNAME = IO-Socket-IP-0.37
+
+CATEGORIES =   net
+
+MAINTAINER =   Giovanni Bechis 
+
+# perl
+PERMIT_PACKAGE_CDROM = Yes
+
+MODULES =  cpan
+
+MAKE_ENV = TEST_POD=1
+
+.include 
Index: distinfo
===
RCS file: distinfo
diff -N distinfo
--- /dev/null   1 Jan 1970 00:00:00 -
+++ distinfo20 Jan 2016 08:49:00 -
@@ -0,0 +1,2 @@
+SHA256 (IO-Socket-IP-0.37.tar.gz) = 
KtxfC2QdQfZitNmcB5V4DGL5r5EZiE0FMmX8iFiub3s=
+SIZE (IO-Socket-IP-0.37.tar.gz) = 44282
Index: pkg/DESCR
===
RCS file: pkg/DESCR
diff -N pkg/DESCR
--- /dev/null   1 Jan 1970 00:00:00 -
+++ pkg/DESCR   20 Jan 2016 08:49:00 -
@@ -0,0 +1,4 @@
+IO::Socket::IP provides a protocol-independent way to use IPv4 and
+IPv6 sockets, as a drop-in replacement for IO::Socket::INET. Most
+constructor arguments and methods are provided in a backward-compatible
+way.
Index: pkg/PLIST
===
RCS file: pkg/PLIST
diff -N pkg/PLIST
--- /dev/null   1 Jan 1970 00:00:00 -
+++ pkg/PLIST   20 Jan 2016 08:49:00 -
@@ -0,0 +1,5 @@
+@comment $OpenBSD: PLIST,v 1.1 2013/04/12 14:11:26 giovanni Exp $
+${P5SITE}/IO/
+${P5SITE}/IO/Socket/
+${P5SITE}/IO/Socket/IP.pm
+@man man/man3p/IO::Socket::IP.3p




Index: Makefile
===
RCS file: /cvs/ports/net/Makefile,v
retrieving revision 1.952
diff -u -p -r1.952 Makefile
--- Makefile13 Jan 2016 07:25:12 -  1.952
+++ Makefile20 Jan 2016 09:01:28 -
@@ -325,6 +325,7 @@
  SUBDIR += p5-Geo-IP
  SUBDIR += p5-IO-Interface
  SUBDIR += p5-IO-Socket-INET6
+ SUBDIR += p5-IO-Socket-IP
  SUBDIR += p5-IO-Socket-Multicast
  SUBDIR += p5-IO-Socket-Socks
  SUBDIR += p5-IO-Socket-Timeout


-- 
Mark Patruck ( mark at wrapped.cx )
GPG key 0xF2865E51 / 187F F6D3 EE04 1DCE 1C74  F644 0D3C F66F F286 5E51

http://www.wrapped.cx