Re: audio/lame: drop GMAKE

[Stuart Henderson]

On 2018/01/28 14:14, Jan Stary wrote:
> lame seems to build just fine with make. Why does it USE_GMAKE?
> 
> While here,
> 
> * delete a stray comment

that's on purpose, it's to quieten syntax highlighting (single '
in the COMMENT)

> * add explicit ./configure --options
> * order them as they appear in ./configure --help

there are various schools of thought for this, I'd defer to
${MAINTAINER}.

audio/lame: drop GMAKE

[Jan Stary]

lame seems to build just fine with make. Why does it USE_GMAKE?

While here,

* delete a stray comment
* add explicit ./configure --options
* order them as they appear in ./configure --help


Index: Makefile
===
RCS file: /cvs/ports/audio/lame/Makefile,v
retrieving revision 1.58
diff -u -p -r1.58 Makefile
--- Makefile27 Jul 2017 14:48:10 -  1.58
+++ Makefile28 Jan 2018 13:11:29 -
@@ -1,7 +1,6 @@
 # $OpenBSD: Makefile,v 1.58 2017/07/27 14:48:10 espie Exp $
 
 COMMENT=   lame ain't an MP3 encoder
-#'
 
 DISTNAME=  lame-3.99.5
 REVISION=  1
@@ -24,14 +23,18 @@ MASTER_SITES=   ${MASTER_SITE_SOURCEFORGE:
 
 LIB_DEPENDS=   converters/libiconv
 
-USE_GMAKE= Yes
-
 AUTOCONF_VERSION=2.69
 CONFIGURE_STYLE=autoconf
-CONFIGURE_ARGS=--enable-mp3rtp \
-   --disable-mp3x \
-   --with-fileio=lame
-
+CONFIGURE_ARGS= \
+   --enable-option-checking\
+   --disable-decoder   \
+   --enable-frontend   \
+   --enable-dynamic-frontends  \
+   --disable-mp3x  \
+   --enable-mp3rtp \
+   --without-dmalloc   \
+   --with-fileio=lame
+ 
 .if ${MACHINE_ARCH} == "i386"
 BUILD_DEPENDS+=devel/nasm
 CONFIGURE_ARGS+= --enable-nasm