Re: boost warning fix

[Marco Peereboom]

The warning should be that you are using boost ;-)

On Tue, Mar 29, 2011 at 04:15:50PM +0100, Federico G. Schwindt wrote:
> 
>   Hi,
> 
>   This fixes the warning when -Wnon-virtual-dtor is used, which is quite
> annoying and might hide other crap.
>   Shouldn't break anything TBH but worth checking in a bulk.
>   Comments? Any OKs?
> 
>   f.-
> 
> Index: Makefile
> ===
> RCS file: /cvs/ports/devel/boost/Makefile,v
> retrieving revision 1.27
> diff -u -p -r1.27 Makefile
> --- Makefile  19 Sep 2010 20:09:41 -  1.27
> +++ Makefile  29 Mar 2011 15:12:22 -
> @@ -3,7 +3,7 @@
>  COMMENT= free peer-reviewed portable C++ source libraries
>  
>  PKGNAME= boost-${VERSION}
> -REVISION=5
> +REVISION=6
>  
>  VERSION= 1.42.0
>  DISTNAME=boost_${VERSION:S/./_/g}
> Index: patches/patch-boost_exception_exception_hpp
> ===
> RCS file: patches/patch-boost_exception_exception_hpp
> diff -N patches/patch-boost_exception_exception_hpp
> --- /dev/null 1 Jan 1970 00:00:00 -
> +++ patches/patch-boost_exception_exception_hpp   29 Mar 2011 15:12:22 
> -
> @@ -0,0 +1,12 @@
> +$OpenBSD$
> +--- boost/exception/exception.hpp.orig   Tue Mar 29 11:54:43 2011
>  boost/exception/exception.hppTue Mar 29 11:54:45 2011
> +@@ -166,7 +166,7 @@ boost
> + 
> + protected:
> + 
> +-~error_info_container() throw()
> ++virtual ~error_info_container() throw()
> + {
> + }
> + };
> 

Re: boost warning fix

[Landry Breuil]

On Tue, Mar 29, 2011 at 04:15:50PM +0100, Federico G. Schwindt wrote:
> 
>   Hi,
> 
>   This fixes the warning when -Wnon-virtual-dtor is used, which is quite
> annoying and might hide other crap.
>   Shouldn't break anything TBH but worth checking in a bulk.

Fwiw, no fallout in a bulk.

Re: boost warning fix

[Matthew Dempsky]

On Tue, Mar 29, 2011 at 8:15 AM, Federico G. Schwindt  wrote:
>  Comments? Any OKs?

I think this changes the ABI, so you should probably bump the soname
if you're going to commit this.

However, it seems like a deliberate decision on their part to omit the
virtual tag here (not familiar with context to know why, but since
it's protected, I can imagine it's safe), so I'm inclined to leave it
alone.

Re: boost warning fix

[Federico G. Schwindt]

On Tue, Mar 29, 2011 at 09:53:39AM -0700, Matthew Dempsky wrote:
> On Tue, Mar 29, 2011 at 8:15 AM, Federico G. Schwindt  
> wrote:
> > ?Comments? Any OKs?
> 
> I think this changes the ABI, so you should probably bump the soname
> if you're going to commit this.

  true.
 
> However, it seems like a deliberate decision on their part to omit the
> virtual tag here (not familiar with context to know why, but since
> it's protected, I can imagine it's safe), so I'm inclined to leave it
> alone.

  maybe. there is a bug open, let's see what they say.

  f.-

boost warning fix

[Federico G. Schwindt]

  Hi,

  This fixes the warning when -Wnon-virtual-dtor is used, which is quite
annoying and might hide other crap.
  Shouldn't break anything TBH but worth checking in a bulk.
  Comments? Any OKs?

  f.-

Index: Makefile
===
RCS file: /cvs/ports/devel/boost/Makefile,v
retrieving revision 1.27
diff -u -p -r1.27 Makefile
--- Makefile19 Sep 2010 20:09:41 -  1.27
+++ Makefile29 Mar 2011 15:12:22 -
@@ -3,7 +3,7 @@
 COMMENT=   free peer-reviewed portable C++ source libraries
 
 PKGNAME=   boost-${VERSION}
-REVISION=  5
+REVISION=  6
 
 VERSION=   1.42.0
 DISTNAME=  boost_${VERSION:S/./_/g}
Index: patches/patch-boost_exception_exception_hpp
===
RCS file: patches/patch-boost_exception_exception_hpp
diff -N patches/patch-boost_exception_exception_hpp
--- /dev/null   1 Jan 1970 00:00:00 -
+++ patches/patch-boost_exception_exception_hpp 29 Mar 2011 15:12:22 -
@@ -0,0 +1,12 @@
+$OpenBSD$
+--- boost/exception/exception.hpp.orig Tue Mar 29 11:54:43 2011
 boost/exception/exception.hpp  Tue Mar 29 11:54:45 2011
+@@ -166,7 +166,7 @@ boost
+ 
+ protected:
+ 
+-~error_info_container() throw()
++virtual ~error_info_container() throw()
+ {
+ }
+ };