Re: explanation of FETCH_PACKAGES in ports(7)

2020-04-27 Thread Ingo Schwarze
Hi Marc,

Marc Espie wrote on Mon, Apr 27, 2020 at 10:20:13AM +0200:

> Let's try anyway.

Looks good to me except for the nits below.

Yours,
  Ingo


> Index: ports.7
> ===
> RCS file: /cvs/src/share/man/man7/ports.7,v
> retrieving revision 1.127
> diff -u -p -r1.127 ports.7
> --- ports.7   16 Jun 2019 14:24:42 -  1.127
> +++ ports.7   27 Apr 2020 08:19:41 -
> @@ -620,10 +620,24 @@ try to use as options to
>  .Xr pkg_add 1
>  to install the missing packages from

If you want, you can say "to install any missing packages from"
because the idea of missing packages wasn't introduced earlier,
so the definite article may not be ideal.

>  .Ev PKG_PATH .
> -For instance:
> +.Xr bsd.port.mk 5
> +does not set
> +.Ev FETCH_PACKAGES ,
> +so even an empty value amounts to setting the variable.
> +.Pp
> +For instance, to run
> +.Nm pkg_add

Please make this line

  .Xr pkg_add 1

because "pkg_add" is not the topic of the present manual page, ports(7).
Repeated .Xrs to the same target are not a problem.

> +with default options
> +.Pc :

These two lines should be one:

  with default options:

>  .Bd -literal -offset indent
> -make FETCH_PACKAGES=
> +make FETCH_PACKAGES= 

Please do not add trailing whitespace.

>  .Ed
> +.Pp
> +or, to enforce the snapshots directory during the final beta period:

Here, i suggest saying "to enforce using the snapshots directory",
or, maybe even better, "to use the snapshots directory".

> +.Bd -literal -offset indent
> +make FETCH_PACKAGES=-Dsnap
> +.Ed
> +.Pp

Please delete this .Pp, it is redundant before .It in a non-compact list.

>  .It Ev PATCH_DEBUG
>  If defined, display verbose output when applying each patch.
>  .It Ev INTERACTIVE



Re: explanation of FETCH_PACKAGES in ports(7)

2020-04-27 Thread Marc Espie
On Sun, Apr 26, 2020 at 06:00:55PM +0100, Stuart Henderson wrote:
> On 2020/04/26 18:28, f.holop wrote:
> > Stuart Henderson - Sun, 26 April 2020 at 17:11:21
> > > > thank you for the explanations.  i am afraid none of this comes across
> > > > really from the man page as it is formulated now.  but i am not a native
> > > > speaker, true.
> > > 
> > > it doesn't come across at all. diffs welcome ;)
> > 
> > do you really want diffs from someone who just asked others to explain
> > it to him?...:]
> 
> better than diffs from someone who already knows how it works!
> 
> 

Let's try anyway.

Index: ports.7
===
RCS file: /cvs/src/share/man/man7/ports.7,v
retrieving revision 1.127
diff -u -p -r1.127 ports.7
--- ports.7 16 Jun 2019 14:24:42 -  1.127
+++ ports.7 27 Apr 2020 08:19:41 -
@@ -620,10 +620,24 @@ try to use as options to
 .Xr pkg_add 1
 to install the missing packages from
 .Ev PKG_PATH .
-For instance:
+.Xr bsd.port.mk 5
+does not set
+.Ev FETCH_PACKAGES ,
+so even an empty value amounts to setting the variable.
+.Pp
+For instance, to run
+.Nm pkg_add
+with default options
+.Pc :
 .Bd -literal -offset indent
-make FETCH_PACKAGES=
+make FETCH_PACKAGES=   
 .Ed
+.Pp
+or, to enforce the snapshots directory during the final beta period:
+.Bd -literal -offset indent
+make FETCH_PACKAGES=-Dsnap
+.Ed
+.Pp
 .It Ev PATCH_DEBUG
 If defined, display verbose output when applying each patch.
 .It Ev INTERACTIVE



Re: explanation of FETCH_PACKAGES in ports(7)

2020-04-26 Thread Ross L Richardson


> On 2020-04-27, at 02:11 , Stuart Henderson  wrote:
> [...]
> it doesn't come across at all. diffs welcome ;)
> [...]

The description in bsd.port.mk(5) is significantly more detailed than
that in ports(7).

Ross



Re: explanation of FETCH_PACKAGES in ports(7)

2020-04-26 Thread Stuart Henderson
On 2020/04/26 18:28, f.holop wrote:
> Stuart Henderson - Sun, 26 April 2020 at 17:11:21
> > > thank you for the explanations.  i am afraid none of this comes across
> > > really from the man page as it is formulated now.  but i am not a native
> > > speaker, true.
> > 
> > it doesn't come across at all. diffs welcome ;)
> 
> do you really want diffs from someone who just asked others to explain
> it to him?...:]

better than diffs from someone who already knows how it works!



Re: explanation of FETCH_PACKAGES in ports(7)

2020-04-26 Thread f.holop
Stuart Henderson - Sun, 26 April 2020 at 17:11:21
> > thank you for the explanations.  i am afraid none of this comes across
> > really from the man page as it is formulated now.  but i am not a native
> > speaker, true.
> 
> it doesn't come across at all. diffs welcome ;)

do you really want diffs from someone who just asked others to explain
it to him?...:]

-f
-- 



Re: explanation of FETCH_PACKAGES in ports(7)

2020-04-26 Thread Stuart Henderson
On 2020/04/26 18:04, f.holop wrote:
> Stuart Henderson - Sun, 26 April 2020 at 16:29:30
> > On 2020/04/26 16:42, f.holop wrote:
> > > hi,
> > > 
> > > i am having difficulties understanding this sentence, could someone
> > > help me out?
> > > 
> > > 
> > >  FETCH_PACKAGES
> > >If set, try to use as options to pkg_add(1) to install 
> > > the
> > >missing packages from PKG_PATH.  For instance:
> > > 
> > >  make FETCH_PACKAGES=
> > > 
> > > -f
> > > -- 
> > > 
> > 
> > If set, even to an empty string) rather than building missing
> > dependencies from source, pkg_add(1) will be called to install missing
> > packages from PKGPATH.
> > 
> > If not an empty string, it will be called as "pkg_add ${FETCH_PACKAGES}"
> > which is useful in some niche cases.
> 
> thank you for the explanations.  i am afraid none of this comes across
> really from the man page as it is formulated now.  but i am not a native
> speaker, true.

it doesn't come across at all. diffs welcome ;)

> i roughly parse it as: "if you want to pass parameters to pkg_add, set
> this to something."  and then there is a (unexplained example) of
> passing nothing...
> 
> while it's main function is really to stop `make build` going recursive
> and all ballistic building every single needed thing not installed atm
> as a package...  (which is rarely what a single port job needs)
> 
> -f
> -- 
> 



Re: explanation of FETCH_PACKAGES in ports(7)

2020-04-26 Thread f.holop
Stuart Henderson - Sun, 26 April 2020 at 16:29:30
> On 2020/04/26 16:42, f.holop wrote:
> > hi,
> > 
> > i am having difficulties understanding this sentence, could someone
> > help me out?
> > 
> > 
> >  FETCH_PACKAGES
> >If set, try to use as options to pkg_add(1) to install 
> > the
> >missing packages from PKG_PATH.  For instance:
> > 
> >  make FETCH_PACKAGES=
> > 
> > -f
> > -- 
> > 
> 
> If set, even to an empty string) rather than building missing
> dependencies from source, pkg_add(1) will be called to install missing
> packages from PKGPATH.
> 
> If not an empty string, it will be called as "pkg_add ${FETCH_PACKAGES}"
> which is useful in some niche cases.

thank you for the explanations.  i am afraid none of this comes across
really from the man page as it is formulated now.  but i am not a native
speaker, true.

i roughly parse it as: "if you want to pass parameters to pkg_add, set
this to something."  and then there is a (unexplained example) of
passing nothing...

while it's main function is really to stop `make build` going recursive
and all ballistic building every single needed thing not installed atm
as a package...  (which is rarely what a single port job needs)

-f
-- 



Re: explanation of FETCH_PACKAGES in ports(7)

2020-04-26 Thread Stuart Henderson
On 2020/04/26 16:42, f.holop wrote:
> hi,
> 
> i am having difficulties understanding this sentence, could someone
> help me out?
> 
> 
>  FETCH_PACKAGES
>If set, try to use as options to pkg_add(1) to install the
>missing packages from PKG_PATH.  For instance:
> 
>  make FETCH_PACKAGES=
> 
> -f
> -- 
> 

If set, even to an empty string) rather than building missing
dependencies from source, pkg_add(1) will be called to install missing
packages from PKGPATH.

If not an empty string, it will be called as "pkg_add ${FETCH_PACKAGES}"
which is useful in some niche cases.



Re: explanation of FETCH_PACKAGES in ports(7)

2020-04-26 Thread Klemens Nanni
On Sun, Apr 26, 2020 at 04:42:06PM +0200, f.holop wrote:
> i am having difficulties understanding this sentence, could someone
> help me out?
> 
> 
>  FETCH_PACKAGES
>If set, try to use as options to pkg_add(1) to install the
>missing packages from PKG_PATH.  For instance:
> 
>  make FETCH_PACKAGES=
In order to satisfy dependencies of the port you're building, our
framework usually goes ahead and builds them from the ports tree.

With FETCH_PACKAGES set, `pkg_add ${FETCH_PACKAGES} ...' is used to
install prebuilt packages instead, that is to avoid building all
dependencies from source.

FETCH_PACKAGES=-Dsnap can be used to do ports development on snapshot
and/or current.



explanation of FETCH_PACKAGES in ports(7)

2020-04-26 Thread f.holop
hi,

i am having difficulties understanding this sentence, could someone
help me out?


 FETCH_PACKAGES
   If set, try to use as options to pkg_add(1) to install the
   missing packages from PKG_PATH.  For instance:

 make FETCH_PACKAGES=

-f
--