Re: graphics/libavif hidden dep?

2023-07-16 Thread Jan Beich
Antoine Jacoutot  writes:

> -- Checking for module 'libyuv'
> --
> -- Could NOT find libyuv (missing: LIBYUV_LIBRARY LIBYUV_LIBRARIES 
> LIBYUV_INCLUDE_DIR) (found version "")
> -- libavif: libyuv not found; libyuv-based fast paths disabled.
> -- Checking for module 'libsharpyuv'
> --   Found libsharpyuv, version 1.3.0
> -- Found libsharpyuv: /usr/local/lib/libsharpyuv.so.0.0 (found version 
> "1.3.0")
> -- libavif: libsharpyuv found; sharp rgb to yuv conversion enabled.
[...]
> FAILED: tests/are_images_equal
> : && /exopi-obj/pobj/libavif-0.11.1/bin/c++ -O2 -pipe -DNDEBUG  
> tests/CMakeFiles/aviftest_helpers.dir/gtest/aviftest_helpers.cc.o 
> tests/CMakeFiles/are_images_equal.dir/gtest/are_images_equal.cc.o -o 
> tests/are_images_equal  -Wl,-z,origin,-
> rpath,/exopi-obj/pobj/libavif-0.11.1/build-amd64:/usr/local/lib  
> libavif_apps.a  libavif.so.6.0  -lm  -pthread  
> /usr/local/lib/libsharpyuv.so.0.0  /usr/local/lib/libpng.so.18.0  
> /usr/lib/libz.so.7.0  /usr/local/lib/libjpeg.so.70.1  -Wl,-r
> path-link,/usr/X11R6/lib:/usr/local/lib && :   
> c++: error: no such file or directory: '/usr/local/lib/libsharpyuv.so.0.0'
> ninja: build stopped: subcommand failed.

I don't use OpenBSD but the following may help:

diff --git a/graphics/libavif/Makefile b/graphics/libavif/Makefile
index b35d21698bd..34e579501ba 100644
--- a/graphics/libavif/Makefile
+++ b/graphics/libavif/Makefile
@@ -31,8 +31,8 @@ CONFIGURE_ARGS+=-DAVIF_BUILD_APPS=ON \
-DAVIF_CODEC_AOM_DECODE=OFF \
-DAVIF_CODEC_DAV1D=ON \
-DAVIF_ENABLE_GTEST=OFF \
-   -DCMAKE_DISABLE_FIND_PACKAGE_libsharpyuv=OFF \
-   -DCMAKE_DISABLE_FIND_PACKAGE_libyuv=OFF
+   -DCMAKE_DISABLE_FIND_PACKAGE_libsharpyuv=ON \
+   -DCMAKE_DISABLE_FIND_PACKAGE_libyuv=ON
 
 do-test:
${WRKBUILD}/tests/aviftest ${WRKSRC}/tests/data



graphics/libavif hidden dep?

2023-07-16 Thread Antoine Jacoutot
Hi.

I got this error in my latest builk trying to build libavif:

===>  Configuring for libavif-0.11.1
-- The C compiler identification is Clang 13.0.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /exopi-obj/pobj/libavif-0.11.1/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- libavif: Enabling warnings for Clang
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD
-- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Failed
-- Check if compiler accepts -pthread
-- Check if compiler accepts -pthread - yes
-- Found Threads: TRUE
-- Found PkgConfig: /usr/bin/pkg-config (found version "0.29.2")
-- Checking for module 'libyuv'
--
-- Could NOT find libyuv (missing: LIBYUV_LIBRARY LIBYUV_LIBRARIES 
LIBYUV_INCLUDE_DIR) (found version "")
-- libavif: libyuv not found; libyuv-based fast paths disabled.
-- Checking for module 'libsharpyuv'
--   Found libsharpyuv, version 1.3.0
-- Found libsharpyuv: /usr/local/lib/libsharpyuv.so.0.0 (found version "1.3.0")
-- libavif: libsharpyuv found; sharp rgb to yuv conversion enabled.
-- Checking for module 'dav1d'
--   Found dav1d, version 1.2.1
-- Found dav1d: /usr/local/lib/libdav1d.so.2.3 (found version "1.2.1")
-- libavif: Codec enabled: dav1d (decode)
-- Checking for module 'aom'
--   Found aom, version 3.6.1
-- Found aom: /usr/local/lib/libaom.so.4.0 (found version "3.6.1")
-- libavif: Codec enabled: aom (encode only)
-- Found ZLIB: /usr/lib/libz.so.7.0 (found version "1.2.13.1")
-- Found PNG: /usr/local/lib/libpng.so.18.0 (found version "1.6.39")
-- Found JPEG: /usr/local/lib/libjpeg.so.70.1 (found version "62")
-- The CXX compiler identification is Clang 13.0.0
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /exopi-obj/pobj/libavif-0.11.1/bin/c++ - 
skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Most tests are disabled because AVIF_ENABLE_GTEST is OFF.
-- Configuring done (11.1s)
-- Generating done (0.1s)

<...>

[37/38] /exopi-obj/pobj/libavif-0.11.1/bin/c++ -DAVIF_DLL 
-I/exopi-obj/pobj/libavif-0.11.1/libavif-0.11.1/apps/shared 
-I/exopi-obj/pobj/libavif-0.11.1/libavif-0.11.1/include -O2 -pipe -DNDEBUG 
-std=gnu++11 -Wall -Wextra -Wshorten-64-to-32
 -Werror -pthread -MD -MT 
tests/CMakeFiles/are_images_equal.dir/gtest/are_images_equal.cc.o -MF 
tests/CMakeFiles/are_images_equal.dir/gtest/are_images_equal.cc.o.d -o 
tests/CMakeFiles/are_images_equal.dir/gtest/are_images_equal.cc.o -c /e
xopi-obj/pobj/libavif-0.11.1/libavif-0.11.1/tests/gtest/are_images_equal.cc
[38/38] : && /exopi-obj/pobj/libavif-0.11.1/bin/c++ -O2 -pipe -DNDEBUG  
tests/CMakeFiles/aviftest_helpers.dir/gtest/aviftest_helpers.cc.o 
tests/CMakeFiles/are_images_equal.dir/gtest/are_images_equal.cc.o -o 
tests/are_images_equal  -Wl,-z,
origin,-rpath,/exopi-obj/pobj/libavif-0.11.1/build-amd64:/usr/local/lib  
libavif_apps.a  libavif.so.6.0  -lm  -pthread  
/usr/local/lib/libsharpyuv.so.0.0  /usr/local/lib/libpng.so.18.0  
/usr/lib/libz.so.7.0  /usr/local/lib/libjpeg.so.70.1
  -Wl,-rpath-link,/usr/X11R6/lib:/usr/local/lib && :
FAILED: tests/are_images_equal
: && /exopi-obj/pobj/libavif-0.11.1/bin/c++ -O2 -pipe -DNDEBUG  
tests/CMakeFiles/aviftest_helpers.dir/gtest/aviftest_helpers.cc.o 
tests/CMakeFiles/are_images_equal.dir/gtest/are_images_equal.cc.o -o 
tests/are_images_equal  -Wl,-z,origin,-
rpath,/exopi-obj/pobj/libavif-0.11.1/build-amd64:/usr/local/lib  libavif_apps.a 
 libavif.so.6.0  -lm  -pthread  /usr/local/lib/libsharpyuv.so.0.0  
/usr/local/lib/libpng.so.18.0  /usr/lib/libz.so.7.0  
/usr/local/lib/libjpeg.so.70.1  -Wl,-r
path-link,/usr/X11R6/lib:/usr/local/lib && :   
c++: error: no such file or directory: '/usr/local/lib/libsharpyuv.so.0.0'
ninja: build stopped: subcommand failed.


Hidden dependency on graphics/libwebp?
(dpb probably junked it)

-- 
Antoine