Re: mail/neomutt: Add slang flavor
On 2017/07/19 15:28, Klemens Nanni wrote: > On Wed, Jul 19, 2017 at 02:15:03PM +0100, Stuart Henderson wrote: > > On 2017/07/19 15:06, Klemens Nanni wrote: > > > I was missing the slang flavor when trying neomutt over mutt so here it > > > is. > > > > > > --with-curses can be safely dropped as it's the default. > > > > > > Feedback? Comments? > > > > I think neomutt already has enough build flavours.. > When building with ncurses, binding ^O won't work unless you disable it > in the controlling terminal: > > $ stty -a | fgrep ^O > cchars: discard = ^O; dsusp = ^Y; eof = ^D; eol = ; > $ stty discard undef > > This happens for both mutt and neomutt with at least xterm and st as > well. > > I don't see why mutt should have a slang flavor but not neomutt. As it > was the case for me, this might break the migration for other users as > well. > The mutt port has some legacy baggage which I am trying to avoid in the neomutt port. Flavour combinations need testing for updates and these happen a lot more often with neomutt than mutt. S-Lang in Mutt used to be quite handy for UTF-8 before it worked in curses, so there was once a good reason for having the choice, but it's not necessary for that any more. For your situation with ^O, stty seems like the sanest approach..
Re: mail/neomutt: Add slang flavor
On Wed, Jul 19, 2017 at 02:15:03PM +0100, Stuart Henderson wrote: > On 2017/07/19 15:06, Klemens Nanni wrote: > > I was missing the slang flavor when trying neomutt over mutt so here it > > is. > > > > --with-curses can be safely dropped as it's the default. > > > > Feedback? Comments? > > I think neomutt already has enough build flavours.. When building with ncurses, binding ^O won't work unless you disable it in the controlling terminal: $ stty -a | fgrep ^O cchars: discard = ^O; dsusp = ^Y; eof = ^D; eol = ; $ stty discard undef This happens for both mutt and neomutt with at least xterm and st as well. I don't see why mutt should have a slang flavor but not neomutt. As it was the case for me, this might break the migration for other users as well.
Re: mail/neomutt: Add slang flavor
On 2017/07/19 15:06, Klemens Nanni wrote: > I was missing the slang flavor when trying neomutt over mutt so here it > is. > > --with-curses can be safely dropped as it's the default. > > Feedback? Comments? I think neomutt already has enough build flavours..
mail/neomutt: Add slang flavor
I was missing the slang flavor when trying neomutt over mutt so here it
is.
--with-curses can be safely dropped as it's the default.
Feedback? Comments?
Index: Makefile
===
RCS file: /cvs/ports/mail/neomutt/Makefile,v
retrieving revision 1.16
diff -u -p -r1.16 Makefile
--- Makefile14 Jul 2017 21:16:20 - 1.16
+++ Makefile19 Jul 2017 12:56:14 -
@@ -23,7 +23,7 @@ LIB_DEPENDS+= devel/gettext \
BUILD_DEPENDS+=textproc/docbook-xsl \
www/lynx
-FLAVORS= gpgme sasl
+FLAVORS= gpgme sasl slang
FLAVOR?=
FLAVOR_COMMA= ${FLAVOR_EXT:S/-/,/g}
@@ -39,7 +39,6 @@ CONFIGURE_ARGS+= --disable-fcntl \
--enable-flock \
--disable-notmuch \
--mandir=${PREFIX}/man \
- --with-curses \
--with-docdir="${PREFIX}/share/doc/neomutt" \
--without-tokyocabinet \
--without-gdbm \
@@ -64,6 +63,12 @@ WANTLIB+=assuan gpg-error gpgme
CONFIGURE_ARGS+= --with-sasl=${LOCALBASE}
LIB_DEPENDS+= security/cyrus-sasl2
WANTLIB+= sasl2
+.endif
+
+.if ${FLAVOR:Mslang}
+CONFIGURE_ARGS+= --with-slang="${PREFIX}"
+LIB_DEPENDS+= devel/libslang
+WANTLIB+= m termlib slang>=14
.endif
.include
