Re: net/libktorrent: remove doxygen as BUILD_DEPENDS

[Jeremie Courreges-Anglas]

Rafael Sadowski  writes:

> On Mon Apr 24, 2017 at 08:43:38PM +0200, Rafael Sadowski wrote:
>> Hi ports@,
>> 
>> libktorrent without Doxygen and dditional CMake policies.
>> 
>> OK? Comments?
>> 
>> Best regards,
>> 
>> Rafael Sadowski
>> 
>
> New diff below with -DCMAKE_DISABLE_FIND_PACKAGE_Doxygen from jca@.

ok for the doxygen removal part.

Discovering cmake policies here.  Is this change only about shutting up
warnings, or is there also a change in the behavior of the cmake code?
If we're only hiding problems that wait to appear in upcoming cmake
releases, then maybe it's not a good move.

It *seems* that those warnings come from Automoc4Config.cmake or
KDE4Macros.cmake.  Can/should those files be modified, instead of
consumer ports like libktorrent?

[...]

> +# XXX Silently ignore non-existent dependencies
> +CONFIGURE_ARGS +=-DCMAKE_POLICY_DEFAULT_CMP0053=OLD
> +CONFIGURE_ARGS +=-DCMAKE_POLICY_DEFAULT_CMP0054=OLD
> +CONFIGURE_ARGS +=-DCMAKE_POLICY_DEFAULT_CMP0064=OLD
> +# XXX Don't treat ``DEFINITIONS`` as a built-in directory property
> +CONFIGURE_ARGS +=-DCMAKE_POLICY_DEFAULT_CMP0059=OLD
>  
>  .include 
>

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Re: net/libktorrent: remove doxygen as BUILD_DEPENDS

[Rafael Sadowski]

On Mon Apr 24, 2017 at 08:43:38PM +0200, Rafael Sadowski wrote:
> Hi ports@,
> 
> libktorrent without Doxygen and dditional CMake policies.
> 
> OK? Comments?
> 
> Best regards,
> 
> Rafael Sadowski
> 

New diff below with -DCMAKE_DISABLE_FIND_PACKAGE_Doxygen from jca@.

Thanks, Rafael


Index: Makefile
===
RCS file: /cvs/ports/net/libktorrent/Makefile,v
retrieving revision 1.11
diff -u -p -u -p -r1.11 Makefile
--- Makefile12 Aug 2015 12:33:02 -  1.11
+++ Makefile25 Apr 2017 06:15:31 -
@@ -27,11 +27,19 @@ MODKDE4_USE =   libs
 MODKDE4_LIB_LINKS =Yes
 
 BUILD_DEPENDS =devel/boost \
-   devel/doxygen \
devel/gettext-tools
 
 LIB_DEPENDS =  devel/gmp \
security/libgcrypt \
security/qca2
+
+CONFIGURE_ARGS +=  -DCMAKE_DISABLE_FIND_PACKAGE_Doxygen:Bool=Yes
+
+# XXX Silently ignore non-existent dependencies
+CONFIGURE_ARGS +=  -DCMAKE_POLICY_DEFAULT_CMP0053=OLD
+CONFIGURE_ARGS +=  -DCMAKE_POLICY_DEFAULT_CMP0054=OLD
+CONFIGURE_ARGS +=  -DCMAKE_POLICY_DEFAULT_CMP0064=OLD
+# XXX Don't treat ``DEFINITIONS`` as a built-in directory property
+CONFIGURE_ARGS +=  -DCMAKE_POLICY_DEFAULT_CMP0059=OLD
 
 .include 

net/libktorrent: remove doxygen as BUILD_DEPENDS

[Rafael Sadowski]

Hi ports@,

libktorrent without Doxygen and dditional CMake policies.

OK? Comments?

Best regards,

Rafael Sadowski

Index: Makefile
===
RCS file: /cvs/ports/net/libktorrent/Makefile,v
retrieving revision 1.11
diff -u -p -u -p -r1.11 Makefile
--- Makefile12 Aug 2015 12:33:02 -  1.11
+++ Makefile24 Apr 2017 16:40:09 -
@@ -5,7 +5,7 @@ COMMENT =   KTorrent engine
 V =1.3.1
 DISTNAME = libktorrent-$V
 HOMEPAGE = http://ktorrent.pwsp.net/
-REVISION = 8
+REVISION = 9
 
 EXTRACT_SUFX = .tar.bz2
 
@@ -27,11 +27,17 @@ MODKDE4_USE =   libs
 MODKDE4_LIB_LINKS =Yes
 
 BUILD_DEPENDS =devel/boost \
-   devel/doxygen \
devel/gettext-tools
 
 LIB_DEPENDS =  devel/gmp \
security/libgcrypt \
security/qca2
+
+# XXX Silently ignore non-existent dependencies
+CONFIGURE_ARGS +=  -DCMAKE_POLICY_DEFAULT_CMP0053=OLD
+CONFIGURE_ARGS +=  -DCMAKE_POLICY_DEFAULT_CMP0054=OLD
+CONFIGURE_ARGS +=  -DCMAKE_POLICY_DEFAULT_CMP0064=OLD
+# XXX Don't treat ``DEFINITIONS`` as a built-in directory property
+CONFIGURE_ARGS +=  -DCMAKE_POLICY_DEFAULT_CMP0059=OLD
 
 .include 
Index: patches/patch-doc_CMakeLists_txt
===
RCS file: patches/patch-doc_CMakeLists_txt
diff -N patches/patch-doc_CMakeLists_txt
--- /dev/null   1 Jan 1970 00:00:00 -
+++ patches/patch-doc_CMakeLists_txt24 Apr 2017 16:40:09 -
@@ -0,0 +1,17 @@
+$OpenBSD$
+disable doxygen
+--- doc/CMakeLists.txt.origMon Apr 24 18:34:09 2017
 doc/CMakeLists.txt Mon Apr 24 18:34:14 2017
+@@ -1,4 +1,4 @@
+-find_package(Doxygen)
++#find_package(Doxygen)
+ if (DOXYGEN_FOUND AND DOXYGEN_DOT_FOUND)
+   message (STATUS "Doxygen and dot found. make docs target is available")
+   # Add support for a docs target
+@@ -24,4 +24,4 @@ if (DOXYGEN_FOUND AND DOXYGEN_DOT_FOUND)
+   endif()
+   
+   add_custom_target(docs ${DOCS_ARGS} )
+-endif()
+\ No newline at end of file
++endif()