Re: pkg/PLIST automation
Latest update for comms/uhd attached. uhd-3.15.0.0p0 package builds from ports successfully right after fix all stupid mistakes. Thanks for help. Yes, USRP devices require async transfers. In what stage async USB transfers codebase now? I'm looking for a project, but I'm not sure that I'm experienced enough to write kernel/libusb code. I have to check. FYI, I have one USRP device on hand with USB interface to test the driver. Martin ‐‐‐ Original Message ‐‐‐ On Sunday, March 22, 2020 2:37 PM, Stuart Henderson wrote: > On 2020/03/22 14:29, Stuart Henderson wrote: > > > On 2020/03/22 14:17, Marc Espie wrote: > > > > > On Sun, Mar 22, 2020 at 01:59:36PM +0100, Marc Espie wrote: > > > > > > > On Sun, Mar 22, 2020 at 08:20:59AM +, Martin wrote: > > > > > > > > > It looks strange, but > > > > > make show=PKGNAME > > > > > uhd-3.15.0.0 > > > > > make show=FULLPKGNAME- > > > > > uhd-3.15.0.0p0 > > > > > make show=FULLPKGNAME > > > > > uhd-3.15.0.0p0 > > > > > I attached the new port I do which builds successfully, but make > > > > > package is broken. > > > > > > > > No it doesn't. > > > > > > > > -DCMAKE_C_COMPILER=/usr/local/bin/clang \\ > > > > -DCMAKE_CXX_COMPILER=/usr/local/bin/clang++ \\ > > > > -DPYTHON_EXECUTABLE=/usr/local/bin/python3.7 \\ > > > > -DCMAKE_INSTALL_PREFIX=/usr/local ../ > > > > > > > > > > I was talking too fast, your problem is waaay more stupid, the spaces > > > you left at the end of the line with REVISION ARE significant, and > > > you end up with a fullpkgname with spaces, which isn't so great ;) > > > You still need to clean up all the rest though... starting with a clean > > > system would help. > > > Also your comment is wy too long > > > > With this port, getting it built is likely only the start - for the > > USB-based devices it looks like they need async transfers, in which case > > it will need some work on the USB stack (kernel/libusb) as these aren't > > implemented yet (same problem with rtl-sdr which is why the port of that > > is barely functional). > > If that doesn't sound like something you want to work on then OpenBSD is > > probably not the right platform to use with this (rather nice looking) > > hardware. > > Here's a slightly cleaned up port FWIW. uhd.tgz Description: application/gzip
Re: pkg/PLIST automation
On 2020/03/22 14:29, Stuart Henderson wrote: > On 2020/03/22 14:17, Marc Espie wrote: > > On Sun, Mar 22, 2020 at 01:59:36PM +0100, Marc Espie wrote: > > > On Sun, Mar 22, 2020 at 08:20:59AM +, Martin wrote: > > > > It looks strange, but > > > > > > > > make show=PKGNAME > > > > uhd-3.15.0.0 > > > > make show=FULLPKGNAME- > > > > uhd-3.15.0.0p0 > > > > make show=FULLPKGNAME > > > > uhd-3.15.0.0p0 > > > > > > > > I attached the new port I do which builds successfully, but make > > > > package is broken. > > > > > > No it doesn't. > > > > > > > > > -DCMAKE_C_COMPILER=/usr/local/bin/clang \ > > > -DCMAKE_CXX_COMPILER=/usr/local/bin/clang++ \ > > > -DPYTHON_EXECUTABLE=/usr/local/bin/python3.7 \ > > > -DCMAKE_INSTALL_PREFIX=/usr/local ../ > > > > > > > I was talking too fast, your problem is waaay more stupid, the spaces > > you left at the end of the line with REVISION *ARE* significant, and > > you end up with a fullpkgname with spaces, which isn't so great ;) > > > > You still need to clean up all the rest though... starting with a clean > > system would help. > > > > Also your comment is wy too long > > > > With this port, getting it built is likely only the start - for the > USB-based devices it looks like they need async transfers, in which case > it will need some work on the USB stack (kernel/libusb) as these aren't > implemented yet (same problem with rtl-sdr which is why the port of that > is barely functional). > > If that doesn't sound like something you want to work on then OpenBSD is > probably not the right platform to use with this (rather nice looking) > hardware. > Here's a slightly cleaned up port FWIW. uhd.tgz Description: application/tar-gz
Re: pkg/PLIST automation
On 2020/03/22 14:17, Marc Espie wrote: > On Sun, Mar 22, 2020 at 01:59:36PM +0100, Marc Espie wrote: > > On Sun, Mar 22, 2020 at 08:20:59AM +, Martin wrote: > > > It looks strange, but > > > > > > make show=PKGNAME > > > uhd-3.15.0.0 > > > make show=FULLPKGNAME- > > > uhd-3.15.0.0p0 > > > make show=FULLPKGNAME > > > uhd-3.15.0.0p0 > > > > > > I attached the new port I do which builds successfully, but make package > > > is broken. > > > > No it doesn't. > > > > > > -DCMAKE_C_COMPILER=/usr/local/bin/clang \ > > -DCMAKE_CXX_COMPILER=/usr/local/bin/clang++ \ > > -DPYTHON_EXECUTABLE=/usr/local/bin/python3.7 \ > > -DCMAKE_INSTALL_PREFIX=/usr/local ../ > > > > I was talking too fast, your problem is waaay more stupid, the spaces > you left at the end of the line with REVISION *ARE* significant, and > you end up with a fullpkgname with spaces, which isn't so great ;) > > You still need to clean up all the rest though... starting with a clean > system would help. > > Also your comment is wy too long > With this port, getting it built is likely only the start - for the USB-based devices it looks like they need async transfers, in which case it will need some work on the USB stack (kernel/libusb) as these aren't implemented yet (same problem with rtl-sdr which is why the port of that is barely functional). If that doesn't sound like something you want to work on then OpenBSD is probably not the right platform to use with this (rather nice looking) hardware.
Re: pkg/PLIST automation
On Sun, Mar 22, 2020 at 01:59:36PM +0100, Marc Espie wrote: > On Sun, Mar 22, 2020 at 08:20:59AM +, Martin wrote: > > It looks strange, but > > > > make show=PKGNAME > > uhd-3.15.0.0 > > make show=FULLPKGNAME- > > uhd-3.15.0.0p0 > > make show=FULLPKGNAME > > uhd-3.15.0.0p0 > > > > I attached the new port I do which builds successfully, but make package is > > broken. > > No it doesn't. > > > -DCMAKE_C_COMPILER=/usr/local/bin/clang \ > -DCMAKE_CXX_COMPILER=/usr/local/bin/clang++ \ > -DPYTHON_EXECUTABLE=/usr/local/bin/python3.7 \ > -DCMAKE_INSTALL_PREFIX=/usr/local ../ > I was talking too fast, your problem is waaay more stupid, the spaces you left at the end of the line with REVISION *ARE* significant, and you end up with a fullpkgname with spaces, which isn't so great ;) You still need to clean up all the rest though... starting with a clean system would help. Also your comment is wy too long
Re: pkg/PLIST automation
On Sun, Mar 22, 2020 at 08:20:59AM +, Martin wrote: > It looks strange, but > > make show=PKGNAME > uhd-3.15.0.0 > make show=FULLPKGNAME- > uhd-3.15.0.0p0 > make show=FULLPKGNAME > uhd-3.15.0.0p0 > > I attached the new port I do which builds successfully, but make package is > broken. No it doesn't. -DCMAKE_C_COMPILER=/usr/local/bin/clang \ -DCMAKE_CXX_COMPILER=/usr/local/bin/clang++ \ -DPYTHON_EXECUTABLE=/usr/local/bin/python3.7 \ -DCMAKE_INSTALL_PREFIX=/usr/local ../ Now your actual problem is rather funny. GH_* creates a PKGNAME that's incompatible with the OpenBSD naming rules, and bsd.port.mk does its best, BUT gets all confused with the v* that looks like an EPOCH already applied.
Re: pkg/PLIST automation
It looks strange, but
make show=PKGNAME
uhd-3.15.0.0
make show=FULLPKGNAME-
uhd-3.15.0.0p0
make show=FULLPKGNAME
uhd-3.15.0.0p0
I attached the new port I do which builds successfully, but make package is
broken.
This is my first port, any advice would be highly appreciated.
Martin
‐‐‐ Original Message ‐‐‐
On Saturday, March 21, 2020 2:11 PM, Ingo Schwarze wrote:
> Hi Martin,
>
> Martin wrote on Sat, Mar 21, 2020 at 06:07:57AM +:
>
> > make fake -> make update-plist successfully generates PLIST but
> > make package and make install produce an error:
> > make: don't know how to make /usr/ports/packages/.tgz
> > (prerequisite of: /usr/ports/packages/amd64/all/uhd-3.15.0.0p0)
>
> It is hard to judge what exactly went wrong without seeing your
> Makefile.
>
> You are supposed to follow thw documentation (e.g. bsd.port.mk(5))
> and also use it for debugging. If you can't find your mistake by
> looking at the documentation, you can try looking at the code -
> in this case /usr/ports/infrastructure/mk/bsd.port.mk - to find
> out where exactly things break, then deduce from that what your
> error might be and go back to the documentation how the specific
> thing(s) that broke for you are supposed to be used correctly.
>
> If you can't find your own mistake and ask for the help of others
> to find them, you are supposed to provide complete information.
> It is hard to find your error without seeing your Makefile.
>
> Here is an example of how i might proceed to debug the message above
> if the documentation wouldn't help me (assuming you did not
> set MULTI_PACKAGES):
>
> - search for "\.tgz" -> line 965
> so ${FULLPKGNAME${_S}} seems to be empty
>
> - without MULTI_PACKAGES, _S is "-"
> (leaving it as an exercise why that is so)
>
> - line 636: FULLPKGNAME- is set to ${FULLPKGNAME}
>
> - line 611: FULLPKGNAME is set to ${PKGNAME}${FLAVOR_EXT}
>
> So try to find out whether in your Makefile, you fiddled with
> variables like PKGNAME or FULLPKGNAME in an invalid manner.
>
> While reading bsd.port.mk, you can also use commands like
> make show=FULLPKGNAME-
> make show=FULLPKGNAME
> make show=PKGNAME
> to inspect various variables that file is using, to debug your Makefile.
>
> I find it hard to be more specific given the amount of information
> you provided.
>
> If you did try to use MULTI_PACKAGES, first try to get it to work
> without that, then add MULTI_PACKAGES once everything works without it.
>
> Yours,
> Ingo
>
port-uhd.tgz
Description: application/gzip
Re: pkg/PLIST automation
Hi Martin,
Martin wrote on Sat, Mar 21, 2020 at 06:07:57AM +:
> make fake -> make update-plist successfully generates PLIST but
>
> make package and make install produce an error:
>
> make: don't know how to make /usr/ports/packages/.tgz
> (prerequisite of: /usr/ports/packages/amd64/all/uhd-3.15.0.0p0)
It is hard to judge what exactly went wrong without seeing your
Makefile.
You are supposed to follow thw documentation (e.g. bsd.port.mk(5))
and also use it for debugging. If you can't find your mistake by
looking at the documentation, you can try looking at the code -
in this case /usr/ports/infrastructure/mk/bsd.port.mk - to find
out where exactly things break, then deduce from that what your
error might be and go back to the documentation how the specific
thing(s) that broke for you are supposed to be used correctly.
If you can't find your own mistake and ask for the help of others
to find them, you are supposed to provide complete information.
It is hard to find your error without seeing your Makefile.
Here is an example of how i might proceed to debug the message above
if the documentation wouldn't help me (assuming you did not
set MULTI_PACKAGES):
- search for "\.tgz" -> line 965
so ${FULLPKGNAME${_S}} seems to be empty
- without MULTI_PACKAGES, _S is "-"
(leaving it as an exercise why that is so)
- line 636: FULLPKGNAME- is set to ${FULLPKGNAME}
- line 611: FULLPKGNAME is set to ${PKGNAME}${FLAVOR_EXT}
So try to find out whether in your Makefile, you fiddled with
variables like PKGNAME or FULLPKGNAME in an invalid manner.
While reading bsd.port.mk, you can also use commands like
make show=FULLPKGNAME-
make show=FULLPKGNAME
make show=PKGNAME
to inspect various variables that file is using, to debug your Makefile.
I find it hard to be more specific given the amount of information
you provided.
If you did try to use MULTI_PACKAGES, first try to get it to work
without that, then add MULTI_PACKAGES once everything works without it.
Yours,
Ingo
Re: pkg/PLIST automation
make fake -> make update-plist successfully generates PLIST but make package and make install produce an error: make: don't know how to make /usr/ports/packages/.tgz (prerequisite of: /usr/ports/packages/amd64/all/uhd-3.15.0.0p0) Stop in: *** Error 2 in . (/usr/ports/infrastructure/mk/bsd.port.mk:2472 '_internal-package') *** Error 1 in /usr/ports/comms/uhd (/usr/ports/infrastructure/mk/bsd.port.mk:2451 'package') Where to find a problem? Martin ‐‐‐ Original Message ‐‐‐ On Friday, March 20, 2020 4:05 PM, Ingo Schwarze wrote: > Hi Martin, > > Martin wrote on Fri, Mar 20, 2020 at 03:59:42PM +: > > > Any automation suggestions for pkg/PLIST create for a new port? > > Read all of: > > https://www.openbsd.org/faq/ports/guide.html#PortsChecklist > > In this case, the answer to your question is in step 22. > > make update-plist > > Yours, > Ingo
pkg/PLIST automation
Any automation suggestions for pkg/PLIST create for a new port? Martin
Re: pkg/PLIST automation
On Fri, Mar 20 2020, Martin wrote: > Any automation suggestions for pkg/PLIST create for a new port? make plist -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
Re: pkg/PLIST automation
Hi Martin, Martin wrote on Fri, Mar 20, 2020 at 03:59:42PM +: > Any automation suggestions for pkg/PLIST create for a new port? Read all of: https://www.openbsd.org/faq/ports/guide.html#PortsChecklist In this case, the answer to your question is in step 22. make update-plist Yours, Ingo
