Re: update: databases/pgpool for -fno-common

[Pierre-Emmanuel André]

On Sat, Feb 20, 2021 at 06:16:34PM +, Stuart Henderson wrote:
> On 2021/02/20 18:41, Landry Breuil wrote:
> > Hi,
> > 
> > the pgpool version we ship is from mid-2018 and fails to build with
> > clang 10. Since there, upstream has released 4.0, 4.1 and 4.2 branches,
> > while 3.7 is still maintained.
> > 
> > so i went the easy route and upgraded to 3.7.18.
> 
> ok for now to unbreak, but this is badly in need of a branch update:
>


Yes ok to unbreak. Thank you.
I will work to update it to the latest version.

> 4.0 - 2018-10-19
> 
> This version adds support for SCRAM and CERT authentication, improves
> load balancing control and import PostgreSQL 11 new SQL parser
> 
> 4.1 - 2019-10-31
> 
> This version implements long awaited features including
> statement_level_load_balance and auto_failback. Also it enhances number
> of areas related to performance. Finally it imports PostgreSQL 12's new
> SQL parser.
> 
> 4.2 - 2020-11-26
> 
> Many enhancements are added to this version for easier configuration
> and administration. Moreover new clustering mode which allows not only
> write consistency but read consistency in multiple PostgreSQL servers.
> Also SSL is improved to allow more secure operation. New PostgreSQL 13
> SQL parse is imported.
> 

Re: update: databases/pgpool for -fno-common

[Stuart Henderson]

On 2021/02/20 18:41, Landry Breuil wrote:
> Hi,
> 
> the pgpool version we ship is from mid-2018 and fails to build with
> clang 10. Since there, upstream has released 4.0, 4.1 and 4.2 branches,
> while 3.7 is still maintained.
> 
> so i went the easy route and upgraded to 3.7.18.

ok for now to unbreak, but this is badly in need of a branch update:

4.0 - 2018-10-19

This version adds support for SCRAM and CERT authentication, improves
load balancing control and import PostgreSQL 11 new SQL parser

4.1 - 2019-10-31

This version implements long awaited features including
statement_level_load_balance and auto_failback. Also it enhances number
of areas related to performance. Finally it imports PostgreSQL 12's new
SQL parser.

4.2 - 2020-11-26

Many enhancements are added to this version for easier configuration
and administration. Moreover new clustering mode which allows not only
write consistency but read consistency in multiple PostgreSQL servers.
Also SSL is improved to allow more secure operation. New PostgreSQL 13
SQL parse is imported.

update: databases/pgpool for -fno-common

[Landry Breuil]

Hi,

the pgpool version we ship is from mid-2018 and fails to build with
clang 10. Since there, upstream has released 4.0, 4.1 and 4.2 branches,
while 3.7 is still maintained.

so i went the easy route and upgraded to 3.7.18. Some things are red
herrings though:

pgpool-regclass.c:124:7: warning: implicit declaration of function 
'SplitIdentifierString' is invalid in C99 [-Wimplicit-function-declaration]
if (!SplitIdentifierString(rawname, '.', &namelist))
protocol/child.c:2206:4: warning: implicit declaration of function 'load_hba' 
is invalid in C99 [-Wimplicit-function-declaration]
load_hba(get_hba_file_name());
protocol/child.c:2416:3: warning: implicit declaration of function 
'ClientAuthentication' is invalid in C99 [-Wimplicit-function-declaration]
ClientAuthentication(frontend);   

afaict those are psql functions, it's just that pgpool doesnt include the
corresponding header ? Not planning to dig more in this port, at least this
unbreaks it..

Landry
Index: Makefile
===
RCS file: /cvs/ports/databases/pgpool/Makefile,v
retrieving revision 1.13
diff -u -r1.13 Makefile
--- Makefile12 Jul 2019 21:15:34 -  1.13
+++ Makefile20 Feb 2021 17:36:40 -
@@ -2,7 +2,7 @@
 
 COMMENT=   connection pool server for PostgreSQL
 
-DISTNAME=  pgpool-II-3.7.5
+DISTNAME=  pgpool-II-3.7.18
 
 CATEGORIES=databases
 
Index: distinfo
===
RCS file: /cvs/ports/databases/pgpool/distinfo,v
retrieving revision 1.9
diff -u -r1.9 distinfo
--- distinfo10 Sep 2018 12:29:24 -  1.9
+++ distinfo20 Feb 2021 17:36:40 -
@@ -1,2 +1,2 @@
-SHA256 (pgpool-II-3.7.5.tar.gz) = UQrHzQDiKW3FCtHMvIb5MI38Ns+pjQQGa5o3pUZMR8E=
-SIZE (pgpool-II-3.7.5.tar.gz) = 3276279
+SHA256 (pgpool-II-3.7.18.tar.gz) = 0I4zuZYUjHukHw5PWjMLU5Ec1srJTHh3gIewaMjaCX4=
+SIZE (pgpool-II-3.7.18.tar.gz) = 3447131
Index: pkg/PLIST
===
RCS file: /cvs/ports/databases/pgpool/pkg/PLIST,v
retrieving revision 1.3
diff -u -r1.3 PLIST
--- pkg/PLIST   19 Dec 2017 09:02:03 -  1.3
+++ pkg/PLIST   20 Feb 2021 17:36:40 -
@@ -1,6 +1,7 @@
 @comment $OpenBSD: PLIST,v 1.3 2017/12/19 09:02:03 pea Exp $
 @newgroup _pgpool:690
 @newuser _pgpool:690:_pgpool:daemon:pgpool daemon:/nonexistent:/sbin/nologin
+@rcscript ${RCDIR}/pgpool
 @bin bin/pcp_attach_node
 @bin bin/pcp_detach_node
 @bin bin/pcp_node_count
@@ -20,10 +21,10 @@
 include/pcp.h
 include/pool_process_reporting.h
 include/pool_type.h
-lib/libpcp.a
+@static-lib lib/libpcp.a
 lib/libpcp.la
 @lib lib/libpcp.so.${LIBpcp_VERSION}
-lib/postgresql/pgpool-regclass.so
+@so lib/postgresql/pgpool-regclass.so
 @man man/man8/pgpool.8
 share/examples/pgpool-II/
 share/examples/pgpool-II/pcp.conf.sample
@@ -43,4 +44,3 @@
 share/postgresql/extension/pgpool-regclass.sql
 share/postgresql/extension/pgpool_regclass--1.0.sql
 share/postgresql/extension/pgpool_regclass.control
-@rcscript ${RCDIR}/pgpool