Re: update emulators/sameboy 0.15.8 [Was Re: update devel/rgbds 0.6.1]

2023-04-18 Thread Nam Nguyen
Nam Nguyen writes:

> "Anthony J. Bentley" writes:
>
>> sameboy actually has a build dependency on rgbds. Can you test that it
>> still builds?
>
> A sameboy update for 0.15.8 is inline. Since 0.15.7, it now builds with
> new rgbds. "SameBoy (and SameBoot) can now be built with RGBDS 0.6.x;
> support for RGBDS 0.4.x has been dropped"
> (https://github.com/LIJI32/SameBoy/releases/tag/v0.15.7)

Here is a fresh diff that regens WANTLIB and adds audio/openal to
LIB_DEPENDS.

>
> I tested snakebird and two other roms. In retroarch I had to use the
> "show desktop menu" option to make it possible to select cores. I was
> not able to use the big picture mode since it shows a blank list of
> suggested cores though I have fbneo and sameboy cores installed.
>
> standalone rgbds also works. sdl seems to have a regression though. ps3
> and ps4 controllers no longer work. xbox 360 controller works.
>
> Also, there's a high chance of usb crashing to ddb while setting
> controls. This was done with xbox 360 pad when it asks to move the
> analog stick. However, this has a chance of happening with sdl-jstest
> and flycast, so it is not specific to sameboy.
>
> see:
> https://namtsui.com/public/ujoy1.jpg
> https://namtsui.com/public/ujoy2.jpg
>
> I forgot to mention that rgbds included a helpful release note about
> requiring bison (https://github.com/gbdev/rgbds/releases/tag/v0.5.0):
>
> Attention downstream packagers
>
> The yacc dependency has been changed to GNU Bison! Our Makefile relies
> on bison -V to conditionally enable some features
> (src/check_bison_ver.sh)

Index: Makefile
===
RCS file: /cvs/ports/emulators/sameboy/Makefile,v
retrieving revision 1.7
diff -u -p -u -p -r1.7 Makefile
--- Makefile11 Mar 2022 18:59:41 -  1.7
+++ Makefile18 Apr 2023 19:48:40 -
@@ -4,7 +4,7 @@ COMMENT-libretro =  accurate Nintendo Gam
 PKGNAME-main = sameboy-$V
 PKGNAME-libretro = libretro-sameboy-$V
 
-V =0.14.3
+V =0.15.8
 
 GH_ACCOUNT =   LIJI32
 GH_PROJECT =   SameBoy
@@ -23,7 +23,7 @@ MAINTAINER =  Anthony J. Bentley 

update emulators/sameboy 0.15.8 [Was Re: update devel/rgbds 0.6.1]

2023-04-18 Thread Nam Nguyen
"Anthony J. Bentley" writes:

> sameboy actually has a build dependency on rgbds. Can you test that it
> still builds?

A sameboy update for 0.15.8 is inline. Since 0.15.7, it now builds with
new rgbds. "SameBoy (and SameBoot) can now be built with RGBDS 0.6.x;
support for RGBDS 0.4.x has been dropped"
(https://github.com/LIJI32/SameBoy/releases/tag/v0.15.7)

I tested snakebird and two other roms. In retroarch I had to use the
"show desktop menu" option to make it possible to select cores. I was
not able to use the big picture mode since it shows a blank list of
suggested cores though I have fbneo and sameboy cores installed.

standalone rgbds also works. sdl seems to have a regression though. ps3
and ps4 controllers no longer work. xbox 360 controller works.

Also, there's a high chance of usb crashing to ddb while setting
controls. This was done with xbox 360 pad when it asks to move the
analog stick. However, this has a chance of happening with sdl-jstest
and flycast, so it is not specific to sameboy.

see:
https://namtsui.com/public/ujoy1.jpg
https://namtsui.com/public/ujoy2.jpg

I forgot to mention that rgbds included a helpful release note about
requiring bison (https://github.com/gbdev/rgbds/releases/tag/v0.5.0):

--8<---cut here---start->8---
Attention downstream packagers

The yacc dependency has been changed to GNU Bison! Our Makefile relies
on bison -V to conditionally enable some features
(src/check_bison_ver.sh)
--8<---cut here---end--->8---

Index: Makefile
===
RCS file: /cvs/ports/emulators/sameboy/Makefile,v
retrieving revision 1.7
diff -u -p -u -p -r1.7 Makefile
--- Makefile11 Mar 2022 18:59:41 -  1.7
+++ Makefile18 Apr 2023 18:22:59 -
@@ -4,7 +4,7 @@ COMMENT-libretro =  accurate Nintendo Gam
 PKGNAME-main = sameboy-$V
 PKGNAME-libretro = libretro-sameboy-$V
 
-V =0.14.3
+V =0.15.8
 
 GH_ACCOUNT =   LIJI32
 GH_PROJECT =   SameBoy
Index: distinfo
===
RCS file: /cvs/ports/emulators/sameboy/distinfo,v
retrieving revision 1.5
diff -u -p -u -p -r1.5 distinfo
--- distinfo13 Jul 2021 19:15:39 -  1.5
+++ distinfo18 Apr 2023 18:22:59 -
@@ -1,2 +1,2 @@
-SHA256 (SameBoy-0.14.3.tar.gz) = Js5Qn2q2wMo933mt2qWN4XioqGnq8Fjwxb3QKmkxcek=
-SIZE (SameBoy-0.14.3.tar.gz) = 2855512
+SHA256 (SameBoy-0.15.8.tar.gz) = TKLiO/+tdUKY1YE9mDPmIX92/x0xI0leyf/i+kjdszs=
+SIZE (SameBoy-0.15.8.tar.gz) = 3112139
Index: patches/patch-Makefile
===
RCS file: /cvs/ports/emulators/sameboy/patches/patch-Makefile,v
retrieving revision 1.5
diff -u -p -u -p -r1.5 patch-Makefile
--- patches/patch-Makefile  11 Mar 2022 18:59:41 -  1.5
+++ patches/patch-Makefile  18 Apr 2023 18:22:59 -
@@ -1,7 +1,7 @@
 Index: Makefile
 --- Makefile.orig
 +++ Makefile
-@@ -106,7 +106,7 @@ OPEN_DIALOG = OpenDialog/cocoa.m
+@@ -112,7 +112,7 @@ OPEN_DIALOG = OpenDialog/cocoa.m
  endif
  
  # These must come before the -Wno- flags
@@ -10,7 +10,7 @@ Index: Makefile
  WARNINGS += -Wno-nonnull -Wno-unused-result -Wno-strict-aliasing 
-Wno-multichar -Wno-int-in-bool-context -Wno-format-truncation
  
  # Only add this flag if the compiler supports it
-@@ -142,7 +142,7 @@ LDFLAGS += -lmsvcrt -lcomdlg32 -luser32 -lshell32 -lol
+@@ -174,7 +174,7 @@ LDFLAGS += -lmsvcrt -lcomdlg32 -luser32 -lshell32 -lol
  SDL_LDFLAGS := -lSDL2
  GL_LDFLAGS := -lopengl32
  else
Index: pkg/PLIST-main
===
RCS file: /cvs/ports/emulators/sameboy/pkg/PLIST-main,v
retrieving revision 1.4
diff -u -p -u -p -r1.4 PLIST-main
--- pkg/PLIST-main  11 Mar 2022 18:59:41 -  1.4
+++ pkg/PLIST-main  18 Apr 2023 18:22:59 -
@@ -21,6 +21,14 @@ share/icons/hicolor/64x64/mimetypes/x-ga
 share/mime/packages/sameboy.xml
 share/sameboy/
 share/sameboy/LICENSE
+share/sameboy/Palettes/
+share/sameboy/Palettes/Desert.sbp
+share/sameboy/Palettes/Evening.sbp
+share/sameboy/Palettes/Fog.sbp
+share/sameboy/Palettes/Magic Eggplant.sbp
+share/sameboy/Palettes/Radioactive Pea.sbp
+share/sameboy/Palettes/Seaweed.sbp
+share/sameboy/Palettes/Twilight.sbp
 share/sameboy/Shaders/
 share/sameboy/Shaders/AAOmniScaleLegacy.fsh
 share/sameboy/Shaders/AAScale2x.fsh
@@ -39,8 +47,10 @@ share/sameboy/Shaders/Scale4x.fsh
 share/sameboy/Shaders/SmoothBilinear.fsh
 share/sameboy/agb_boot.bin
 share/sameboy/background.bmp
+share/sameboy/cgb0_boot.bin
 share/sameboy/cgb_boot.bin
 share/sameboy/dmg_boot.bin
+share/sameboy/mgb_boot.bin
 share/sameboy/registers.sym
 share/sameboy/sgb2_boot.bin
 share/sameboy/sgb_boot.bin