Re: vlc no telnet interface
I've just updated to 7.4 and now I see that vlc has the telnet interface.
It works like a charm.
Thanks again and regards
Il giorno ven 26 mag 2023 alle ore 14:09 Luca Di Gregorio
ha scritto:
> Ok, clear, thanks a lot for the effort and for the clarification.
>
> Il giorno ven 26 mag 2023 alle ore 10:58 Stuart Henderson <
> s...@spacehopper.org> ha scritto:
>
>> You are running 7.3. That has been added for -current only (the first
>> release it will make it into is 7.4).
>>
>> --
>> Sent from a phone, apologies for poor formatting.
>>
>>
>> On 26 May 2023 07:42:18 Luca Di Gregorio wrote:
>>
>> Hello, I've just done a 'pkg_add -Uu -v':
>>>
>>> Update candidates: vlc-3.0.18 -> vlc-3.0.18
>>>
>>> and tried to run 'vlc -vvv -I telnet', but I see again:
>>>
>>> main interface debug: looking for interface module matching "telnet": 13
>>> candidates
>>> main interface debug: no interface modules matched
>>> main interface error: no suitable interface module
>>>
>>> Am I doing something wrong?
>>>
>>> With a 'vlc --version' I see:
>>> VLC media player 3.0.18 Vetinari (revision 3.0.13-8-g41878ff4f2)
>>> VLC version 3.0.18 Vetinari (3.0.13-8-g41878ff4f2)
>>> Compiled by _pbuild on amd64-3.ports.openbsd.org (Mar 25 2023 12:30:05)
>>>
>>> Regards
>>> Luca
>>>
>>> Il giorno ven 12 mag 2023 alle ore 23:48 Brad Smith
>>> ha
>>> scritto:
>>>
>>> On 2023-05-10 4:29 a.m., Stuart Henderson wrote:
>>>>
>>>>> On 2023/04/30 11:53, Antoine Jacoutot wrote:
>>>>>
>>>>>> + if test "${enable_lua}" != "no"
>>>>>>> + then
>>>>>>> +- PKG_CHECK_MODULES(LUA, lua5.2,
>>>>>>> ++ PKG_CHECK_MODULES(LUA, lua51,
>>>>>>>
>>>>>> Can we use SUBST_CMD to prevent hardcoding?
>>>>>>
>>>>> I don't see anything wrong with hardcoding here? I think MODLUA_VERSION
>>>>> should reflect what the port wants, it's not like SHARED_LIBS.
>>>>>
>>>>> On 2023/05/09 02:29, Brad Smith wrote:
>>>>>
>>>>>> On 2023-05-01 5:36 a.m., Stuart Henderson wrote:
>>>>>>
>>>>>>> Any particular reason to use 5.1 instead of 5.2? (They're all EoL
>>>>>>>
>>>>>> except
>>>>
>>>>> 5.4, but 5.1 is much longer since EoL).
>>>>>>>
>>>>>> Just that is what the default is, MODLUA_DEFAULT_VERSION.
>>>>>>
>>>>> I don't think this is meant to be prescriptive any more than
>>>>> say AUTOCONF_VERSION, just that it's what most things used when the
>>>>> module was added. We haven't run into problems with ports pulling
>>>>> in multiple lua versions via lib deps.
>>>>>
>>>>> (I have a diff to add lua5.X pkg-config files to the lua ports to
>>>>> test sometime but the i386 builders are unhappy atm, also the include
>>>>> directories are non-standard too and also need patches in various
>>>>> ports,
>>>>> so it would be good to clean up that whole lot at once).
>>>>>
>>>>> How about this diff for vlc? Compared to your previous:
>>>>>
>>>>> - uses the lua version which upstream prefers
>>>>> - brings back UPDATE_PLIST_ARGS from my earlier one to avoid the
>>>>> a52/a${MODLUA_VERSION} that is subst'ed in PLIST-main with 5.2
>>>>>
>>>> I saw this part and did not understand what it was for.
>>>>
>>>>> - uses the minimum necessary configure.ac patch to handle lua52.pc.
>>>>>
>>>>
>>>> Sure.
>>>>
>>>>
>>>>
>>
Re: vlc no telnet interface
Ok, clear, thanks a lot for the effort and for the clarification.
Il giorno ven 26 mag 2023 alle ore 10:58 Stuart Henderson <
s...@spacehopper.org> ha scritto:
> You are running 7.3. That has been added for -current only (the first
> release it will make it into is 7.4).
>
> --
> Sent from a phone, apologies for poor formatting.
>
>
> On 26 May 2023 07:42:18 Luca Di Gregorio wrote:
>
> Hello, I've just done a 'pkg_add -Uu -v':
>>
>> Update candidates: vlc-3.0.18 -> vlc-3.0.18
>>
>> and tried to run 'vlc -vvv -I telnet', but I see again:
>>
>> main interface debug: looking for interface module matching "telnet": 13
>> candidates
>> main interface debug: no interface modules matched
>> main interface error: no suitable interface module
>>
>> Am I doing something wrong?
>>
>> With a 'vlc --version' I see:
>> VLC media player 3.0.18 Vetinari (revision 3.0.13-8-g41878ff4f2)
>> VLC version 3.0.18 Vetinari (3.0.13-8-g41878ff4f2)
>> Compiled by _pbuild on amd64-3.ports.openbsd.org (Mar 25 2023 12:30:05)
>>
>> Regards
>> Luca
>>
>> Il giorno ven 12 mag 2023 alle ore 23:48 Brad Smith
>> ha
>> scritto:
>>
>> On 2023-05-10 4:29 a.m., Stuart Henderson wrote:
>>>
On 2023/04/30 11:53, Antoine Jacoutot wrote:
> + if test "${enable_lua}" != "no"
>> + then
>> +- PKG_CHECK_MODULES(LUA, lua5.2,
>> ++ PKG_CHECK_MODULES(LUA, lua51,
>>
> Can we use SUBST_CMD to prevent hardcoding?
>
I don't see anything wrong with hardcoding here? I think MODLUA_VERSION
should reflect what the port wants, it's not like SHARED_LIBS.
On 2023/05/09 02:29, Brad Smith wrote:
> On 2023-05-01 5:36 a.m., Stuart Henderson wrote:
>
>> Any particular reason to use 5.1 instead of 5.2? (They're all EoL
>>
> except
>>>
5.4, but 5.1 is much longer since EoL).
>>
> Just that is what the default is, MODLUA_DEFAULT_VERSION.
>
I don't think this is meant to be prescriptive any more than
say AUTOCONF_VERSION, just that it's what most things used when the
module was added. We haven't run into problems with ports pulling
in multiple lua versions via lib deps.
(I have a diff to add lua5.X pkg-config files to the lua ports to
test sometime but the i386 builders are unhappy atm, also the include
directories are non-standard too and also need patches in various ports,
so it would be good to clean up that whole lot at once).
How about this diff for vlc? Compared to your previous:
- uses the lua version which upstream prefers
- brings back UPDATE_PLIST_ARGS from my earlier one to avoid the
a52/a${MODLUA_VERSION} that is subst'ed in PLIST-main with 5.2
>>> I saw this part and did not understand what it was for.
>>>
- uses the minimum necessary configure.ac patch to handle lua52.pc.
>>>
>>> Sure.
>>>
>>>
>>>
>
Re: vlc no telnet interface
You are running 7.3. That has been added for -current only (the first
release it will make it into is 7.4).
--
Sent from a phone, apologies for poor formatting.
On 26 May 2023 07:42:18 Luca Di Gregorio wrote:
Hello, I've just done a 'pkg_add -Uu -v':
Update candidates: vlc-3.0.18 -> vlc-3.0.18
and tried to run 'vlc -vvv -I telnet', but I see again:
main interface debug: looking for interface module matching "telnet": 13
candidates
main interface debug: no interface modules matched
main interface error: no suitable interface module
Am I doing something wrong?
With a 'vlc --version' I see:
VLC media player 3.0.18 Vetinari (revision 3.0.13-8-g41878ff4f2)
VLC version 3.0.18 Vetinari (3.0.13-8-g41878ff4f2)
Compiled by _pbuild on amd64-3.ports.openbsd.org (Mar 25 2023 12:30:05)
Regards
Luca
Il giorno ven 12 mag 2023 alle ore 23:48 Brad Smith ha
scritto:
On 2023-05-10 4:29 a.m., Stuart Henderson wrote:
> On 2023/04/30 11:53, Antoine Jacoutot wrote:
>>> + if test "${enable_lua}" != "no"
>>> + then
>>> +- PKG_CHECK_MODULES(LUA, lua5.2,
>>> ++ PKG_CHECK_MODULES(LUA, lua51,
>> Can we use SUBST_CMD to prevent hardcoding?
> I don't see anything wrong with hardcoding here? I think MODLUA_VERSION
> should reflect what the port wants, it's not like SHARED_LIBS.
>
> On 2023/05/09 02:29, Brad Smith wrote:
>> On 2023-05-01 5:36 a.m., Stuart Henderson wrote:
>>> Any particular reason to use 5.1 instead of 5.2? (They're all EoL
except
>>> 5.4, but 5.1 is much longer since EoL).
>> Just that is what the default is, MODLUA_DEFAULT_VERSION.
> I don't think this is meant to be prescriptive any more than
> say AUTOCONF_VERSION, just that it's what most things used when the
> module was added. We haven't run into problems with ports pulling
> in multiple lua versions via lib deps.
>
> (I have a diff to add lua5.X pkg-config files to the lua ports to
> test sometime but the i386 builders are unhappy atm, also the include
> directories are non-standard too and also need patches in various ports,
> so it would be good to clean up that whole lot at once).
>
> How about this diff for vlc? Compared to your previous:
>
> - uses the lua version which upstream prefers
> - brings back UPDATE_PLIST_ARGS from my earlier one to avoid the
> a52/a${MODLUA_VERSION} that is subst'ed in PLIST-main with 5.2
I saw this part and did not understand what it was for.
> - uses the minimum necessary configure.ac patch to handle lua52.pc.
Sure.
Re: vlc no telnet interface
Hello, I've just done a 'pkg_add -Uu -v':
Update candidates: vlc-3.0.18 -> vlc-3.0.18
and tried to run 'vlc -vvv -I telnet', but I see again:
main interface debug: looking for interface module matching "telnet": 13
candidates
main interface debug: no interface modules matched
main interface error: no suitable interface module
Am I doing something wrong?
With a 'vlc --version' I see:
VLC media player 3.0.18 Vetinari (revision 3.0.13-8-g41878ff4f2)
VLC version 3.0.18 Vetinari (3.0.13-8-g41878ff4f2)
Compiled by _pbuild on amd64-3.ports.openbsd.org (Mar 25 2023 12:30:05)
Regards
Luca
Il giorno ven 12 mag 2023 alle ore 23:48 Brad Smith ha
scritto:
> On 2023-05-10 4:29 a.m., Stuart Henderson wrote:
> > On 2023/04/30 11:53, Antoine Jacoutot wrote:
> >>> + if test "${enable_lua}" != "no"
> >>> + then
> >>> +- PKG_CHECK_MODULES(LUA, lua5.2,
> >>> ++ PKG_CHECK_MODULES(LUA, lua51,
> >> Can we use SUBST_CMD to prevent hardcoding?
> > I don't see anything wrong with hardcoding here? I think MODLUA_VERSION
> > should reflect what the port wants, it's not like SHARED_LIBS.
> >
> > On 2023/05/09 02:29, Brad Smith wrote:
> >> On 2023-05-01 5:36 a.m., Stuart Henderson wrote:
> >>> Any particular reason to use 5.1 instead of 5.2? (They're all EoL
> except
> >>> 5.4, but 5.1 is much longer since EoL).
> >> Just that is what the default is, MODLUA_DEFAULT_VERSION.
> > I don't think this is meant to be prescriptive any more than
> > say AUTOCONF_VERSION, just that it's what most things used when the
> > module was added. We haven't run into problems with ports pulling
> > in multiple lua versions via lib deps.
> >
> > (I have a diff to add lua5.X pkg-config files to the lua ports to
> > test sometime but the i386 builders are unhappy atm, also the include
> > directories are non-standard too and also need patches in various ports,
> > so it would be good to clean up that whole lot at once).
> >
> > How about this diff for vlc? Compared to your previous:
> >
> > - uses the lua version which upstream prefers
> > - brings back UPDATE_PLIST_ARGS from my earlier one to avoid the
> > a52/a${MODLUA_VERSION} that is subst'ed in PLIST-main with 5.2
> I saw this part and did not understand what it was for.
> > - uses the minimum necessary configure.ac patch to handle lua52.pc.
>
> Sure.
>
>
Re: vlc no telnet interface
On 2023-05-10 4:29 a.m., Stuart Henderson wrote:
On 2023/04/30 11:53, Antoine Jacoutot wrote:
+ if test "${enable_lua}" != "no"
+ then
+- PKG_CHECK_MODULES(LUA, lua5.2,
++ PKG_CHECK_MODULES(LUA, lua51,
Can we use SUBST_CMD to prevent hardcoding?
I don't see anything wrong with hardcoding here? I think MODLUA_VERSION
should reflect what the port wants, it's not like SHARED_LIBS.
On 2023/05/09 02:29, Brad Smith wrote:
On 2023-05-01 5:36 a.m., Stuart Henderson wrote:
Any particular reason to use 5.1 instead of 5.2? (They're all EoL except
5.4, but 5.1 is much longer since EoL).
Just that is what the default is, MODLUA_DEFAULT_VERSION.
I don't think this is meant to be prescriptive any more than
say AUTOCONF_VERSION, just that it's what most things used when the
module was added. We haven't run into problems with ports pulling
in multiple lua versions via lib deps.
(I have a diff to add lua5.X pkg-config files to the lua ports to
test sometime but the i386 builders are unhappy atm, also the include
directories are non-standard too and also need patches in various ports,
so it would be good to clean up that whole lot at once).
How about this diff for vlc? Compared to your previous:
- uses the lua version which upstream prefers
- brings back UPDATE_PLIST_ARGS from my earlier one to avoid the
a52/a${MODLUA_VERSION} that is subst'ed in PLIST-main with 5.2
I saw this part and did not understand what it was for.
- uses the minimum necessary configure.ac patch to handle lua52.pc.
Sure.
Re: vlc no telnet interface
Just one less file to edit. But sure.
—
Antoine
> On 10 May 2023, at 10:30, Stuart Henderson wrote:
>
> On 2023/04/30 11:53, Antoine Jacoutot wrote:
>>> + if test "${enable_lua}" != "no"
>>> + then
>>> +- PKG_CHECK_MODULES(LUA, lua5.2,
>>> ++ PKG_CHECK_MODULES(LUA, lua51,
>>
>> Can we use SUBST_CMD to prevent hardcoding?
>
> I don't see anything wrong with hardcoding here? I think MODLUA_VERSION
> should reflect what the port wants, it's not like SHARED_LIBS.
>
>> On 2023/05/09 02:29, Brad Smith wrote:
>>> On 2023-05-01 5:36 a.m., Stuart Henderson wrote:
>>> Any particular reason to use 5.1 instead of 5.2? (They're all EoL except
>>> 5.4, but 5.1 is much longer since EoL).
>> Just that is what the default is, MODLUA_DEFAULT_VERSION.
>
> I don't think this is meant to be prescriptive any more than
> say AUTOCONF_VERSION, just that it's what most things used when the
> module was added. We haven't run into problems with ports pulling
> in multiple lua versions via lib deps.
>
> (I have a diff to add lua5.X pkg-config files to the lua ports to
> test sometime but the i386 builders are unhappy atm, also the include
> directories are non-standard too and also need patches in various ports,
> so it would be good to clean up that whole lot at once).
>
> How about this diff for vlc? Compared to your previous:
>
> - uses the lua version which upstream prefers
> - brings back UPDATE_PLIST_ARGS from my earlier one to avoid the
> a52/a${MODLUA_VERSION} that is subst'ed in PLIST-main with 5.2
> - uses the minimum necessary configure.ac patch to handle lua52.pc.
>
> Index: Makefile
> ===
> RCS file: /cvs/ports/x11/vlc/Makefile,v
> retrieving revision 1.262
> diff -u -p -r1.262 Makefile
> --- Makefile24 Apr 2023 11:42:50 -1.262
> +++ Makefile10 May 2023 08:26:06 -
> @@ -5,7 +5,7 @@ V=3.0.18
> DISTNAME=vlc-${V}
> PKGNAME-main=${DISTNAME}
> PKGNAME-jack=vlc-jack-${V}
> -REVISION-main=1
> +REVISION-main=2
> CATEGORIES=x11
> MASTER_SITES=https://download.videolan.org/pub/videolan/vlc/${V}/
> EXTRACT_SUFX=.tar.xz
> @@ -43,7 +43,7 @@ WANTLIB-main=EGL GL ICE Qt5Core Qt5Gui
>vpx webp x264 x265 xcb xcb-composite xcb-dri2 xcb-dri3 \
>xcb-glx xcb-keysyms xcb-present xcb-randr xcb-render \
>xcb-shm xcb-sync xcb-xfixes xcb-xv xml2 xshmfence \
> -xvidcore z zstd ${WANTLIB-common}
> +xvidcore z zstd ${WANTLIB-common} ${MODLUA_WANTLIB}
> # v4l2 is dlopen'd
> WANTLIB-main+=v4l2
>
> @@ -53,7 +53,13 @@ AUTOCONF_VERSION= 2.69
> AUTOMAKE_VERSION= 1.16
> AUTORECONF=./bootstrap
>
> -MODULES=x11/qt5
> +MODULES=lang/lua \
> +x11/qt5
> +
> +MODLUA_VERSION=5.2
> +MODLUA_SA=Yes
> +MODLUA_RUNDEP=No
> +UPDATE_PLIST_ARGS+= -i MODLUA_DEP_VERSION
>
> COMPILER=base-clang ports-gcc
>
> @@ -145,7 +151,6 @@ CONFIGURE_ARGS+=--disable-a52 \
>--disable-libva \
>--disable-linsys \
>--disable-live555 \
> ---disable-lua \
>--disable-mad \
>--disable-mfx \
>--disable-microdns \
> @@ -188,7 +193,8 @@ CONFIGURE_ENV+=BUILDCC="${CC}" \
>LDFLAGS="-L${X11BASE}/lib -L${LOCALBASE}/lib" \
>LIBS_libvlccore="-lexecinfo" \
>PKG_CONFIG_PATH="${LOCALBASE}/lib/qt5/pkgconfig" \
> -RCC="${LOCALBASE}/bin/rcc-qt5"
> +RCC="${LOCALBASE}/bin/rcc-qt5" \
> +LUAC="${LOCALBASE}/bin/luac${MODLUA_DEP_VERSION}"
>
> PSEUDO_FLAVORS=no_jack
> FLAVOR?=
> Index: patches/patch-configure_ac
> ===
> RCS file: /cvs/ports/x11/vlc/patches/patch-configure_ac,v
> retrieving revision 1.43
> diff -u -p -r1.43 patch-configure_ac
> --- patches/patch-configure_ac25 Nov 2022 11:52:17 -1.43
> +++ patches/patch-configure_ac10 May 2023 08:26:06 -
> @@ -11,11 +11,10 @@ Index: configure.ac
> ;;
>netbsd*)
> SYS=netbsd
> -@@ -1122,22 +1121,6 @@ AC_ARG_ENABLE(optimizations,
> -
> +@@ -1123,22 +1122,6 @@ AC_ARG_ENABLE(optimizations,
> dnl Check for various optimization flags
> AS_IF([test "${enable_optimizations}" != "no"], [
> --
> +
> - dnl -O3 only in production builds
> - AS_IF([test "${enable_debug}" = "no"], [
> -VLC_SAVE_FLAGS
> @@ -31,6 +30,16 @@ Index: configure.ac
> -])
> -AS_IF([test "${ac_cv_c_o3}" = "no"], [VLC_RESTORE_FLAGS])
> - ])
> -
> +-
>dnl Check for fast maths
>AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
> -fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CFLAGS])
> + AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
> -fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CXXFLAGS])
> +@@ -1664,7 +1647,7 @@ AC_ARG_ENABLE(lua,
> + [disable LUA scripting support (default enabled)])])
> + if test "${enable_lua}" != "no"
> + then
> +- PKG_CHECK_MODULES(LUA, lua5.2,
> ++
Re: vlc no telnet interface
On 2023/04/30 11:53, Antoine Jacoutot wrote:
> > + if test "${enable_lua}" != "no"
> > + then
> > +- PKG_CHECK_MODULES(LUA, lua5.2,
> > ++ PKG_CHECK_MODULES(LUA, lua51,
>
> Can we use SUBST_CMD to prevent hardcoding?
I don't see anything wrong with hardcoding here? I think MODLUA_VERSION
should reflect what the port wants, it's not like SHARED_LIBS.
On 2023/05/09 02:29, Brad Smith wrote:
> On 2023-05-01 5:36 a.m., Stuart Henderson wrote:
> > Any particular reason to use 5.1 instead of 5.2? (They're all EoL except
> > 5.4, but 5.1 is much longer since EoL).
> Just that is what the default is, MODLUA_DEFAULT_VERSION.
I don't think this is meant to be prescriptive any more than
say AUTOCONF_VERSION, just that it's what most things used when the
module was added. We haven't run into problems with ports pulling
in multiple lua versions via lib deps.
(I have a diff to add lua5.X pkg-config files to the lua ports to
test sometime but the i386 builders are unhappy atm, also the include
directories are non-standard too and also need patches in various ports,
so it would be good to clean up that whole lot at once).
How about this diff for vlc? Compared to your previous:
- uses the lua version which upstream prefers
- brings back UPDATE_PLIST_ARGS from my earlier one to avoid the
a52/a${MODLUA_VERSION} that is subst'ed in PLIST-main with 5.2
- uses the minimum necessary configure.ac patch to handle lua52.pc.
Index: Makefile
===
RCS file: /cvs/ports/x11/vlc/Makefile,v
retrieving revision 1.262
diff -u -p -r1.262 Makefile
--- Makefile24 Apr 2023 11:42:50 - 1.262
+++ Makefile10 May 2023 08:26:06 -
@@ -5,7 +5,7 @@ V= 3.0.18
DISTNAME= vlc-${V}
PKGNAME-main= ${DISTNAME}
PKGNAME-jack= vlc-jack-${V}
-REVISION-main= 1
+REVISION-main= 2
CATEGORIES=x11
MASTER_SITES= https://download.videolan.org/pub/videolan/vlc/${V}/
EXTRACT_SUFX= .tar.xz
@@ -43,7 +43,7 @@ WANTLIB-main= EGL GL ICE Qt5Core Qt5Gui
vpx webp x264 x265 xcb xcb-composite xcb-dri2 xcb-dri3 \
xcb-glx xcb-keysyms xcb-present xcb-randr xcb-render \
xcb-shm xcb-sync xcb-xfixes xcb-xv xml2 xshmfence \
- xvidcore z zstd ${WANTLIB-common}
+ xvidcore z zstd ${WANTLIB-common} ${MODLUA_WANTLIB}
# v4l2 is dlopen'd
WANTLIB-main+= v4l2
@@ -53,7 +53,13 @@ AUTOCONF_VERSION= 2.69
AUTOMAKE_VERSION= 1.16
AUTORECONF=./bootstrap
-MODULES= x11/qt5
+MODULES= lang/lua \
+ x11/qt5
+
+MODLUA_VERSION=5.2
+MODLUA_SA= Yes
+MODLUA_RUNDEP= No
+UPDATE_PLIST_ARGS+= -i MODLUA_DEP_VERSION
COMPILER= base-clang ports-gcc
@@ -145,7 +151,6 @@ CONFIGURE_ARGS+=--disable-a52 \
--disable-libva \
--disable-linsys \
--disable-live555 \
- --disable-lua \
--disable-mad \
--disable-mfx \
--disable-microdns \
@@ -188,7 +193,8 @@ CONFIGURE_ENV+= BUILDCC="${CC}" \
LDFLAGS="-L${X11BASE}/lib -L${LOCALBASE}/lib" \
LIBS_libvlccore="-lexecinfo" \
PKG_CONFIG_PATH="${LOCALBASE}/lib/qt5/pkgconfig" \
- RCC="${LOCALBASE}/bin/rcc-qt5"
+ RCC="${LOCALBASE}/bin/rcc-qt5" \
+ LUAC="${LOCALBASE}/bin/luac${MODLUA_DEP_VERSION}"
PSEUDO_FLAVORS=no_jack
FLAVOR?=
Index: patches/patch-configure_ac
===
RCS file: /cvs/ports/x11/vlc/patches/patch-configure_ac,v
retrieving revision 1.43
diff -u -p -r1.43 patch-configure_ac
--- patches/patch-configure_ac 25 Nov 2022 11:52:17 - 1.43
+++ patches/patch-configure_ac 10 May 2023 08:26:06 -
@@ -11,11 +11,10 @@ Index: configure.ac
;;
netbsd*)
SYS=netbsd
-@@ -1122,22 +1121,6 @@ AC_ARG_ENABLE(optimizations,
-
+@@ -1123,22 +1122,6 @@ AC_ARG_ENABLE(optimizations,
dnl Check for various optimization flags
AS_IF([test "${enable_optimizations}" != "no"], [
--
+
- dnl -O3 only in production builds
- AS_IF([test "${enable_debug}" = "no"], [
-VLC_SAVE_FLAGS
@@ -31,6 +30,16 @@ Index: configure.ac
-])
-AS_IF([test "${ac_cv_c_o3}" = "no"], [VLC_RESTORE_FLAGS])
- ])
-
+-
dnl Check for fast maths
AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
-fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CFLAGS])
+ AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
-fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CXXFLAGS])
+@@ -1664,7 +1647,7 @@ AC_ARG_ENABLE(lua,
+ [disable LUA scripting support (default enabled)])])
+ if test "${enable_lua}" != "no"
+ then
+- PKG_CHECK_MODULES(LUA, lua5.2,
++ PKG_CHECK_MODULES(LUA, lua52,
+ [ have_lua=yes ],
+ [
+ AC_MSG_WARN([${LUA_PKG_ERRORS}, trying lua 5.1 instead])
Index: pkg/PLIST-main
Re: vlc no telnet interface
On 2023-05-01 5:36 a.m., Stuart Henderson wrote:
On 2023/04/30 02:19, Brad Smith wrote:
+@@ -1664,12 +1647,12 @@ AC_ARG_ENABLE(lua,
+ [disable LUA scripting support (default enabled)])])
+ if test "${enable_lua}" != "no"
+ then
+- PKG_CHECK_MODULES(LUA, lua5.2,
++ PKG_CHECK_MODULES(LUA, lua51,
Any particular reason to use 5.1 instead of 5.2? (They're all EoL except
5.4, but 5.1 is much longer since EoL).
Just that is what the default is, MODLUA_DEFAULT_VERSION.
Perhaps our lua ports should install pkg-config files under the lua5X
names which most other people seem to use, or maybe both lua5X and
lua5.X, to reduce the need for patching other ports.
That's another issue that affects any project that hasn't been modified
to understand
OpenBSD's naming scheme.
I'm thinking probably both.
Re: vlc no telnet interface
On 2023/04/30 02:19, Brad Smith wrote:
> +@@ -1664,12 +1647,12 @@ AC_ARG_ENABLE(lua,
> + [disable LUA scripting support (default enabled)])])
> + if test "${enable_lua}" != "no"
> + then
> +- PKG_CHECK_MODULES(LUA, lua5.2,
> ++ PKG_CHECK_MODULES(LUA, lua51,
Any particular reason to use 5.1 instead of 5.2? (They're all EoL except
5.4, but 5.1 is much longer since EoL).
Perhaps our lua ports should install pkg-config files under the lua5X
names which most other people seem to use, or maybe both lua5X and
lua5.X, to reduce the need for patching other ports.
Re: vlc no telnet interface
On Sun, Apr 30, 2023 at 02:19:09AM -0400, Brad Smith wrote:
> On Wed, Apr 26, 2023 at 04:15:44PM +0100, Stuart Henderson wrote:
> > On 2023/04/25 09:55, Luca Di Gregorio wrote:
> > > Hi, I see that vlc doesn't have the telnet interface:
> > >
> > > # vlc -vvv -I telnet
> > > VLC media player 3.0.18 Vetinari (revision 3.0.13-8-g41878ff4f2)
> > > ...
> > > main interface debug: looking for interface module matching "telnet": 13
> > >candidates
> > > main interface debug: no interface modules matched
> > > ...
> > >
> > > Do you think that it's possible to have a new executable of vlc
> > > with the telnet interface available?
> >
> > It can be done like this. I have no idea whether the maintainer
> > (cc'd) would like to do that or not though, it will add a bit of
> > extra work at port update time if the PLISTs need updating.
>
> Something like this is fine with me.
>
>
> Index: Makefile
> ===
> RCS file: /home/cvs/ports/x11/vlc/Makefile,v
> retrieving revision 1.262
> diff -u -p -u -p -r1.262 Makefile
> --- Makefile 24 Apr 2023 11:42:50 - 1.262
> +++ Makefile 27 Apr 2023 22:48:50 -
> @@ -5,7 +5,7 @@ V=3.0.18
> DISTNAME=vlc-${V}
> PKGNAME-main=${DISTNAME}
> PKGNAME-jack=vlc-jack-${V}
> -REVISION-main= 1
> +REVISION-main= 2
> CATEGORIES= x11
> MASTER_SITES=https://download.videolan.org/pub/videolan/vlc/${V}/
> EXTRACT_SUFX=.tar.xz
> @@ -43,7 +43,7 @@ WANTLIB-main= EGL GL ICE Qt5Core Qt5Gui
> vpx webp x264 x265 xcb xcb-composite xcb-dri2 xcb-dri3 \
> xcb-glx xcb-keysyms xcb-present xcb-randr xcb-render \
> xcb-shm xcb-sync xcb-xfixes xcb-xv xml2 xshmfence \
> - xvidcore z zstd ${WANTLIB-common}
> + xvidcore z zstd ${WANTLIB-common} ${MODLUA_WANTLIB}
> # v4l2 is dlopen'd
> WANTLIB-main+= v4l2
>
> @@ -53,7 +53,11 @@ AUTOCONF_VERSION= 2.69
> AUTOMAKE_VERSION= 1.16
> AUTORECONF= ./bootstrap
>
> -MODULES= x11/qt5
> +MODULES= lang/lua \
> + x11/qt5
> +
> +MODLUA_SA= Yes
> +MODLUA_RUNDEP= No
>
> COMPILER=base-clang ports-gcc
>
> @@ -145,7 +149,6 @@ CONFIGURE_ARGS+=--disable-a52 \
> --disable-libva \
> --disable-linsys \
> --disable-live555 \
> - --disable-lua \
> --disable-mad \
> --disable-mfx \
> --disable-microdns \
> @@ -188,7 +191,8 @@ CONFIGURE_ENV+= BUILDCC="${CC}" \
> LDFLAGS="-L${X11BASE}/lib -L${LOCALBASE}/lib" \
> LIBS_libvlccore="-lexecinfo" \
> PKG_CONFIG_PATH="${LOCALBASE}/lib/qt5/pkgconfig" \
> - RCC="${LOCALBASE}/bin/rcc-qt5"
> + RCC="${LOCALBASE}/bin/rcc-qt5" \
> + LUAC="${LOCALBASE}/bin/luac${MODLUA_DEP_VERSION}"
>
> PSEUDO_FLAVORS= no_jack
> FLAVOR?=
> Index: patches/patch-configure_ac
> ===
> RCS file: /home/cvs/ports/x11/vlc/patches/patch-configure_ac,v
> retrieving revision 1.43
> diff -u -p -u -p -r1.43 patch-configure_ac
> --- patches/patch-configure_ac25 Nov 2022 11:52:17 - 1.43
> +++ patches/patch-configure_ac25 Apr 2023 08:45:33 -
> @@ -11,11 +11,10 @@ Index: configure.ac
> ;;
> netbsd*)
> SYS=netbsd
> -@@ -1122,22 +1121,6 @@ AC_ARG_ENABLE(optimizations,
> -
> +@@ -1123,22 +1122,6 @@ AC_ARG_ENABLE(optimizations,
> dnl Check for various optimization flags
> AS_IF([test "${enable_optimizations}" != "no"], [
> --
> +
> - dnl -O3 only in production builds
> - AS_IF([test "${enable_debug}" = "no"], [
> -VLC_SAVE_FLAGS
> @@ -31,6 +30,34 @@ Index: configure.ac
> -])
> -AS_IF([test "${ac_cv_c_o3}" = "no"], [VLC_RESTORE_FLAGS])
> - ])
> -
> +-
> dnl Check for fast maths
> AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
> -fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CFLAGS])
> + AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
> -fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CXXFLAGS])
> +@@ -1664,12 +1647,12 @@ AC_ARG_ENABLE(lua,
> + [disable LUA scripting support (default enabled)])])
> + if test "${enable_lua}" != "no"
> + then
&g
Re: vlc no telnet interface
On Wed, Apr 26, 2023 at 04:15:44PM +0100, Stuart Henderson wrote:
> On 2023/04/25 09:55, Luca Di Gregorio wrote:
> > Hi, I see that vlc doesn't have the telnet interface:
> >
> > # vlc -vvv -I telnet
> > VLC media player 3.0.18 Vetinari (revision 3.0.13-8-g41878ff4f2)
> > ...
> > main interface debug: looking for interface module matching "telnet": 13
> >candidates
> > main interface debug: no interface modules matched
> > ...
> >
> > Do you think that it's possible to have a new executable of vlc
> > with the telnet interface available?
>
> It can be done like this. I have no idea whether the maintainer
> (cc'd) would like to do that or not though, it will add a bit of
> extra work at port update time if the PLISTs need updating.
Something like this is fine with me.
Index: Makefile
===
RCS file: /home/cvs/ports/x11/vlc/Makefile,v
retrieving revision 1.262
diff -u -p -u -p -r1.262 Makefile
--- Makefile24 Apr 2023 11:42:50 - 1.262
+++ Makefile27 Apr 2023 22:48:50 -
@@ -5,7 +5,7 @@ V= 3.0.18
DISTNAME= vlc-${V}
PKGNAME-main= ${DISTNAME}
PKGNAME-jack= vlc-jack-${V}
-REVISION-main= 1
+REVISION-main= 2
CATEGORIES=x11
MASTER_SITES= https://download.videolan.org/pub/videolan/vlc/${V}/
EXTRACT_SUFX= .tar.xz
@@ -43,7 +43,7 @@ WANTLIB-main= EGL GL ICE Qt5Core Qt5Gui
vpx webp x264 x265 xcb xcb-composite xcb-dri2 xcb-dri3 \
xcb-glx xcb-keysyms xcb-present xcb-randr xcb-render \
xcb-shm xcb-sync xcb-xfixes xcb-xv xml2 xshmfence \
- xvidcore z zstd ${WANTLIB-common}
+ xvidcore z zstd ${WANTLIB-common} ${MODLUA_WANTLIB}
# v4l2 is dlopen'd
WANTLIB-main+= v4l2
@@ -53,7 +53,11 @@ AUTOCONF_VERSION= 2.69
AUTOMAKE_VERSION= 1.16
AUTORECONF=./bootstrap
-MODULES= x11/qt5
+MODULES= lang/lua \
+ x11/qt5
+
+MODLUA_SA= Yes
+MODLUA_RUNDEP= No
COMPILER= base-clang ports-gcc
@@ -145,7 +149,6 @@ CONFIGURE_ARGS+=--disable-a52 \
--disable-libva \
--disable-linsys \
--disable-live555 \
- --disable-lua \
--disable-mad \
--disable-mfx \
--disable-microdns \
@@ -188,7 +191,8 @@ CONFIGURE_ENV+= BUILDCC="${CC}" \
LDFLAGS="-L${X11BASE}/lib -L${LOCALBASE}/lib" \
LIBS_libvlccore="-lexecinfo" \
PKG_CONFIG_PATH="${LOCALBASE}/lib/qt5/pkgconfig" \
- RCC="${LOCALBASE}/bin/rcc-qt5"
+ RCC="${LOCALBASE}/bin/rcc-qt5" \
+ LUAC="${LOCALBASE}/bin/luac${MODLUA_DEP_VERSION}"
PSEUDO_FLAVORS=no_jack
FLAVOR?=
Index: patches/patch-configure_ac
===
RCS file: /home/cvs/ports/x11/vlc/patches/patch-configure_ac,v
retrieving revision 1.43
diff -u -p -u -p -r1.43 patch-configure_ac
--- patches/patch-configure_ac 25 Nov 2022 11:52:17 - 1.43
+++ patches/patch-configure_ac 25 Apr 2023 08:45:33 -
@@ -11,11 +11,10 @@ Index: configure.ac
;;
netbsd*)
SYS=netbsd
-@@ -1122,22 +1121,6 @@ AC_ARG_ENABLE(optimizations,
-
+@@ -1123,22 +1122,6 @@ AC_ARG_ENABLE(optimizations,
dnl Check for various optimization flags
AS_IF([test "${enable_optimizations}" != "no"], [
--
+
- dnl -O3 only in production builds
- AS_IF([test "${enable_debug}" = "no"], [
-VLC_SAVE_FLAGS
@@ -31,6 +30,34 @@ Index: configure.ac
-])
-AS_IF([test "${ac_cv_c_o3}" = "no"], [VLC_RESTORE_FLAGS])
- ])
-
+-
dnl Check for fast maths
AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
-fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CFLAGS])
+ AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
-fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CXXFLAGS])
+@@ -1664,12 +1647,12 @@ AC_ARG_ENABLE(lua,
+ [disable LUA scripting support (default enabled)])])
+ if test "${enable_lua}" != "no"
+ then
+- PKG_CHECK_MODULES(LUA, lua5.2,
++ PKG_CHECK_MODULES(LUA, lua51,
+ [ have_lua=yes ],
+ [
+ AC_MSG_WARN([${LUA_PKG_ERRORS}, trying lua 5.1 instead])
+
+-PKG_CHECK_MODULES(LUA, lua5.1,
++PKG_CHECK_MODULES(LUA, lua51,
+ [ have_lua=yes ],
+ [
+ AC_MSG_WARN([${LUA_PKG_ERRORS}, trying lua >= 5.1 instead])
+@@ -1681,9 +1664,9 @@ then
+ AC_CHECK_HEADERS([lua.h lauxlib.h lualib.h],
+ [],
+ [ have_lua=no ] )
+- AC_CHECK_LIB( lua5.2 , luaL_newstate,
++ AC_CHECK_LIB( lua52 , luaL_newstate,
+ [LUA_LIBS="-ll
Re: vlc no telnet interface
It would be great for my project.
With oldrc I can only add/enqueue items to the playlist,
but I cannot remove a specific item.
There is the command 'clear', but it removes all the items of the playlist.
Thanks a lot
Il giorno gio 27 apr 2023 alle ore 06:58 Brad Smith ha
scritto:
> On 2023-04-26 11:15 a.m., Stuart Henderson wrote:
> > On 2023/04/25 09:55, Luca Di Gregorio wrote:
> >> Hi, I see that vlc doesn't have the telnet interface:
> >>
> >> # vlc -vvv -I telnet
> >> VLC media player 3.0.18 Vetinari (revision 3.0.13-8-g41878ff4f2)
> >> ...
> >> main interface debug: looking for interface module matching "telnet": 13
> >> candidates
> >> main interface debug: no interface modules matched
> >> ...
> >>
> >> Do you think that it's possible to have a new executable of vlc
> >> with the telnet interface available?
> > It can be done like this. I have no idea whether the maintainer
> > (cc'd) would like to do that or not though, it will add a bit of
> > extra work at port update time if the PLISTs need updating.
>
> I don't mind adding it to the main package.
>
> > Index: Makefile
> > ===
> > RCS file: /cvs/ports/x11/vlc/Makefile,v
> > retrieving revision 1.262
> > diff -u -p -r1.262 Makefile
> > --- Makefile 24 Apr 2023 11:42:50 - 1.262
> > +++ Makefile 26 Apr 2023 15:12:15 -
> > @@ -1,11 +1,13 @@
> > COMMENT-main= VideoLAN client; multimedia player
> > COMMENT-jack= JACK audio output module for VLC
> > +COMMENT-lua= Lua support for VLC, including telnet module
> >
> > V= 3.0.18
> > DISTNAME= vlc-${V}
> > PKGNAME-main= ${DISTNAME}
> > PKGNAME-jack= vlc-jack-${V}
> > -REVISION-main= 1
> > +PKGNAME-lua= vlc-lua-${V}
> > +REVISION-main= 2
> > CATEGORIES= x11
> > MASTER_SITES=
> https://download.videolan.org/pub/videolan/vlc/${V}/
> > EXTRACT_SUFX= .tar.xz
> > @@ -49,6 +51,8 @@ WANTLIB-main+= v4l2
> >
> > WANTLIB-jack= db execinfo jack vlccore ${WANTLIB-common}
> >
> > +WANTLIB-lua= ${MODLUA_WANTLIB}
> > +
> > AUTOCONF_VERSION= 2.69
> > AUTOMAKE_VERSION= 1.16
> > AUTORECONF= ./bootstrap
> > @@ -101,6 +105,8 @@ LIB_DEPENDS-main= ${MODQT5_LIB_DEPENDS}
> > x11/gtk+3
> > LIB_DEPENDS-jack= ${BUILD_PKGPATH} \
> > audio/jack
> > +RUN_DEPENDS-lua= ${BUILD_PKGPATH}
> > +LIB_DEPENDS-lua= ${MODLUA_LIB_DEPENDS}
> > BUILD_DEPENDS= ${MODGNU_AUTOCONF_DEPENDS} \
> > ${MODGNU_AUTOMAKE_DEPENDS} \
> > archivers/gtar \
> > @@ -145,7 +151,6 @@ CONFIGURE_ARGS+=--disable-a52 \
> > --disable-libva \
> > --disable-linsys \
> > --disable-live555 \
> > - --disable-lua \
> > --disable-mad \
> > --disable-mfx \
> > --disable-microdns \
> > @@ -190,19 +195,27 @@ CONFIGURE_ENV+= BUILDCC="${CC}" \
> > PKG_CONFIG_PATH="${LOCALBASE}/lib/qt5/pkgconfig" \
> > RCC="${LOCALBASE}/bin/rcc-qt5"
> >
> > -PSEUDO_FLAVORS= no_jack
> > +PSEUDO_FLAVORS= no_jack no_lua
> > FLAVOR?=
> >
> > -MULTI_PACKAGES= -main
> > -
> > -.if !${FLAVOR:Mno_jack}
> > -MULTI_PACKAGES+=-jack
> > -.endif
> > +MULTI_PACKAGES= -main -jack -lua
> >
> > .include
> >
> > .if !${BUILD_PACKAGES:M-jack}
> > CONFIGURE_ARGS+=--disable-jack
> > +.endif
> > +
> > +.if !${BUILD_PACKAGES:M-lua}
> > +CONFIGURE_ARGS+= --disable-lua
> > +.else
> > +CONFIGURE_ENV+= LUAC="luac${MODLUA_DEP_VERSION}"
> > +MODULES+=lang/lua
> > +MODLUA_VERSION= 5.2
> > +MODLUA_SA= Yes
> > +MODLUA_RUNDEP= No
> > +CONFIGURE_ARGS+= --enable-lua
> > +UPDATE_PLIST_ARGS+= -i MODLUA_DEP_VERSION
> > .endif
> >
> > .if ${MACHINE_ARCH} == "amd64"
> > Index: patches/patch-configure_ac
> > ===
> > RCS file: /cvs/ports/x11/vlc/patches/patch-configure_ac,v
> > retrieving revision 1.43
> > diff -u -p -r1.43 patch-configure_ac
> > --- patches/patch-configure_ac25 Nov 2022 11:52:17 -
> 1.43
> > +++ patches/patch-configure_ac26 Apr 2023 15:12:15 -
> > @@ -11,11 +11,10 @@ Index: configur
Re: vlc no telnet interface
On 2023-04-26 11:15 a.m., Stuart Henderson wrote:
On 2023/04/25 09:55, Luca Di Gregorio wrote:
Hi, I see that vlc doesn't have the telnet interface:
# vlc -vvv -I telnet
VLC media player 3.0.18 Vetinari (revision 3.0.13-8-g41878ff4f2)
...
main interface debug: looking for interface module matching "telnet": 13
candidates
main interface debug: no interface modules matched
...
Do you think that it's possible to have a new executable of vlc
with the telnet interface available?
It can be done like this. I have no idea whether the maintainer
(cc'd) would like to do that or not though, it will add a bit of
extra work at port update time if the PLISTs need updating.
I don't mind adding it to the main package.
Index: Makefile
===
RCS file: /cvs/ports/x11/vlc/Makefile,v
retrieving revision 1.262
diff -u -p -r1.262 Makefile
--- Makefile24 Apr 2023 11:42:50 - 1.262
+++ Makefile26 Apr 2023 15:12:15 -
@@ -1,11 +1,13 @@
COMMENT-main= VideoLAN client; multimedia player
COMMENT-jack= JACK audio output module for VLC
+COMMENT-lua= Lua support for VLC, including telnet module
V= 3.0.18
DISTNAME= vlc-${V}
PKGNAME-main= ${DISTNAME}
PKGNAME-jack= vlc-jack-${V}
-REVISION-main= 1
+PKGNAME-lua= vlc-lua-${V}
+REVISION-main= 2
CATEGORIES= x11
MASTER_SITES= https://download.videolan.org/pub/videolan/vlc/${V}/
EXTRACT_SUFX= .tar.xz
@@ -49,6 +51,8 @@ WANTLIB-main+=v4l2
WANTLIB-jack= db execinfo jack vlccore ${WANTLIB-common}
+WANTLIB-lua= ${MODLUA_WANTLIB}
+
AUTOCONF_VERSION= 2.69
AUTOMAKE_VERSION= 1.16
AUTORECONF= ./bootstrap
@@ -101,6 +105,8 @@ LIB_DEPENDS-main= ${MODQT5_LIB_DEPENDS}
x11/gtk+3
LIB_DEPENDS-jack= ${BUILD_PKGPATH} \
audio/jack
+RUN_DEPENDS-lua= ${BUILD_PKGPATH}
+LIB_DEPENDS-lua= ${MODLUA_LIB_DEPENDS}
BUILD_DEPENDS=${MODGNU_AUTOCONF_DEPENDS} \
${MODGNU_AUTOMAKE_DEPENDS} \
archivers/gtar \
@@ -145,7 +151,6 @@ CONFIGURE_ARGS+=--disable-a52 \
--disable-libva \
--disable-linsys \
--disable-live555 \
- --disable-lua \
--disable-mad \
--disable-mfx \
--disable-microdns \
@@ -190,19 +195,27 @@ CONFIGURE_ENV+= BUILDCC="${CC}" \
PKG_CONFIG_PATH="${LOCALBASE}/lib/qt5/pkgconfig" \
RCC="${LOCALBASE}/bin/rcc-qt5"
-PSEUDO_FLAVORS= no_jack
+PSEUDO_FLAVORS=no_jack no_lua
FLAVOR?=
-MULTI_PACKAGES= -main
-
-.if !${FLAVOR:Mno_jack}
-MULTI_PACKAGES+=-jack
-.endif
+MULTI_PACKAGES=-main -jack -lua
.include
.if !${BUILD_PACKAGES:M-jack}
CONFIGURE_ARGS+=--disable-jack
+.endif
+
+.if !${BUILD_PACKAGES:M-lua}
+CONFIGURE_ARGS+= --disable-lua
+.else
+CONFIGURE_ENV+=LUAC="luac${MODLUA_DEP_VERSION}"
+MODULES+= lang/lua
+MODLUA_VERSION=5.2
+MODLUA_SA= Yes
+MODLUA_RUNDEP= No
+CONFIGURE_ARGS+= --enable-lua
+UPDATE_PLIST_ARGS+= -i MODLUA_DEP_VERSION
.endif
.if ${MACHINE_ARCH} == "amd64"
Index: patches/patch-configure_ac
===
RCS file: /cvs/ports/x11/vlc/patches/patch-configure_ac,v
retrieving revision 1.43
diff -u -p -r1.43 patch-configure_ac
--- patches/patch-configure_ac 25 Nov 2022 11:52:17 - 1.43
+++ patches/patch-configure_ac 26 Apr 2023 15:12:15 -
@@ -11,11 +11,10 @@ Index: configure.ac
;;
netbsd*)
SYS=netbsd
-@@ -1122,22 +1121,6 @@ AC_ARG_ENABLE(optimizations,
-
+@@ -1123,22 +1122,6 @@ AC_ARG_ENABLE(optimizations,
dnl Check for various optimization flags
AS_IF([test "${enable_optimizations}" != "no"], [
--
+
- dnl -O3 only in production builds
- AS_IF([test "${enable_debug}" = "no"], [
-VLC_SAVE_FLAGS
@@ -31,6 +30,16 @@ Index: configure.ac
-])
-AS_IF([test "${ac_cv_c_o3}" = "no"], [VLC_RESTORE_FLAGS])
- ])
-
+-
dnl Check for fast maths
AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
-fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CFLAGS])
+ AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
-fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CXXFLAGS])
+@@ -1664,7 +1647,7 @@ AC_ARG_ENABLE(lua,
+ [disable LUA scripting support (default enabled)])])
+ if test "${enable_lua}" != "no"
+ then
+- PKG_CHECK_MODULES(LUA, lua5.2,
++ PKG_CHECK_MODULES(LUA, lua52,
+ [ have_lua=yes ],
+ [
+ AC_MSG_WARN([${LUA_PKG_ERRORS}, trying lua 5.1 instead])
Index: pkg/DESCR-lua
===
RCS file: pkg/DESCR-lua
diff -N pkg/DESCR-lua
--- /dev/null 1 Jan 1970 00:00:00 -
+++ pkg/DESCR-lua 26 Apr 2023 15:1
Re: vlc no telnet interface
I would really appreciate it a lot.
Currently I'm setting vlc via the oldrc interface, which has a smaller
set of options than the telnet interface.
And I don't want to use Linux, PF is by far smarter than iptables.
I'm sorry but I can't help in compiling, I have poor knowledge on C.
Regards, thanks for your time
Il giorno mer 26 apr 2023 alle ore 17:15 Stuart Henderson <
s...@spacehopper.org> ha scritto:
> On 2023/04/25 09:55, Luca Di Gregorio wrote:
> > Hi, I see that vlc doesn't have the telnet interface:
> >
> > # vlc -vvv -I telnet
> > VLC media player 3.0.18 Vetinari (revision 3.0.13-8-g41878ff4f2)
> > ...
> > main interface debug: looking for interface module matching "telnet": 13
> >candidates
> > main interface debug: no interface modules matched
> > ...
> >
> > Do you think that it's possible to have a new executable of vlc
> > with the telnet interface available?
>
> It can be done like this. I have no idea whether the maintainer
> (cc'd) would like to do that or not though, it will add a bit of
> extra work at port update time if the PLISTs need updating.
>
> Index: Makefile
> ===
> RCS file: /cvs/ports/x11/vlc/Makefile,v
> retrieving revision 1.262
> diff -u -p -r1.262 Makefile
> --- Makefile24 Apr 2023 11:42:50 - 1.262
> +++ Makefile26 Apr 2023 15:12:15 -
> @@ -1,11 +1,13 @@
> COMMENT-main= VideoLAN client; multimedia player
> COMMENT-jack= JACK audio output module for VLC
> +COMMENT-lua= Lua support for VLC, including telnet module
>
> V= 3.0.18
> DISTNAME= vlc-${V}
> PKGNAME-main= ${DISTNAME}
> PKGNAME-jack= vlc-jack-${V}
> -REVISION-main= 1
> +PKGNAME-lua= vlc-lua-${V}
> +REVISION-main= 2
> CATEGORIES=x11
> MASTER_SITES= https://download.videolan.org/pub/videolan/vlc/${V}/
> EXTRACT_SUFX= .tar.xz
> @@ -49,6 +51,8 @@ WANTLIB-main+=v4l2
>
> WANTLIB-jack= db execinfo jack vlccore ${WANTLIB-common}
>
> +WANTLIB-lua= ${MODLUA_WANTLIB}
> +
> AUTOCONF_VERSION= 2.69
> AUTOMAKE_VERSION= 1.16
> AUTORECONF=./bootstrap
> @@ -101,6 +105,8 @@ LIB_DEPENDS-main= ${MODQT5_LIB_DEPENDS}
> x11/gtk+3
> LIB_DEPENDS-jack= ${BUILD_PKGPATH} \
> audio/jack
> +RUN_DEPENDS-lua= ${BUILD_PKGPATH}
> +LIB_DEPENDS-lua= ${MODLUA_LIB_DEPENDS}
> BUILD_DEPENDS= ${MODGNU_AUTOCONF_DEPENDS} \
> ${MODGNU_AUTOMAKE_DEPENDS} \
> archivers/gtar \
> @@ -145,7 +151,6 @@ CONFIGURE_ARGS+=--disable-a52 \
> --disable-libva \
> --disable-linsys \
> --disable-live555 \
> - --disable-lua \
> --disable-mad \
> --disable-mfx \
> --disable-microdns \
> @@ -190,19 +195,27 @@ CONFIGURE_ENV+= BUILDCC="${CC}" \
> PKG_CONFIG_PATH="${LOCALBASE}/lib/qt5/pkgconfig" \
> RCC="${LOCALBASE}/bin/rcc-qt5"
>
> -PSEUDO_FLAVORS=no_jack
> +PSEUDO_FLAVORS=no_jack no_lua
> FLAVOR?=
>
> -MULTI_PACKAGES=-main
> -
> -.if !${FLAVOR:Mno_jack}
> -MULTI_PACKAGES+=-jack
> -.endif
> +MULTI_PACKAGES=-main -jack -lua
>
> .include
>
> .if !${BUILD_PACKAGES:M-jack}
> CONFIGURE_ARGS+=--disable-jack
> +.endif
> +
> +.if !${BUILD_PACKAGES:M-lua}
> +CONFIGURE_ARGS+= --disable-lua
> +.else
> +CONFIGURE_ENV+=LUAC="luac${MODLUA_DEP_VERSION}"
> +MODULES+= lang/lua
> +MODLUA_VERSION=5.2
> +MODLUA_SA= Yes
> +MODLUA_RUNDEP= No
> +CONFIGURE_ARGS+= --enable-lua
> +UPDATE_PLIST_ARGS+= -i MODLUA_DEP_VERSION
> .endif
>
> .if ${MACHINE_ARCH} == "amd64"
> Index: patches/patch-configure_ac
> ===
> RCS file: /cvs/ports/x11/vlc/patches/patch-configure_ac,v
> retrieving revision 1.43
> diff -u -p -r1.43 patch-configure_ac
> --- patches/patch-configure_ac 25 Nov 2022 11:52:17 - 1.43
> +++ patches/patch-configure_ac 26 Apr 2023 15:12:15 -
> @@ -11,11 +11,10 @@ Index: configure.ac
> ;;
> netbsd*)
> SYS=netbsd
> -@@ -1122,22 +1121,6 @@ AC_ARG_ENABLE(optimizations,
> -
> +@@ -1123,22 +1122,6 @@ AC_ARG_ENABLE(optimizations,
> dnl Check for various optimization flags
> AS_IF([test "${enable_optimizations}" != "no"], [
> --
> +
> - dnl -O3 only in production builds
> - AS_IF([test "${enable_debug}" = "no"], [
> -VLC_SAVE_FLAGS
> @@ -31,6 +30,16 @@ Index: configure.ac
> -])
Re: vlc no telnet interface
On 2023/04/25 09:55, Luca Di Gregorio wrote:
> Hi, I see that vlc doesn't have the telnet interface:
>
> # vlc -vvv -I telnet
> VLC media player 3.0.18 Vetinari (revision 3.0.13-8-g41878ff4f2)
> ...
> main interface debug: looking for interface module matching "telnet": 13
>candidates
> main interface debug: no interface modules matched
> ...
>
> Do you think that it's possible to have a new executable of vlc
> with the telnet interface available?
It can be done like this. I have no idea whether the maintainer
(cc'd) would like to do that or not though, it will add a bit of
extra work at port update time if the PLISTs need updating.
Index: Makefile
===
RCS file: /cvs/ports/x11/vlc/Makefile,v
retrieving revision 1.262
diff -u -p -r1.262 Makefile
--- Makefile24 Apr 2023 11:42:50 - 1.262
+++ Makefile26 Apr 2023 15:12:15 -
@@ -1,11 +1,13 @@
COMMENT-main= VideoLAN client; multimedia player
COMMENT-jack= JACK audio output module for VLC
+COMMENT-lua= Lua support for VLC, including telnet module
V= 3.0.18
DISTNAME= vlc-${V}
PKGNAME-main= ${DISTNAME}
PKGNAME-jack= vlc-jack-${V}
-REVISION-main= 1
+PKGNAME-lua= vlc-lua-${V}
+REVISION-main= 2
CATEGORIES=x11
MASTER_SITES= https://download.videolan.org/pub/videolan/vlc/${V}/
EXTRACT_SUFX= .tar.xz
@@ -49,6 +51,8 @@ WANTLIB-main+=v4l2
WANTLIB-jack= db execinfo jack vlccore ${WANTLIB-common}
+WANTLIB-lua= ${MODLUA_WANTLIB}
+
AUTOCONF_VERSION= 2.69
AUTOMAKE_VERSION= 1.16
AUTORECONF=./bootstrap
@@ -101,6 +105,8 @@ LIB_DEPENDS-main= ${MODQT5_LIB_DEPENDS}
x11/gtk+3
LIB_DEPENDS-jack= ${BUILD_PKGPATH} \
audio/jack
+RUN_DEPENDS-lua= ${BUILD_PKGPATH}
+LIB_DEPENDS-lua= ${MODLUA_LIB_DEPENDS}
BUILD_DEPENDS= ${MODGNU_AUTOCONF_DEPENDS} \
${MODGNU_AUTOMAKE_DEPENDS} \
archivers/gtar \
@@ -145,7 +151,6 @@ CONFIGURE_ARGS+=--disable-a52 \
--disable-libva \
--disable-linsys \
--disable-live555 \
- --disable-lua \
--disable-mad \
--disable-mfx \
--disable-microdns \
@@ -190,19 +195,27 @@ CONFIGURE_ENV+= BUILDCC="${CC}" \
PKG_CONFIG_PATH="${LOCALBASE}/lib/qt5/pkgconfig" \
RCC="${LOCALBASE}/bin/rcc-qt5"
-PSEUDO_FLAVORS=no_jack
+PSEUDO_FLAVORS=no_jack no_lua
FLAVOR?=
-MULTI_PACKAGES=-main
-
-.if !${FLAVOR:Mno_jack}
-MULTI_PACKAGES+=-jack
-.endif
+MULTI_PACKAGES=-main -jack -lua
.include
.if !${BUILD_PACKAGES:M-jack}
CONFIGURE_ARGS+=--disable-jack
+.endif
+
+.if !${BUILD_PACKAGES:M-lua}
+CONFIGURE_ARGS+= --disable-lua
+.else
+CONFIGURE_ENV+=LUAC="luac${MODLUA_DEP_VERSION}"
+MODULES+= lang/lua
+MODLUA_VERSION=5.2
+MODLUA_SA= Yes
+MODLUA_RUNDEP= No
+CONFIGURE_ARGS+= --enable-lua
+UPDATE_PLIST_ARGS+= -i MODLUA_DEP_VERSION
.endif
.if ${MACHINE_ARCH} == "amd64"
Index: patches/patch-configure_ac
===
RCS file: /cvs/ports/x11/vlc/patches/patch-configure_ac,v
retrieving revision 1.43
diff -u -p -r1.43 patch-configure_ac
--- patches/patch-configure_ac 25 Nov 2022 11:52:17 - 1.43
+++ patches/patch-configure_ac 26 Apr 2023 15:12:15 -
@@ -11,11 +11,10 @@ Index: configure.ac
;;
netbsd*)
SYS=netbsd
-@@ -1122,22 +1121,6 @@ AC_ARG_ENABLE(optimizations,
-
+@@ -1123,22 +1122,6 @@ AC_ARG_ENABLE(optimizations,
dnl Check for various optimization flags
AS_IF([test "${enable_optimizations}" != "no"], [
--
+
- dnl -O3 only in production builds
- AS_IF([test "${enable_debug}" = "no"], [
-VLC_SAVE_FLAGS
@@ -31,6 +30,16 @@ Index: configure.ac
-])
-AS_IF([test "${ac_cv_c_o3}" = "no"], [VLC_RESTORE_FLAGS])
- ])
-
+-
dnl Check for fast maths
AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
-fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CFLAGS])
+ AX_APPEND_COMPILE_FLAGS([-fno-math-errno -funsafe-math-optimizations
-fno-rounding-math -fno-signaling-nans -fcx-limited-range], [CXXFLAGS])
+@@ -1664,7 +1647,7 @@ AC_ARG_ENABLE(lua,
+ [disable LUA scripting support (default enabled)])])
+ if test "${enable_lua}" != "no"
+ then
+- PKG_CHECK_MODULES(LUA, lua5.2,
++ PKG_CHECK_MODULES(LUA, lua52,
+ [ have_lua=yes ],
+ [
+ AC_MSG_WARN([${LUA_PKG_ERRORS}, trying lua 5.1 instead])
Index: pkg/DESCR-lua
===
RCS file: pkg/DESCR-lua
diff -N pkg/DESCR-lua
--- /dev/null 1 Jan 1970 00:00:00 -
+++ pkg/DESCR-lua 26 Apr 2023 15:12:15 -
@@ -0,0 +1,2 @@
+Lua support for VLC. Fun
vlc no telnet interface
Hi, I see that vlc doesn't have the telnet interface: # vlc -vvv -I telnet VLC media player 3.0.18 Vetinari (revision 3.0.13-8-g41878ff4f2) ... main interface debug: looking for interface module matching "telnet": 13 candidates main interface debug: no interface modules matched ... Do you think that it's possible to have a new executable of vlc with the telnet interface available?
