Re: www/ezpublish update to 4.4.0

2010-12-06 Thread Stuart Henderson 
On 2010/12/06 08:19, Felix Kronlage wrote:
 Hi!
 
 anyone using ezpublish? Attached to this mail
 is an update to 4.4.0.
 Any feedback much appreciated.

I'm not using it, but I noticed a few of these in your plist:

 @@ -263,6 +265,11 @@
  ezpublish/design/admin/templates/content/collectedinfo/poll.tpl
  ezpublish/design/admin/templates/content/confirmtranslationremove.tpl
  ezpublish/design/admin/templates/content/create_languages.tpl
 +...@mode
 +...@group
 +ezpublish/design/admin/templates/content/dashboard.tpl
 +...@mode g+w
 +...@group www
  ezpublish/design/admin/templates/content/diff.tpl
  ezpublish/design/admin/templates/content/draft.tpl
  ezpublish/design/admin/templates/content/edit.tpl

So the new tpl files (dashboard, page_head_script, page_head_style,
etc in design/admin, and a whole load of new files in design/admin2)
aren't writable by the webserver whereas other files are. I haven't
looked to see whether it makes sense for these to be writable,
but it doesn't look like they should be any different to the other
files in the directory.

I'd suggest maybe doing a chown/chmod -R in the do-install stage,
that way you can just use @owner/@group/@mode in the PLIST for
exceptions, which generally makes it easier to update things in the
future (then you generally won't need to tweak the output from
make plist).

Re: www/ezpublish update to 4.4.0

2010-12-06 Thread Felix Kronlage 
On Mon, Dec 06, 2010 at 12:13:17PM +, Stuart Henderson wrote:

Hi,

 So the new tpl files (dashboard, page_head_script, page_head_style,
 etc in design/admin, and a whole load of new files in design/admin2)
 aren't writable by the webserver whereas other files are. I haven't
 looked to see whether it makes sense for these to be writable,
 but it doesn't look like they should be any different to the other
 files in the directory.

ack. Jasper also mailed me a hint regarding this.

 I'd suggest maybe doing a chown/chmod -R in the do-install stage,
 that way you can just use @owner/@group/@mode in the PLIST for
 exceptions, which generally makes it easier to update things in the
 future (then you generally won't need to tweak the output from
 make plist).

yeah, that makes sense. I will resend the diff this afternoon.

thanks for the feedback,

felix