Re: [Potlatch-dev] [OpenStreetMap] #4137: Support tram, train, etc routes in simple editor

2012-02-16 Thread OpenStreetMap
#4137: Support tram, train, etc routes in simple editor
--+-
  Reporter:  stevage  |   Owner:  potlatch-dev@…
  Type:  enhancement  |  Status:  closed
  Priority:  minor|   Milestone:
 Component:  potlatch2| Version:
Resolution:  fixed|Keywords:
--+-
Changes (by stevage):

  * status:  new = closed
  * resolution:  = fixed


Comment:

 Train routes here:

 
https://github.com/stevage/potlatch2/commit/7993b5cfe128df624c61abd53e509585b39e8ffe

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/4137#comment:2
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Github, and tram/road issues

2012-02-16 Thread Andy Allan
 On 16 February 2012 06:03, Steve Bennett stevag...@gmail.com wrote:
 Hi all,
  I just did a pull request to the Github repository (which is fairly

You just made a pull request to a read-only mirror.

 up to date) but it looks like no one is watching. Is there somewhere
 else these pull requests should go? It's here anyway:

http://wiki.openstreetmap.org/wiki/Potlatch_2/Developer_Documentation#Sending_patches

We like patches in any way, but if you're sending a pull request,
please send it to systemed on github ([1]) aka Richard, rather than
git.openstreetmap.org or the openstreetmap  account on github.
Thanks.

Cheers,
Andy

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


[Potlatch-dev] [OpenStreetMap] #4225: Undoing way leaves one node behind

2012-02-16 Thread OpenStreetMap
#4225: Undoing way leaves one node behind
---+
 Reporter:  stevage|   Owner:  potlatch-dev@…
 Type:  defect |  Status:  new   
 Priority:  minor  |   Milestone:
Component:  potlatch2  | Version:
 Keywords: |  
---+
 1. Draw a new, closed way.
 2. Undo it all
 3. The start/end node remains behind.

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/4225
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #4133: P2 'simple view' not show tags for node features in T-junctions

2012-02-16 Thread OpenStreetMap
#4133: P2 'simple view' not show tags for node features in T-junctions
+---
 Reporter:  Harry Wood  |   Owner:  potlatch-dev@…
 Type:  defect  |  Status:  new   
 Priority:  minor   |   Milestone:
Component:  potlatch2   | Version:
 Keywords:  |  
+---

Comment(by stevage):

 It's a limitation of the way turn restrictions are implemented: a turn
 restriction (or if you prefer, a junction node) is a type of entity,
 rather than being an inputset. So once the junction node has matched,
 there is no more matching: it can't also be a bollard.

 This is a specific case of the general problem with feature matching being
 exclusive. There are a few solutions, none particularly simple:

 1. Show multiple simple editors
 2. Show one, combined simple editor (conceptually easy in this case, not
 always so).
 3. Show a simple editor and an advanced editor.
 ...

 Specific cases like this one actually could be worked around, by creating
 hybrid bollard with turn restriction features, and making sure they get
 matched before either bollard or plain turn restriction. Probably not
 worth it yet.

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/4133#comment:2
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] [OpenStreetMap] #4192: Power line voltage preset typo

2012-02-16 Thread OpenStreetMap
#4192: Power line voltage preset typo
+---
  Reporter:  dcat   |   Owner:  potlatch-dev@…
  Type:  defect |  Status:  closed
  Priority:  trivial|   Milestone:
 Component:  potlatch2  | Version:
Resolution:  fixed  |Keywords:
+---
Changes (by stevage):

  * status:  new = closed
  * resolution:  = fixed


Comment:

 Fixed in
 
https://github.com/stevage/potlatch2/commit/da1afa9ae79e5475771fb8341fb886ce39abb7b6

-- 
Ticket URL: https://trac.openstreetmap.org/ticket/4192#comment:1
OpenStreetMap http://www.openstreetmap.org/
OpenStreetMap is a free editable map of the whole world

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev


Re: [Potlatch-dev] Github, and tram/road issues

2012-02-16 Thread Steve Bennett
On Thu, Feb 16, 2012 at 8:11 PM, Andy Allan gravityst...@gmail.com wrote:
 http://wiki.openstreetmap.org/wiki/Potlatch_2/Developer_Documentation#Sending_patches

 We like patches in any way, but if you're sending a pull request,
 please send it to systemed on github ([1]) aka Richard, rather than
 git.openstreetmap.org or the openstreetmap account on github. Thanks.
 

Thanks, I did eventually stumble upon this.

Are there any policies/practice around using feature branches? I'm not
sure if it's a Github limitation (or standard Git), but it seems one
doesn't actually send individual pull requests - at any one time,
you can have a grand total of 1 pull request outstanding. If I'm
working on a bug fix for bug #1234, is it easier if I make a branch
(eg, bug-1234) first? Does that help anything?

Steve

___
Potlatch-dev mailing list
Potlatch-dev@openstreetmap.org
http://lists.openstreetmap.org/listinfo/potlatch-dev