Re: [prometheus-developers] Making Augustin Husson a maintainer for the PromQL editor support code in the Prometheus repo

[Richard Hartmann]

SGTM.

Sent by mobile; please excuse my brevity.

On Wed, Aug 11, 2021, 11:29 Julius Volz  wrote:

> Hi,
>
> Since we are moving the PromQL editor support module (
> https://github.com/prometheus-community/codemirror-promql) into the main
> Prometheus server repo (https://github.com/prometheus/prometheus) as part
> of https://github.com/prometheus/prometheus/pull/9188, I am proposing to
> make Augustin Husson a maintainer for that part of the code in the main
> Prometheus repo. Augustin has maintained the PromQL editor support in the
> external repo so far, but isn't a Prometheus Team member yet.
>
> Since https://prometheus.io/governance/#maintainers requires only lazy
> consensus for this, I assume that this is fine unless someone objects.
>
> Regards,
> Julius
>
> --
> Julius Volz
> PromLabs - promlabs.com
>
> --
> You received this message because you are subscribed to the Google Groups
> "Prometheus Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to prometheus-developers+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/prometheus-developers/CAObpH5xxRyQju72VL0s4_SJN-QM2dLrj1Bd7JX9NNPHW0B8m4w%40mail.gmail.com
> 
> .
>

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CAD77%2BgRR_fLmgoKT2x7UJptvsR01ig15nzFEzz-gu1a8zrQE0A%40mail.gmail.com.

[prometheus-developers] Making Augustin Husson a maintainer for the PromQL editor support code in the Prometheus repo

[Julius Volz]

Hi,

Since we are moving the PromQL editor support module (
https://github.com/prometheus-community/codemirror-promql) into the main
Prometheus server repo (https://github.com/prometheus/prometheus) as part
of https://github.com/prometheus/prometheus/pull/9188, I am proposing to
make Augustin Husson a maintainer for that part of the code in the main
Prometheus repo. Augustin has maintained the PromQL editor support in the
external repo so far, but isn't a Prometheus Team member yet.

Since https://prometheus.io/governance/#maintainers requires only lazy
consensus for this, I assume that this is fine unless someone objects.

Regards,
Julius

-- 
Julius Volz
PromLabs - promlabs.com

-- 
You received this message because you are subscribed to the Google Groups 
"Prometheus Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to prometheus-developers+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/prometheus-developers/CAObpH5xxRyQju72VL0s4_SJN-QM2dLrj1Bd7JX9NNPHW0B8m4w%40mail.gmail.com.

Re: [prometheus-developers] Moving the PromQL editor to prometheus/prometheus

[Augustin Husson]

Cool thanks :).

I started with this PR: https://github.com/prometheus/prometheus/pull/9188

By the way, do you think the repository prometheus-community/codemirror
should move to the org prometheus ?

Le mar. 10 août 2021 à 19:27, Julien Pivotto  a
écrit :

> On 10 Aug 18:51, Augustin Husson wrote:
> > Is it ok for you too Julien ?
> >
> > If yes, is it ok if I'm doing some PRs to proceed ?
>
> Yes :)
>
>
> >
> > Le mar. 10 août 2021 à 16:31, Julius Volz  a
> > écrit :
> >
> > > I would be fine with that as well, yeah. It's more overall complexity
> > > having to sync things, but then at least that extra complexity doesn't
> > > concern the main Prometheus repo :)
> > >
> > > On Tue, Aug 10, 2021 at 3:10 PM Augustin Husson <
> husson.augus...@gmail.com>
> > > wrote:
> > >
> > >> Oh yeah, I like this idea ! Thanks Rob :).
> > >>
> > >> I think that would cover all concerns raised for the moment, right
> Julien
> > >> and Julius ?
> > >>
> > >> I forgot to mention it, but yes of course Julien the prometheus web ui
> > >> will use the local version of the codemirror-promql and won't use the
> npm
> > >> package.
> > >>
> > >> Le mar. 10 août 2021 à 14:32, Rob Skillington  a
> > >> écrit :
> > >>
> > >>> You could also follow the Kubernetes model where subdirectories of
> the
> > >>> repository is mirrored to a second repository (either by CI or some
> other
> > >>> infrastructure) and there the code is tagged.
> > >>>
> > >>> That way you still have a monorepo of all the code and can make
> single
> > >>> changes across layers, but the releasing and other versioning aspect
> is
> > >>> done in a separate repo (and potentially handling issues, etc too).
> > >>>
> > >>> This is how the k8s client is released separately even though the
> code
> > >>> lives in the main k8s central repo alongside k8s API server,
> kubelet, etc.
> > >>>
> > >>> Rob
> > >>>
> > >>> On Tue, Aug 10, 2021 at 8:17 AM Augustin Husson <
> > >>> husson.augus...@gmail.com> wrote:
> > >>>
> >  From my point of view, to have a different tag wasn't because I
> didn't
> >  want to wait for a Prometheus release.
> > 
> >  In fact, currently these repositories are for the moment quite in a
> >  maintenance mode. It just follows the changes of PromQL basically.
> So it's
> >  quite fine to wait for the Prometheus release to unleash any
> bugfixes /
> >  features.
> > 
> >  On my side, my concern regarding following the tag version of
> >  Prometheus is more we will release the npm package quite often with
> no
> >  changes. That's something weird to release a library with no
> changes.
> > 
> >  It is still interesting to create UI module to be able to share code
> >  between Thanos and Prometheus (I have made a proposal in this sense
> >  here
> >  <
> https://github.com/thanos-io/thanos/issues/3142#issuecomment-87284>,
> >  which I think can be improved), but in that particular case, I
> think the
> >  changes will appear quite often and it will be one npm package that
> would
> >  contain all Prometheus module. ( a bit like angular is doing for
> example).
> >  So in that particular case, it makes sense to follow the tag of
> Prometheus.
> > 
> >  In this perspective, I could imagine that the PromQL editor is
> actually
> >  a Prometheus module, but then it will be a different npm package. I
> could
> >  leave with that, as long as it won't be the unique UI module.
> > 
> >  Another idea would be to release the npm package during the release
> >  process of Prometheus, but the version won't follow the tag, it
> will follow
> >  what is written in the npm package. So if the version didn't change
> between
> >  2 Prometheus versions, then it won't release the npm package.
> >  Like that we don't have extra git tag, we don't release any extra
> >  version with no changes.
> >  WDYT about this last proposition ?
> > 
> >  Le mar. 10 août 2021 à 13:29, Julien Pivotto <
> roidelapl...@inuits.eu>
> >  a écrit :
> > 
> > > Hello,
> > >
> > > I like the idea to combine them in one repository.
> > >
> > > I would rather see if we can use it "unversioned" inside
> > > prometheus/prometheus and release it together with the Prometheus
> > > releases for the outside world.
> > >
> > > My concerns are:
> > >
> > > - It would add an extra burden to release management if we add
> extra
> > > steps or
> > >   more packages
> > > - I expect that some people actually build Prometheus from the
> tags and
> > >   adding extra tags could break quite a few workloads. I do not
> think
> > >   that building tags is a xkcd 1172 case https://xkcd.com/1172/
> > >
> > > Additionally, there has been interests in the past to have even
> more
> > > UI modules available, e.g. for thanos.
> > >
> > > I know that it would be quite inconvenient to