[protobuf] Re: Issue 196 in protobuf: Python: Ascii output is not assured to be in utf-8

2010-12-14 Thread protobuf

Updates:
Status: Fixed
Labels: FixedIn-2.4.0

Comment #5 on issue 196 by ken...@google.com: Python: Ascii output is not  
assured to be in utf-8

http://code.google.com/p/protobuf/issues/detail?id=196

Cool, it sounds like it is indeed fixed.

--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To post to this group, send email to proto...@googlegroups.com.
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en.



[protobuf] Re: Issue 196 in protobuf: Python: Ascii output is not assured to be in utf-8

2010-12-08 Thread protobuf


Comment #4 on issue 196 by liuj...@google.com: Python: Ascii output is not  
assured to be in utf-8

http://code.google.com/p/protobuf/issues/detail?id=196

I see, this was actually fixed by another CL that always encodes unicode  
string field to utf8 to fix this bug in our internal branch(s/14267948).
testRoundTripExoticAsOneLine() already covered the as_utf8=False round trip  
case, so I'll add another testcase to test as_utf8=True.


--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To post to this group, send email to proto...@googlegroups.com.
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en.



[protobuf] Re: Issue 196 in protobuf: Python: Ascii output is not assured to be in utf-8

2010-12-07 Thread protobuf

Updates:
Status: Accepted
Labels: -FixedIn-2.4.0

Comment #3 on issue 196 by ken...@google.com: Python: Ascii output is not  
assured to be in utf-8

http://code.google.com/p/protobuf/issues/detail?id=196

Jisi, I'm not convinced that this is fixed.  The as_utf parameter simply  
prevents the printer from escaping character codes = 128.  The bug report  
seems like it may actually be a problem in the parser.  Also, round trips  
should work correctly even if as_utf is not used.  We should investigate  
further, and make sure we have test cases that print and then parse a  
message containing Unicode characters, both with and without as_utf enabled.


--
You received this message because you are subscribed to the Google Groups Protocol 
Buffers group.
To post to this group, send email to proto...@googlegroups.com.
To unsubscribe from this group, send email to 
protobuf+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/protobuf?hl=en.