[protobuf] Re: Issue 678 in protobuf: HasExtension() called on a repeated field should cause a compile error (Protobuf 2.4.1)

2014-11-06 Thread protobuf


Comment #3 on issue 678 by kaspar.f...@dreizak.com: HasExtension() called  
on a repeated field should cause a compile error (Protobuf 2.4.1)

https://code.google.com/p/protobuf/issues/detail?id=678

That makes sense – and is consistent with the other uses of "has" in the  
API. Thanks for the response.


--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups "Protocol 
Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] Re: Issue 678 in protobuf: HasExtension() called on a repeated field should cause a compile error (Protobuf 2.4.1)

2014-11-06 Thread protobuf

Updates:
	Summary: HasExtension() called on a repeated field should cause a compile  
error (Protobuf 2.4.1)

Owner: xiaof...@google.com

Comment #2 on issue 678 by xiaof...@google.com: HasExtension() called on a  
repeated field should cause a compile error (Protobuf 2.4.1)

https://code.google.com/p/protobuf/issues/detail?id=678

HasExtension() is for optional fields and cannot be used upon a repeated  
field. Likewise ExtensionSize() can be used against a repeated field only.  
In your example, the line that currently is failing should really cause a  
compile error. we actually already has a DCHECK to prevent this kind of  
user error but seems it's not triggered:

https://github.com/google/protobuf/blob/master/src/google/protobuf/extension_set.cc#L194

--
You received this message because this project is configured to send all  
issue notifications to this address.

You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
You received this message because you are subscribed to the Google Groups "Protocol 
Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at http://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.