Re: [protobuf] file import via another import

2017-01-13 Thread 'Feng Xiao' via Protocol Buffers
On Fri, Jan 13, 2017 at 4:17 PM, Arpit Baldeva  wrote:

> Hi,
>
> It seems like the import directive in a proto file does not import the
> import dependencies of the file being imported. Easier to explain by
> example here.
>
> Say you have 3 files - a.proto, b.proto, c.proto
>
> If b.proto imports a.proto and c.proto imports b.proto, c.proto does not
> automatically import a.proto. Importing a.proto needs to be explicit.
>
> Is there a reason for not supporting automatic import?
>
It's supported but need to be explicit. Instead of:

import "a.proto";

do:

import public "a.proto";

This is recommended only when refactoring proto files. In general you
should use the regular import statement and stick with the IWYU
 practice.

>
> Thanks.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Protocol Buffers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to protobuf+unsubscr...@googlegroups.com.
> To post to this group, send email to protobuf@googlegroups.com.
> Visit this group at https://groups.google.com/group/protobuf.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at https://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.


[protobuf] file import via another import

2017-01-13 Thread Arpit Baldeva
Hi,

It seems like the import directive in a proto file does not import the 
import dependencies of the file being imported. Easier to explain by 
example here.

Say you have 3 files - a.proto, b.proto, c.proto

If b.proto imports a.proto and c.proto imports b.proto, c.proto does not 
automatically import a.proto. Importing a.proto needs to be explicit. 

Is there a reason for not supporting automatic import?

Thanks. 

-- 
You received this message because you are subscribed to the Google Groups 
"Protocol Buffers" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to protobuf+unsubscr...@googlegroups.com.
To post to this group, send email to protobuf@googlegroups.com.
Visit this group at https://groups.google.com/group/protobuf.
For more options, visit https://groups.google.com/d/optout.