[protobuf] Issue 180 in protobuf: Compiler warning for negating a uint64 in compiler/parser.cc:723
Status: New Owner: ken...@google.com Labels: Type-Defect Priority-Medium New issue 180 by jam...@chromium.org: Compiler warning for negating a uint64 in compiler/parser.cc:723 http://code.google.com/p/protobuf/issues/detail?id=180 http://code.google.com/p/protobuf/source/browse/trunk/src/google/protobuf/co mpiler/parser.cc#723 is: uninterpreted_option-set_negative_int_value(-value); where 'value' is of type uint64. Visual Studio 2008 generates a compiler warning for this since the negation is a no-op. Looking at the implementation of set_negative_int_value() I think the '-' is unneeded anyway. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 180 in protobuf: Compiler warning for negating a uint64 in compiler/parser.cc:723
Comment #1 on issue 180 by jam...@chromium.org: Compiler warning for negating a uint64 in compiler/parser.cc:723 http://code.google.com/p/protobuf/issues/detail?id=180 Simple patch (cast to int64 before negating). Passes 'make check' Attachments: patch.diff 652 bytes -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
[protobuf] Re: Issue 180 in protobuf: Compiler warning for negating a uint64 in compiler/parser.cc:723
Comment #2 on issue 180 by jam...@chromium.org: Compiler warning for negating a uint64 in compiler/parser.cc:723 http://code.google.com/p/protobuf/issues/detail?id=180 Patch in rietveld form (I accidentally uploaded it to the Chromium rietveld instance instead of the normal one, but it shouldn't matter too much): http://codereview.chromium.org/1728008/ -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- You received this message because you are subscribed to the Google Groups Protocol Buffers group. To post to this group, send email to proto...@googlegroups.com. To unsubscribe from this group, send email to protobuf+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/protobuf?hl=en.
