[jira] [Resolved] (PROTON-19) Dynamic language bindings forbid context from being null for connectors and listeners.
[ https://issues.apache.org/jira/browse/PROTON-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming resolved PROTON-19. --- Resolution: Fixed Applied the patch. > Dynamic language bindings forbid context from being null for connectors and > listeners. > -- > > Key: PROTON-19 > URL: https://issues.apache.org/jira/browse/PROTON-19 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Reporter: Darryl L. Pierce >Assignee: Darryl L. Pierce >Priority: Blocker > Attachments: > 0001-Removes-the-not-null-restriction-on-contexts-for-lis.patch > > > The swig contracts currently forbid setting the context for either a > connector or a listener to null, even though such states are allowed. This > patch fixes that, removing the restriction. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-18) Add application context field to pn_connection_t
[ https://issues.apache.org/jira/browse/PROTON-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming resolved PROTON-18. --- Resolution: Fixed > Add application context field to pn_connection_t > > > Key: PROTON-18 > URL: https://issues.apache.org/jira/browse/PROTON-18 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Ted Ross >Assignee: Rafael H. Schloming > Attachments: PROTON-18.patch > > > pn_connection_t needs an application context field. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-18) Add application context field to pn_connection_t
[ https://issues.apache.org/jira/browse/PROTON-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming reassigned PROTON-18: - Assignee: Rafael H. Schloming > Add application context field to pn_connection_t > > > Key: PROTON-18 > URL: https://issues.apache.org/jira/browse/PROTON-18 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Ted Ross >Assignee: Rafael H. Schloming > Attachments: PROTON-18.patch > > > pn_connection_t needs an application context field. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-18) Add application context field to pn_connection_t
[ https://issues.apache.org/jira/browse/PROTON-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450933#comment-13450933 ] Rafael H. Schloming commented on PROTON-18: --- I committed a slightly modified version of this patch. I had to preserve pn_endpoint_t as the first field in the struct because the implementation needs to be able to cast pn_connection_t to pn_endpoint_t. > Add application context field to pn_connection_t > > > Key: PROTON-18 > URL: https://issues.apache.org/jira/browse/PROTON-18 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Ted Ross > Attachments: PROTON-18.patch > > > pn_connection_t needs an application context field. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-18) Add application context field to pn_connection_t
[ https://issues.apache.org/jira/browse/PROTON-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450845#comment-13450845 ] Ted Ross commented on PROTON-18: Patch attached. Note that I added only set/get methods for the context. There's no context in the constructor function. Whether that is appropriate is a topic for debate. It would be a change to the API. > Add application context field to pn_connection_t > > > Key: PROTON-18 > URL: https://issues.apache.org/jira/browse/PROTON-18 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Ted Ross > Attachments: PROTON-18.patch > > > pn_connection_t needs an application context field. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-19) Dynamic language bindings forbid context from being null for connectors and listeners.
[ https://issues.apache.org/jira/browse/PROTON-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated PROTON-19: --- Attachment: 0001-Removes-the-not-null-restriction-on-contexts-for-lis.patch > Dynamic language bindings forbid context from being null for connectors and > listeners. > -- > > Key: PROTON-19 > URL: https://issues.apache.org/jira/browse/PROTON-19 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Reporter: Darryl L. Pierce >Assignee: Darryl L. Pierce >Priority: Blocker > Attachments: > 0001-Removes-the-not-null-restriction-on-contexts-for-lis.patch > > > The swig contracts currently forbid setting the context for either a > connector or a listener to null, even though such states are allowed. This > patch fixes that, removing the restriction. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-19) Dynamic language bindings forbid context from being null for connectors and listeners.
Darryl L. Pierce created PROTON-19: -- Summary: Dynamic language bindings forbid context from being null for connectors and listeners. Key: PROTON-19 URL: https://issues.apache.org/jira/browse/PROTON-19 Project: Qpid Proton Issue Type: Bug Components: proton-c Reporter: Darryl L. Pierce Assignee: Darryl L. Pierce Priority: Blocker The swig contracts currently forbid setting the context for either a connector or a listener to null, even though such states are allowed. This patch fixes that, removing the restriction. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-18) Add application context field to pn_connection_t
[ https://issues.apache.org/jira/browse/PROTON-18?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Ross updated PROTON-18: --- Attachment: PROTON-18.patch > Add application context field to pn_connection_t > > > Key: PROTON-18 > URL: https://issues.apache.org/jira/browse/PROTON-18 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Ted Ross > Attachments: PROTON-18.patch > > > pn_connection_t needs an application context field. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-18) Add application context field to pn_connection_t
Ted Ross created PROTON-18: -- Summary: Add application context field to pn_connection_t Key: PROTON-18 URL: https://issues.apache.org/jira/browse/PROTON-18 Project: Qpid Proton Issue Type: Improvement Components: proton-c Reporter: Ted Ross pn_connection_t needs an application context field. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: driver/transport/sasl refactor
As of last night this is on trunk. --Rafael On Thu, Sep 6, 2012 at 4:11 PM, Ken Giusti wrote: > Good improvement. > Once it's on trunk I'll refactor the ssl branch to move the ssl i/o into > the transport, as per the intent. > > -K > > - Original Message - > > On Tue, Sep 4, 2012 at 5:53 PM, Rajith Attapattu > > wrote: > > > > > I'm trying to figure out what changes are needed on the Java side. > > > It seems the bind method will be of interest. > > > > > > Rafi, could you also explain how the refactor is going to help with > > > SSL ? > > > > > > > Sure, the idea is to integrate the SSL implementation into the > > transport > > object similarly to the way SASL is integrated in the patch. This way > > it is > > separated from the driver, and porting of the driver won't conflict > > with > > the SSL implementation, i.e. cliff's windows port and ken's ssl > > branch > > won't tread on each other's toes. > > > > --Rafael > > >
Re: pn_message_load with nil data
This should work now with the possibly slightly unintuitive caveat that when you load None/null/nil into a text message and then save it, you get back an empty string. --Rafael On Wed, Sep 5, 2012 at 8:02 AM, Darryl L. Pierce wrote: > Should attempting to load a message with nil data raise an exception or > result in an empty string as the message data? The message format is > TEXT, and currently what I see is the content of the message contains > random data. > > -- > Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. > Delivering value year after year. > Red Hat ranks #1 in value among software vendors. > http://www.redhat.com/promo/vendor/ > >
[jira] [Updated] (PROTON-15) Remove get/set Prev/Next methods from EndpointImpl.java as they seem redundant/unused
[ https://issues.apache.org/jira/browse/PROTON-15?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming updated PROTON-15: -- Component/s: proton-j > Remove get/set Prev/Next methods from EndpointImpl.java as they seem > redundant/unused > - > > Key: PROTON-15 > URL: https://issues.apache.org/jira/browse/PROTON-15 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Reporter: Rajith Attapattu >Priority: Minor > > _next and _prev fields handled by the above methods does not seem to be > set/used properly causing errors in other parts of the code. > After further investigation it appears the _transportPrev and _transportNext > fields are the correct fields to use. > The issues that was caused by the above are fixed when switched to the > methods that use _transportPrev/Next -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PROTON-16) addTransportWork and addWork methods in ConnectionImpl.java could cause an infinite loop
[ https://issues.apache.org/jira/browse/PROTON-16?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming updated PROTON-16: -- Component/s: proton-j > addTransportWork and addWork methods in ConnectionImpl.java could cause an > infinite loop > > > Key: PROTON-16 > URL: https://issues.apache.org/jira/browse/PROTON-16 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Reporter: Rajith Attapattu > > When adding a head or tail with non null pointers for next and previous the > resulting link list will loop infinitely. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-6) Missing const on functions returning char*
[ https://issues.apache.org/jira/browse/PROTON-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming resolved PROTON-6. -- Resolution: Fixed > Missing const on functions returning char* > -- > > Key: PROTON-6 > URL: https://issues.apache.org/jira/browse/PROTON-6 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Reporter: Ted Ross >Assignee: Rafael H. Schloming >Priority: Minor > > in engine.h, the following API functions return char* without "const": > pn_remote_source > pn_remote_target -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (PROTON-6) Missing const on functions returning char*
[ https://issues.apache.org/jira/browse/PROTON-6?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming reassigned PROTON-6: Assignee: Rafael H. Schloming > Missing const on functions returning char* > -- > > Key: PROTON-6 > URL: https://issues.apache.org/jira/browse/PROTON-6 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Reporter: Ted Ross >Assignee: Rafael H. Schloming >Priority: Minor > > in engine.h, the following API functions return char* without "const": > pn_remote_source > pn_remote_target -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-12) Delivery structure uses malloc/free for every delivery (delivery tag)
[ https://issues.apache.org/jira/browse/PROTON-12?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming resolved PROTON-12. --- Resolution: Fixed > Delivery structure uses malloc/free for every delivery (delivery tag) > - > > Key: PROTON-12 > URL: https://issues.apache.org/jira/browse/PROTON-12 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Reporter: Ted Ross >Assignee: Rafael H. Schloming >Priority: Minor > > The implementation of the pn_delivery_t structure uses malloc/free for the > delivery tag resulting in heap access per-delivery. It would be desirable to > use in-structure memory for delivery tags, even if only for tags below a > certain length, to avoid the cost of frequent heap usage. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
