[jira] [Updated] (PROTON-61) Need a means of specifying and reading connection capabilities properties

2013-02-14 Thread Rob Godfrey (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey updated PROTON-61:
--

Assignee: Rafael H. Schloming  (was: Rob Godfrey)

 Need a means of specifying and reading connection capabilities  properties
 ---

 Key: PROTON-61
 URL: https://issues.apache.org/jira/browse/PROTON-61
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c, proton-j
Reporter: Gordon Sim
Assignee: Rafael H. Schloming
  Labels: api
 Fix For: 0.4


 The properties are very useful for providing details about a client 
 connection for management purposes (pid, process name, client library version 
 etc).
 The capabilities are needed to turn on optional functionality (e.g. filters).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


proton interop tests failed on Jenkins

2013-02-14 Thread Phil Harvey
I notice that the proton-jni Jenkins job has failed:

https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-jni/25/

The commit that broke this build was probably this one for PROTON-215, by
aconway:

PROTON-215: Add tests to verify AMQP type support for python bindings.

http://svn.apache.org/viewvc?view=revisionrevision=1445920

Any volunteers to look into this?


Phil


[jira] [Commented] (PROTON-235) SASL layer can replicate inbound SASL frames under some circumstances.

2013-02-14 Thread Ken Giusti (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578553#comment-13578553
 ] 

Ken Giusti commented on PROTON-235:
---

Link to related Review Board post:

https://reviews.apache.org/r/9447/

 SASL layer can replicate inbound SASL frames under some circumstances.
 

 Key: PROTON-235
 URL: https://issues.apache.org/jira/browse/PROTON-235
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Affects Versions: 0.3
Reporter: Ken Giusti
Assignee: Ken Giusti
 Fix For: 0.4


 If an inbound SASL frame is fragmented, then the SASL layer incorrectly 
 re-reads the same frame data.  This causes the engine to fail.
 Reproducer:
   def testFracturedSASL(self):
 self.s1.mechanisms(ANONYMOUS)
 self.s1.client()
 self.t1.trace(Transport.TRACE_FRM)
 out = self.t1.output(1024)
 print(out=%s % str(out))
 self.t1.input(AMQP\x03\x01\x00\x00)
 out = self.t1.output(1024)
 print(out=%s % str(out))
 self.t1.input(\x00\x00\x00)
 out = self.t1.output(1024)
 print(out=%s % str(out))
 
 self.t1.input(A\x02\x01\x00\x00\x00S@\xc04\x01\xe01\x06\xa3\x06GSSAPI\x05PLAIN\x0aDIGEST-MD5\x08AMQPLAIN\x08CRAM-MD5\x04NTLM)
 out = self.t1.output(1024)
 print(out=%s % str(out))
 self.t1.input(\x00\x00\x00\x10\x02\x01\x00\x00\x00SD\xc0\x03\x01P\x00)
 out = self.t1.output(1024)
 while out:
   print(out=%s % str(out))
   out = self.t1.output(1024)
 When tracing is turned on, SASL will report the following frames as received:
 - SASL
 [0x200f0e0:0] - SASL-MECHANISMS @64 [@PN_SYMBOL[:GSSAPI, :PLAIN, 
 :DIGEST-MD5, :AMQPLAIN, :CRAM-MD5, :NTLM]]
 [0x200f0e0:0] - SASL-MECHANISMS @64 [@PN_SYMBOL[:GSSAPI, :PLAIN, 
 :DIGEST-MD5, :AMQPLAIN, :CRAM-MD5, :NTLM]]
 Notice the MECHANISM frame is reported as received twice by the SASL layer, 
 but it was only read once from the network.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


[jira] [Commented] (PROTON-238) Initial CTest support

2013-02-14 Thread Mary hinton (JIRA)

[ 
https://issues.apache.org/jira/browse/PROTON-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13578572#comment-13578572
 ] 

Mary hinton commented on PROTON-238:


This will be a nice feature.

Visual Studio doesn't use make. I think we could substitute the devenv (IDE) 
command line for make.
e.g.
devenv proton.sln /Build Debug

That might help automate it for Visual Studio.

 Initial CTest support
 -

 Key: PROTON-238
 URL: https://issues.apache.org/jira/browse/PROTON-238
 Project: Qpid Proton
  Issue Type: New Feature
  Components: proton-c
Affects Versions: 0.3
 Environment: Mainly proton-c and interop testing.
Reporter: Cliff Jansen
Assignee: Cliff Jansen

 This is a proposal for starting to use CMake's built in CTest capabilities in 
 order to allow a unified test mechanism on multiple platforms.
 For the supplied review patch, it assumes that instead of using 
 trunk/config.sh and calling proton-test directly, you do:
   cd path/to/trunk
   mkdir build
   cd build
   cmake ..
   make
   ctest
 Assuming the make succeeds, this will test two targets for now (proton-c and 
 proton-jni), but the newer proposed tests (i.e. performance) can be added as 
 well.
 Once the desired work flow is captured, this can be tweaked to run in a 
 platform neutral way.  CMake even has the capability to run CTest from inside 
 the Visual Studio IDE.  Concepts and strategies are stolen from the qpid/cpp 
 tree.
 By default, you just get a brief summary of the tests.  Also try
   ctest -V   [ to see the full output ]
   ctest -N   [ to list the available tests ]
   ctest -R proton-c  [ just run the one test in this case, or a regexp if 
 supplied ]
   ctest -E regexp  [ run all tests except ones that match regexp ]
 Fancier tests can use cmake scripts to do things in a platform neutral manner 
 (move files around), run the test from a different directory, etc.  Python 
 scripts and Java programs are already platform neutral, so there is no need 
 to make changes for those. 
 Tests can be conditionally configured (in the example proton-jni will not be 
 configured if maven or java aren't found).
 Note that if you wish to just build and test proton-c, there is no 
 requirement to build from within the specific directory .../trunk/build.  
 This restriction currently exists for testing proton-jni using maven, but 
 perhaps that can be relaxed in future.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


Re: proton interop tests failed on Jenkins

2013-02-14 Thread Alan Conway
On Thu, 2013-02-14 at 15:13 +, Phil Harvey wrote:
 I notice that the proton-jni Jenkins job has failed:
 
 https://builds.apache.org/view/M-R/view/Qpid/job/Qpid-proton-jni/25/
 
 The commit that broke this build was probably this one for PROTON-215, by
 aconway:
 
 PROTON-215: Add tests to verify AMQP type support for python bindings.
 
 http://svn.apache.org/viewvc?view=revisionrevision=1445920
 
 Any volunteers to look into this?
 
 
 Phil

Should be fixed now.



[jira] [Created] (PROTON-241) proton-c: mark old transport interfaces 'deprecated'

2013-02-14 Thread Ken Giusti (JIRA)
Ken Giusti created PROTON-241:
-

 Summary: proton-c: mark old transport interfaces 'deprecated'
 Key: PROTON-241
 URL: https://issues.apache.org/jira/browse/PROTON-241
 Project: Qpid Proton
  Issue Type: Bug
  Components: proton-c
Reporter: Ken Giusti
Priority: Trivial


Once PROTON-225 is implemented, we should eventually remove the old interfaces 
after marking them deprecated.

Example:
#ifdef __GNUC__
#define DEPRECATED(func) func __attribute__ ((deprecated))
#elif defined(_MSC_VER)
#define DEPRECATED(func) __declspec(deprecated) func
#else
#pragma message(WARNING: You need to implement DEPRECATED for this compiler)
#define DEPRECATED(func) func
#endif


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


Running the java tests

2013-02-14 Thread Alan Conway
Anyone know how to run a subset of proton's Java tests? The pom.xml
explains how to do it for the jython test but not for other Java tests.



Re: Running the java tests

2013-02-14 Thread Phil Harvey
Hi Alan,

You can use the test system property, as described here:

http://maven.apache.org/surefire/maven-surefire-plugin/examples/single-test.html

If I remember correctly, the special pattern property mentioned you're
seeing in the pom is a non-standard one we added to tell JythonTest to run
a subset of the Python tests.

Note that there are not very many Java Junit tests yet,  but Keith and I
are currently looking to add some more.

Phil
On Feb 14, 2013 9:51 PM, Alan Conway acon...@redhat.com wrote:

 Anyone know how to run a subset of proton's Java tests? The pom.xml
 explains how to do it for the jython test but not for other Java tests.