Proton Version Detection / Changing Function Calls
Hi Folks, Please bear with me as I have a few questions to pose to the mailing list but I'm going to send them in separate emails to avoid cross-talk on different topics... I noticed recently that in your SVN copy of proton, pn_messenger_send has been modified to support providing another parameter. When I tried to support both implementations, I could find no reliable way to do so because: 1. Version numbers are currently the same for both 0.4 and the latest off SVN 2. The version as generated to produce pn_config.h (even if it was different) does not seem to be distributed during the build so when building against compiled libraries, there doesn't seem to be any way to detect the version of the qpid proton libraries Maybe I'm missing something and the version information is to be found elsewhere? If not, could you consider adding this? Cheers, Frank Please consider the environment before printing this e-mail. This e-mail may contain confidential and/or privileged information. If you are not the intended recipient or have received this e-mail in error, please advise the sender immediately by reply e-mail and delete this message and any attachments without retaining a copy. Any unauthorised copying, disclosure or distribution of the material in this e-mail is strictly forbidden. -- Please consider the environment before printing this email. Visit our website at http://www.nyse.com http://www.nyse.com * Note: The information contained in this message and any attachment to it is privileged, confidential and protected from disclosure. If the reader of this message is not the intended recipient, or an employee or agent responsible for delivering this message to the intended recipient, you are hereby notified that any dissemination, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify the sender immediately by replying to the message, and please delete it from your system. Thank you. NYSE Euronext.
[jira] [Commented] (PROTON-351) Proton-J engine violates link credit window
[ https://issues.apache.org/jira/browse/PROTON-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712189#comment-13712189 ] ASF subversion and git services commented on PROTON-351: Commit 1504407 from r...@apache.org in branch 'proton/trunk' [ https://svn.apache.org/r1504407 ] Bounded messenger's credit allocation when an unlimited value is passed to recv; added tests for pushback at both messenger and engine level; fixed proton-j engine to respect credit window; fixed java messenger to properly report if work has been done. This addresses PROTON-350 and PROTON-351. Proton-J engine violates link credit window --- Key: PROTON-351 URL: https://issues.apache.org/jira/browse/PROTON-351 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.4 Reporter: Rafael H. Schloming Assignee: Rafael H. Schloming Fix For: 0.5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-350) Messenger - pn_messenger_recv( -1 ) does not flow control senders
[ https://issues.apache.org/jira/browse/PROTON-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712188#comment-13712188 ] ASF subversion and git services commented on PROTON-350: Commit 1504407 from r...@apache.org in branch 'proton/trunk' [ https://svn.apache.org/r1504407 ] Bounded messenger's credit allocation when an unlimited value is passed to recv; added tests for pushback at both messenger and engine level; fixed proton-j engine to respect credit window; fixed java messenger to properly report if work has been done. This addresses PROTON-350 and PROTON-351. Messenger - pn_messenger_recv( -1 ) does not flow control senders - Key: PROTON-350 URL: https://issues.apache.org/jira/browse/PROTON-350 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Reporter: Ken Giusti Fix For: 0.5 Attachments: test-recv.py When using pn_messenger_recv( -1 ), remote senders are not back-pressured, and the number of messages received can grow without bounds. It appears that messenger is unconditionally granting credit as messages arrive. Messenger should instead only replenish credit when received messages are actually consumed by the application (maybe after they are settled?). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-351) Proton-J engine violates link credit window
[ https://issues.apache.org/jira/browse/PROTON-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming resolved PROTON-351. Resolution: Fixed Proton-J engine violates link credit window --- Key: PROTON-351 URL: https://issues.apache.org/jira/browse/PROTON-351 Project: Qpid Proton Issue Type: Bug Components: proton-j Affects Versions: 0.4 Reporter: Rafael H. Schloming Assignee: Rafael H. Schloming Fix For: 0.5 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-350) Messenger - pn_messenger_recv( -1 ) does not flow control senders
[ https://issues.apache.org/jira/browse/PROTON-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712193#comment-13712193 ] Rafael H. Schloming commented on PROTON-350: I've submitted a fix for this and added a test. Can you verify that this also fixes your reproducer? Messenger - pn_messenger_recv( -1 ) does not flow control senders - Key: PROTON-350 URL: https://issues.apache.org/jira/browse/PROTON-350 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Reporter: Ken Giusti Fix For: 0.5 Attachments: test-recv.py When using pn_messenger_recv( -1 ), remote senders are not back-pressured, and the number of messages received can grow without bounds. It appears that messenger is unconditionally granting credit as messages arrive. Messenger should instead only replenish credit when received messages are actually consumed by the application (maybe after they are settled?). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PROTON-295) recv(-1) + incoming_window == bad
[ https://issues.apache.org/jira/browse/PROTON-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming resolved PROTON-295. Resolution: Fixed recv(-1) + incoming_window == bad - Key: PROTON-295 URL: https://issues.apache.org/jira/browse/PROTON-295 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.5 Reporter: michael goulish Assignee: Rafael H. Schloming Fix For: 0.5 Use of recv(-1) could receive enough messages that some would exceed the incoming window size and be automatically accepted -- with app logic never getting a say in the matter. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
Usage of pn_message_properties and pn_message_annotations
Hi Folks,
I am looking for ways to inject meta data into a pn_message_t in a message body
agnostic way as I send it across a messenger interface. I have found
pn_message_properties and pn_message_annotations and it is unclear to me what
their purpose is.
Key questions are:
1. Will data inserted in here still survive for all proposed data types (e.g.
will this still be a pn_data_t accessible even if the message body is json?)
2. Should I as an application developer be writing to these structures at all?
3. If the answer to #2 is yes, can properties be used to pass parameters to the
broker such as {create:always, delete:always} which I have seen in other
implementations but I'm not sure how to construct an equivalent instruction in C
4. Again if the answer to #2 is yes, are there any particular data types which
should be used so it doesn't interfere with the underlying workings of
pn_messenger or confuse the broker?
Cheers,
Frank
Please consider the environment before printing this e-mail.
This e-mail may contain confidential and/or privileged information. If you are
not the intended recipient or have received this e-mail in error, please advise
the sender immediately by reply e-mail and delete this message and any
attachments without retaining a copy.
Any unauthorised copying, disclosure or distribution of the material in this
e-mail is strictly forbidden.
--
Please consider the environment before printing this email.
Visit our website at http://www.nyse.com http://www.nyse.com
*
Note: The information contained in this message and any attachment to it is
privileged, confidential and protected from disclosure. If the reader of this
message is not the intended recipient, or an employee or agent responsible for
delivering this message to the intended recipient, you are hereby notified that
any dissemination, distribution or copying of this communication is strictly
prohibited. If you have received this communication in error, please notify the
sender immediately by replying to the message, and please delete it from your
system. Thank you. NYSE Euronext.
[jira] [Resolved] (PROTON-358) [Proton-j] CategoryLoggerDiscoveryTest fails when run on Java 7 due to tests being run in a different order
[ https://issues.apache.org/jira/browse/PROTON-358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved PROTON-358. Resolution: Fixed [Proton-j] CategoryLoggerDiscoveryTest fails when run on Java 7 due to tests being run in a different order --- Key: PROTON-358 URL: https://issues.apache.org/jira/browse/PROTON-358 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Rob Godfrey Assignee: Rob Godfrey Some tests in CategoryLoggerDiscoveryTest change the default logger, but do not restore the default at the end of the test. If these tests are run before the test which checks the default logger is StdOut that that test fails. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-358) [Proton-j] CategoryLoggerDiscoveryTest fails when run on Java 7 due to tests being run in a different order
Rob Godfrey created PROTON-358: -- Summary: [Proton-j] CategoryLoggerDiscoveryTest fails when run on Java 7 due to tests being run in a different order Key: PROTON-358 URL: https://issues.apache.org/jira/browse/PROTON-358 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Rob Godfrey Assignee: Rob Godfrey Some tests in CategoryLoggerDiscoveryTest change the default logger, but do not restore the default at the end of the test. If these tests are run before the test which checks the default logger is StdOut that that test fails. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Created] (PROTON-359) [Proton-j] Create a simple entry point for creating all Proton entities
Rob Godfrey created PROTON-359: -- Summary: [Proton-j] Create a simple entry point for creating all Proton entities Key: PROTON-359 URL: https://issues.apache.org/jira/browse/PROTON-359 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Rob Godfrey Assignee: Rob Godfrey Rather than requiring users to create a ProtonFactoryLoader, get a factory and then create an object, instead just do Proton.connection(), Proton.message(), etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-359) [Proton-j] Create a simple entry point for creating all Proton entities
[ https://issues.apache.org/jira/browse/PROTON-359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712759#comment-13712759 ] ASF subversion and git services commented on PROTON-359: Commit 1504633 from [~godfrer] in branch 'proton/trunk' [ https://svn.apache.org/r1504633 ] PROTON-359 : [Proton-j] Create a simple entry point for creating all Proton entities [Proton-j] Create a simple entry point for creating all Proton entities --- Key: PROTON-359 URL: https://issues.apache.org/jira/browse/PROTON-359 Project: Qpid Proton Issue Type: Bug Components: proton-j Reporter: Rob Godfrey Assignee: Rob Godfrey Rather than requiring users to create a ProtonFactoryLoader, get a factory and then create an object, instead just do Proton.connection(), Proton.message(), etc. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
