[jira] [Commented] (PROTON-200) [Proton-c] Credit distribution by messenger is not balanced across all links
[ https://issues.apache.org/jira/browse/PROTON-200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781780#comment-13781780 ] ASF subversion and git services commented on PROTON-200: Commit 1527535 from r...@apache.org in branch 'proton/trunk' [ https://svn.apache.org/r1527535 ] Modified the engine to track how much credit is drained vs used. This should simplify PROTON-200. [Proton-c] Credit distribution by messenger is not balanced across all links Key: PROTON-200 URL: https://issues.apache.org/jira/browse/PROTON-200 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.3 Reporter: Ken Giusti Assignee: Ken Giusti Attachments: proton-200.patch, upstream-credit.patch The method used to distribute credit to receiving links may lead to starvation when the number of receiving links is the available credit. The distribution algorithm always starts with the same link - see messenger.c::pn_messenger_flow() -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (PROTON-401) Ordering issue prevents credit drain from working properly
[ https://issues.apache.org/jira/browse/PROTON-401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781811#comment-13781811 ] Ken Giusti commented on PROTON-401: --- I see your point - I'll update the PROTON-200 patch to call drained as you explain in your comment. Ordering issue prevents credit drain from working properly -- Key: PROTON-401 URL: https://issues.apache.org/jira/browse/PROTON-401 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Reporter: Ken Giusti Assignee: Ken Giusti Attachments: drain-error.patch, drain-hack.patch If the sending link calls pn_link_drained() to indicate that it has send all pending data, and afterwards it receives a Flow frame with drain=true from the peer, then the drain never completes. The ordering is the problem: if the flow frame w/drain=true is received _BEFORE_ the sender calls pn_link_drained(), then it works. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (PROTON-375) Engine does not indicate when a link has completed draining.
[ https://issues.apache.org/jira/browse/PROTON-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13781840#comment-13781840 ] ASF subversion and git services commented on PROTON-375: Commit 1527576 from r...@apache.org in branch 'proton/trunk' [ https://svn.apache.org/r1527576 ] PROTON-375: added pn_link_draining/Receiver.draining() Engine does not indicate when a link has completed draining. Key: PROTON-375 URL: https://issues.apache.org/jira/browse/PROTON-375 Project: Qpid Proton Issue Type: Bug Components: proton-c, proton-j Affects Versions: 0.4 Reporter: Ken Giusti Assignee: Ken Giusti The engine API provides the pn_link_drain() method, which allows the application to force the peer to drain its credit. The engine API does not provide a way for the application to know when the remote has completed draining. At least there needs to be a way to find out when the remote credit value has been exhausted. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Resolved] (PROTON-375) Engine does not indicate when a link has completed draining.
[ https://issues.apache.org/jira/browse/PROTON-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rafael H. Schloming resolved PROTON-375. Resolution: Fixed Assignee: Rafael H. Schloming (was: Ken Giusti) Engine does not indicate when a link has completed draining. Key: PROTON-375 URL: https://issues.apache.org/jira/browse/PROTON-375 Project: Qpid Proton Issue Type: Bug Components: proton-c, proton-j Affects Versions: 0.4 Reporter: Ken Giusti Assignee: Rafael H. Schloming The engine API provides the pn_link_drain() method, which allows the application to force the peer to drain its credit. The engine API does not provide a way for the application to know when the remote has completed draining. At least there needs to be a way to find out when the remote credit value has been exhausted. -- This message was sent by Atlassian JIRA (v6.1#6144)
[jira] [Commented] (PROTON-342) installing into custom location doesn't work nicely (and is not properly documented)
[ https://issues.apache.org/jira/browse/PROTON-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13782072#comment-13782072 ] Darryl L. Pierce commented on PROTON-342: - Looking into this more, the pkg-config file (libqpid-proton.pc) seems to be setting its values properly. There was a separate bug (PROTON-412) that fixed issues with that file, where the paths were being misconfigured. The only issue that'll come up is that the paths within it are based on the environment as described to CMake prior to the build. Using DESTDIR isn't meant to update the paths in that file but is used for things like building for a package distribution; i.e., you wouldn't use it to actually install onto your system. The dynamic languages are behaving as expected, as they will install to directories as specified by the dynamic languages themselves. Should we then close this issue? installing into custom location doesn't work nicely (and is not properly documented) Key: PROTON-342 URL: https://issues.apache.org/jira/browse/PROTON-342 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.4 Reporter: Gordon Sim Assignee: Darryl L. Pierce The README suggests setting -DCMAKE_INSTALL_PREFIX when running cmake, it does not mention setting DESTDIR when invoking make install. If you don't set the DESTDIR on make install it will honour the CMAKE_INSTALL_PREFIX for some parts of the installation (e.g. header files, native libraries, pkg-config file etc) but the python bindings (and I assume other bindings) will still install in the standard location which will fail if you are not running as root. However if you set DESTDIR then this alters the location of the headers, libraries and pkg-config , which now install into $DESTDIR/$CMAKE_INSTALL_PREFIX and the pkg-config file no longer has the correct include or library paths in it. -- This message was sent by Atlassian JIRA (v6.1#6144)
