[jira] [Created] (PROTON-597) Improve the memory footprint of TrasportImpl
Marcel Meulemans created PROTON-597: --- Summary: Improve the memory footprint of TrasportImpl Key: PROTON-597 URL: https://issues.apache.org/jira/browse/PROTON-597 Project: Qpid Proton Issue Type: Improvement Components: proton-j Affects Versions: 0.7 Reporter: Marcel Meulemans Priority: Minor The memory footprint of the TrasportImpl can be quite high when using large maxFrameSizes (for example 1MB). In the TrasportImpl of proton-j there are two classes TrasportOutputAdaptor and FrameParser (TrasportImpl has a member of both) that hold a ByteBuffer of maxFrameSize throughout their lifetime. In the case of the 1MB frame size that means that each transport has a fairly high memory footprint (2MB) considering that this memory is hardly ever used, i.e. only when there is a frame to transfer in/out and in most cases the frame will not be maxFrameSize. Because there is a Transport for every connection the memory usage can become quite high when dealing with many connections with large maxFrameSize, e.g. 2GB for only 1000 connections. An proof of concept implementation for reducing the memory footprint by only allocating the buffers when needed can be found here: https://github.com/marcelmeulemans/qpid-proton/ See also the short mailinglist disscusion here: http://qpid.2158936.n2.nabble.com/High-memory-footprint-of-proton-j-in-ActiveMQ-td7608977.html -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (PROTON-598) CProton python binding fails to build Windows debug configuration
Chuck Rolke created PROTON-598: -- Summary: CProton python binding fails to build Windows debug configuration Key: PROTON-598 URL: https://issues.apache.org/jira/browse/PROTON-598 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.7 Environment: Windows, Python 2.6.1 Reporter: Chuck Rolke cpython fails to link with file python26_d.lib not found. The issue here is that the windows installer for python does not install the debug versions (identified by the _d suffix) of the python libraries. Wisdom from the web suggests either to build your own debug python or to debug using a release build. Links using the RelWithDebInfo work just fine and I can make progress running ctest. Just a heads up for anyone who wants to run ctest with Debug builds. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (PROTON-595) Python test function MessengerApp.start fails on Windows
[
https://issues.apache.org/jira/browse/PROTON-595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020223#comment-14020223
]
ASF subversion and git services commented on PROTON-595:
Commit 1600981 from c...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1600981 ]
PROTON-595: Accomodate windows when launching Popen(xxx.py,...)
Detects running on windows and in that case runs Popen with shell=True.
Python test function MessengerApp.start fails on Windows
Key: PROTON-595
URL: https://issues.apache.org/jira/browse/PROTON-595
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Affects Versions: 0.7
Environment: Windows ctest
Reporter: Chuck Rolke
The function uses Popen() where the first cmd arg is the name of a python
file. Windows doesn't honor the #! at the beginning of the file and then
fails with
{noformat}
[Error 193] %1 is not a valid Win32 application
{noformat}
This code could also be improved by printing the exception error text along
with the path setting hint.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (PROTON-596) There is no equivalent to 'config.sh' for windows
[
https://issues.apache.org/jira/browse/PROTON-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020354#comment-14020354
]
ASF subversion and git services commented on PROTON-596:
Commit 1601010 from c...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1601010 ]
PROTON-596: Suppress MSVC warnings
This suppression covers:
..\..\proton-c\src\object\object.c(232):
warning C4244: 'argument' : conversion from 'ssize_t' to 'int',
possible loss of data
2..\..\proton-c\src\object\object.c(260):
warning C4267: 'argument' : conversion from 'size_t' to 'int',
possible loss of data
2..\..\proton-c\src\windows\driver.c(777):
warning C4800: 'int' : forcing value to bool 'true' or 'false'
(performance warning)
6..\..\..\..\..\tests\tools\apps\c\msgr-recv.c(90):
warning C4996: 'sscanf': This function or variable may be unsafe.
Consider using sscanf_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS
This covers the majority of the warnings. A typical 64-bit compile has 172
warnings making real problems harder to see. It also follows the
pattern used in Qpid proper.
* C4244 and C4267 could still be real problems.
Try enabling -Wconversion in GCC if you want to be pedantic in Qpid or
Proton.
* C4800 is probably not a risk as it's a fairly idiomatic pattern in C.
* C4996 is MSVC complaining of functions that consume buffers using
{pointer} and not {pointer, size}. They have been the source of seg
faults and innumerable security vulnerabilities throughout the years.
There is no equivalent to 'config.sh' for windows
-
Key: PROTON-596
URL: https://issues.apache.org/jira/browse/PROTON-596
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Affects Versions: 0.7
Environment: Proton on windows
Reporter: Chuck Rolke
ctest fails to find compiled C tests. Some environment settings are needed in
addition to those supplied by cmake/ctest.
Linux users have the luxury of config.sh to steer their environment correctly
for tests built in proton/build. Windows users need the same.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (PROTON-546) C++ Windows warnings: conversions and possible loss of data
[
https://issues.apache.org/jira/browse/PROTON-546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020381#comment-14020381
]
Chuck Rolke commented on PROTON-546:
I confused PROTON-546 and PROTON-596 in a commit message. This commit is for
PROTON-546.
Commit 1601010 from c...@apache.org in branch 'proton/trunk'
[ https://svn.apache.org/r1601010 ]
PROTON-596: Suppress MSVC warnings
This suppression covers:
..\..\proton-c\src\object\object.c(232):
warning C4244: 'argument' : conversion from 'ssize_t' to 'int',
possible loss of data
2..\..\proton-c\src\object\object.c(260):
warning C4267: 'argument' : conversion from 'size_t' to 'int',
possible loss of data
2..\..\proton-c\src\windows\driver.c(777):
warning C4800: 'int' : forcing value to bool 'true' or 'false'
(performance warning)
6..\..\..\..\..\tests\tools\apps\c\msgr-recv.c(90):
warning C4996: 'sscanf': This function or variable may be unsafe.
Consider using sscanf_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS
This covers the majority of the warnings. A typical 64-bit compile has 172
warnings making real problems harder to see. It also follows the
pattern used in Qpid proper.
* C4244 and C4267 could still be real problems.
Try enabling -Wconversion in GCC if you want to be pedantic in Qpid or
Proton.
* C4800 is probably not a risk as it's a fairly idiomatic pattern in C.
* C4996 is MSVC complaining of functions that consume buffers using
{pointer} and not {pointer, size}. They have been the source of seg
faults and innumerable security vulnerabilities throughout the years.
C++ Windows warnings: conversions and possible loss of data
---
Key: PROTON-546
URL: https://issues.apache.org/jira/browse/PROTON-546
Project: Qpid Proton
Issue Type: Bug
Components: proton-c
Affects Versions: 0.6
Reporter: Chuck Rolke
Assignee: Andrew Stitcher
Attachments: PROTON-546-size-warnings.txt
Windows has other warnings similar to PROTON-545, especially during 64-bit
builds.
See attached file for details.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (PROTON-596) There is no equivalent to 'config.sh' for windows
[ https://issues.apache.org/jira/browse/PROTON-596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020390#comment-14020390 ] Chuck Rolke commented on PROTON-596: The previous subversion services comment for Commit 1601010 from c...@apache.org in branch 'proton/trunk' should be in PROTON-546 and not here. Sorry for the noise. There is no equivalent to 'config.sh' for windows - Key: PROTON-596 URL: https://issues.apache.org/jira/browse/PROTON-596 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.7 Environment: Proton on windows Reporter: Chuck Rolke ctest fails to find compiled C tests. Some environment settings are needed in addition to those supplied by cmake/ctest. Linux users have the luxury of config.sh to steer their environment correctly for tests built in proton/build. Windows users need the same. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Created] (PROTON-599) Visual Studio warnings - enumeration update
Chuck Rolke created PROTON-599: -- Summary: Visual Studio warnings - enumeration update Key: PROTON-599 URL: https://issues.apache.org/jira/browse/PROTON-599 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.7 Environment: Visual Studio 2008, 2010, 2012, 2013 Reporter: Chuck Rolke After suppressing the 'usual' warnings (see PROTON-546, http://svn.apache.org/r1601010) and running some later compiler versions a new list of errors emerges. Please see attached listing for details. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Updated] (PROTON-599) Visual Studio warnings - enumeration update
[ https://issues.apache.org/jira/browse/PROTON-599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chuck Rolke updated PROTON-599: --- Attachment: vs-proton-warnings.txt Today's crop of Visual Studio warnings. Before suppressing other warnings this list exceeded 3000 lines. Visual Studio warnings - enumeration update --- Key: PROTON-599 URL: https://issues.apache.org/jira/browse/PROTON-599 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.7 Environment: Visual Studio 2008, 2010, 2012, 2013 Reporter: Chuck Rolke Attachments: vs-proton-warnings.txt After suppressing the 'usual' warnings (see PROTON-546, http://svn.apache.org/r1601010) and running some later compiler versions a new list of errors emerges. Please see attached listing for details. -- This message was sent by Atlassian JIRA (v6.2#6252)
