[jira] [Created] (PROTON-615) Cmake binding dependencies wrong (building python binding always; no dependency for include/proton/cproton.i)

2014-06-25 Thread Andrew Stitcher (JIRA)
Andrew Stitcher created PROTON-615:
--

 Summary: Cmake binding dependencies wrong (building python binding 
always; no dependency for include/proton/cproton.i)
 Key: PROTON-615
 URL: https://issues.apache.org/jira/browse/PROTON-615
 Project: Qpid Proton
  Issue Type: Bug
Affects Versions: 0.7
Reporter: Andrew Stitcher


The CMake dependencies for the script language bindings are wrong in 2 ways:

* The python binding always gets rebuilt, because the cmake swig module has 
specific naming requirements for python.
* The bindings do not have a dependency on the common included swig include 
file so that when it changes they will not automatically get rebuilt.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Assigned] (PROTON-615) Cmake binding dependencies wrong (building python binding always; no dependency for include/proton/cproton.i)

2014-06-25 Thread Andrew Stitcher (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Stitcher reassigned PROTON-615:
--

Assignee: Andrew Stitcher

 Cmake binding dependencies wrong (building python binding always; no 
 dependency for include/proton/cproton.i)
 -

 Key: PROTON-615
 URL: https://issues.apache.org/jira/browse/PROTON-615
 Project: Qpid Proton
  Issue Type: Bug
Affects Versions: 0.7
Reporter: Andrew Stitcher
Assignee: Andrew Stitcher

 The CMake dependencies for the script language bindings are wrong in 2 ways:
 * The python binding always gets rebuilt, because the cmake swig module has 
 specific naming requirements for python.
 * The bindings do not have a dependency on the common included swig include 
 file so that when it changes they will not automatically get rebuilt.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Resolved] (PROTON-615) Cmake binding dependencies wrong (building python binding always; no dependency for include/proton/cproton.i)

2014-06-25 Thread Andrew Stitcher (JIRA)

 [ 
https://issues.apache.org/jira/browse/PROTON-615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Stitcher resolved PROTON-615.


   Resolution: Fixed
Fix Version/s: 0.8

 Cmake binding dependencies wrong (building python binding always; no 
 dependency for include/proton/cproton.i)
 -

 Key: PROTON-615
 URL: https://issues.apache.org/jira/browse/PROTON-615
 Project: Qpid Proton
  Issue Type: Bug
Affects Versions: 0.7
Reporter: Andrew Stitcher
Assignee: Andrew Stitcher
 Fix For: 0.8


 The CMake dependencies for the script language bindings are wrong in 2 ways:
 * The python binding always gets rebuilt, because the cmake swig module has 
 specific naming requirements for python.
 * The bindings do not have a dependency on the common included swig include 
 file so that when it changes they will not automatically get rebuilt.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


MessageImplde.decode(ByteBuffer)

2014-06-25 Thread Clebert Suconic


I have a case where I have a ByteBuffer (which could be a native buffer 
(ByteBuffer.allocateNative (whatever method name that is)), and using the 
decode (byte[] ) would make me duplicate the byte region.


Would be ok if someone merged this simple commit on qpid-proton-j? It's a very 
simple change... current code still works.


https://github.com/clebertsuconic/qpid-proton/commit/2515b60ee69cb4d7ee240ff54d311cb8cf763f59


You could make the method as part of the interface if you like.. but I would be 
happy on casting MessageImpl for now.