On Mon, 2015-12-14 at 11:40 -0700, Philippe Le Rohellec wrote: > Thanks Alan, > > I tried that but a recent change to the SWIG bindings broke the > reactor > interface in ruby. I commented on > https://issues.apache.org/jira/browse/PROTON-949 as you already notic > ed. > Even after it's fixed there are other issues popping up with the > reactor > interface, something with a prototype mismatch of an ssl.rb method > (https://gist.github.com/plerohellec/3a73b71b04aaa22845c3), I couldn' > t find > an easy fix for that. > I also switched to the 0.10.x branch with the same result so I gave > up on > the reactor. Funny you should say that. I also recently gave up on the reactor in ruby - the last straw was the GVL, which blocks every ruby thread in the process while proton is in blocking select calls. However messenger is also problematic, so I am working on a ConnectionEngine, a kind of mini-reactor. The user API is almost identical to reactor apps (event-based), but the setup is different. Take a look at: https://github.com/BitScoutOrg/docker-fluentd/tree/master/amqp_qpid/lib /fluent/plugin qpid_proton_extra.rb is all stuff I plan to bring into proton when I get a chance to clean it up. The rest is a fluent plugin, which is not relevant, but illustrates the use of ConnectionEngine. The handlers are the same as the reactor handlers but the IO and threading parts are native in Ruby which avoids the GVL problems and fits more neatly into a Ruby application. I haven't tried anything with SSL, if you find a problem there JIRA it. I'm on the hook for ruby now. > I added the missing binding (Messenger#get_link) but I haven't been > able to > get the expected result from passing a filter yet. I will open a PR > if I > manage to get it to work. By the way, this is a modified recv.rb that > sets > the filter: https://gist.github.com/plerohellec/55f3fde1b303f04d259d > I'm not sure the filter are actually used when when receiving a > message, > could you give it a quick review? It looks ok but I hit the get link problem also. I think the code will work though, as I tried a similar example using the reactor and both wireshark and qpidd debug logs confirm that the filter string is passed correctly. I found some other bugs in the ruby binding while doing this so I will fix it all up and put up the example ASAP. Please feel free to raise JIRAs for any and all problems you find, I want to beat the ruby binding into shape and your input helps tremendously.
[jira] [Commented] (PROTON-1082) add ability to specify and inspect properties for link attach frames
[ https://issues.apache.org/jira/browse/PROTON-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066802#comment-15066802 ] ASF GitHub Bot commented on PROTON-1082: Github user gemmellr commented on the pull request: https://github.com/apache/qpid-proton/pull/52#issuecomment-166376050 Hi Sreeram, I have committed changes to implement support for both setting the local properties to be sent to the peer and inspecting the remote properties conveyed from the peer. The local bit is fairly close to your changes, other than updating the names for consistency the main change is that it adds type details to the Map and restricts the keys to be Symbol values, since symbols are the only type of key AMQP 1.0 spec permits in the case of the link properties. Robbie (Mentioning PROTON-1082 here so the bot updates it too, since it isn't in the PR title) > add ability to specify and inspect properties for link attach frames > > > Key: PROTON-1082 > URL: https://issues.apache.org/jira/browse/PROTON-1082 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-j >Affects Versions: 0.12.0 > Environment: all >Reporter: Sreeram Garlapati >Assignee: Robbie Gemmell > Labels: patch > Fix For: 0.12.0 > > Original Estimate: 4h > Remaining Estimate: 4h > > This is a feature request from windows azure eventhubs team. Here's the Pull > request which has the required feature: > https://github.com/apache/qpid-proton/pull/52 > I (sreeram, from windows azure eventHubs team) am starting to build eventHubs > Java SDK and taking a dependency on proton-j (which will be available on > GitHub, hopefully, soon). EventHubs amqp client will need to set > AttachProperties to enable Critical scenarios for us. > Currently, in the proton-j framework - all attach frame fields are exposed > using the Link Interface. So, following the same pattern I added new Get/Set > methods for setting AttachProperties. > Couple of SSL tests which are completely unrelated to my pull request are > failing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] qpid-proton pull request: Expose get/set on 'properties Map' of Li...
Github user gemmellr commented on the pull request: https://github.com/apache/qpid-proton/pull/52#issuecomment-166376050 Hi Sreeram, I have committed changes to implement support for both setting the local properties to be sent to the peer and inspecting the remote properties conveyed from the peer. The local bit is fairly close to your changes, other than updating the names for consistency the main change is that it adds type details to the Map and restricts the keys to be Symbol values, since symbols are the only type of key AMQP 1.0 spec permits in the case of the link properties. Robbie (Mentioning PROTON-1082 here so the bot updates it too, since it isn't in the PR title) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Resolved] (PROTON-1082) add ability to specify and inspect properties for link attach frames
[ https://issues.apache.org/jira/browse/PROTON-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell resolved PROTON-1082. Resolution: Fixed > add ability to specify and inspect properties for link attach frames > > > Key: PROTON-1082 > URL: https://issues.apache.org/jira/browse/PROTON-1082 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-j >Affects Versions: 0.12.0 > Environment: all >Reporter: Sreeram Garlapati >Assignee: Robbie Gemmell > Labels: patch > Fix For: 0.12.0 > > Original Estimate: 4h > Remaining Estimate: 4h > > This is a feature request from windows azure eventhubs team. Here's the Pull > request which has the required feature: > https://github.com/apache/qpid-proton/pull/52 > I (sreeram, from windows azure eventHubs team) am starting to build eventHubs > Java SDK and taking a dependency on proton-j (which will be available on > GitHub, hopefully, soon). EventHubs amqp client will need to set > AttachProperties to enable Critical scenarios for us. > Currently, in the proton-j framework - all attach frame fields are exposed > using the Link Interface. So, following the same pattern I added new Get/Set > methods for setting AttachProperties. > Couple of SSL tests which are completely unrelated to my pull request are > failing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] qpid-proton pull request: Expose get/set on 'properties Map' of Li...
Github user astitcher commented on the pull request: https://github.com/apache/qpid-proton/pull/52#issuecomment-166296481 I looked at this - I can't see any problems, but I don't have enough real expertise in the Java code to be comfortable saying it's ok and merging it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Assigned] (PROTON-1082) ability to specify properties on attach frame before link.open
[ https://issues.apache.org/jira/browse/PROTON-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell reassigned PROTON-1082: -- Assignee: Robbie Gemmell > ability to specify properties on attach frame before link.open > -- > > Key: PROTON-1082 > URL: https://issues.apache.org/jira/browse/PROTON-1082 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-j >Affects Versions: 0.12.0 > Environment: all >Reporter: Sreeram Garlapati >Assignee: Robbie Gemmell > Labels: patch > Fix For: 0.12.0 > > Original Estimate: 4h > Remaining Estimate: 4h > > This is a feature request from windows azure eventhubs team. Here's the Pull > request which has the required feature: > https://github.com/apache/qpid-proton/pull/52 > I (sreeram, from windows azure eventHubs team) am starting to build eventHubs > Java SDK and taking a dependency on proton-j (which will be available on > GitHub, hopefully, soon). EventHubs amqp client will need to set > AttachProperties to enable Critical scenarios for us. > Currently, in the proton-j framework - all attach frame fields are exposed > using the Link Interface. So, following the same pattern I added new Get/Set > methods for setting AttachProperties. > Couple of SSL tests which are completely unrelated to my pull request are > failing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] qpid-proton pull request: Expose get/set on 'properties Map' of Li...
Github user gemmellr commented on the pull request: https://github.com/apache/qpid-proton/pull/52#issuecomment-166302294 Thanks Andrew. I was planning to get to this once the final bits for the Proton 0.11.1 release are out the way. I think it needs adjustment for naming consistency with the similar Connection level bits, and as only the 'local' half has been implemented here it wouldn't satisfy the needs of either servers or any clients looking to inspect the remote link properties, so I'd add that too. I'll look at doing that later today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Expose get/set on 'properties Map' of Li...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Commented] (PROTON-1082) add ability to specify and inspect properties for link attach frames
[ https://issues.apache.org/jira/browse/PROTON-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15066784#comment-15066784 ] ASF subversion and git services commented on PROTON-1082: - Commit e9e0f31c6894736e54d7d5b624bf3245f704d9af in qpid-proton's branch refs/heads/master from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e9e0f31 ] PROTON-1082: add support for setting and inspecting link properties conveyed during link attach This closes #52 > add ability to specify and inspect properties for link attach frames > > > Key: PROTON-1082 > URL: https://issues.apache.org/jira/browse/PROTON-1082 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-j >Affects Versions: 0.12.0 > Environment: all >Reporter: Sreeram Garlapati >Assignee: Robbie Gemmell > Labels: patch > Fix For: 0.12.0 > > Original Estimate: 4h > Remaining Estimate: 4h > > This is a feature request from windows azure eventhubs team. Here's the Pull > request which has the required feature: > https://github.com/apache/qpid-proton/pull/52 > I (sreeram, from windows azure eventHubs team) am starting to build eventHubs > Java SDK and taking a dependency on proton-j (which will be available on > GitHub, hopefully, soon). EventHubs amqp client will need to set > AttachProperties to enable Critical scenarios for us. > Currently, in the proton-j framework - all attach frame fields are exposed > using the Link Interface. So, following the same pattern I added new Get/Set > methods for setting AttachProperties. > Couple of SSL tests which are completely unrelated to my pull request are > failing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (PROTON-1082) add ability to specify and inspect properties for link attach frames
[ https://issues.apache.org/jira/browse/PROTON-1082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated PROTON-1082: --- Summary: add ability to specify and inspect properties for link attach frames (was: ability to specify properties on attach frame before link.open) > add ability to specify and inspect properties for link attach frames > > > Key: PROTON-1082 > URL: https://issues.apache.org/jira/browse/PROTON-1082 > Project: Qpid Proton > Issue Type: New Feature > Components: proton-j >Affects Versions: 0.12.0 > Environment: all >Reporter: Sreeram Garlapati >Assignee: Robbie Gemmell > Labels: patch > Fix For: 0.12.0 > > Original Estimate: 4h > Remaining Estimate: 4h > > This is a feature request from windows azure eventhubs team. Here's the Pull > request which has the required feature: > https://github.com/apache/qpid-proton/pull/52 > I (sreeram, from windows azure eventHubs team) am starting to build eventHubs > Java SDK and taking a dependency on proton-j (which will be available on > GitHub, hopefully, soon). EventHubs amqp client will need to set > AttachProperties to enable Critical scenarios for us. > Currently, in the proton-j framework - all attach frame fields are exposed > using the Link Interface. So, following the same pattern I added new Get/Set > methods for setting AttachProperties. > Couple of SSL tests which are completely unrelated to my pull request are > failing. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
