[jira] [Commented] (PROTON-1179) [C++ binding] Rework condition class
[ https://issues.apache.org/jira/browse/PROTON-1179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243683#comment-15243683 ] ASF subversion and git services commented on PROTON-1179: - Commit e826d858858152f7a64dad8a5247f89c3f4942e1 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e826d85 ] PROTON-1179: [C++ binding] rename condition::info->properties > [C++ binding] Rework condition class > > > Key: PROTON-1179 > URL: https://issues.apache.org/jira/browse/PROTON-1179 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > * Rename condition to error_condition > * rename info member to properties > * change it from a pure wrapper of pn_condition_t to be a value type. > ** privately constructed from a pn_condition_t > ** API constructed from name [description [properties] ] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1180) [C++ binding] Change endpoint API
[ https://issues.apache.org/jira/browse/PROTON-1180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243685#comment-15243685 ] ASF subversion and git services commented on PROTON-1180: - Commit 288b1a6f76fa20f6414b64c03a7c6b5243b27797 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=288b1a6 ] PROTON-1180: [C++ binding] remove local_condition; rename remote_condition -> condition > [C++ binding] Change endpoint API > - > > Key: PROTON-1180 > URL: https://issues.apache.org/jira/browse/PROTON-1180 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > * Rename remote_condition to condition; remove local_condition (the remote > state is authoritative) > * Add boolean accessors for uninitialized, active, and closed; remove > endpoint.state bit field > * Lift close operation to endpoint from its descendents > * Add new close operation with condition arg -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243684#comment-15243684 ] ASF subversion and git services commented on PROTON-1153: - Commit 9be087df797229fb025d6d9cdd96ca1051d15596 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=9be087d ] PROTON-1153: [C++ binding] Change message member names: - address -> to (retaining address as an alias) - application_properties -> properties > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1178) [C++ binding] Rearrange delivery class
[
https://issues.apache.org/jira/browse/PROTON-1178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15243059#comment-15243059
]
ASF subversion and git services commented on PROTON-1178:
-
Commit c62d5d4efda2accedc25e4dedabb3306d3c9e787 in qpid-proton's branch
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c62d5d4 ]
PROTON-1178: [C++ binding] Rearrange delivery class
- Renamed delivery to transfer
- Split into sub classes tracker (sender side)
and delivery (receiver side)
- Reaaranged some of the original delivery methods between
new delivery, tracker and transfer.
> [C++ binding] Rearrange delivery class
> --
>
> Key: PROTON-1178
> URL: https://issues.apache.org/jira/browse/PROTON-1178
> Project: Qpid Proton
> Issue Type: Improvement
> Components: cpp-binding
>Reporter: Andrew Stitcher
>Assignee: Andrew Stitcher
>
> * Rename {{delivery}} to {{transfer}} and make it the parent class for
> ** {{tracker}} - to track message transfers from sender
> ** {{delivery}} - to manage message delivery at the receiver
> * Split old {{delivery}} methods appropriately between {{transfer}},
> {{tracker}} & {{delivery}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-1171) [proton-j] transport SSL wrapper does not flush all decoded bytes to the underlying input
[ https://issues.apache.org/jira/browse/PROTON-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239272#comment-15239272 ] ASF subversion and git services commented on PROTON-1171: - Commit 3ea4287d483f3ce275be75bf50ac1728527d697a in qpid-proton's branch refs/heads/master from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3ea4287 ] PROTON-1171: update transport ssl wrapper to ensure attempt to pass all decoded bytes to the underlying input or throw, and avoid processing the underlying layer when no bytes have been passed on This closes #73 > [proton-j] transport SSL wrapper does not flush all decoded bytes to the > underlying input > - > > Key: PROTON-1171 > URL: https://issues.apache.org/jira/browse/PROTON-1171 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.12.0, 0.12.1 > Environment: Any >Reporter: Sreeram Garlapati >Assignee: Robbie Gemmell >Priority: Critical > Fix For: 0.13.0, 0.12.2 > > > Actual Issue/scenario hit by Microsoft Azure EventHubs: > We have a pattern where customers sends messages in a burst to our Queue and > stop sending and then wait for all of them to be received. > Because of this issue in Proton-j Amqp implementation - we can see many bytes > were stuck in the SSL Decode Buffer and were only picked up when new > transport frames arrive. > Given that this is a 1 line fix - it would be great if you folks can publish > an incremental minor update to 0.12.X. > Here are my findings after debugging through this issue: > - When incoming bytes arrive on the SocketChannel – proton-j client > gets signaled by nio & as a result it unwinds the transport stack – as a > result all the TransportInput implementations performs its task on the Read > Bytes and hands off to the Next Layer in the stack (transport to ssl, ssl to > frameparser etc). > - While unwinding that stack, SimpleSSLTransportWrapper.unwrapInput > reads(16k bytes) from _inputBuffer and the result - decoded bytes are written > to _decodedInputBuffer – as an intermediate buffer. > - It then flushes bytes from intermediate buffer to the next layer & > invokes an _underlyingInput.Process() – to signal it that it has bytes in its > input buffer. > - If the underlyingInput (lets say FrameParser) buffer size is small > – lets say 4k – then decodedInputBuffer will be left with 12k bytes & Over > time this accrues. > The fix here is to flush decodedInputBuffer to the Next transport in the > Network Stack & call _underlyingInput.Process() - until decodedInputBuffer is > empty. Here’s the pull request: > https://github.com/apache/qpid-proton/pull/73 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1133) Proton C includes port number in AMQP Open hostname
[
https://issues.apache.org/jira/browse/PROTON-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15237330#comment-15237330
]
ASF subversion and git services commented on PROTON-1133:
-
Commit 619c5c7ff6f155468f472b66a60021db72af8ecf in qpid-proton's branch
refs/heads/master from [~kgiusti]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=619c5c7 ]
PROTON-1133: Reactor should not use the connection hostname as a
transport address.
This patch introduces a new reactor API for setting the host address
for a connection created via the reactor. This API is intended to
replace the existing semantics where the connection's host address is
derived via the connection's hostname setting.
> Proton C includes port number in AMQP Open hostname
> ---
>
> Key: PROTON-1133
> URL: https://issues.apache.org/jira/browse/PROTON-1133
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c, python-binding
>Affects Versions: 0.12.0
>Reporter: Chuck Rolke
>Assignee: Ken Giusti
> Fix For: 0.13.0
>
>
> A command like:
> {noformat}
> qdmanage -b amqp://u1:password@photoserver:21000 --type policyStats query
> {noformat}
> sends the port number in the hostname field of the AMQP Open:
> {noformat}
> Mon Feb 8 11:37:46 2016 SERVER (trace) [2]:0 <- @open(16)
> [container-id="34e49947-b4df-4a01-9570-0a74e9e57b5b",
> hostname="photoserver:21000", channel-max=32767]
> (/home/chug/git/qpid-dispatch/src/server.c:75)
> {noformat}
> Built in C example code using Proton only does the same thing.
> This bug originally reported at
> https://issues.apache.org/jira/browse/DISPATCH-214
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-1173) Proton C core dump in face of channel-max protocol violation
[
https://issues.apache.org/jira/browse/PROTON-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235328#comment-15235328
]
ASF subversion and git services commented on PROTON-1173:
-
Commit 9d88f823c1951012888440501fdbe111f344518d in qpid-proton's branch
refs/heads/master from [~chug]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=9d88f82 ]
PROTON-1173: Close channel with error on channel-max violation
> Proton C core dump in face of channel-max protocol violation
>
>
> Key: PROTON-1173
> URL: https://issues.apache.org/jira/browse/PROTON-1173
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: 0.11.1
>Reporter: Chuck Rolke
>
> A rogue client creates a session on a channel higher than the channel-max
> exchanged at connection open.
> {noformat}
> Mon Apr 11 10:34:27 2016 SERVER (trace) [1]:pn_session: too many sessions: 1
> channel_max is 0 (/home/chug/git/qpid-dispatch/src/server.c:116)
> Program received signal SIGSEGV, Segmentation fault.
> 0x7793b84a in pn_do_begin (transport=0x6a4bd0, frame_type=0 '\000',
> channel=1, args=0x7c1f60, payload=0x7fffd2c0)
> at /home/chug/git/qpid-proton/proton-c/src/transport/transport.c:1205
> 1205ssn->state.incoming_transfer_count = next;
> Missing separate debuginfos, use: debuginfo-install
> nss-mdns-0.10-15.fc21.x86_64
> (gdb)
> (gdb) list
> 1200 // XXX: what if session is NULL?
> 1201 ssn = (pn_session_t *) pn_hash_get(transport->local_channels,
> remote_channel);
> 1202} else {
> 1203 ssn = pn_session(transport->connection);
> 1204}
> 1205ssn->state.incoming_transfer_count = next;
> 1206pni_map_remote_channel(ssn, channel);
> 1207PN_SET_REMOTE(ssn->endpoint.state, PN_REMOTE_ACTIVE);
> 1208pn_collector_put(transport->connection->collector, PN_OBJECT, ssn,
> PN_SESSION_REMOTE_OPEN);
> 1209return 0;
> (gdb) p ssn
> $1 = (pn_session_t *) 0x0
> (gdb)
> {noformat}
> Session is null and SEGV is what happens.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-1164) Update handlers to align with current proposal
[ https://issues.apache.org/jira/browse/PROTON-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231105#comment-15231105 ] ASF subversion and git services commented on PROTON-1164: - Commit 3ca3cb3b519c38b1da917449cc6545cc25714315 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3ca3cb3 ] PROTON-1164: [C++ binding] Add a container accessor to object hierarchy - This allows simple access to all layers of the object model from every object type that can bre passed to a handler > Update handlers to align with current proposal > -- > > Key: PROTON-1164 > URL: https://issues.apache.org/jira/browse/PROTON-1164 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The current event handler proposal includes the primary object that the event > is concerned with in the handler signature. This makes it more convenient to > process the event by giving the most likely object to be needed directly to > the handler without any other lookups. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231106#comment-15231106 ] ASF subversion and git services commented on PROTON-1153: - Commit ac5d3c6871fed288cec36f8a7d9473a14033dfe7 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ac5d3c6 ] PROTON-1153: [C++ binding] Remove all data members from proton_handler - It's now a pure interface - This does mean that you currently create more pn_handler_t structs than before, but they could be cached somewhere else. > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1164) Update handlers to align with current proposal
[ https://issues.apache.org/jira/browse/PROTON-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15231104#comment-15231104 ] ASF subversion and git services commented on PROTON-1164: - Commit edd8bc57b41f77752779110790a4399cc91eebd5 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=edd8bc5 ] PROTON-1164: [C++ binding] Remove the proton::event parameter from handler invocations - It was no longer needed as there is now always a parameter that gives you access to the object tree. - Consequently removed the proton::event interface and its implementation class proton::messaging_event - Fixed all the examples > Update handlers to align with current proposal > -- > > Key: PROTON-1164 > URL: https://issues.apache.org/jira/browse/PROTON-1164 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The current event handler proposal includes the primary object that the event > is concerned with in the handler signature. This makes it more convenient to > process the event by giving the most likely object to be needed directly to > the handler without any other lookups. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1135) [proton-c] dont pipeline SASL and OPEN frames for ANONYMOUS logins by default
[
https://issues.apache.org/jira/browse/PROTON-1135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228378#comment-15228378
]
ASF subversion and git services commented on PROTON-1135:
-
Commit 6738c16ffcb93981f1bb936b21e86515b1787f54 in qpid-proton's branch
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6738c16 ]
PROTON-1135: Do not pipeline SASL frames into AMQP frames from client side
- Test that we will accept pipelined frames though.
> [proton-c] dont pipeline SASL and OPEN frames for ANONYMOUS logins by default
> -
>
> Key: PROTON-1135
> URL: https://issues.apache.org/jira/browse/PROTON-1135
> Project: Qpid Proton
> Issue Type: Bug
> Components: proton-c
>Affects Versions: 0.12.0
>Reporter: Ganesh Murthy
>Assignee: Andrew Stitcher
>
> Dispatch router (which uses Proton-c) currently sends pipelined SASL and OPEN
> frames by default when connecting out to other peers using the ANONYMOUS
> mech, as shown in the following trace -
> {code}
> [0x7f41f80079c0]: -> SASL
> [0x7f41f80079c0]:0 -> @sasl-init(65) [mechanism=:ANONYMOUS,
> initial-response=b"anonymous@localhost.localdomain"]
> [0x7f41f80079c0]: -> AMQP
> [0x7f41f80079c0]:0 -> @open(16) [container-id="Qpid.Dispatch.Router.A",
> max-frame-size=65536, channel-max=32767, idle-time-out=8000,
> offered-capabilities=:"ANONYMOUS-RELAY",
> properties={:product="qpid-dispatch-router", :version="0.6.0"}]
> [0x7f41f80079c0]: <- SASL
> [0x7f41f80079c0]:0 <- @sasl-mechanisms(64) [sasl-server-mechanisms=:ANONYMOUS]
> [0x7f41f80079c0]:0 <- @sasl-outcome(68) [code=0]
> [0x7f41f80079c0]: <- AMQP
> [0x7f41f80079c0]:0 <- @open(16)
> [container-id="ce103199-af03-4d37-bb35-24ad4e55653e", channel-max=32767,
> idle-time-out=8000, offered-capabilities=@PN_SYMBOL[:"ANONYMOUS-RELAY"],
> properties={:product="qpid-cpp", :version="0.35", :platform="Linux",
> :host="localhost.localdomain"}]
> {code}
> The AMQP 1.0 spec does not make it clear that this is supported (e.g. see
> diagram below) but in any case various components have shown difficulty with
> it (such as PROTON-1135 just raised, and QPID-6639 which has yet to be
> included in a release but permitted the above protocol trace log).
> {code}
> TCP Client TCP Server
> =
> AMQP%d3.1.0.0 ->
> <- AMQP%d3.1.0.0
> :
> :
>
> :
> :
> AMQP%d0.1.0.0 ->
> (over SASL secured connection)
> <- AMQP%d0.1.0.0
> open ->
> <- open
> {code}
> Proton should by default disable sending pipelined OPEN frames for ANONYMOUS
> logins, to aid compatibility with other components that don't expect/handle
> such behaviour.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219039#comment-15219039 ] ASF subversion and git services commented on PROTON-1153: - Commit c7dff22d4d4ab05ffd7f6375bfa64222fc148a05 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c7dff22 ] PROTON-1153, PROTON-1153: [C++ binding] Align code with API doc - Remove sender/receiver/session member functions no longer needed - Removed sasl member functions not needed - Made private some sasl member functions that shouldn't be exposed to API - Made condition and sasl object not user creatable or copyable > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15219040#comment-15219040 ] ASF subversion and git services commented on PROTON-1153: - Commit c7dff22d4d4ab05ffd7f6375bfa64222fc148a05 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c7dff22 ] PROTON-1153, PROTON-1153: [C++ binding] Align code with API doc - Remove sender/receiver/session member functions no longer needed - Removed sasl member functions not needed - Made private some sasl member functions that shouldn't be exposed to API - Made condition and sasl object not user creatable or copyable > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1164) Update handlers to align with current proposal
[ https://issues.apache.org/jira/browse/PROTON-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210758#comment-15210758 ] ASF subversion and git services commented on PROTON-1164: - Commit 45390a9c526b9f7cefdcb6344aabdac2595488bb in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=45390a9 ] PROTON-1164: [C++ binding] Remove now unnecessary message menber of proton::event - We don't need to carry this in the event anymore as it is passed directly into the handler > Update handlers to align with current proposal > -- > > Key: PROTON-1164 > URL: https://issues.apache.org/jira/browse/PROTON-1164 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The current event handler proposal includes the primary object that the event > is concerned with in the handler signature. This makes it more convenient to > process the event by giving the most likely object to be needed directly to > the handler without any other lookups. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1164) Update handlers to align with current proposal
[ https://issues.apache.org/jira/browse/PROTON-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210593#comment-15210593 ] ASF subversion and git services commented on PROTON-1164: - Commit 6713bd5adef87efa5d1c213aacf9162692ff4331 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6713bd5 ] PROTON-1164: [C++ binding] Change on_message(event&, message&) - To on_message(event&, delivery&, message&) - Also simplify other delivery handlers by adding session(), connection() accessors > Update handlers to align with current proposal > -- > > Key: PROTON-1164 > URL: https://issues.apache.org/jira/browse/PROTON-1164 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The current event handler proposal includes the primary object that the event > is concerned with in the handler signature. This makes it more convenient to > process the event by giving the most likely object to be needed directly to > the handler without any other lookups. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1164) Update handlers to align with current proposal
[ https://issues.apache.org/jira/browse/PROTON-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210295#comment-15210295 ] ASF subversion and git services commented on PROTON-1164: - Commit 70fe0758053cb69a8fd533546baeaa4403c4b373 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=70fe075 ] PROTON-1164: [C++ binding] Remove access to container from proton::event - This is not needed as container related events are passed a container directly > Update handlers to align with current proposal > -- > > Key: PROTON-1164 > URL: https://issues.apache.org/jira/browse/PROTON-1164 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The current event handler proposal includes the primary object that the event > is concerned with in the handler signature. This makes it more convenient to > process the event by giving the most likely object to be needed directly to > the handler without any other lookups. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1164) Update handlers to align with current proposal
[ https://issues.apache.org/jira/browse/PROTON-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210294#comment-15210294 ] ASF subversion and git services commented on PROTON-1164: - Commit d4ec34fc84276202c5220ad2565652025159f3bf in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d4ec34f ] PROTON-1164: [C++ binding] Change on_timer(event&) -> on_timer(event&, container&) > Update handlers to align with current proposal > -- > > Key: PROTON-1164 > URL: https://issues.apache.org/jira/browse/PROTON-1164 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The current event handler proposal includes the primary object that the event > is concerned with in the handler signature. This makes it more convenient to > process the event by giving the most likely object to be needed directly to > the handler without any other lookups. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1164) Update handlers to align with current proposal
[ https://issues.apache.org/jira/browse/PROTON-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210292#comment-15210292 ] ASF subversion and git services commented on PROTON-1164: - Commit 9bdea3b652b05e6cc01e60c0681411d2ab10a9b4 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=9bdea3b ] PROTON-1164: [C++ binding] Update handlers to split link events into receiver and sender events > Update handlers to align with current proposal > -- > > Key: PROTON-1164 > URL: https://issues.apache.org/jira/browse/PROTON-1164 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The current event handler proposal includes the primary object that the event > is concerned with in the handler signature. This makes it more convenient to > process the event by giving the most likely object to be needed directly to > the handler without any other lookups. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1164) Update handlers to align with current proposal
[ https://issues.apache.org/jira/browse/PROTON-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210291#comment-15210291 ] ASF subversion and git services commented on PROTON-1164: - Commit 3d522203cb9e1c3aad86158e63d358faddd7e5d2 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3d52220 ] PROTON-1164: [C++ binding] Update most event handler definitions to include relevant objects > Update handlers to align with current proposal > -- > > Key: PROTON-1164 > URL: https://issues.apache.org/jira/browse/PROTON-1164 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The current event handler proposal includes the primary object that the event > is concerned with in the handler signature. This makes it more convenient to > process the event by giving the most likely object to be needed directly to > the handler without any other lookups. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1164) Update handlers to align with current proposal
[ https://issues.apache.org/jira/browse/PROTON-1164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15210293#comment-15210293 ] ASF subversion and git services commented on PROTON-1164: - Commit 5c35609cc4613866c31e121deeb860266e9da8df in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5c35609 ] PROTON-1164: [C++ binding] Change on_start(event&) -> on_container_start(event&, container&) > Update handlers to align with current proposal > -- > > Key: PROTON-1164 > URL: https://issues.apache.org/jira/browse/PROTON-1164 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > The current event handler proposal includes the primary object that the event > is concerned with in the handler signature. This makes it more convenient to > process the event by giving the most likely object to be needed directly to > the handler without any other lookups. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1161) c++: better interface to connection_engine.
[ https://issues.apache.org/jira/browse/PROTON-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208955#comment-15208955 ] ASF subversion and git services commented on PROTON-1161: - Commit 222574ed95acaa4143ea3e2c2cd9e7abac9e1dd9 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=222574e ] PROTON-1161 - c++: better interface to connection_engine. More flexible connection_engine interface to support reactor and proactor patterns. Provides direct access to proton buffers for minimal copies in either case. connection_engine is now completely IO and thread neutral, it simply handles: bytes-in -> events as handler function calls -> bytes-out Moved connection_engine and related classes into the proton::io namespace. Cleaned up engine implementation, improved the unit tests. > c++: better interface to connection_engine. > --- > > Key: PROTON-1161 > URL: https://issues.apache.org/jira/browse/PROTON-1161 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.12.0 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: 0.13.0 > > > The connection_engine interface was over-simplified to support reactor-style > IO frameworks, and did not efficiently support proactor frameworks. > Change the API to support both with no copies imposed by the > connection_engine (allow read/write direct to/from proton buffers) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1161) c++: better interface to connection_engine.
[ https://issues.apache.org/jira/browse/PROTON-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208956#comment-15208956 ] ASF subversion and git services commented on PROTON-1161: - Commit 38a71ffe5fd34de17b14564d7f121bd9594c5e94 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=38a71ff ] PROTON-1161: c++: drop use of on_start by connection_engine. > c++: better interface to connection_engine. > --- > > Key: PROTON-1161 > URL: https://issues.apache.org/jira/browse/PROTON-1161 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.12.0 >Reporter: Alan Conway >Assignee: Alan Conway > Fix For: 0.13.0 > > > The connection_engine interface was over-simplified to support reactor-style > IO frameworks, and did not efficiently support proactor frameworks. > Change the API to support both with no copies imposed by the > connection_engine (allow read/write direct to/from proton buffers) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207972#comment-15207972 ] ASF subversion and git services commented on PROTON-1138: - Commit c63b2bea65f38b961a0f672a6cbb9a7de918c9e7 in qpid-proton's branch refs/heads/master from Clifford Jansen [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c63b2be ] PROTON-1138: C++ handler options, Visual Studio fix for f2ae27d > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205438#comment-15205438 ] ASF subversion and git services commented on PROTON-1138: - Commit f2ae27d7e7a09c016a89be59e93d5796e01cc725 in qpid-proton's branch refs/heads/master from Clifford Jansen [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f2ae27d ] PROTON-1138: handler options become link or connection options (https://reviews.apache.org/r/44927) > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1159) [C++ binding] Improvements and updates necessary for qpid-interop-test
[ https://issues.apache.org/jira/browse/PROTON-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204993#comment-15204993 ] ASF subversion and git services commented on PROTON-1159: - Commit 9e2649ac4f4996bbd84c217761fb506569cfd2a8 in qpid-proton's branch refs/heads/master from [~kpvdr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=9e2649a ] PROTON-1159: Fixed linage for proton::internal::print_hex() > [C++ binding] Improvements and updates necessary for qpid-interop-test > -- > > Key: PROTON-1159 > URL: https://issues.apache.org/jira/browse/PROTON-1159 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Kim van der Riet >Assignee: Kim van der Riet > > A number of changes, additions and improvements which simplify the use of the > binding on qpid-interop-test (an interop test for AMQP clients). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1159) [C++ binding] Improvements and updates necessary for qpid-interop-test
[ https://issues.apache.org/jira/browse/PROTON-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204992#comment-15204992 ] ASF subversion and git services commented on PROTON-1159: - Commit caf4f8a16c137b8bb16a6d1fdbe51b9042d33293 in qpid-proton's branch refs/heads/master from [~kpvdr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=caf4f8a ] PROTON-1159: Some improvements for qpid-interop-test: Added operator<<() to byte_array and decimal classes. Fixed UUID print bug. > [C++ binding] Improvements and updates necessary for qpid-interop-test > -- > > Key: PROTON-1159 > URL: https://issues.apache.org/jira/browse/PROTON-1159 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Kim van der Riet >Assignee: Kim van der Riet > > A number of changes, additions and improvements which simplify the use of the > binding on qpid-interop-test (an interop test for AMQP clients). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1159) [C++ binding] Improvements and updates necessary for qpid-interop-test
[ https://issues.apache.org/jira/browse/PROTON-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204978#comment-15204978 ] ASF subversion and git services commented on PROTON-1159: - Commit 1b1503c128e32f9e8c4bdca7e18980dd856d46ea in qpid-proton's branch refs/heads/kvdr-PROTON-1159 from [~kpvdr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1b1503c ] PROTON-1159: Fixed linage for proton::internal::print_hex() > [C++ binding] Improvements and updates necessary for qpid-interop-test > -- > > Key: PROTON-1159 > URL: https://issues.apache.org/jira/browse/PROTON-1159 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Kim van der Riet >Assignee: Kim van der Riet > > A number of changes, additions and improvements which simplify the use of the > binding on qpid-interop-test (an interop test for AMQP clients). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202005#comment-15202005 ] ASF subversion and git services commented on PROTON-1153: - Commit 045768b4171c5f0f9129669a57ed9e9ca72c88fc in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=045768b ] PROTON-1153: [C++ binding] Stop exporting symbols for overridable handler virtuals > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202236#comment-15202236 ] ASF subversion and git services commented on PROTON-1153: - Commit 2390f77ecd0e6cc04b347daceaff98865c8b8883 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=2390f77 ] Revert "PROTON-1153: [C++ binding] Stop exporting symbols for overridable handler virtuals" This seems to break the Visual Studio build (not sure why, reverting whilst I investigate) This reverts commit 045768b4171c5f0f9129669a57ed9e9ca72c88fc. > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199725#comment-15199725 ] ASF subversion and git services commented on PROTON-1138: - Commit d70dab5df243f3a595be21a436f1ef46fa8d8c6d in qpid-proton's branch refs/heads/kvdr-PROTON-1159 from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d70dab5 ] PROTON-1138: c++: get<>/coerce<> API and documentation. Consistent get/coerce templates for proton::value, scalar, message_id and annotation_key. get - get the value, throw conversion_error if type is not exactly T. coerce - coerce the value to T if it is std::is_convertible, else throw conversion_error - documentation page on C++/AMQP type conversion - API doc for all types involved. - cleanup/hide some internals. > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1159) [C++ binding] Improvements and updates necessary for qpid-interop-test
[ https://issues.apache.org/jira/browse/PROTON-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200210#comment-15200210 ] ASF subversion and git services commented on PROTON-1159: - Commit 43cebe18b6aeeedc5dfedf47d30a5383f16887e3 in qpid-proton's branch refs/heads/kvdr-PROTON-1159 from [~kpvdr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=43cebe1 ] PROTON-1159: Some improvements for qpid-interop-test: Added operator<<() to byte_array and decimal classes. Fixed UUID print bug. > [C++ binding] Improvements and updates necessary for qpid-interop-test > -- > > Key: PROTON-1159 > URL: https://issues.apache.org/jira/browse/PROTON-1159 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Kim van der Riet >Assignee: Kim van der Riet > > A number of changes, additions and improvements which simplify the use of the > binding on qpid-interop-test (an interop test for AMQP clients). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1159) [C++ binding] Improvements and updates necessary for qpid-interop-test
[ https://issues.apache.org/jira/browse/PROTON-1159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199726#comment-15199726 ] ASF subversion and git services commented on PROTON-1159: - Commit e15bcdd097f5db718a0ca8204e734ad5727787f2 in qpid-proton's branch refs/heads/kvdr-PROTON-1159 from [~kpvdr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e15bcdd ] PROTON-1159: Merge with trunk > [C++ binding] Improvements and updates necessary for qpid-interop-test > -- > > Key: PROTON-1159 > URL: https://issues.apache.org/jira/browse/PROTON-1159 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Kim van der Riet >Assignee: Kim van der Riet > > A number of changes, additions and improvements which simplify the use of the > binding on qpid-interop-test (an interop test for AMQP clients). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15198149#comment-15198149 ] ASF subversion and git services commented on PROTON-1138: - Commit d70dab5df243f3a595be21a436f1ef46fa8d8c6d in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d70dab5 ] PROTON-1138: c++: get<>/coerce<> API and documentation. Consistent get/coerce templates for proton::value, scalar, message_id and annotation_key. get - get the value, throw conversion_error if type is not exactly T. coerce - coerce the value to T if it is std::is_convertible, else throw conversion_error - documentation page on C++/AMQP type conversion - API doc for all types involved. - cleanup/hide some internals. > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191534#comment-15191534 ] ASF subversion and git services commented on PROTON-1138: - Commit a2eb5f0f21fe88feca9e0f461b06ee42bc4f358c in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=a2eb5f0 ] PROTON-1138: c++: Add support for AMQP null type. > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1158) [proton-c] Some messenger SSL tests use hardcoded port number 12345
[
https://issues.apache.org/jira/browse/PROTON-1158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190067#comment-15190067
]
ASF subversion and git services commented on PROTON-1158:
-
Commit fd2119770102c4d7b18cb8003e3474148587f9ce in qpid-proton's branch
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=fd21197 ]
PROTON-1158 - Removed hardcoded port 12345 from MessengerSSLTests. Used
free_tcp_ports() instead
> [proton-c] Some messenger SSL tests use hardcoded port number 12345
> ---
>
> Key: PROTON-1158
> URL: https://issues.apache.org/jira/browse/PROTON-1158
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: 0.12.0
>Reporter: Ganesh Murthy
>Assignee: Ganesh Murthy
>Priority: Minor
>
> A couple of tests in the MessengerSSLTests (in
> tests/python/proton_tests/ssl.py) hard code the port numbers as 12345
> {code}
> def test_server_credentials(self,
> cert="server-certificate.pem",
> key="server-private-key.pem",
> password="server-password",
> exception=None):
> import sys
> # java doesn't do validation in the same way (yet)
> if exception and "java" in sys.platform:
> raise Skipped()
> self.server.certificate = _testpath(cert)
> self.server.private_key = _testpath(key)
> self.server.password = password
> try:
> self.server.start()
> self.server.subscribe("amqps://~0.0.0.0:12345")
> if exception is not None:
> assert False, "expected failure did not occur"
> except MessengerException:
> e = sys.exc_info()[1]
> if exception:
> assert exception in str(e), str(e)
> else:
> raise e
> {code}
> Hard coding the port sometimes leads to errors if port 12345 is already
> bound.
> {code}
> File "./tests/python/proton-test", line 362, in run
> phase()
> File
> "
> line 992, in test_client_credentials
> self.server.subscribe("amqps://~0.0.0.0:12345")
> File
> "
> line 496, in subscribe
> self._check(pn_error_code(pn_messenger_error(self._mng)))
> File
> "
> line 300, in _check
> raise exc("[%s]: %s" % (err,
> pn_error_text(pn_messenger_error(self._mng
> MessengerException: [-2]: CONNECTION ERROR (0.0.0.0:12345): bind: errno: 98
> proton_tests.ssl.MessengerSSLTests.test_client_credentials_bad_cert . fail
> {code}
> Remove all occurrences of hard coded ports in MessengerSSLTests
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-1157) Reactor sends messages in the clear if ssl is requested by not available.
[ https://issues.apache.org/jira/browse/PROTON-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188059#comment-15188059 ] ASF subversion and git services commented on PROTON-1157: - Commit a0585851e1e8ed9678496e38278f4a7554d03636 in qpid-proton's branch refs/heads/master from [~kgiusti] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=a058585 ] PROTON-1157: fail if amqps: scheme is specified but SSL is not available > Reactor sends messages in the clear if ssl is requested by not available. > - > > Key: PROTON-1157 > URL: https://issues.apache.org/jira/browse/PROTON-1157 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: 0.12.0 >Reporter: Ken Giusti >Assignee: Gordon Sim >Priority: Blocker > Fix For: 0.13.0 > > > See > https://github.com/apache/qpid-proton/blob/master/proton-c/bindings/python/proton/reactor.py#L529 > If 'amqps:' is specified and the SSL libraries are not available the client > will use an unsecured connection instead. This is done silently so the user > is not aware of the security violation. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1155) [proton-c] Add allowed_mechs to BlockingConnection constructor
[
https://issues.apache.org/jira/browse/PROTON-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15187378#comment-15187378
]
ASF subversion and git services commented on PROTON-1155:
-
Commit 747ee17215d520b862c81ed4d15949e96da5a6a2 in qpid-proton's branch
refs/heads/master from [~ganeshmurthy]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=747ee17 ]
PROTON-1155 - Modified BlockingConnection to pass **kwargs to the
container.connect call
> [proton-c] Add allowed_mechs to BlockingConnection constructor
> --
>
> Key: PROTON-1155
> URL: https://issues.apache.org/jira/browse/PROTON-1155
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: 0.12.0
>Reporter: Ganesh Murthy
>Priority: Minor
>
> In the Proton Python binding, currently there is no way to pass in
> allowed_mechs to BlockingConnection's constructor
> BlockingConnection's constructor should take in an allowed_mechs parameter.
> The Container object has a connect function
> {code}
> def connect(self, url=None, urls=None, address=None, handler=None,
> reconnect=None, heartbeat=None, ssl_domain=None, **kwargs):
> {code}
> The above function already sets the allowed_mechs on the Connector
> {code}
> connector.allowed_mechs = kwargs.get('allowed_mechs', self.allowed_mechs)
> {code}
> So BlockingConnection just needs to pass in the allowed_mechs and the rest is
> take care of by the Container
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185134#comment-15185134 ] ASF subversion and git services commented on PROTON-1138: - Commit bdaf901a13b4d710b9db845b7c102e10c7d88778 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=bdaf901 ] PROTON-1138: c++: Enable implicit value conversion Enable implicit template conversion constructor for proton::value, with a compile-time enable_amqp_type template test to ensure it only matches C++ types that can be encoded as AMQP values. Messge constructor and body setter also use this test. Type traits is_encodable and is_decodable are true if the << or >> operators exist on the proton::encoder and proton::decoder. This means user-defined operators for custom type encodings are respected by value and message. Other notes: - encoder operator<< for value is a template to ensure exact match and avoid recursion via implicit conversion in is_encodable - Moved encoder, decoder, data into proton::internal namespace. - Cleaned up some friendships (more work to do) Make encoder/decoder operators members operators for built-in types (friend of class not free operator function.) > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15180339#comment-15180339 ] ASF subversion and git services commented on PROTON-1138: - Commit 1f4337c4a42fb765a341316dfba2ad544f5665fd in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1f4337c ] PROTON-1138: c++: Simplify find_links, find_sessions. Remove "mask" argument from find_links(), find_sessions(). Rename as just links() sessions(). Simplifies the API, the user can filter the returned endpoints by state to get the same functionality. > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1154) Travis CI failing due to valgrind problems
[ https://issues.apache.org/jira/browse/PROTON-1154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178583#comment-15178583 ] ASF subversion and git services commented on PROTON-1154: - Commit e978f0ecb50663230b8b13a8ee8edb4e3fba0a8f in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e978f0e ] PROTON-1154: Turn off valgrind for tests which fail Travis CI. - This should be reverted if we move to a different Travis environment or find another fix for this problem. > Travis CI failing due to valgrind problems > -- > > Key: PROTON-1154 > URL: https://issues.apache.org/jira/browse/PROTON-1154 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: 0.13.0 > Environment: Ubuntu 12.04 Travis CI test environment >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > > 2 of the tests in cpp_example_container_test (test_ssl & > test_ssl_client_cert) fail due to valgrind problems on the Travis CI 12.04 > build environment. > It looks like the issues are due to the specific environment on that > machine/that version of Ubuntu as other environments don't seem to fail these > tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178496#comment-15178496 ] ASF subversion and git services commented on PROTON-1153: - Commit 500f3597cea11fea461aa24d1232ac9f096f74c3 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=500f359 ] PROTON-1153: Settle on what() as name for printable condition summary. > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178373#comment-15178373 ] ASF subversion and git services commented on PROTON-1153: - Commit 5d106e15ccbc05677ca5edca38ae6db0837d13f8 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5d106e1 ] PROTON-1153: Fix VS 2010 dll export problem > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1151) [C++ binding] Move exposed implementation details into proton::internal namespace
[ https://issues.apache.org/jira/browse/PROTON-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15178072#comment-15178072 ] ASF subversion and git services commented on PROTON-1151: - Commit 0a45ed1f5e1a0d411080076b6d14e1ff8e6f7355 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=0a45ed1 ] PROTON-1151: Missed object -> internal::object change > [C++ binding] Move exposed implementation details into proton::internal > namespace > - > > Key: PROTON-1151 > URL: https://issues.apache.org/jira/browse/PROTON-1151 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-250) Add -fvisibility option when building shared libraries
[ https://issues.apache.org/jira/browse/PROTON-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177431#comment-15177431 ] ASF subversion and git services commented on PROTON-250: Commit 4d90acd6eeb254155aff07caf1aaef00f6338b5a in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=4d90acd ] PROTON-250: [C++ binding] Hide all exported library internal only symbols > Add -fvisibility option when building shared libraries > --- > > Key: PROTON-250 > URL: https://issues.apache.org/jira/browse/PROTON-250 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.3 > Environment: GNU Compiler >Reporter: Irina Boverman >Assignee: Andrew Stitcher >Priority: Minor > Labels: patch > Fix For: 0.13.0 > > Attachments: proton.patch > > > Add an option to "hide" symbols in shared libraries except when they are > declared public. > Extends efforts already in place for Windows builds. > Excludes an effort to determine what symbols should be considered "public" > interfaces. > The gcc 4 -fvisibility option is said to: > ...very substantially improve linking and load times of shared object > libraries, produce more optimized code, provide near-perfect API export and > prevent symbol clashes. It is strongly recommended that you use this in any > shared objects you distribute. > See here: http://gcc.gnu.org/wiki/Visibility > Attached patch (patch.txt) will build libqpid-proton.so shared library using > this flag. > It reduces number of symbols from 700+ to 500+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176349#comment-15176349 ] ASF subversion and git services commented on PROTON-1153: - Commit 1832e326900b2cffd9dac71040dd44468b55674c in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1832e32 ] PROTON-1153: [C++ binding] Finish renaming PN_... -> PN_CPP_... - Fix Windows compiler feature detection > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176318#comment-15176318 ] ASF subversion and git services commented on PROTON-1153: - Commit 2a8bc3c142c8543582ae56ca41ed5982018c6144 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=2a8bc3c ] PROTON-1153: [C++ binding] Clean up #defines - Rename the C++ binding defines to be PN_CPP_... > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1151) [C++ binding] Move exposed implementation details into proton::internal namespace
[ https://issues.apache.org/jira/browse/PROTON-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175811#comment-15175811 ] ASF subversion and git services commented on PROTON-1151: - Commit d79c23d1810c866ba6ffc93cb140413c5319009b in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d79c23d ] PROTON-1151: [C++ binding] Move pn_ptr and object into the proton::internal namespace. > [C++ binding] Move exposed implementation details into proton::internal > namespace > - > > Key: PROTON-1151 > URL: https://issues.apache.org/jira/browse/PROTON-1151 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175806#comment-15175806 ] ASF subversion and git services commented on PROTON-1153: - Commit e3e1d7da55b859f17935c5d3ad32ea826fed1294 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e3e1d7d ] PROTON-1153: [C++ binding] Tidy up proton::handler > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175807#comment-15175807 ] ASF subversion and git services commented on PROTON-1153: - Commit 3b62bf91b8fb12ec47f0062a8b0720e820555775 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3b62bf9 ] PROTON-1153: [C++ binding] Tidy up link - This involved some tidying up of delivery and message too > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175805#comment-15175805 ] ASF subversion and git services commented on PROTON-1153: - Commit f55a67be88208d315410e2c4a297dd4e597626eb in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f55a67b ] PROTON-1152, PROTON-1153: [C++ binding] Tidy up Header files API docs, and API - Make constructors for type wrapping proton-c types private as they are only to be used internally. - Allow default construction of the wrapper types so the use can declare a variable of the type that is not yet assigned. - Ensure that no private functions have exported symbols. - Small doc improvements > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1152) [C++ binding] Make sure non API details in classes are private
[ https://issues.apache.org/jira/browse/PROTON-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175804#comment-15175804 ] ASF subversion and git services commented on PROTON-1152: - Commit f55a67be88208d315410e2c4a297dd4e597626eb in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f55a67b ] PROTON-1152, PROTON-1153: [C++ binding] Tidy up Header files API docs, and API - Make constructors for type wrapping proton-c types private as they are only to be used internally. - Allow default construction of the wrapper types so the use can declare a variable of the type that is not yet assigned. - Ensure that no private functions have exported symbols. - Small doc improvements > [C++ binding] Make sure non API details in classes are private > -- > > Key: PROTON-1152 > URL: https://issues.apache.org/jira/browse/PROTON-1152 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175808#comment-15175808 ] ASF subversion and git services commented on PROTON-1153: - Commit d758832dd7341f786617502ace6cc0f0f08cc140 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d758832 ] PROTON-1153: [C+ binding] Made reactor an internal class - Moved header file from exported headers to internal source - Reworked reconnect_timer to not use reactor at all > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173871#comment-15173871 ] ASF subversion and git services commented on PROTON-1138: - Commit af64ead9dde90a47c3c3d93ed52c8885fc51e0e7 in qpid-proton's branch refs/heads/master from Clifford Jansen [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=af64ead ] PROTON-1138: clearer naming of SASL options; make private various implementation details > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15169197#comment-15169197 ] ASF subversion and git services commented on PROTON-1138: - Commit cd58e7774a8612ce70fe5f5f55dc9dfb15254723 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=cd58e77 ] PROTON-1138: C++ address review comments https://reviews.apache.org/r/43742/#review120777 > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168119#comment-15168119 ] ASF subversion and git services commented on PROTON-1138: - Commit 1de2f11f32bfa45ce0bad3b768b3d0f94aadb540 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1de2f11 ] PROTON-1138: c++: Extend_CXX_FLAGS in CMakeLists.txt, don't overwrite user setting. > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168122#comment-15168122 ] ASF subversion and git services commented on PROTON-1138: - Commit a0fa5ce2323179d04726243f20d71daa78cbbb81 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=a0fa5ce ] PROTON-1138: c++: Remove value_* types, add amqp:: typedefs. Consistently use either native C++ types or types defined in the proton:: namespace in the API. The proton::amqp namespace contains typedefs and documentation explaining the relationship between the AMQP type system and the C++/proton types. Its use is optional, a C++ programmer will most likely use the C++ types directly. However an AMQP programmer working in multiple languages may find it convenient to use the AMQP type names consistently across languages. > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168121#comment-15168121 ] ASF subversion and git services commented on PROTON-1138: - Commit 8cbde66258b1389c85fc467d5c0ed65301587250 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=8cbde66 ] PROTON-1138: c++: Clean up error types. Removed proton::closed_error Renamed proton::io_error as proton::connection_engine::io_error Replaced encode_error, decode_error and type_error with proton::conversion_error > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168117#comment-15168117 ] ASF subversion and git services commented on PROTON-1138: - Commit 71be1c6912ca77aa297492b019ee0ec0736f3546 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=71be1c6 ] PROTON-1138: c++: Add proton::uuid, proton::timestamp and proton::decimal types. - removed amqp_ prefixed uuid/timestamp/decimal types. - added proton::byte_array base class for fixed-size types with no C++ equivalent. - Got rid of public duration::milliseconds data member. - Gave duration and timestamp consistent accessors, constructors and operator= for milliseconds values. - Completed duration/timestamp arithmetic. NOTE: changed duration to use int64_t instead of uint64_t. Durations can be added and subtracted and negative durations can occur during calculations. Also AMQP timestamp is defined as signed so we should be consistent. UNIX time_t is traditionally unsigned because signed 32 bits is too small to express a useful time range after the epoch. 64 bit timestamps (and durations) do not require this restriction, signed timestamps can express time before and after epoch. > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168118#comment-15168118 ] ASF subversion and git services commented on PROTON-1138: - Commit c7f3f558511ed07b8972304a2ba7a69dfc6b6354 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=c7f3f55 ] PROTON-1138: Simplify comparable class, make comparable inheritance private. Simplified the comparable class. - comparable is a private empty base class that exists only to instantiate operator friends of T. - comparable is never used in any other way. - for any compiler with even rudimentary empty-base-class support, this has 0 run-time overhead. I did some research to try and eliminate inheritance entirely. There are 2 well known approaches. 1. boost::operators uses exactly the approach above. 2. std::rel_ops uses unconstrained templates that match anything with op == or < operator, we already agreed that approach is unsuitable for public API. I tried type-trait approaches but could not find one that was better than the above. IMO inheritance is the right fit: It has no run-time overhead, it is easy to understand, and we *want* "is-a" inheritance semantics: if `object` is comparable then sub-classes of `object` should be comparable. (That is the part that is hard to achieve with type-traits. When I realized I was trying to reinvent inheritance I decided to let go.) > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15168120#comment-15168120 ] ASF subversion and git services commented on PROTON-1138: - Commit 6e8570898998beea953628238c897989a0344ca1 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6e85708 ] PROTON-1138: c++: Make id_generator class private > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1147) Add OSGi bundle metadata to the proton-j jar manifest
[ https://issues.apache.org/jira/browse/PROTON-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163823#comment-15163823 ] ASF subversion and git services commented on PROTON-1147: - Commit ce2dfd5010b3dba21b95be59f6ed0439ee54611e in qpid-proton's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ce2dfd5 ] PROTON-1147 Use the maven-bundle-plugin to embed osgi metadata in the module manifest. > Add OSGi bundle metadata to the proton-j jar manifest > -- > > Key: PROTON-1147 > URL: https://issues.apache.org/jira/browse/PROTON-1147 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Timothy Bish >Assignee: Timothy Bish > Fix For: 0.13.0 > > > Add OSGi bundle metadata to the proton-j module using the maven BND plugin. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1146) [proton-j] fixes for issues identified by Coverity
[ https://issues.apache.org/jira/browse/PROTON-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163395#comment-15163395 ] ASF subversion and git services commented on PROTON-1146: - Commit 316e34d44a03ba318012d92f57e2f9beb20a53c9 in qpid-proton's branch refs/heads/master from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=316e34d ] PROTON-1146: misc coverity(/findbugs) fixes, and cleanups noticed along the way > [proton-j] fixes for issues identified by Coverity > -- > > Key: PROTON-1146 > URL: https://issues.apache.org/jira/browse/PROTON-1146 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 0.13.0 > > > Holder for small fixes/improvements identified by Coverity -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1146) [proton-j] fixes for issues identified by Coverity
[ https://issues.apache.org/jira/browse/PROTON-1146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163396#comment-15163396 ] ASF subversion and git services commented on PROTON-1146: - Commit 802fb209b72637b3d6ad20a2f7fcb9b8a11fa9db in qpid-proton's branch refs/heads/master from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=802fb20 ] PROTON-1146: mark various inner classes as static > [proton-j] fixes for issues identified by Coverity > -- > > Key: PROTON-1146 > URL: https://issues.apache.org/jira/browse/PROTON-1146 > Project: Qpid Proton > Issue Type: Bug > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Robbie Gemmell >Assignee: Robbie Gemmell >Priority: Minor > Fix For: 0.13.0 > > > Holder for small fixes/improvements identified by Coverity -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1145) Move the python shim code to the test module where it is used.
[ https://issues.apache.org/jira/browse/PROTON-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163364#comment-15163364 ] ASF subversion and git services commented on PROTON-1145: - Commit 482012b9c8f6cac48b3c95196ddbc879c3d0fb94 in qpid-proton's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=482012b ] PROTON-1145 move the python shim code from proton-j into the tests module where it is used. > Move the python shim code to the test module where it is used. > -- > > Key: PROTON-1145 > URL: https://issues.apache.org/jira/browse/PROTON-1145 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Timothy Bish >Assignee: Timothy Bish > Fix For: 0.13.0 > > > The proton-j project embeds the python binding code used in the tests module > which can result in breakages when other maven tooling attempts to > interoperate with the proton-j jar. Since the shim code is only currently > used in the tests module we should relocate it there. If there is some > demand to have have these python modules available outside the test module we > could create a new proton-j-bindings module that produces a jar with only > those files inside. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1141) Update JUnit Dependency and fix some warnings in the tests.
[ https://issues.apache.org/jira/browse/PROTON-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159427#comment-15159427 ] ASF subversion and git services commented on PROTON-1141: - Commit ff64a31605b32b2feb569a09b11a3ef43ba8a3b4 in qpid-proton's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ff64a31 ] PROTON-1141 fix some more tests that use deprecated assertions. > Update JUnit Dependency and fix some warnings in the tests. > --- > > Key: PROTON-1141 > URL: https://issues.apache.org/jira/browse/PROTON-1141 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Timothy Bish >Assignee: Timothy Bish > Fix For: 0.13.0 > > > Update to the latest JUnit dependency and fix some use of deprecated JUnit > assertions in the tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1050) 0.12.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158838#comment-15158838 ] ASF subversion and git services commented on PROTON-1050: - Commit f438f83d3d990dcf9f8b30ea3841ab7c7ab3dc79 in qpid-proton's branch refs/heads/0.12.x from Robert Gemmell [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f438f83 ] PROTON-1050: bump versions on 0.12.x branch to 0.12.1-SNAPSHOT now that 0.12.0 is release > 0.12.0 release tasks > > > Key: PROTON-1050 > URL: https://issues.apache.org/jira/browse/PROTON-1050 > Project: Qpid Proton > Issue Type: Task > Components: release >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.12.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1143) Bump Minimum version of CMake to 2.8.7
[ https://issues.apache.org/jira/browse/PROTON-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158320#comment-15158320 ] ASF subversion and git services commented on PROTON-1143: - Commit 36059eba2cfe0135dacd8dbd11371f041239fdc9 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=36059eb ] PROTON-1143: CMake minimum version now 2.8.7 - Remove some old cruft > Bump Minimum version of CMake to 2.8.7 > -- > > Key: PROTON-1143 > URL: https://issues.apache.org/jira/browse/PROTON-1143 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > Fix For: 0.13.0 > > > As discussed in: > http://qpid.2158936.n2.nabble.com/Dropping-proton-dump-Moving-to-newer-minimum-CMake-version-td7638474.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1142) Remove proton-dump executable
[ https://issues.apache.org/jira/browse/PROTON-1142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158319#comment-15158319 ] ASF subversion and git services commented on PROTON-1142: - Commit 1bfc05e4c15ae4c39ebcb807b95a0cd987f90a8f in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1bfc05e ] PROTON-1142: Remove proton-dump > Remove proton-dump executable > - > > Key: PROTON-1142 > URL: https://issues.apache.org/jira/browse/PROTON-1142 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.12.0 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > Fix For: 0.13.0 > > > Remove the old and creaky proton-dump executable. > As discussed in: > http://qpid.2158936.n2.nabble.com/Dropping-proton-dump-Moving-to-newer-minimum-CMake-version-td7638474.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1143) Bump Minimum version of CMake to 2.8.7
[ https://issues.apache.org/jira/browse/PROTON-1143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158321#comment-15158321 ] ASF subversion and git services commented on PROTON-1143: - Commit 26553f0123bed0cd5997eafc516a0116552da9d5 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=26553f0 ] PROTON-1143: Simplified some of the CMake system with 2.8.7 features > Bump Minimum version of CMake to 2.8.7 > -- > > Key: PROTON-1143 > URL: https://issues.apache.org/jira/browse/PROTON-1143 > Project: Qpid Proton > Issue Type: Improvement >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > Fix For: 0.13.0 > > > As discussed in: > http://qpid.2158936.n2.nabble.com/Dropping-proton-dump-Moving-to-newer-minimum-CMake-version-td7638474.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1144) IPv6 addresses could be truncated by the accept code
[ https://issues.apache.org/jira/browse/PROTON-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158318#comment-15158318 ] ASF subversion and git services commented on PROTON-1144: - Commit a22e6c77d8f7a14abe97f344e25282ebced128cd in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=a22e6c7 ] PROTON-1144: Fixed some socket level issues: - Fixed very strange unecessary lookup of protocol "tcp" - Fixed accepting IPv6 addresses (would have been truncated before) > IPv6 addresses could be truncated by the accept code > > > Key: PROTON-1144 > URL: https://issues.apache.org/jira/browse/PROTON-1144 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding, proton-c >Affects Versions: 0.12.0 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-405) [proton-c] Windows install fails to find proton-api.jar file
[ https://issues.apache.org/jira/browse/PROTON-405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15158298#comment-15158298 ] ASF subversion and git services commented on PROTON-405: Commit 1640d20d9b03e97ff2b23aba00773f5d873f873a in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1640d20 ] PROTON-405: Allow Java install not to fail if symlink file is missing - This allows the Windows Java Install to succeed - This is a bit nasty as it just hacks our copy of UseJava.cmake > [proton-c] Windows install fails to find proton-api.jar file > > > Key: PROTON-405 > URL: https://issues.apache.org/jira/browse/PROTON-405 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.4 > Environment: Windows install >Reporter: Chuck Rolke > Labels: windows > > The install script is looking for file > 4> CMake Error at proton-j/proton-api/cmake_install.cmake:31 (FILE): > 4>file INSTALL cannot find > 4>"D:/Users/crolke/svn/proton/build/proton-j/proton-api/proton-api.jar". > but the actual file is versioned > Directory of D:\Users\chug\svn\proton\build\proton-j\proton-api > 08/17/2013 10:04 AM 120,690 proton-api-0.5.jar -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1141) Update JUnit Dependency and fix some warnings in the tests.
[ https://issues.apache.org/jira/browse/PROTON-1141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157844#comment-15157844 ] ASF subversion and git services commented on PROTON-1141: - Commit 6c09f1c9fbf1603fe729e53874a6825e3290fcaf in qpid-proton's branch refs/heads/master from [~tabish121] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=6c09f1c ] PROTON-1141 Update to JUnit 4.12 and fix some tests that use deprecated assertions. > Update JUnit Dependency and fix some warnings in the tests. > --- > > Key: PROTON-1141 > URL: https://issues.apache.org/jira/browse/PROTON-1141 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-j >Affects Versions: 0.12.0 >Reporter: Timothy Bish >Assignee: Timothy Bish > Fix For: 0.13.0 > > > Update to the latest JUnit dependency and fix some use of deprecated JUnit > assertions in the tests. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1139) tx_recv_interactive.py example doesn't work
[ https://issues.apache.org/jira/browse/PROTON-1139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154970#comment-15154970 ] ASF subversion and git services commented on PROTON-1139: - Commit 55d9f82fea5e55ce986d570f50258a0dc41e in qpid-proton's branch refs/heads/master from [~scholzj] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=55d9f82 ] PROTON-1139 using selectable() instead of get_event_trigger() > tx_recv_interactive.py example doesn't work > --- > > Key: PROTON-1139 > URL: https://issues.apache.org/jira/browse/PROTON-1139 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: 0.12.0 >Reporter: Jakub Scholz >Priority: Minor > > It looks like the tx_recv_interactive.py example doesn't work anymore, > because the get_event_trigger method no longer exists. > $ ./tx_recv_interactive.py > Traceback (most recent call last): > File "./tx_recv_interactive.py", line 70, in > events = reactor.get_event_trigger() > File "/usr/lib64/python2.7/site-packages/proton/wrapper.py", line 69, in > __getattr__ > raise AttributeError(name + " not in _attrs") > AttributeError: get_event_trigger not in _attrs > It looks like it should be replaced by the selectable method and > EventInjector object. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1138) Assorted C++ API cleanups
[ https://issues.apache.org/jira/browse/PROTON-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150842#comment-15150842 ] ASF subversion and git services commented on PROTON-1138: - Commit 45d59f7627670f7f7db204de6d13a9ec6cfc09b8 in qpid-proton's branch refs/heads/master from [~jr...@redhat.com] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=45d59f7 ] PROTON-1138: Capture and update header comments from review; some minor formatting adjustments > Assorted C++ API cleanups > - > > Key: PROTON-1138 > URL: https://issues.apache.org/jira/browse/PROTON-1138 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.13.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-515) Port to OpenVMS
[ https://issues.apache.org/jira/browse/PROTON-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149028#comment-15149028 ] ASF subversion and git services commented on PROTON-515: Commit 603c0e725682fc05941d91d2b92529c782136e21 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=603c0e7 ] PROTON-515: Fixed hand built swig python binding code to build with C89 - We now have to build the SWIG generated code with C not C++. > Port to OpenVMS > --- > > Key: PROTON-515 > URL: https://issues.apache.org/jira/browse/PROTON-515 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.11.1 > Environment: OpenVMS >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: OpenVMS, patch > Attachments: > 0001-PROTON-515-Change-pn_handle_t-to-be-void-to-get-arou.patch, io.c.patch, > object.h.patch > > > There is a need for proton-c port to OpenVMS platform. > To make proton-c functional on OpenVMS few changes in the source code are > required. > Here is list of files I have identified which require some attention: > proton-c/src/platform_fmt.h > proton-c/src/posix/driver.c > proton-c/src/object/object.c > proton-c/src/codec/codec.c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-515) Port to OpenVMS
[ https://issues.apache.org/jira/browse/PROTON-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147836#comment-15147836 ] ASF subversion and git services commented on PROTON-515: Commit de94b253ad7b5f212973244968fedad043de8402 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=de94b25 ] PROTON-515: Change pn_handle_t to be void* to get around limitations in OpenVMS linker > Port to OpenVMS > --- > > Key: PROTON-515 > URL: https://issues.apache.org/jira/browse/PROTON-515 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.11.1 > Environment: OpenVMS >Reporter: Tomas Soltys >Assignee: Andrew Stitcher > Labels: OpenVMS, patch > Attachments: > 0001-PROTON-515-Change-pn_handle_t-to-be-void-to-get-arou.patch, io.c.patch, > object.h.patch > > > There is a need for proton-c port to OpenVMS platform. > To make proton-c functional on OpenVMS few changes in the source code are > required. > Here is list of files I have identified which require some attention: > proton-c/src/platform_fmt.h > proton-c/src/posix/driver.c > proton-c/src/object/object.c > proton-c/src/codec/codec.c -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-988) pn_messenger_set_flags does not support new SASL flag correctly
[ https://issues.apache.org/jira/browse/PROTON-988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147816#comment-15147816 ] ASF subversion and git services commented on PROTON-988: Commit f77163529d8b29d459ee8d1948b8ad829f63a545 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f771635 ] PROTON-988: Make pn_messenger_set_flags() work correctly > pn_messenger_set_flags does not support new SASL flag correctly > --- > > Key: PROTON-988 > URL: https://issues.apache.org/jira/browse/PROTON-988 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 > Environment: All OS >Reporter: Clemens Vasters >Assignee: Andrew Stitcher > Labels: messenger > > The new flag PN_FLAGS_ALLOW_INSECURE_MECHS cannot be set though > pn_messenger_set_flags. > Setting the other defined flag, PN_FLAGS_CHECK_ROUTES, causes the preset > PN_FLAGS_ALLOW_INSECURE_MECHS to be irrecoverably overridden. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-250) Add -fvisibility option when building shared libraries
[ https://issues.apache.org/jira/browse/PROTON-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147755#comment-15147755 ] ASF subversion and git services commented on PROTON-250: Commit 525fad994b2610f9d1c6ee92dddc419cd5c2d180 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=525fad9 ] PROTON-250: [C++ binding] Hide symbol visibility - Make necessary C++ symbols visible > Add -fvisibility option when building shared libraries > --- > > Key: PROTON-250 > URL: https://issues.apache.org/jira/browse/PROTON-250 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.3 > Environment: GNU Compiler >Reporter: Irina Boverman >Assignee: Andrew Stitcher >Priority: Minor > Labels: patch > Attachments: proton.patch > > > Add an option to "hide" symbols in shared libraries except when they are > declared public. > Extends efforts already in place for Windows builds. > Excludes an effort to determine what symbols should be considered "public" > interfaces. > The gcc 4 -fvisibility option is said to: > ...very substantially improve linking and load times of shared object > libraries, produce more optimized code, provide near-perfect API export and > prevent symbol clashes. It is strongly recommended that you use this in any > shared objects you distribute. > See here: http://gcc.gnu.org/wiki/Visibility > Attached patch (patch.txt) will build libqpid-proton.so shared library using > this flag. > It reduces number of symbols from 700+ to 500+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-250) Add -fvisibility option when building shared libraries
[ https://issues.apache.org/jira/browse/PROTON-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147757#comment-15147757 ] ASF subversion and git services commented on PROTON-250: Commit ca433506c346f088077bb786d5544e419b210cf7 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ca43350 ] PROTON-250: Adjust proton-dump to keep on compiling: - It uses proton-c internals so some files from proton are compiled explicitly with proton-dump. Perhaps making a static proton would be a better solution. - Do the trivial arglist scanning manually instead of using getopt - Fix a change in include path missed in the test tools. > Add -fvisibility option when building shared libraries > --- > > Key: PROTON-250 > URL: https://issues.apache.org/jira/browse/PROTON-250 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.3 > Environment: GNU Compiler >Reporter: Irina Boverman >Assignee: Andrew Stitcher >Priority: Minor > Labels: patch > Attachments: proton.patch > > > Add an option to "hide" symbols in shared libraries except when they are > declared public. > Extends efforts already in place for Windows builds. > Excludes an effort to determine what symbols should be considered "public" > interfaces. > The gcc 4 -fvisibility option is said to: > ...very substantially improve linking and load times of shared object > libraries, produce more optimized code, provide near-perfect API export and > prevent symbol clashes. It is strongly recommended that you use this in any > shared objects you distribute. > See here: http://gcc.gnu.org/wiki/Visibility > Attached patch (patch.txt) will build libqpid-proton.so shared library using > this flag. > It reduces number of symbols from 700+ to 500+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-250) Add -fvisibility option when building shared libraries
[ https://issues.apache.org/jira/browse/PROTON-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147756#comment-15147756 ] ASF subversion and git services commented on PROTON-250: Commit 874d85b2d6ec53e4ca9e75c3018862f84cf18300 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=874d85b ] PROTON-250: Fix misc symbol visibility issues: - Hide all library internal only symbols - Make log.h export only unmangled C symbols > Add -fvisibility option when building shared libraries > --- > > Key: PROTON-250 > URL: https://issues.apache.org/jira/browse/PROTON-250 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.3 > Environment: GNU Compiler >Reporter: Irina Boverman >Assignee: Andrew Stitcher >Priority: Minor > Labels: patch > Attachments: proton.patch > > > Add an option to "hide" symbols in shared libraries except when they are > declared public. > Extends efforts already in place for Windows builds. > Excludes an effort to determine what symbols should be considered "public" > interfaces. > The gcc 4 -fvisibility option is said to: > ...very substantially improve linking and load times of shared object > libraries, produce more optimized code, provide near-perfect API export and > prevent symbol clashes. It is strongly recommended that you use this in any > shared objects you distribute. > See here: http://gcc.gnu.org/wiki/Visibility > Attached patch (patch.txt) will build libqpid-proton.so shared library using > this flag. > It reduces number of symbols from 700+ to 500+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-250) Add -fvisibility option when building shared libraries
[ https://issues.apache.org/jira/browse/PROTON-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147754#comment-15147754 ] ASF subversion and git services commented on PROTON-250: Commit 0576b607e16292bd963997420323ebebb35ce3a6 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=0576b60 ] PROTON-250: [C] Hide symbol visibility on Linux too (as well as Windows) - Also allow link time optimisation (lto) (but initially default is disabled) > Add -fvisibility option when building shared libraries > --- > > Key: PROTON-250 > URL: https://issues.apache.org/jira/browse/PROTON-250 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.3 > Environment: GNU Compiler >Reporter: Irina Boverman >Assignee: Andrew Stitcher >Priority: Minor > Labels: patch > Attachments: proton.patch > > > Add an option to "hide" symbols in shared libraries except when they are > declared public. > Extends efforts already in place for Windows builds. > Excludes an effort to determine what symbols should be considered "public" > interfaces. > The gcc 4 -fvisibility option is said to: > ...very substantially improve linking and load times of shared object > libraries, produce more optimized code, provide near-perfect API export and > prevent symbol clashes. It is strongly recommended that you use this in any > shared objects you distribute. > See here: http://gcc.gnu.org/wiki/Visibility > Attached patch (patch.txt) will build libqpid-proton.so shared library using > this flag. > It reduces number of symbols from 700+ to 500+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1083) [C++] Simplify the messaging events
[ https://issues.apache.org/jira/browse/PROTON-1083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147715#comment-15147715 ] ASF subversion and git services commented on PROTON-1083: - Commit 958d009599f13f2aa79d9bfc6baa6964fb3e6967 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=958d009 ] PROTON-1083: Make proton::event a pure abstract class (interface) > [C++] Simplify the messaging events > --- > > Key: PROTON-1083 > URL: https://issues.apache.org/jira/browse/PROTON-1083 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > Fix For: 0.12.0 > > > This work simplifies the events generated in the C++ binding to a new set > that is probably easier and simpler to work with (only time will tell whether > this is true or not) -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-629) Can't include proton-c header files in c-only applications in visual studio
[ https://issues.apache.org/jira/browse/PROTON-629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147716#comment-15147716 ] ASF subversion and git services commented on PROTON-629: Commit 13150e4935d0de0bf390db4474b22c20e72a54e7 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=13150e4 ] PROTON-629: Allow proton/delivery.h to be compiled as C89 > Can't include proton-c header files in c-only applications in visual studio > --- > > Key: PROTON-629 > URL: https://issues.apache.org/jira/browse/PROTON-629 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.7 > Environment: Windows >Reporter: Sahir Hoda >Assignee: Andrew Stitcher > Labels: build, easyfix, patch > Original Estimate: 1h > Remaining Estimate: 1h > > The public API for the proton-c library includes the function in delivery.h: > 61:static inline pn_delivery_tag_t pn_dtag(const char *bytes, size_t size) > The 'inline' keyword is problematic for applications building with Visual > Studio in a non-C++ mode. Per the msdn doc > [http://msdn.microsoft.com/en-us/library/z8y1yy88.aspx]: > "The inline keyword is available only in C++. The __inline and __forceinline > keywords are available in both C and C++. For compatibility with previous > versions, _inline is a synonym for __inline." > So 'inline' is only available for C++ applications, however C applications > must use the '__inline' keyword instead. > To resolve this issue, I would suggest the following patch: > diff --git a/proton-c/include/proton/type_compat.h > b/proton-c/include/proton/type_compat.h > index 9501d9a..9423cf1 100644 > --- a/proton-c/include/proton/type_compat.h > +++ b/proton-c/include/proton/type_compat.h > @@ -130,4 +130,9 @@ typedef unsigned __int64 uint64_t; > # endif > #endif // PNI_DEFINE_SSIZE_T > > +#if !defined(__cplusplus) && defined(_MSC_VER) > +// visual studio and not using c++ > + #define inline __inline > +#endif > + > #endif /* type_compat.h */ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1132) Timeout in valgrind test
[ https://issues.apache.org/jira/browse/PROTON-1132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15147367#comment-15147367 ] ASF subversion and git services commented on PROTON-1132: - Commit 8293164d8755f91df08b4c70f586d1862aa84016 in qpid-proton's branch refs/heads/master from Clifford Jansen [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=8293164 ] PROTON-1132: Timeout in valgrind test > Timeout in valgrind test > > > Key: PROTON-1132 > URL: https://issues.apache.org/jira/browse/PROTON-1132 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Cliff Jansen >Assignee: Cliff Jansen > > Since PROTON-1115 was fixed some CI tests are failing with timeouts. Working > theory is that re-introducing valgrind just takes longer on some slower test > machinery. Will increase the timeout (doesn't slow down a successful run) > and close the JIRA if runs complete successfully. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1061) [Python Binding] Add support for all AMQP 1.0 types
[ https://issues.apache.org/jira/browse/PROTON-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139003#comment-15139003 ] ASF subversion and git services commented on PROTON-1061: - Commit 5ada2ec00b30b67d4f182d6c418011c0b77ca1ca in qpid-proton's branch refs/heads/master from [~kpvdr] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5ada2ec ] PROTON-1061: Fixed error in Python binding in which int types were mapped to AMQP type long. > [Python Binding] Add support for all AMQP 1.0 types > --- > > Key: PROTON-1061 > URL: https://issues.apache.org/jira/browse/PROTON-1061 > Project: Qpid Proton > Issue Type: Task > Components: python-binding >Reporter: Kim van der Riet >Assignee: Kim van der Riet > > Currently, a number of AMQP 1.0 simple types are not supported in the Python > binding. Only those types that "make sense" from a Python language > point-of-view are currently supported, but types such as the unsigned > integral types, 32-bit float and the decimal types are not supported. As > long as the Python client only talks to other Python clients, this approach > makes sense, but as soon as a Python client needs to talk to some other > client that may require these types, then an impasse is reached. > The AMQP types currently *NOT* supported in the Python binding are: > * Byte > * Short > * Int (32-bit) > * Ubyte > * Ushort > * Uint (32-bit) > * Float (32-bit) > * Decimal32 > * Decimal64 > * Decimal128 > A proposed patch is available for review at > https://reviews.apache.org/r/39479/. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1129) C++ binding test failure with older python
[ https://issues.apache.org/jira/browse/PROTON-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136351#comment-15136351 ] ASF subversion and git services commented on PROTON-1129: - Commit 5e5bb2e0ea2a5e2b4cb0f448bba1cd28fcd98745 in qpid-proton's branch refs/heads/master from Clifford Jansen [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5e5bb2e ] PROTON-1129: C++ example_test.py - rework new python 2.7 calls for older python > C++ binding test failure with older python > -- > > Key: PROTON-1129 > URL: https://issues.apache.org/jira/browse/PROTON-1129 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: 0.13.0 >Reporter: Cliff Jansen >Assignee: Cliff Jansen > > See errors like: > AttributeError: type object 'ContainerExampleTest' has no attribute 'broker' > Working theory: unittest.TestCase.setUpClass() not implemented until python > 2.7. The classmethod overrides are never called. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1127) [Windows] qpid-proton-cpp.dll not installed by "make install" target
[ https://issues.apache.org/jira/browse/PROTON-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134535#comment-15134535 ] ASF subversion and git services commented on PROTON-1127: - Commit fda572f4088c5dc25be77ce6dbf847fba99a396f in qpid-proton's branch refs/heads/0.12.x from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=fda572f ] PROTON-1127: [C++ binding] Install qpid-proton-cpp.dll > [Windows] qpid-proton-cpp.dll not installed by "make install" target > > > Key: PROTON-1127 > URL: https://issues.apache.org/jira/browse/PROTON-1127 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: 0.12.0 > Environment: Windows MSVC >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > Fix For: 0.12.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1126) Allow setting connection properties in BlockingConnection
[ https://issues.apache.org/jira/browse/PROTON-1126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134548#comment-15134548 ] ASF subversion and git services commented on PROTON-1126: - Commit 0c8ba1df78fac9bebfda6b08f88105ff1b20d219 in qpid-proton's branch refs/heads/master from [~gsim] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=0c8ba1d ] PROTON-1126: allow setting of various connection fields. Patch from Ganesh Murthy. > Allow setting connection properties in BlockingConnection > - > > Key: PROTON-1126 > URL: https://issues.apache.org/jira/browse/PROTON-1126 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: 0.11.1 >Reporter: Ganesh Murthy >Priority: Minor > Fix For: 0.13.0 > > > The BlockingConnection class in proton/bindings/python/proton/utils.py does > not have a way to set the connection properties. > connection properties are sent as part of the AMQP open frame. > Allow the connection properties to be set on the BlockingConnection -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1128) [C++ binding] Symbol exports use wrong directive for proton::condition
[ https://issues.apache.org/jira/browse/PROTON-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132831#comment-15132831 ] ASF subversion and git services commented on PROTON-1128: - Commit 4ea3d26257ff5f707dfd7b44214ad22857d7b364 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=4ea3d26 ] PROTON-1128: [C++ binding] Fix incorrect symbol export declaration. > [C++ binding] Symbol exports use wrong directive for proton::condition > -- > > Key: PROTON-1128 > URL: https://issues.apache.org/jira/browse/PROTON-1128 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: 0.12.0 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > > The C++ binding API header file incorrectly uses PN_CPP_EXPORT rather than > PN_CPP_EXTERN. > In theory on Windows (the only system where these directives are currently > active) this could mean that user programs using the proton::condition API > would be unable to do so as the program would be exporting the API rather > than importing it. > However in limited tests using VS 2015 it doesn't seem to actually be causing > a problem. > It may be that it is problematic in other (earlier) VS compilers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1127) [Windows] qpid-proton-cpp.dll not installed by "make install" target
[ https://issues.apache.org/jira/browse/PROTON-1127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132691#comment-15132691 ] ASF subversion and git services commented on PROTON-1127: - Commit 135aebb2bc87ff792a4019651d380b5044f8acff in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=135aebb ] PROTON-1127: [C++ binding] Install qpid-proton-cpp.dll > [Windows] qpid-proton-cpp.dll not installed by "make install" target > > > Key: PROTON-1127 > URL: https://issues.apache.org/jira/browse/PROTON-1127 > Project: Qpid Proton > Issue Type: Bug > Components: cpp-binding >Affects Versions: 0.12.0 > Environment: Windows MSVC >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > Fix For: 0.12.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1116) Potential infinite recursion detected by VC++14 compiler
[
https://issues.apache.org/jira/browse/PROTON-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129034#comment-15129034
]
ASF subversion and git services commented on PROTON-1116:
-
Commit ef37b23208f31bef224f82bc493867409f4aceeb in qpid-proton's branch
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ef37b23 ]
PROTON-1116: Potential infinite recursion detected by VC++14 compiler
The problem is caused by the implicit conversion constructor in proton::value.
Made it explicit and fixed a few places that relied on it.
This is a simple fix for 0.12, a safer and more flexible encoding/decoding
system based on type-traits will be committed to master.
> Potential infinite recursion detected by VC++14 compiler
>
>
> Key: PROTON-1116
> URL: https://issues.apache.org/jira/browse/PROTON-1116
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
>Affects Versions: 0.12.0
> Environment: Visual Studio 2015 Update 1, Visual Studio 2010
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
>Priority: Blocker
>
> I get the following warning when running the Visual Studio 2015 compiler on
> the C++ binding code
> {noformat}
> 29>c:\users\andrew\documents\github\qpid-proton\proton-c\bindings\cpp\include\proton\value.hpp(49):
> warning C4717:
> 'proton::value::value >,proton::value> >': recursive on all control paths, function will cause
> runtime stack overflow
> {noformat}
> My guess is that we never actually try to run this code in the tests or e
> would indeed by seeing a failure, however I think we must eliminate this as a
> bug before releasing 0.12.
> Either remove the code so removing the warning (as the code seems like it
> can't have been called in testing) or fix the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-1121) Zero pointer derefence in pn_sasl_allowed_mechs()
[ https://issues.apache.org/jira/browse/PROTON-1121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129180#comment-15129180 ] ASF subversion and git services commented on PROTON-1121: - Commit 5917bf8aac443a2ab3da24dcf5bc923cd8b77375 in qpid-proton's branch refs/heads/0.12.x from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5917bf8 ] PROTON-1121: Avoid null dereference discovered by Coverity. > Zero pointer derefence in pn_sasl_allowed_mechs() > - > > Key: PROTON-1121 > URL: https://issues.apache.org/jira/browse/PROTON-1121 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.10 >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > Labels: coverity, crash > Fix For: 0.13.0 > > > Coverity detected a potential derefence of a null string pointer in > pn_sasl_allowed_mechs(). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1043) Possible typo in messenger.c
[
https://issues.apache.org/jira/browse/PROTON-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129001#comment-15129001
]
ASF subversion and git services commented on PROTON-1043:
-
Commit 8227452984349b3ab5e69489c7d40b6b4ffbf4f5 in qpid-proton's branch
refs/heads/master from [~astitcher]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=8227452 ]
PROTON-1043: Fix error in boolean flag check
[discovered both by aconway and Coverity)
> Possible typo in messenger.c
>
>
> Key: PROTON-1043
> URL: https://issues.apache.org/jira/browse/PROTON-1043
> Project: Qpid Proton
> Issue Type: Bug
>Reporter: Alan Conway
> Labels: messenger
>
> From mailing list:
> http://qpid.2158936.n2.nabble.com/Possible-typo-in-messenger-c-td7632895.html
>
> Is this an error:
> if (messenger->flags | PN_FLAGS_CHECK_ROUTES) {
> (line 1498 in messenger.c)?
> Shouldn't it be:
> if (messenger->flags & PN_FLAGS_CHECK_ROUTES) {
>
> In my opinion this comment is correct but I'm not an expert on messenger so
> wary of fixing without knowing if some of the code controlled by the if
> statement really should be running even if PN_FLAGS_CHECK_ROUTES is off.
> Clearly the code is incorrect as it stands I'm just uncertain if the fix
> suggested is safe or if the code needs review.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-1124) Small problems detected by Coverity scanner
[ https://issues.apache.org/jira/browse/PROTON-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128999#comment-15128999 ] ASF subversion and git services commented on PROTON-1124: - Commit d8537ee7dbc3f0b17f94cd8b2c2fcf629e70437c in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d8537ee ] PROTON-1124: Fix missing error handling discovered by Coverity > Small problems detected by Coverity scanner > --- > > Key: PROTON-1124 > URL: https://issues.apache.org/jira/browse/PROTON-1124 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > > Some minor problems detected in proton-c by Coverity scan of Jan 31 2016 > master. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1124) Small problems detected by Coverity scanner
[ https://issues.apache.org/jira/browse/PROTON-1124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129000#comment-15129000 ] ASF subversion and git services commented on PROTON-1124: - Commit 3b8be927b41c350ff5b10da4cea036dda0d236cb in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3b8be92 ] PROTON-1124: Removed dead code pointed out by Coverity > Small problems detected by Coverity scanner > --- > > Key: PROTON-1124 > URL: https://issues.apache.org/jira/browse/PROTON-1124 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher >Priority: Minor > > Some minor problems detected in proton-c by Coverity scan of Jan 31 2016 > master. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1116) Potential infinite recursion detected by VC++14 compiler
[
https://issues.apache.org/jira/browse/PROTON-1116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129179#comment-15129179
]
ASF subversion and git services commented on PROTON-1116:
-
Commit 5c380018978e1b55b4c39b1a3aa75bc7a0ab29a8 in qpid-proton's branch
refs/heads/0.12.x from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5c38001 ]
PROTON-1116: Potential infinite recursion detected by VC++14 compiler
The problem is caused by the implicit conversion constructor in proton::value.
Made it explicit and fixed a few places that relied on it.
This is a simple fix for 0.12, a safer and more flexible encoding/decoding
system based on type-traits will be committed to master.
> Potential infinite recursion detected by VC++14 compiler
>
>
> Key: PROTON-1116
> URL: https://issues.apache.org/jira/browse/PROTON-1116
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
>Affects Versions: 0.12.0
> Environment: Visual Studio 2015 Update 1, Visual Studio 2010
>Reporter: Andrew Stitcher
>Assignee: Alan Conway
>Priority: Blocker
>
> I get the following warning when running the Visual Studio 2015 compiler on
> the C++ binding code
> {noformat}
> 29>c:\users\andrew\documents\github\qpid-proton\proton-c\bindings\cpp\include\proton\value.hpp(49):
> warning C4717:
> 'proton::value::value >,proton::value> >': recursive on all control paths, function will cause
> runtime stack overflow
> {noformat}
> My guess is that we never actually try to run this code in the tests or e
> would indeed by seeing a failure, however I think we must eliminate this as a
> bug before releasing 0.12.
> Either remove the code so removing the warning (as the code seems like it
> can't have been called in testing) or fix the code.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-1120) Memory leak using proton.utils
[
https://issues.apache.org/jira/browse/PROTON-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15127972#comment-15127972
]
ASF subversion and git services commented on PROTON-1120:
-
Commit 5dc39f8fc4e89f1e45ca42bda961260db458e128 in qpid-proton's branch
refs/heads/0.12.x from [~gsim]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=5dc39f8 ]
PROTON-1120: ensure messages are settled locally
> Memory leak using proton.utils
> --
>
> Key: PROTON-1120
> URL: https://issues.apache.org/jira/browse/PROTON-1120
> Project: Qpid Proton
> Issue Type: Bug
> Components: python-binding
>Affects Versions: 0.10
> Environment: python-qpid-proton-0.10-2.fc23.x86_64
> And 0.9-13
>Reporter: Jeff Ortel
>Assignee: Gordon Sim
> Fix For: 0.12.0
>
> Attachments: memory-leak.py
>
>
> I have observed a fairly substantial memory leak using the blocking classes
> in proton.utils. Mainly with sending messages.
> Observations:
> {code}
> growth = 52 MB for 10,000 messages sent
> growth = 104 MB for 20,000 messages sent
> leak = 52 MB per 10,000 sends or ~5 kB / send
> {code}
> The attached reproducer, can be used to collect and display statistics.
> There is likely a better method for measuring the memory growth but this was
> easy. Perhaps there is something incorrect/missing with the way I'm using
> proton or measuring the memory growth/leak?
> {code}
>
> 1 messages
>
> total kB 242088 162567552 - sending
> total kB 293980 68224 59520 - sent
> total kB 293980 68228 59524 - receiving
> total kB 294236 68340 59632 - received
> SizeGrowth Context
> __||__
> 242088 kB +242088 kB sending
> 293980 kB + 51892 kB sent
> 293980 kB + 0 kB receiving
> 294236 kB + 256 kB received
>
> 2 messages
>
> total kB 294236 68348 59640 - sending
> total kB 397820 171896 163232 - sent
> total kB 397820 171900 163236 - receiving
> total kB 398020 172060 163396 - received
> SizeGrowth Context
> __||__
> 294236 kB +294236 kB sending
> 397820 kB +103584 kB sent
> 397820 kB + 0 kB receiving
> 398020 kB + 200 kB received
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (PROTON-1118) python setup.py build fails if run from git repo
[ https://issues.apache.org/jira/browse/PROTON-1118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128538#comment-15128538 ] ASF subversion and git services commented on PROTON-1118: - Commit de397c5fc1c1957aa257d93a05e586e966217b9b in qpid-proton's branch refs/heads/0.12.x from [~kgiusti] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=de397c5 ] PROTON-1118: use CMakeLists.txt to determine the location of sources for the python binding > python setup.py build fails if run from git repo > > > Key: PROTON-1118 > URL: https://issues.apache.org/jira/browse/PROTON-1118 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: 0.12.0 >Reporter: Ken Giusti >Assignee: Ken Giusti > Labels: build-failure > Fix For: 0.13.0 > > > If setup.py is run from the proton-c/bindings/proton directory, it should > build the local python bindings. Instead it tries to download the > distribution from the Apache servers. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1123) cmake fails under python3 when -DSYSINSTALL_BINDINGS=ON
[ https://issues.apache.org/jira/browse/PROTON-1123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15128578#comment-15128578 ] ASF subversion and git services commented on PROTON-1123: - Commit acbaa502bbd11939390156f41684b4f66aceb311 in qpid-proton's branch refs/heads/master from [~kgiusti] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=acbaa50 ] PROTON-1123: fix print syntax error in CMakeLists.txt > cmake fails under python3 when -DSYSINSTALL_BINDINGS=ON > --- > > Key: PROTON-1123 > URL: https://issues.apache.org/jira/browse/PROTON-1123 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: 0.12.0 >Reporter: Ken Giusti >Assignee: Ken Giusti > Fix For: 0.12.0 > > > The following syntax error is raised: > -- Found Doxygen: /usr/bin/doxygen (found version "1.8.10") > File "", line 1 > from distutils.sysconfig import get_python_lib; print get_python_lib(True) >^ > SyntaxError: invalid syntax > In python3 print is a function and requires parenthesis. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1050) 0.12.0 release tasks
[ https://issues.apache.org/jira/browse/PROTON-1050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15129715#comment-15129715 ] ASF subversion and git services commented on PROTON-1050: - Commit 4f46645569e74978aa7c40b5ed55f732a08e4c10 in qpid-proton's branch refs/heads/master from [~jr...@redhat.com] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=4f46645 ] PROTON-1050: Bump .so version on master > 0.12.0 release tasks > > > Key: PROTON-1050 > URL: https://issues.apache.org/jira/browse/PROTON-1050 > Project: Qpid Proton > Issue Type: Task > Components: release >Reporter: Justin Ross >Assignee: Justin Ross > Fix For: 0.12.0 > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
