[GitHub] qpid-proton pull request: -Fix 2 Code Analysis warnings in iocp.c ...
Github user dcristoloveanu closed the pull request at: https://github.com/apache/qpid-proton/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: -Fix 2 Code Analysis warnings in iocp.c ...
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/45#issuecomment-120549130 Thanks, appreciate your help with the review! /Dan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: -Fix 2 Code Analysis warnings and a real...
Github user dcristoloveanu closed the pull request at: https://github.com/apache/qpid-proton/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: -Fix 2 Code Analysis warnings in iocp.c ...
GitHub user dcristoloveanu opened a pull request: https://github.com/apache/qpid-proton/pull/45 -Fix 2 Code Analysis warnings in iocp.c and a realloc leak -Fix one realloc leak and the fact that the realloc result was not checked. This rippled through codec.c as more functions needed to have error checking. Also, more fixes regarding return values being checked need to be done throughout message.c, transport.c, etc., but the amount of changes is significant, so it needs to be done in several chunks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dcristoloveanu/qpid-proton FixCodeAnalysis Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/45.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #45 commit 9d14e1dd3d2fa5886752ff00eece93c4827cd1bd Author: dcristoloveanu dcri...@microsoft.com Date: 2015-07-09T20:01:30Z -Fix 2 Code Analysis warnings in iocp.c -Fix one realloc leak and the fact that the realloc result was not checked. This rippled through codec.c as more functions needed to have error checking. Also, more fixes regarding return values being checked need to be done throughout message.c, transport.c, etc., but the amount of changes is significant, so it needs to be done in several chunks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fix 2 Code Analysis warnings and a reall...
Github user dcristoloveanu closed the pull request at: https://github.com/apache/qpid-proton/pull/39 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: -Fix 2 Code Analysis warnings and a real...
GitHub user dcristoloveanu opened a pull request: https://github.com/apache/qpid-proton/pull/43 -Fix 2 Code Analysis warnings and a realloc failure -Fix 2 Code Analysis warnings in iocp.c -Fix one realloc leak and the fact that the realloc result was not checked. This rippled through codec.c as more functions needed to have error checking. Also, more fixes regarding return values being checked need to be done throughout message.c, transport.c, etc., but the amount of changes is significant, so it needs to be done in several chunks. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dcristoloveanu/qpid-proton FixCodeAnalysis Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/43.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #43 commit a41bcbd6b48bc9a4507a844d4aa9ec1a37cec189 Author: dcristoloveanu dcri...@microsoft.com Date: 2015-07-08T00:18:05Z -Fix 2 Code Analysis warnings in iocp.c -Fix one realloc leak and the fact that the realloc result was not checked. This rippled through codec.c as more functions needed to have error checking. Also, more fixes regarding return values being checked need to be done throughout message.c, transport.c, etc., but the amount of changes is significant, so it needs to be done in several chunks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fix 2 Code Analysis warnings and a reall...
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/39#issuecomment-114940533 Ping ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/25#issuecomment-100987919 @dnwe Sorry about that, I updated the branch to have only on commit. Thanks, /Dan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Add some NULL checks and fix some reallo...
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/27#issuecomment-100289485 I couldn't agree more. Actually all calls should have their result checked. After all malloc/realloc are not more important than pb_buffer and all the constructors or other APIs. Unfortunately doing all of it in one sweep is not really sustainable, so I thought it would be a good idea to start somewhere. I'd love to send more PRs like this to finish dealing with malloc/realloc and then move higher to ensuring that each unit checks returns of the functions it calls. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/25#issuecomment-99319844 Friendly ping ... Thanks, /Dan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Add some NULL checks and fix some reallo...
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/27#issuecomment-99319790 Friendly ping ... Thanks, /Dan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Add some NULL checks and fix some reallo...
GitHub user dcristoloveanu opened a pull request: https://github.com/apache/qpid-proton/pull/27 Add some NULL checks and fix some realloc leaks Along the lines of PROTON-727, added NULL checks for some malloc/realloc calls that were either ignoring the result or leaking in the case of realloc. Thanks, /Dan You can merge this pull request into a Git repository by running: $ git pull https://github.com/dcristoloveanu/qpid-proton FixCodeAnalysis Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/27.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #27 commit c31b068656579b3b6e47a44bd97b40001f2a66ca Author: dcristoloveanu dcri...@microsoft.com Date: 2015-04-30T00:15:51Z Add some NULL checks and fix some realloc leaks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Initial transport frame size 256 bytes
GitHub user dcristoloveanu opened a pull request: https://github.com/apache/qpid-proton/pull/25 Initial transport frame size 256 bytes In order to reduce RAM footprint on rather simple scenarios on small devices the initial transport frame size could be lowered to 256, since the buffer is anyhow automatically enlarged if needed. Per earlier suggestions I created a config.h where parameters like this can go (the next candidate is the initial size for pn_data). If the need arises these parameters should be easily changeable in this case to match the platform need. You can merge this pull request into a Git repository by running: $ git pull https://github.com/dcristoloveanu/qpid-proton RAM-Transport-Frame-256-bytes Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/25.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #25 commit 2158ef3447bab718cfa7b1cb9f9c635cb83beb7f Author: dcristoloveanu dcri...@microsoft.com Date: 2015-04-28T21:01:49Z Add config.h commit 65c6ce3df2c1c531cce49d2c3aab5f79f59c63bb Author: dcristoloveanu dcri...@microsoft.com Date: 2015-04-29T21:21:31Z -Added a configuration file named config.h where various parameters should be configurable (like transport initial frame buffer size, pnin the future _data initial size, etc.) -Set initial transport frame buffer size to 256 instead of 4K -Added config.h to the cmakelists.txt so that it shows up also in the Proton.sln Windows solution --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Fix none_sasl.c to use pn_strdup instead...
GitHub user dcristoloveanu opened a pull request: https://github.com/apache/qpid-proton/pull/24 Fix none_sasl.c to use pn_strdup instead of strdup (PROTON-870) none_sasl.c should use pn_strdup. none_sasl.c uses strdup, but strdup is not part of C99 and subsequently does not exist on some platforms. Instead pn_strdup should be used. Thanks, /Dan You can merge this pull request into a Git repository by running: $ git pull https://github.com/dcristoloveanu/qpid-proton NoneSASL Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/24.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #24 commit 300ffc4246f0007a70b40954e29fbbe44796ad74 Author: dcristoloveanu dcri...@microsoft.com Date: 2015-04-28T00:44:05Z Fix none_sasl.c to use pn_strdup instead of strdup --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Mbed minor changes and sasl mech
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/19#issuecomment-95988615 I think this can be merged in now, unless there's anything else that you think needs addressing. Thanks! /Dan --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Mbed minor changes and sasl mech
Github user dcristoloveanu commented on the pull request: https://github.com/apache/qpid-proton/pull/19#issuecomment-94641331 Iâve removed the SASL client mechanism setter as I think PROTON-334 should do when it comes online. And if it does not we can always bring this back in another pull request. One small thing at a time. Thanks for the feedback. /Dan From: Rafael Schloming [mailto:notificati...@github.com] Sent: Monday, April 20, 2015 5:27 AM To: apache/qpid-proton Cc: Dan Cristoloveanu Subject: Re: [qpid-proton] Mbed minor changes and sasl mech (#19) @astitcherhttps://github.com/astitcher: do you want to wait until PROTON-334 lands to pull this in given the conflict you mention? â Reply to this email directly or view it on GitHubhttps://github.com/apache/qpid-proton/pull/19#issuecomment-94438477. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] qpid-proton pull request: Mbed minor changes and sasl mech
GitHub user dcristoloveanu opened a pull request: https://github.com/apache/qpid-proton/pull/19 Mbed minor changes and sasl mech This are 2 minor changes in order to be able to: - Compile on an Arm CC compiler and more specifically compile in mbed.org's environment. These are basically some minor header include changes. - Addition of an API to inject which client SASL mechanism to use (needed in order to be able to talk to Azure Event Hubs while using CBS). Any feedback is most appreciated. Thanks, /Dan You can merge this pull request into a Git repository by running: $ git pull https://github.com/dcristoloveanu/qpid-proton MBEDMinorChangesAndSASLMech Alternatively you can review and apply these changes as the patch at: https://github.com/apache/qpid-proton/pull/19.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #19 commit 477dfb07c5f6a208e755f9a6b1ffdda145ebe475 Author: dcristoloveanu dcri...@microsoft.oocm Date: 2015-03-17T16:55:58Z Minor fixes to be able to build on MBED commit 4ad92010ad9864d186031e9450045a64bc435fbc Author: dcristoloveanu dcri...@microsoft.com Date: 2015-04-14T23:00:57Z Merge branch 'originalprotoncmaster' --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
