[GitHub] qpid-proton pull request: PROTON-576: modified UTF-8 encoder fixes

2015-03-04 Thread dnwe
GitHub user dnwe opened a pull request:

https://github.com/apache/qpid-proton/pull/10

PROTON-576: modified UTF-8 encoder fixes

Commit 5069bb6 applied a modified version of a patch I submitted, to
ensure that the UTF-8 encoder (and UTF-8 byte length calculator) would
cope with surrogate pairs. This commit fixes an issue with three byte
characters in the = 0x range being incorrectly detected as invalid
four byte surrogates.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dnwe/qpid-proton fix-proton-576

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/10.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #10


commit 6ed99b97164d1bdb463b3bdbfc0507e0e603949e
Author: Dominic Evans dominic.ev...@uk.ibm.com
Date:   2015-03-04T16:21:46Z

PROTON-576: modified UTF-8 encoder fixes

Commit 5069bb6 applied a modified version of a patch I submitted, to
ensure that the UTF-8 encoder (and UTF-8 byte length calculator) would
cope with surrogate pairs. This commit fixes an issue with three byte
characters in the = 0x range being incorrectly detected as invalid
four byte surrogates.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] qpid-proton pull request: PROTON-576: modified UTF-8 encoder fixes

2015-03-04 Thread gemmellr
Github user gemmellr commented on the pull request:

https://github.com/apache/qpid-proton/pull/10#issuecomment-77209715
  
I had a chat with Rob and he thought the change looked ok. Could you make a 
new JIRA though and merge it against that, since PROTON-576 was already release 
in 0.8.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---