[GitHub] qpid-proton pull request: PROTON-834: further UTF-8 encoder fixes

2015-03-16 Thread dnwe
GitHub user dnwe opened a pull request:

https://github.com/apache/qpid-proton/pull/13

PROTON-834: further UTF-8 encoder fixes

After commit c65e897 it turned out there were still some issues with
strings containing a codepoint 0xDBFF which was being incorrectly
treated as a surrogate pair in the calculateUTF8Length method.

Fixed this up and added some more test coverage.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/dnwe/qpid-proton fix-proton-834

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/qpid-proton/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #13


commit dc52650e7de53ef5fe294b9066620b4698c30a94
Author: Dominic Evans dominic.ev...@uk.ibm.com
Date:   2015-03-16T12:18:20Z

PROTON-834: further UTF-8 encoder fixes

After commit c65e897 it turned out there were still some issues with
strings containing a codepoint 0xDBFF which was being incorrectly
treated as a surrogate pair in the calculateUTF8Length method.

Fixed this up and added some more test coverage.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] qpid-proton pull request: PROTON-834: further UTF-8 encoder fixes

2015-03-16 Thread gemmellr
Github user gemmellr commented on the pull request:

https://github.com/apache/qpid-proton/pull/13#issuecomment-81751109
  
Looks good to me. We should request for inclusion in 0.9 if there is an RC3 
to pick up aconways SSL change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---