[jira] [Commented] (PROTON-350) Messenger - pn_messenger_recv( -1 ) does not flow control senders
[ https://issues.apache.org/jira/browse/PROTON-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712193#comment-13712193 ] Rafael H. Schloming commented on PROTON-350: I've submitted a fix for this and added a test. Can you verify that this also fixes your reproducer? > Messenger - pn_messenger_recv( -1 ) does not flow control senders > - > > Key: PROTON-350 > URL: https://issues.apache.org/jira/browse/PROTON-350 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.4 >Reporter: Ken Giusti > Fix For: 0.5 > > Attachments: test-recv.py > > > When using pn_messenger_recv( -1 ), remote senders are not back-pressured, > and the number of messages received can grow without bounds. It appears that > messenger is unconditionally granting credit as messages arrive. > Messenger should instead only replenish credit when received messages are > actually consumed by the application (maybe after they are settled?). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PROTON-350) Messenger - pn_messenger_recv( -1 ) does not flow control senders
[ https://issues.apache.org/jira/browse/PROTON-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712188#comment-13712188 ] ASF subversion and git services commented on PROTON-350: Commit 1504407 from r...@apache.org in branch 'proton/trunk' [ https://svn.apache.org/r1504407 ] Bounded messenger's credit allocation when an unlimited value is passed to recv; added tests for pushback at both messenger and engine level; fixed proton-j engine to respect credit window; fixed java messenger to properly report if work has been done. This addresses PROTON-350 and PROTON-351. > Messenger - pn_messenger_recv( -1 ) does not flow control senders > - > > Key: PROTON-350 > URL: https://issues.apache.org/jira/browse/PROTON-350 > Project: Qpid Proton > Issue Type: Bug > Components: proton-c >Affects Versions: 0.4 >Reporter: Ken Giusti > Fix For: 0.5 > > Attachments: test-recv.py > > > When using pn_messenger_recv( -1 ), remote senders are not back-pressured, > and the number of messages received can grow without bounds. It appears that > messenger is unconditionally granting credit as messages arrive. > Messenger should instead only replenish credit when received messages are > actually consumed by the application (maybe after they are settled?). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
