[jira] [Commented] (PROTON-498) Set VALGRIND environment variable to be compatible with the QPID build
[ https://issues.apache.org/jira/browse/PROTON-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13887171#comment-13887171 ] ASF subversion and git services commented on PROTON-498: Commit 1563000 from [~kgiusti] in branch 'proton/trunk' [ https://svn.apache.org/r1563000 ] PROTON-498: fix shell variable quoting Set VALGRIND environment variable to be compatible with the QPID build -- Key: PROTON-498 URL: https://issues.apache.org/jira/browse/PROTON-498 Project: Qpid Proton Issue Type: Improvement Components: proton-c Affects Versions: 0.6 Reporter: Ken Giusti Assignee: Ken Giusti Priority: Trivial Fix For: 0.7 The proton build system detects if valgrind is installed, and exports the VALGRIND environment variable for use by the tests. However the proton build system sets this environment variable to 1. The QPID build system also sets the VALGRIND environment variable, but it sets it to the path to the valgrind executable (eg. /usr/bin/valgrind, or equivalent). The QPID test bed assumes $VALGRIND is the path to the executable. Modify the proton build system to use the same convention as the QPID build system. This prevents problems when switching from one build system to the other. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (PROTON-498) Set VALGRIND environment variable to be compatible with the QPID build
[ https://issues.apache.org/jira/browse/PROTON-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884542#comment-13884542 ] ASF subversion and git services commented on PROTON-498: Commit 1562213 from [~kgiusti] in branch 'proton/trunk' [ https://svn.apache.org/r1562213 ] PROTON-498: set the VALGRIND env var to the path to the valgrind executable Set VALGRIND environment variable to be compatible with the QPID build -- Key: PROTON-498 URL: https://issues.apache.org/jira/browse/PROTON-498 Project: Qpid Proton Issue Type: Improvement Components: proton-c Affects Versions: 0.6 Reporter: Ken Giusti Assignee: Ken Giusti Priority: Trivial Fix For: 0.7 The proton build system detects if valgrind is installed, and exports the VALGRIND environment variable for use by the tests. However the proton build system sets this environment variable to 1. The QPID build system also sets the VALGRIND environment variable, but it sets it to the path to the valgrind executable (eg. /usr/bin/valgrind, or equivalent). The QPID test bed assumes $VALGRIND is the path to the executable. Modify the proton build system to use the same convention as the QPID build system. This prevents problems when switching from one build system to the other. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
[jira] [Commented] (PROTON-498) Set VALGRIND environment variable to be compatible with the QPID build
[ https://issues.apache.org/jira/browse/PROTON-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13884583#comment-13884583 ] ASF subversion and git services commented on PROTON-498: Commit 1562224 from [~kgiusti] in branch 'proton/trunk' [ https://svn.apache.org/r1562224 ] PROTON-498: fix the CMake valgrind logic Set VALGRIND environment variable to be compatible with the QPID build -- Key: PROTON-498 URL: https://issues.apache.org/jira/browse/PROTON-498 Project: Qpid Proton Issue Type: Improvement Components: proton-c Affects Versions: 0.6 Reporter: Ken Giusti Assignee: Ken Giusti Priority: Trivial Fix For: 0.7 The proton build system detects if valgrind is installed, and exports the VALGRIND environment variable for use by the tests. However the proton build system sets this environment variable to 1. The QPID build system also sets the VALGRIND environment variable, but it sets it to the path to the valgrind executable (eg. /usr/bin/valgrind, or equivalent). The QPID test bed assumes $VALGRIND is the path to the executable. Modify the proton build system to use the same convention as the QPID build system. This prevents problems when switching from one build system to the other. -- This message was sent by Atlassian JIRA (v6.1.5#6160)
