[jira] [Commented] (PROTON-696) The header file usage needs some improvement
[ https://issues.apache.org/jira/browse/PROTON-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242112#comment-14242112 ] ASF subversion and git services commented on PROTON-696: Commit 815e97efeeb964d782861353751d44b253fc2c24 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=815e97e ] PROTON-696: Remove pn_buffer_t and pn_frame_t from the public API (they are currently only used privately) - Don't want to expose a potentially changing internal detail - XXX Currently left the DLL exports in because of proton and proton-dump The header file usage needs some improvement Key: PROTON-696 URL: https://issues.apache.org/jira/browse/PROTON-696 Project: Qpid Proton Issue Type: Improvement Reporter: Andrew Stitcher Assignee: Andrew Stitcher There are a number of small header file problems with proton. * Some header files include too many other header files and so export too many symbols - this is especially problematic if they use platform header files. * Conversely some header files are not self contained and do not define all the symbols they use (by using the correct include files themselves) * There are symbols exported in the installed header files which are internal only symbols -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-696) The header file usage needs some improvement
[ https://issues.apache.org/jira/browse/PROTON-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14166780#comment-14166780 ] ASF subversion and git services commented on PROTON-696: Commit 1630849 from [~gsim] in branch 'proton/branches/examples' [ https://svn.apache.org/r1630849 ] PROTON-696: Rearrange the header files: - Reduce transitive header inclusions - Remove proton/util.h and move its contents to src/util.h. All the defined symbols were internal. - Stop including with lines like #include ../blah.h as this isn't needed anymore. (Fixes windows breakage from PROTON-676) The header file usage needs some improvement Key: PROTON-696 URL: https://issues.apache.org/jira/browse/PROTON-696 Project: Qpid Proton Issue Type: Improvement Reporter: Andrew Stitcher Assignee: Andrew Stitcher There are a number of small header file problems with proton. * Some header files include too many other header files and so export too many symbols - this is especially problematic if they use platform header files. * Conversely some header files are not self contained and do not define all the symbols they use (by using the correct include files themselves) * There are symbols exported in the installed header files which are internal only symbols -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-696) The header file usage needs some improvement
[ https://issues.apache.org/jira/browse/PROTON-696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145905#comment-14145905 ] ASF subversion and git services commented on PROTON-696: Commit 1627219 from [~astitcher] in branch 'proton/trunk' [ https://svn.apache.org/r1627219 ] PROTON-696: Rearrange the header files: - Reduce transitive header inclusions - Remove proton/util.h and move its contents to src/util.h. All the defined symbols were internal. - Stop including with lines like #include ../blah.h as this isn't needed anymore. (Fixes windows breakage from PROTON-676) The header file usage needs some improvement Key: PROTON-696 URL: https://issues.apache.org/jira/browse/PROTON-696 Project: Qpid Proton Issue Type: Improvement Reporter: Andrew Stitcher Assignee: Andrew Stitcher There are a number of small header file problems with proton. * Some header files include too many other header files and so export too many symbols - this is especially problematic if they use platform header files. * Conversely some header files are not self contained and do not define all the symbols they use (by using the correct include files themselves) * There are symbols exported in the installed header files which are internal only symbols -- This message was sent by Atlassian JIRA (v6.3.4#6332)
