[jira] [Commented] (PROTON-807) Proton does not decode AMQP small long encoding correctly and does not use it.
[ https://issues.apache.org/jira/browse/PROTON-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14296165#comment-14296165 ] ASF subversion and git services commented on PROTON-807: Commit a515e195c4ea28b4bb513ed6e7a905b4fa34e2ad in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=a515e19 ] PROTON-807: Use the small int and small long encodings when possible. Due to an oversight, proton was using small encodings for unsigned int and long types but not for signed types. This patch corrects that. Proton does not decode AMQP small long encoding correctly and does not use it. -- Key: PROTON-807 URL: https://issues.apache.org/jira/browse/PROTON-807 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.8 Reporter: Alan Conway Assignee: Alan Conway Fix For: 0.9 Proton incorrectly decodes an AMQP small long encoded value of -1 as 255. Proton itself never uses the small long encoding but qpid dispatch does, which is where this cropped up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-807) Proton does not decode AMQP small long encoding correctly and does not use it.
[ https://issues.apache.org/jira/browse/PROTON-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295412#comment-14295412 ] ASF subversion and git services commented on PROTON-807: Commit 249685a8cb675ab6fc16b14828fac2da949c9510 in qpid-proton's branch refs/heads/master from [~aconway] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=249685a ] PROTON-807: Fix incorrect decoding of small long values. codec/decoder.c: Was treating signed small long values as unsigned. proton-j/src/main/resources/ccodec.py: Added missing byte operations, fix ulong decoeing. tests/python/proton_tests/codec.py: Test all integer types, positive, negative and min/max. Proton does not decode AMQP small long encoding correctly and does not use it. -- Key: PROTON-807 URL: https://issues.apache.org/jira/browse/PROTON-807 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.8 Reporter: Alan Conway Assignee: Alan Conway Fix For: 0.9 Proton incorrectly decodes an AMQP small long encoded value of -1 as 255. Proton itself never uses the small long encoding but qpid dispatch does, which is where this cropped up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-807) Proton does not decode AMQP small long encoding correctly and does not use it.
[ https://issues.apache.org/jira/browse/PROTON-807?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14295418#comment-14295418 ] Alan Conway commented on PROTON-807: Fixed the decoding problem. Did not modify proton to use small encodings, this needs more thought. Needs to work correctly with arrays, so encoder must know whether in array context and use array encoding if specified. Will raise separate issue. Has been verified to work with dispatch, proton needs additional tests for optional types (e.g. small long) that it does not generate. Will raise separate issue. Proton does not decode AMQP small long encoding correctly and does not use it. -- Key: PROTON-807 URL: https://issues.apache.org/jira/browse/PROTON-807 Project: Qpid Proton Issue Type: Bug Components: proton-c Affects Versions: 0.8 Reporter: Alan Conway Assignee: Alan Conway Fix For: 0.9 Proton incorrectly decodes an AMQP small long encoded value of -1 as 255. Proton itself never uses the small long encoding but qpid dispatch does, which is where this cropped up. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
