[jira] [Created] (PROTON-1153) [C++ binding] Tidy up various details
Andrew Stitcher created PROTON-1153: --- Summary: [C++ binding] Tidy up various details Key: PROTON-1153 URL: https://issues.apache.org/jira/browse/PROTON-1153 Project: Qpid Proton Issue Type: Improvement Components: cpp-binding Reporter: Andrew Stitcher Assignee: Andrew Stitcher -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175806#comment-15175806 ] ASF subversion and git services commented on PROTON-1153: - Commit e3e1d7da55b859f17935c5d3ad32ea826fed1294 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=e3e1d7d ] PROTON-1153: [C++ binding] Tidy up proton::handler > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175807#comment-15175807 ] ASF subversion and git services commented on PROTON-1153: - Commit 3b62bf91b8fb12ec47f0062a8b0720e820555775 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=3b62bf9 ] PROTON-1153: [C++ binding] Tidy up link - This involved some tidying up of delivery and message too > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-1151) [C++ binding] Move exposed implementation details into proton::internal namespace
Andrew Stitcher created PROTON-1151: --- Summary: [C++ binding] Move exposed implementation details into proton::internal namespace Key: PROTON-1151 URL: https://issues.apache.org/jira/browse/PROTON-1151 Project: Qpid Proton Issue Type: Improvement Components: cpp-binding Reporter: Andrew Stitcher Assignee: Andrew Stitcher -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1152) [C++ binding] Make sure non API details in classes are private
[ https://issues.apache.org/jira/browse/PROTON-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175804#comment-15175804 ] ASF subversion and git services commented on PROTON-1152: - Commit f55a67be88208d315410e2c4a297dd4e597626eb in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f55a67b ] PROTON-1152, PROTON-1153: [C++ binding] Tidy up Header files API docs, and API - Make constructors for type wrapping proton-c types private as they are only to be used internally. - Allow default construction of the wrapper types so the use can declare a variable of the type that is not yet assigned. - Ensure that no private functions have exported symbols. - Small doc improvements > [C++ binding] Make sure non API details in classes are private > -- > > Key: PROTON-1152 > URL: https://issues.apache.org/jira/browse/PROTON-1152 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175808#comment-15175808 ] ASF subversion and git services commented on PROTON-1153: - Commit d758832dd7341f786617502ace6cc0f0f08cc140 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d758832 ] PROTON-1153: [C+ binding] Made reactor an internal class - Moved header file from exported headers to internal source - Reworked reconnect_timer to not use reactor at all > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175805#comment-15175805 ] ASF subversion and git services commented on PROTON-1153: - Commit f55a67be88208d315410e2c4a297dd4e597626eb in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=f55a67b ] PROTON-1152, PROTON-1153: [C++ binding] Tidy up Header files API docs, and API - Make constructors for type wrapping proton-c types private as they are only to be used internally. - Allow default construction of the wrapper types so the use can declare a variable of the type that is not yet assigned. - Ensure that no private functions have exported symbols. - Small doc improvements > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1151) [C++ binding] Move exposed implementation details into proton::internal namespace
[ https://issues.apache.org/jira/browse/PROTON-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175811#comment-15175811 ] ASF subversion and git services commented on PROTON-1151: - Commit d79c23d1810c866ba6ffc93cb140413c5319009b in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=d79c23d ] PROTON-1151: [C++ binding] Move pn_ptr and object into the proton::internal namespace. > [C++ binding] Move exposed implementation details into proton::internal > namespace > - > > Key: PROTON-1151 > URL: https://issues.apache.org/jira/browse/PROTON-1151 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-1152) [C++ binding] Make sure non API details in classes are private
Andrew Stitcher created PROTON-1152: --- Summary: [C++ binding] Make sure non API details in classes are private Key: PROTON-1152 URL: https://issues.apache.org/jira/browse/PROTON-1152 Project: Qpid Proton Issue Type: Improvement Components: cpp-binding Reporter: Andrew Stitcher Assignee: Andrew Stitcher -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176318#comment-15176318 ] ASF subversion and git services commented on PROTON-1153: - Commit 2a8bc3c142c8543582ae56ca41ed5982018c6144 in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=2a8bc3c ] PROTON-1153: [C++ binding] Clean up #defines - Rename the C++ binding defines to be PN_CPP_... > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-1153) [C++ binding] Tidy up various details
[ https://issues.apache.org/jira/browse/PROTON-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176349#comment-15176349 ] ASF subversion and git services commented on PROTON-1153: - Commit 1832e326900b2cffd9dac71040dd44468b55674c in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=1832e32 ] PROTON-1153: [C++ binding] Finish renaming PN_... -> PN_CPP_... - Fix Windows compiler feature detection > [C++ binding] Tidy up various details > - > > Key: PROTON-1153 > URL: https://issues.apache.org/jira/browse/PROTON-1153 > Project: Qpid Proton > Issue Type: Improvement > Components: cpp-binding >Reporter: Andrew Stitcher >Assignee: Andrew Stitcher > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (PROTON-250) Add -fvisibility option when building shared libraries
[ https://issues.apache.org/jira/browse/PROTON-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177431#comment-15177431 ] ASF subversion and git services commented on PROTON-250: Commit 4d90acd6eeb254155aff07caf1aaef00f6338b5a in qpid-proton's branch refs/heads/master from [~astitcher] [ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=4d90acd ] PROTON-250: [C++ binding] Hide all exported library internal only symbols > Add -fvisibility option when building shared libraries > --- > > Key: PROTON-250 > URL: https://issues.apache.org/jira/browse/PROTON-250 > Project: Qpid Proton > Issue Type: Improvement > Components: proton-c >Affects Versions: 0.3 > Environment: GNU Compiler >Reporter: Irina Boverman >Assignee: Andrew Stitcher >Priority: Minor > Labels: patch > Fix For: 0.13.0 > > Attachments: proton.patch > > > Add an option to "hide" symbols in shared libraries except when they are > declared public. > Extends efforts already in place for Windows builds. > Excludes an effort to determine what symbols should be considered "public" > interfaces. > The gcc 4 -fvisibility option is said to: > ...very substantially improve linking and load times of shared object > libraries, produce more optimized code, provide near-perfect API export and > prevent symbol clashes. It is strongly recommended that you use this in any > shared objects you distribute. > See here: http://gcc.gnu.org/wiki/Visibility > Attached patch (patch.txt) will build libqpid-proton.so shared library using > this flag. > It reduces number of symbols from 700+ to 500+. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] qpid-proton pull request: Preserve environment variables when runn...
GitHub user rkuska opened a pull request:
https://github.com/apache/qpid-proton/pull/69
Preserve environment variables when running Popen.
`Popen` does not inherit environment variables of current process
when run with `env` argument defined (and not None). We therefore
pass copy of the current environment with PYTHONPATH modified to
our needs.
See:
```
>>> subprocess.Popen('/usr/bin/echo $LD_LIBRARY_PATH', shell=True,
env={'PYTHONPATH': '.'}, stdout=subprocess.PIPE).stdout.read()
b'\n'
>>> subprocess.Popen('/usr/bin/echo $LD_LIBRARY_PATH', shell=True,
stdout=subprocess.PIPE).stdout.read()
b'/opt/rh/rh-python34/root/usr/lib64\n'
```
This may lead to failure when trying to install python bindings of
qpid-proton.
https://bugzilla.redhat.com/show_bug.cgi?id=1312590
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rkuska/qpid-proton master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-proton/pull/69.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #69
commit bbb42e7d933298fa4cc8036aeb6a7da7e53fe078
Author: Robert Kuska
Date: 2016-03-02T09:31:05Z
Preserve environment variables when running Popen.
`Popen` does not inherit environment variables of current process
when run with `env` argument defined (and not None). We therefore
pass copy of the current environment with PYTHONPATH modified to
our needs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[jira] [Commented] (PROTON-1150) Python setup.py fails to use environment settings
[ https://issues.apache.org/jira/browse/PROTON-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175679#comment-15175679 ] Ken Giusti commented on PROTON-1150: Ooopsie - I pulled Robert's fix but failed to add the 'PROTON-1150' to the log. Commit is here: https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;a=commit;h=b9cd200c532e968bc349145b957c586684b08f02 > Python setup.py fails to use environment settings > - > > Key: PROTON-1150 > URL: https://issues.apache.org/jira/browse/PROTON-1150 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: 0.12.0 >Reporter: Ken Giusti >Assignee: Ken Giusti > Fix For: 0.13.0 > > > This causes the bindings build/install to ignore any environment variables > that have been set by the user. The setup.py script intends to only modify > the PYTHONPATH env variable when running Popen, but actually results in > resetting all other env variables to their defaults. > See: https://github.com/apache/qpid-proton/pull/69/commits -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Resolved] (PROTON-1150) Python setup.py fails to use environment settings
[ https://issues.apache.org/jira/browse/PROTON-1150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ken Giusti resolved PROTON-1150. Resolution: Fixed > Python setup.py fails to use environment settings > - > > Key: PROTON-1150 > URL: https://issues.apache.org/jira/browse/PROTON-1150 > Project: Qpid Proton > Issue Type: Bug > Components: python-binding >Affects Versions: 0.12.0 >Reporter: Ken Giusti >Assignee: Ken Giusti > Fix For: 0.13.0 > > > This causes the bindings build/install to ignore any environment variables > that have been set by the user. The setup.py script intends to only modify > the PYTHONPATH env variable when running Popen, but actually results in > resetting all other env variables to their defaults. > See: https://github.com/apache/qpid-proton/pull/69/commits -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (PROTON-1150) Python setup.py fails to use environment settings
Ken Giusti created PROTON-1150: -- Summary: Python setup.py fails to use environment settings Key: PROTON-1150 URL: https://issues.apache.org/jira/browse/PROTON-1150 Project: Qpid Proton Issue Type: Bug Components: python-binding Affects Versions: 0.12.0 Reporter: Ken Giusti Assignee: Ken Giusti Fix For: 0.13.0 This causes the bindings build/install to ignore any environment variables that have been set by the user. The setup.py script intends to only modify the PYTHONPATH env variable when running Popen, but actually results in resetting all other env variables to their defaults. See: https://github.com/apache/qpid-proton/pull/69/commits -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] qpid-proton pull request: Preserve environment variables when runn...
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
