Re: [ptxdist] [PATCH v2] yajl: add new package
Hello Denis, Am Freitag, 22. Juni 2018, 09:07:58 CEST schrieb Denis OSTERLAND: > So I just used the wrong template. I would not say so. You wanted a target package with external sources and you picked the right template for that. I guess it just makes no sense to have more target templates for all those different build systems used out there? The 'src-cmake-prog' package would generate some source files including a basic CMakeLists.txt below your folder 'local_src'. In my opinion it makes sense to have different src templates, because those add some more than a single line to select the conf tool. But that template had a matching comment, I didn't mean to confuse anyone. ;-) Maybe it gets more clear now? Sorry to bother everyone with those minor things. :-/ Greets Alex ___ ptxdist mailing list ptxdist@pengutronix.de
Re: [ptxdist] [PATCH v2] yajl: add new package
Am Freitag, den 22.06.2018, 10:52 +0200 schrieb Alexander Dahl: > Hello Denis, > > > > > > > > > > > > > > +# > > > > +# autoconf > > > > +# > > > > +YAJL_CONF_TOOL := cmake > > > Comment does not match assignment. ;-) > > You are guess configtool as comment would be better. > From the 'src-cmake-prog' template you would get: > > # > > > # cmake > > > # > > > FOO_CONF_TOOL := cmake > > > > > > > Shall we patch it in the template? > I guess you used the 'target' template, which got you this: > > # > > > # autoconf > > > # > > > FOO_CONF_TOOL := autoconf > > > > I would not touch this in the template, it is consistent. > > So I would say, just change the comment to 'cmake' or remove those comment > lines. The line assigning the conf tool speaks for itself. > > Greets > Alex > So I just used the wrong template. Thanks for that hint. I will remove the useless comment. Regards Denis Diehl AKO Stiftung & Co. KG, Pfannerstraße 75-83, 88239 Wangen im Allgäu Bereichsvorstand: Dipl.-Ing. Michael Siedentop (Sprecher), Josef Fellner (Mitglied) Sitz der Gesellschaft: Wangen i.A. – Registergericht: Amtsgericht Ulm HRA 620609 – Persönlich haftende Gesellschafterin: Diehl Verwaltungs-Stiftung – Sitz: Nürnberg – Registergericht: Amtsgericht Nürnberg HRA 11756 – Vorstand: Dr.-Ing. Karl Tragl (Vorsitzender), Herr Dipl.-Wirtsch.-Ing. Wolfgang Weggen (stellvertretender Vorsitzender), Dipl.-Kfm. Claus Günther, Dipl.-Kfm. Frank Gutzeit, Dr.-Ing. Heinrich Schunk, Dr.-Ing. Michael Siedentop , Dipl.-Kfm. Dr.-Ing. Martin Sommer, Dipl.-Ing. (FH) Rainer von Borstel, Vorsitzender des Aufsichtsrates: Dr. Klaus Maier ___ Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen. Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht. Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt. The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. ___ ptxdist mailing list ptxdist@pengutronix.de
Re: [ptxdist] [PATCH v2] yajl: add new package
Hello Denis, > > > +# > > > +# autoconf > > > +# > > > +YAJL_CONF_TOOL := cmake > > > > Comment does not match assignment. ;-) > > You are guess configtool as comment would be better. From the 'src-cmake-prog' template you would get: # # cmake # FOO_CONF_TOOL := cmake > Shall we patch it in the template? I guess you used the 'target' template, which got you this: # # autoconf # FOO_CONF_TOOL := autoconf I would not touch this in the template, it is consistent. So I would say, just change the comment to 'cmake' or remove those comment lines. The line assigning the conf tool speaks for itself. Greets Alex ___ ptxdist mailing list ptxdist@pengutronix.de
Re: [ptxdist] [PATCH v2] yajl: add new package
Am Freitag, den 22.06.2018, 10:25 +0200 schrieb Alexander Dahl: > Hei hei, > > Am Freitag, 22. Juni 2018, 08:12:10 CEST schrieb Denis OSTERLAND: > > > > +# > > +# autoconf > > +# > > +YAJL_CONF_TOOL := cmake > Comment does not match assignment. ;-) You are guess configtool as comment would be better. Shall we patch it in the template? > > Greets > Alex > Diehl AKO Stiftung & Co. KG, Pfannerstraße 75-83, 88239 Wangen im Allgäu Bereichsvorstand: Dipl.-Ing. Michael Siedentop (Sprecher), Josef Fellner (Mitglied) Sitz der Gesellschaft: Wangen i.A. – Registergericht: Amtsgericht Ulm HRA 620609 – Persönlich haftende Gesellschafterin: Diehl Verwaltungs-Stiftung – Sitz: Nürnberg – Registergericht: Amtsgericht Nürnberg HRA 11756 – Vorstand: Dr.-Ing. Karl Tragl (Vorsitzender), Herr Dipl.-Wirtsch.-Ing. Wolfgang Weggen (stellvertretender Vorsitzender), Dipl.-Kfm. Claus Günther, Dipl.-Kfm. Frank Gutzeit, Dr.-Ing. Heinrich Schunk, Dr.-Ing. Michael Siedentop , Dipl.-Kfm. Dr.-Ing. Martin Sommer, Dipl.-Ing. (FH) Rainer von Borstel, Vorsitzender des Aufsichtsrates: Dr. Klaus Maier ___ Der Inhalt der vorstehenden E-Mail ist nicht rechtlich bindend. Diese E-Mail enthaelt vertrauliche und/oder rechtlich geschuetzte Informationen. Informieren Sie uns bitte, wenn Sie diese E-Mail faelschlicherweise erhalten haben. Bitte loeschen Sie in diesem Fall die Nachricht. Jede unerlaubte Form der Reproduktion, Bekanntgabe, Aenderung, Verteilung und/oder Publikation dieser E-Mail ist strengstens untersagt. The contents of the above mentioned e-mail is not legally binding. This e-mail contains confidential and/or legally protected information. Please inform us if you have received this e-mail by mistake and delete it in such a case. Each unauthorized reproduction, disclosure, alteration, distribution and/or publication of this e-mail is strictly prohibited. ___ ptxdist mailing list ptxdist@pengutronix.de
Re: [ptxdist] [PATCH v2] yajl: add new package
Hei hei, Am Freitag, 22. Juni 2018, 08:12:10 CEST schrieb Denis OSTERLAND: > +# > +# autoconf > +# > +YAJL_CONF_TOOL := cmake Comment does not match assignment. ;-) Greets Alex ___ ptxdist mailing list ptxdist@pengutronix.de
