[IndexedDB] Should removeIndex/ObjectStore be renamed to match s/remove/delete/ elsewhere?

2010-10-19 Thread Jeremy Orlow
Jonas just checked in a change to replace .remove() with .delete() (amongst
other changes we agreed upon a while ago).  In light of that, does it make
sense for removeIndex and removeObjectStore to be renamed to deleteIndex and
deleteObjectStore to match the new naming?  I don't care a whole lot, but it
seems like that'd make things more consistent.

Thanks,
Jeremy


Re: [IndexedDB] Should removeIndex/ObjectStore be renamed to match s/remove/delete/ elsewhere?

2010-10-19 Thread Tab Atkins Jr.
On Tue, Oct 19, 2010 at 3:39 PM, Jeremy Orlow jor...@chromium.org wrote:
 Jonas just checked in a change to replace .remove() with .delete() (amongst
 other changes we agreed upon a while ago).  In light of that, does it make
 sense for removeIndex and removeObjectStore to be renamed to deleteIndex and
 deleteObjectStore to match the new naming?  I don't care a whole lot, but it
 seems like that'd make things more consistent.

Yes.  All of the action verbs in the API should be consistent.
Anything else is gratuitous inconsistency that makes it hard to use
the API from memory.

~TJ



Re: [IndexedDB] Should removeIndex/ObjectStore be renamed to match s/remove/delete/ elsewhere?

2010-10-19 Thread Jonas Sicking
On Tue, Oct 19, 2010 at 3:39 PM, Jeremy Orlow jor...@chromium.org wrote:
 Jonas just checked in a change to replace .remove() with .delete() (amongst
 other changes we agreed upon a while ago).  In light of that, does it make
 sense for removeIndex and removeObjectStore to be renamed to deleteIndex and
 deleteObjectStore to match the new naming?  I don't care a whole lot, but it
 seems like that'd make things more consistent.

Heh, I was thinking about exactly that when I made the change. I don't
feel strongly but consistency is always nice.

/ Jonas