[pulseaudio-tickets] [Bug 104958] Crash when enabling echo cancellation and also specifying PULSE_PROP="filter.want=echo-cancel media.role=phone"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104958

Tanu Kaskinen  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #9 from Tanu Kaskinen  ---
Georg's fix is now in master, closing bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
pulseaudio-bugs mailing list
pulseaudio-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-bugs

[pulseaudio-tickets] [Bug 104958] Crash when enabling echo cancellation and also specifying PULSE_PROP="filter.want=echo-cancel media.role=phone"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104958

Tanu Kaskinen  changed:

   What|Removed |Added

 Blocks||102546

--- Comment #8 from Tanu Kaskinen  ---
Since this is a crash bug, I'm marking this as a release blocker.


Referenced Bugs:

https://bugs.freedesktop.org/show_bug.cgi?id=102546
[Bug 102546] [TRACKER] PulseAudio 12.0 release
-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
pulseaudio-bugs mailing list
pulseaudio-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-bugs

[pulseaudio-tickets] [Bug 104958] Crash when enabling echo cancellation and also specifying PULSE_PROP="filter.want=echo-cancel media.role=phone"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104958

--- Comment #7 from Georg Chini  ---
Thanks for testing. Regarding the new feature, there is not much documentation.
You can find some in the release notes for 11.0 under "Notes for application
developers". Release notes are at
https://www.freedesktop.org/wiki/Software/PulseAudio/Notes/11.0/. The commit
which introduced the feature is here:
https://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=caabff2728d9d588664f8a0ea2f8441804c8b91a

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
pulseaudio-bugs mailing list
pulseaudio-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-bugs

[pulseaudio-tickets] [Bug 104958] Crash when enabling echo cancellation and also specifying PULSE_PROP="filter.want=echo-cancel media.role=phone"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104958

--- Comment #5 from Georg Chini  ---
Since 11.0 there is a way to pass parameters to a filter loaded via
filter.want. You should be able to specify them via the
filter.apply.echo-cancel.parameters property.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
pulseaudio-bugs mailing list
pulseaudio-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-bugs

[pulseaudio-tickets] [Bug 104958] Crash when enabling echo cancellation and also specifying PULSE_PROP="filter.want=echo-cancel media.role=phone"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104958

--- Comment #4 from Georg Chini  ---
Created attachment 137188
  --> https://bugs.freedesktop.org/attachment.cgi?id=137188=edit
Patch ignore monitor sources

Could you try the attached patch? Zoiper seems to test all the available
sources and sinks if I read the log right. So module-filter-apply at some point
tried to use the monitor source of the echo-cancel sink as source for the
filter.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
pulseaudio-bugs mailing list
pulseaudio-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-bugs

[pulseaudio-tickets] [Bug 104958] Crash when enabling echo cancellation and also specifying PULSE_PROP="filter.want=echo-cancel media.role=phone"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104958

--- Comment #3 from Raman Gupta  ---
Created attachment 137182
  --> https://bugs.freedesktop.org/attachment.cgi?id=137182=edit
Output of pa

(In reply to Georg Chini from comment #2)
> There is no need to load module-echo-cancel explicitly when you specify
> filter.want.

Agreed, though I note that the only reason I added loading of the module
explicitly was because I there does not appear to be any way to specify
parameters to the echo cancel module when using filter.want...

> Nevertheless the crash should not happen. Can you please supply
> a full log? It looks like module-filter-apply tries to use the filter while
> its master source is moving, but there is not enough of the log to verify.
> The simple fix might be to return false in find_paired_master() if
> so->source->output_from_master is NULL, but I need to be sure about the
> order of events.

I have attached the full log as pa.log.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
pulseaudio-bugs mailing list
pulseaudio-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-bugs

[pulseaudio-tickets] [Bug 104958] Crash when enabling echo cancellation and also specifying PULSE_PROP="filter.want=echo-cancel media.role=phone"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104958

--- Comment #2 from Georg Chini  ---
There is no need to load module-echo-cancel explicitly when you specify
filter.want. Nevertheless the crash should not happen. Can you please supply a
full log? It looks like module-filter-apply tries to use the filter while its
master source is moving, but there is not enough of the log to verify. The
simple fix might be to return false in find_paired_master() if
so->source->output_from_master is NULL, but I need to be sure about the order
of events.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.___
pulseaudio-bugs mailing list
pulseaudio-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-bugs

[pulseaudio-tickets] [Bug 104958] Crash when enabling echo cancellation and also specifying PULSE_PROP="filter.want=echo-cancel media.role=phone"

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104958

--- Comment #1 from Raman Gupta  ---
One followup: if the echo cancel module is not added explicitly to default.pa,
then there is no crash.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.___
pulseaudio-bugs mailing list
pulseaudio-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/pulseaudio-bugs