Re: [pulseaudio-discuss] [PATCH v13 00/10] Bluetooth A2DP codecs
On 14.12.19 19:15, Tanu Kaskinen wrote: On Wed, 2019-12-11 at 15:44 +0100, Pali Rohár wrote: Hello! Some of these patches are already reviewed. Can you include these patches into pulseaudio master git branch? You me this also on IRC, but at the moment you're not on the channel, so I'm responding here: Georg knows better which patches are ready to be merged than me, so I'll let Georg do the merging. I read a few messages, and it seemed that there were still small issues left unresolved. As discussed briefly on IRC, the first two patches are good to merge. Pali, it would be good if you could open a MR for them as our policy now is that every patch has to go through gitlab. ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH v13 00/10] Bluetooth A2DP codecs
On Wed, 2019-12-11 at 15:44 +0100, Pali Rohár wrote: > Hello! Some of these patches are already reviewed. Can you include these > patches into pulseaudio master git branch? You me this also on IRC, but at the moment you're not on the channel, so I'm responding here: Georg knows better which patches are ready to be merged than me, so I'll let Georg do the merging. I read a few messages, and it seemed that there were still small issues left unresolved. -- Tanu https://www.patreon.com/tanuk https://liberapay.com/tanuk ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH v13 00/10] Bluetooth A2DP codecs
Hello! Some of these patches are already reviewed. Can you include these patches into pulseaudio master git branch? -- Pali Rohár pali.ro...@gmail.com ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH v13 00/10] Bluetooth A2DP codecs
On Thu, 2019-10-17 at 15:45 +0300, Tanu Kaskinen wrote: > On Thu, 2019-10-17 at 12:06 +0200, Pali Rohár wrote: > > Hello! > > > > On Sunday 06 October 2019 19:58:32 Pali Rohár wrote: > > > Changes in v13: > > > * Do not use read smoother for A2DP sink when backchannel is in use > > > * Use new bluez org.freedesktop.DBus.ObjectManager and RegisterApplication > > > DBus APIs for codec switching > > > * Add FastStream codec profile without microphone support > > > * Correctly calculate and fill RTP sequence number in aptX-HD encoded > > > frames > > > > > > Pali Rohár (10): > > > bluetooth: Implement reading SO_TIMESTAMP for A2DP source > > > bluetooth: Print SO_TIMESTAMP warning for SCO source only once > > > bluetooth: Parse remote timestamp from A2DP RTP packets when available > > > bluetooth: Set initial A2DP profile which bluez already activated > > > > May I ask for review at least for these first 4 patches? > > Sure, I'll put you in the queue of people who have requested me to > review their patches. The queue so far: > > 1. Improvements to reconfiguration > https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/24 > > 2. Adds SBC XQ negotiated at the best of capabilities of the BT device > https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/177 > > 3. alsa-ucm: Support Playback/CaptureVolume > https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/32 > > 4. [PATCH v13 00/10] Bluetooth A2DP codecs Update: Georg rightfully complained that I've for a long time promised to review his message API patches, so I put that to the second position in this priority list. Georg said he could review the A2DP codec patches, so that's not blocking on me any more. -- Tanu https://www.patreon.com/tanuk https://liberapay.com/tanuk ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH v13 00/10] Bluetooth A2DP codecs
On Thu, 2019-10-17 at 12:06 +0200, Pali Rohár wrote: > Hello! > > On Sunday 06 October 2019 19:58:32 Pali Rohár wrote: > > Changes in v13: > > * Do not use read smoother for A2DP sink when backchannel is in use > > * Use new bluez org.freedesktop.DBus.ObjectManager and RegisterApplication > > DBus APIs for codec switching > > * Add FastStream codec profile without microphone support > > * Correctly calculate and fill RTP sequence number in aptX-HD encoded frames > > > > Pali Rohár (10): > > bluetooth: Implement reading SO_TIMESTAMP for A2DP source > > bluetooth: Print SO_TIMESTAMP warning for SCO source only once > > bluetooth: Parse remote timestamp from A2DP RTP packets when available > > bluetooth: Set initial A2DP profile which bluez already activated > > May I ask for review at least for these first 4 patches? Sure, I'll put you in the queue of people who have requested me to review their patches. The queue so far: 1. Improvements to reconfiguration https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/24 2. Adds SBC XQ negotiated at the best of capabilities of the BT device https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/177 3. alsa-ucm: Support Playback/CaptureVolume https://gitlab.freedesktop.org/pulseaudio/pulseaudio/merge_requests/32 4. [PATCH v13 00/10] Bluetooth A2DP codecs -- Tanu https://www.patreon.com/tanuk https://liberapay.com/tanuk ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH v13 00/10] Bluetooth A2DP codecs
Will test12:06, 17 octobre 2019, "Pali Rohár" :Hello!On Sunday 06 October 2019 19:58:32 Pali Rohár wrote: Changes in v13: * Do not use read smoother for A2DP sink when backchannel is in use * Use new bluez org.freedesktop.DBus.ObjectManager and RegisterApplication DBus APIs for codec switching * Add FastStream codec profile without microphone support * Correctly calculate and fill RTP sequence number in aptX-HD encoded frames Pali Rohár (10): bluetooth: Implement reading SO_TIMESTAMP for A2DP source bluetooth: Print SO_TIMESTAMP warning for SCO source only once bluetooth: Parse remote timestamp from A2DP RTP packets when available bluetooth: Set initial A2DP profile which bluez already activatedMay I ask for review at least for these first 4 patches?-- Pali Rohárpali.ro...@gmail.com___pulseaudio-discuss mailing listpulseaudio-discuss@lists.freedesktop.orghttps://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss-- Sent from Yandex.Mail for mobile___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
Re: [pulseaudio-discuss] [PATCH v13 00/10] Bluetooth A2DP codecs
Hello! On Sunday 06 October 2019 19:58:32 Pali Rohár wrote: > Changes in v13: > * Do not use read smoother for A2DP sink when backchannel is in use > * Use new bluez org.freedesktop.DBus.ObjectManager and RegisterApplication > DBus APIs for codec switching > * Add FastStream codec profile without microphone support > * Correctly calculate and fill RTP sequence number in aptX-HD encoded frames > > Pali Rohár (10): > bluetooth: Implement reading SO_TIMESTAMP for A2DP source > bluetooth: Print SO_TIMESTAMP warning for SCO source only once > bluetooth: Parse remote timestamp from A2DP RTP packets when available > bluetooth: Set initial A2DP profile which bluez already activated May I ask for review at least for these first 4 patches? -- Pali Rohár pali.ro...@gmail.com ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
[pulseaudio-discuss] [PATCH v13 00/10] Bluetooth A2DP codecs
Changes in v13: * Do not use read smoother for A2DP sink when backchannel is in use * Use new bluez org.freedesktop.DBus.ObjectManager and RegisterApplication DBus APIs for codec switching * Add FastStream codec profile without microphone support * Correctly calculate and fill RTP sequence number in aptX-HD encoded frames Pali Rohár (10): bluetooth: Implement reading SO_TIMESTAMP for A2DP source bluetooth: Print SO_TIMESTAMP warning for SCO source only once bluetooth: Parse remote timestamp from A2DP RTP packets when available bluetooth: Set initial A2DP profile which bluez already activated bluetooth: Add A2DP aptX and aptX HD codecs support bluetooth: Add A2DP FastStream codec support bluetooth: Add more variants of SBC codec bluetooth: policy: Reflect a2dp profile names bluetooth: Implement A2DP codec switching and backchannel support bluetooth: policy: Treat bi-directional A2DP profiles as suitable for VOIP configure.ac| 36 ++ src/Makefile.am | 8 + src/modules/bluetooth/a2dp-codec-api.h | 4 +- src/modules/bluetooth/a2dp-codec-aptx.c | 479 +++ src/modules/bluetooth/a2dp-codec-faststream.c | 554 ++ src/modules/bluetooth/a2dp-codec-sbc.c | 740 +++- src/modules/bluetooth/a2dp-codec-util.c | 28 +- src/modules/bluetooth/bluez5-util.c | 723 +-- src/modules/bluetooth/bluez5-util.h | 40 +- src/modules/bluetooth/meson.build | 1 + src/modules/bluetooth/module-bluetooth-policy.c | 127 ++-- src/modules/bluetooth/module-bluez5-device.c| 535 - src/modules/bluetooth/module-bluez5-discover.c | 3 +- 13 files changed, 2885 insertions(+), 393 deletions(-) create mode 100644 src/modules/bluetooth/a2dp-codec-aptx.c create mode 100644 src/modules/bluetooth/a2dp-codec-faststream.c -- 2.11.0 ___ pulseaudio-discuss mailing list pulseaudio-discuss@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
