date:20151204

Jira (HI-484) parse_string doesnt interpolate %{key} with Puppet 4.0

2015-12-04 Thread Craig Dunn (JIRA)

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Craig Dunn commented on  HI-484 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: parse_string doesnt interpolate %{key} with Puppet 4.0  
 
 
 
 
 
 
 
 
 
 
Thomas Hallgren You appear to be correct here scope['key'] returns true 
Puppet 3 
 Debug: Runtime environment: puppet_version=3.8.4, ruby_version=2.0.0, run_mode=user, default_encoding=UTF-8  Debug: hiera(): Scope contains key? true Debug: hiera(): unparsed: foo bar % {key} to parsed: foo bar test::my_key  Puppet 4  Debug: Runtime environment: puppet_version=4.0.0, ruby_version=2.0.0, run_mode=user, default_encoding=UTF-8 Debug: hiera(): Scope contains key? true Debug: hiera(): unparsed: foo bar %{key} 
 to parsed: foo bar 
Hiera CLI 
 DEBUG: 2015-12-04 08:37:30 +0100: Scope contains key? false DEBUG: 2015-12-04 08:37:30 +0100: unparsed: foo bar % {key} to parsed: foo bar my_key  This supports your theory, assuming the scope['key'] has always returned true, but in Puppet 3.x this was considered an non-valid value and therefore ignored and the extra_data value used, but in Puppet 4.x because it's considered legal it's being interpolated into the hash  This lead me to do a bit more digging - the problem is not related soley to interpolating %{key} 
. For some reason, `scope.include?('anything')` always returns true, therefore values from the extra_hash are never interpolated thus breaking this option entirely. 
 scope.include?('askdjhajh') => true 
Hiera::Scope in puppet//lib/hiera/scope.rb has the following method 
 def include?(key) if key == CALLING_CLASS or key == CALLING_MODULE true else @real.lookupvar(key) != "" end end 
If real.lookupvar returns nil then the method will return true since nil != "" - this is as far as I've got with it  
This has been reported by two different users of hiera-mysql and hiera-http so far, so it's clearly a behaviour that people need. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)

Jira (HI-484) parse_string doesnt interpolate %{key} with Puppet 4.0

2015-12-04 Thread Thomas Hallgren (JIRA)

Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  HI-484 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: parse_string doesnt interpolate %{key} with Puppet 4.0  
 
 
 
 
 
 
 
 
 
 
Craig Dunn, thanks for confirming my theory and also finding where the problem is. Do you want to submit a PR that fixes this or should I? Either way is find by me but I don't want to steal well earned credit without asking  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-5502) lookup adapter "lookup_global" produces bad error message for faulty hiera.yaml

2015-12-04 Thread Henrik Lindberg (JIRA)

Title: Message Title

Henrik Lindberg commented on PUP-5502

Re: lookup adapter "lookup_global" produces bad error message for faulty hiera.yaml

This is from a user - I did not run this myself. We had the ticket in triage to follow up if this was a problem or not. (I know I should have pasted a link to where this was reported from - now I cannot find it).
I did find this though - one occurrence of the problem reported: https://ask.puppetlabs.com/question/16614/error-400-on-server-error-from-databinding-hiera-while-looking-up-puppet_enterprisecertificate_authority_port-unknown-could-not-found-expected-while/
Similar: https://ask.puppetlabs.com/question/11000/does-puppet-provide-a-validationsyntax-checker-for-hiera/
Looks like the is produced in the error message shown when an agent attempts to get a catalog.

Add Comment

This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc)

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

58 matches

Mail list logo