Jira (PUP-6726) Tag Puppet for 4.7.0

2016-09-22 Thread Moses Mendoza (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Moses Mendoza created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6726 
 
 
 
  Tag Puppet for 4.7.0  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Task 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/09/22 9:59 AM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Moses Mendoza 
 
 
 
 
 
 
 
 
 
 
This is just a ticket in the PUP project (linked to PA-521, the ticket for release of Puppet Agent) to ensure we have appropriate commit message with ticket. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 

Jira (PUP-6713) Vim should highlight data types in a class definition

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-6713 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Vim should highlight data types in a class definition  
 
 
 
 
 
 
 
 
 
 
There are many things not working: 
 

string interpolation is most certainly broken
 

differentiation of whitespace before brackets is not supported
 

differentiation of new line containing whitespace before () is not supported
 

bare words, hyphen rules are probably not correct
 

type names are probably not correct
 

functions are only recognized if they are in a hard coded list
 

keywords are missing
 

doubt it does the right thing on unquoted numbers
 
 
Not sure it helps with individual tickets for all of these as the existing implementation is flawed. At the moment it is better with all of these problems under one umbrella ticket. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You 

Jira (PUP-6706) Add Binary type to Puppet Serialization

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6706 
 
 
 
  Add Binary type to Puppet Serialization  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Release Notes Summary:
 
 Part of a larger (experimental) feature --rich_data 
 
 
 

Release Notes:
 
 Not Needed 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-5834) Handle extended data in the catalog

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-5834 
 
 
 
  Handle extended data in the catalog  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Assignee:
 
 Henrik Lindberg Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6713) Vim should highlight data types in a class definition

2016-09-22 Thread Paul Anderson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Paul Anderson commented on  PUP-6713 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Vim should highlight data types in a class definition  
 
 
 
 
 
 
 
 
 
 
Tobias Wolter, PUP-6725 opened and linked 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6725) Vim should work with heredocs

2016-09-22 Thread Paul Anderson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Paul Anderson created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6725 
 
 
 
  Vim should work with heredocs  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  New Feature 
 
 
 

Affects Versions:
 

 PUP 4.6.2 
 
 
 

Assignee:
 
 Lindsey Smith 
 
 
 

Components:
 

 Community 
 
 
 

Created:
 

 2016/09/22 8:21 AM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Paul Anderson 
 
 
 
 
 
 
 
 
 
 
See PUP-6713 for information. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 

Jira (PUP-6713) Vim should highlight data types in a class definition

2016-09-22 Thread Tobias Wolter (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Tobias Wolter commented on  PUP-6713 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Vim should highlight data types in a class definition  
 
 
 
 
 
 
 
 
 
 
If this triggers a syntax file overhaul, be advised that heredocs are broken in a similar fashion. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6706) Add Binary type to Puppet Serialization

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-6706 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Add Binary type to Puppet Serialization  
 
 
 
 
 
 
 
 
 
 
merged to master at: 0e17f07 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6705) Add Sensitive type to Puppet Serialization

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-6705 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Add Sensitive type to Puppet Serialization  
 
 
 
 
 
 
 
 
 
 
merged to master at: 8b2db0a 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6713) Vim should highlight data types in a class definition

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-6713 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Vim should highlight data types in a class definition  
 
 
 
 
 
 
 
 
 
 
I took a quick look at the highlighter code - it has not changed since 2010 and even at that point in time it could not have done a good job. While it may be possible to shoehorn support for parameter type definitions there are a lot of things missing or just downright wrong. Looks like a rewrite is needed as the entire thing needs to be constructed from the bottom up in a way that allows things to be lexically recognized and then semantically interpreted depending on context. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6119) environment returned from ENC makes site.pp not be included

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-6119 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: environment returned from ENC makes site.pp not be included  
 
 
 
 
 
 
 
 
 
 
Thanks Robert Brooks - maybe run just a small sample on puppet 4.x alone - if that shows the problem then we have something to work with. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDOC-85) Handle the case of 4x functions and 3x stubs

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PDOC-85 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Handle the case of 4x functions and 3x stubs  
 
 
 
 
 
 
 
 
 
 
Lindsey Smith Nicholas Fagerlund How exactly? We have three cases: 
 

documented in both 3.x stub and 4.x
 

documented in 3.x, and 4.x contains a reference to see the 3.x stub - that reference looks just like documentation
 

documented in 4.x only (although we no longer have any in this category)
 
 
I can imagine that if there is a 3.x function with the same name, then that wins - is that what we will do in the templates? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6723) collector_transformer: negation query for array type properties is broken

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6723 
 
 
 
  collector_transformer: negation query for array type properties is broken  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Team:
 
 Puppet Developer Support 
 
 
 

Sprint:
 
 PDS Triage 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6723) collector_transformer: negation query for array type properties is broken

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-6723 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: collector_transformer: negation query for array type properties is broken  
 
 
 
 
 
 
 
 
 
 
The proposed changes may be backwards incompatible and therefore require a major version bump. If the implementation in the collector transformer is incompatible with older versions then this could possibly be argued to be a bug. 
Queries against arrays and negations are tricky because of the difference in semantics of "does not contain a value that matches" vs. "contains a value that is not matching". Not sure how this was handled in older versions of puppet where the collector transformer was not present (i.e. before future parser). 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6723) collector_transformer: negation query for array type properties is broken

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6723 
 
 
 
  collector_transformer: negation query for array type properties is broken  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Fix Version/s:
 
 PUP 4.6.2 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (HI-519) Hiera Filecache doesn't support encoding / doesn't load JSON backend files as UTF-8

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  HI-519 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Hiera Filecache doesn't support encoding / doesn't load JSON backend files as UTF-8  
 
 
 
 
 
 
 
 
 
 
The data providers in lookup (json and yaml) read content with File read with utf-8 (json), and with YAML.load_file (yaml). if BOM support is to be supported there as well, a ticket is needed for the json_data_provider_factory.rb ('utf-8' specified on line 18). 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6724) The new strftime function is not compatible with the strftime function in stdlib.

2016-09-22 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6724 
 
 
 
  The new strftime function is not compatible with the strftime function in stdlib.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 

Acceptance Criteria:
 
 1. That {{strftime}} can be used with the same argument combinations as  the function found in  stdlib . , and produce the same results2. That {{strftime}} accepts a third, optional, timezone argument.3. That the timezone argument impacts the formatted result. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6724) The new strftime function is not compatible with the strftime function in stdlib.

2016-09-22 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6724 
 
 
 
  The new strftime function is not compatible with the strftime function in stdlib.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 The {{strftime}} function in [puppetlabs-stdlib|https://github.com/puppetlabs/puppetlabs-stdlib/blob/72f6e379a647396c276d7f216b307361ac76f376/lib/puppet/parser/functions/strftime.rb] and the new {{strftime}} function added as part of PUP-5871 are not compatible. The one from stdlib has the following API:{code:puppet}String strftime(String format, String timezone = undef){code}whereas the API of the new function is:{code:puppet}String strftime(Variant[Timespan,Timestamp], String format){code} Since the arguments are completely different and format argument is in different positions, the only sane thing is to rename the new function. The new name should be {{format_time}}.   As part of this change, a third optional timezone argument should also be added, to allow the given time to be formatted in accordance with that timezone. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6724) The new strftime function is not compatible with the strftime function in stdlib.

2016-09-22 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6724 
 
 
 
  The new strftime function is not compatible with the strftime function in stdlib.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 

Acceptance Criteria:
 
 1. That {{strftime}} , when  can be  used , references  with  the  function in  same argument combinations as  stdlib. , and produce the same results 2. That {{ format_time}} works like the new {{ strftime}}  did earlier.3. That {{format_time}}  accepts a third, optional, timezone argument. 4 3 . That the timezone argument impacts the formatted result. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6724) The new strftime function is not compatible with the strftime function in stdlib.

2016-09-22 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-6724 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: The new strftime function is not compatible with the strftime function in stdlib.  
 
 
 
 
 
 
 
 
 
 
After a lengthy discussion with Henrik Lindberg, we decided that the best solution would be to keep the strftime function and add a dispatcher that is backwards compatible with the stdlib function. When used, that dispatcher must issue a deprecation warning, preferably with a reference to the new Timestamp type. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PDB-3063) latest_report_noop_pending=null, should be =true

2016-09-22 Thread Elof Ofel (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Elof Ofel commented on  PDB-3063 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: latest_report_noop_pending=null, should be =true  
 
 
 
 
 
 
 
 
 
 
Wyatt Alt, Ah. Testing. Yes, from an updated Debian client (puppet agent --version: 4.6.2), I get  "latest_report_noop" : true, "latest_report_noop_pending" : true, "latest_report_status" : "unchanged" 
The 'null' values in my original post came from a FreeBSD client with v4.5.1. So, once all my clients are updated I can start using latest_report_noop_pending. Great. 
— 
Regarding section #2: 
 
 
 
 
 
 
Prior to PuppetDB v4.2: 
 
 
 
 
The query #report { latest_report?=true and noop=true and status="unchanged" } 
 
 
 
 
matches clients with pending jobs. (the last performed puppet run is a noop run, and it reported changes) 
 
 
 
 
  
 
 
 
 
Now after PuppetDB v4.2: 
 
 
 
 
The query #report { latest_report?=true and noop=true and status="unchanged" } 
 
 
 
 
matches *any and all nodes* that use the new version of the puppet client, wether they have pending jobs or not. 
 
 
 
 
This is possibly bad, if there are applications out there who rely on the old logic. They must update their syntax. 
 
 
 
   

Jira (FACT-1510) Custom facts don't work correctly in Vagrant on Windows

2016-09-22 Thread Rory Browne (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Rory Browne created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Facter /  FACT-1510 
 
 
 
  Custom facts don't work correctly in Vagrant on Windows  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Components:
 

 Windows 
 
 
 

Created:
 

 2016/09/22 3:09 AM 
 
 
 

Environment:
 
 
Vagrant (virtualbox) on Windows, Facter 3.2, Custom ( Ruby ) facts. 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Rory Browne 
 
 
 
 
 
 
 
 
 
 
Hello 
We've had an issue with using custom facts in Ruby on our Vagrant Windows instance. 
Vagrant shared the puppet code with the instance, through it's synced folder feature, which in this case is backed by Virtualbox Shared Folder. Facter tries to canonicalise this directory, and it seems ( haven't dug too much into boost ) that because this is a symlink to a UNC path, that this fails, so the facts don't get included. 
If nothing else (I'm not sure if we can do without or work around the canonical() call), then there could be better logging around this; using facter with --custom-dir didn't reveal anything useful, while using the FACTERLIB environment variable revealed the following debug entry, which isn't a lot of help in debugging why the path won't be searched ( I initially thought it was lack of a suitable ruby runtime ): 
2016-09-22 

Jira (PUP-6724) The new strftime function is not compatible with the strftime function in stdlib.

2016-09-22 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6724 
 
 
 
  The new strftime function is not compatible with the strftime function in stdlib.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 The {{ strtime strftime }} function in [puppetlabs-stdlib|https://github.com/puppetlabs/puppetlabs-stdlib/blob/72f6e379a647396c276d7f216b307361ac76f376/lib/puppet/parser/functions/strftime.rb] and the new {{strftime}} function added as part of PUP-5871 are not compatible. The one from stdlib has the following API:{code:puppet}String strftime(String format, String timezone = undef){code}whereas the API of the new function is:{code:puppet}String strftime(Variant[Timespan,Timestamp], String format){code}Since the arguments are completely different and format argument is in different positions, the only sane thing is to rename the new function. The new name should be {{format_time}}.As part of this change, a third optional timezone argument should also be added, to allow the given time to be formatted in accordance with that timezone. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6724) The new strftime function is not compatible with the strftime function in stdlib.

2016-09-22 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren assigned an issue to Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6724 
 
 
 
  The new strftime function is not compatible with the strftime function in stdlib.  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 

Assignee:
 
 Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6724) The new strftime function is not compatible with the strftime function in stdlib.

2016-09-22 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6724 
 
 
 
  The new strftime function is not compatible with the strftime function in stdlib.  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/09/22 2:10 AM 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 
The strtime function in puppetlabs-stdlib and the new strftime function added as part of 

PUP-5871
 are not compatible. The one from stdlib has the following API: 
 
 
 
 
 
 
String strftime(String format, String timezone = undef)
 
 
 
 
 
 
 
whereas the API of the new function is: 
 
 
 
 
 
 
String strftime(Variant[Timespan,Timestamp], String format)
 
 
 
 
   

<    1   2   3